- 16 Aug, 2018 40 commits
-
-
Ben Pastene authored
We don't have enough capacity for layout tests in 10.13, and the fall back triggering isn't working sufficiently (crbug.com/871453) The 10.12 pool w/ 8086:0a2e GPUs has plenty of spare capacity, and flashing them up to 10.13 isn't going to happen soon (crbug.com/873421). Meanwhile, pending times are getting out of hand on ios-sim and mac_chromium_rel_ng bots. So this temporarily moves layout tests fully back to 10.12 That should free up plenty of 10.13 capacity. According to my SQL'ing, the 10.13 pool ran ~8100 bot hours of tests yesterday; and layout tests on mac_chromium_rel_ng accounted for ~1000 of them. (LMK if you want my queries and I can link them.) # No-try to help unblock mac_chromium_rel_ng NOTRY=true Bug: 854874 Change-Id: Ibd708f795d1df67de74cebf3f955ff175c00c0f3 Reviewed-on: https://chromium-review.googlesource.com/1175243 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583818}
-
Dominik Laskowski authored
ClientControlledShellSurface does not use the configure protocol. Bug: b:77972398 Test: exo_unittests Change-Id: I87f7be2e385c7184e7c717ccf5f0d41921c80e36 Reviewed-on: https://chromium-review.googlesource.com/1164552Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#583817}
-
Tarun Bansal authored
Use network quality tracker instead of network quality estimator (NQE) to obtain network quality in offline pages. Network quality tracker can provide network service when network service is enabled as well as when network service is disabled. Bug: 819244 Change-Id: I0b2bad429c1e7745759a1172fb1fbaa843dd8b8b Reviewed-on: https://chromium-review.googlesource.com/1171863Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#583816}
-
Tessa Nijssen authored
Previously, -updateTextSelection:range:offset: could receive an invalid range from WebContentsTextObserver::DidChangeTextSelection(). This invalid range would then cause a crash in -requestSuggestions. A check has been added to -updateTextSelection:range:offset: to make sure that a selection with an invalid range is not passed to -requestSuggestions. This should prevent future crashes. TextSuggestionsTouchBarControllerTest.InvalidRange tests that an invalid range does not crash the controller and is handled properly. Bug: 717553 Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d Reviewed-on: https://chromium-review.googlesource.com/1178467Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#583815}
-
Stephan Stross authored
This CL adds a README.md file to the tools/fuchsia/comparative_tester/ directory, explaining how all the scripts interact with each other, and how they should be used. Change-Id: Ib9f668fb09f5fa1ba50d6da396251b2c8113d4a5 Reviewed-on: https://chromium-review.googlesource.com/1176366 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583814}
-
Lei Zhang authored
Split all IO thread code into a separate helper class. Now there is no refcounting, so ownership is clearer. Now only the helper class has a WeakPtrFactory, so WeakPtrs are only used on the IO thread. BUG=873529 Change-Id: I326aa6f69839c193507df4c63250aa1560bbd0ef Reviewed-on: https://chromium-review.googlesource.com/1177444 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583813}
-
Katie D authored
Changes a "if" to a "DCHECK". Change-Id: I17cbe0efee059bbc76ca85cacd395f57b1ac41a2 Reviewed-on: https://chromium-review.googlesource.com/1178224Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#583812}
-
Robbie McElrath authored
This migrates all NetworkChangeNotifier usages in components/data_reduction_proxy/core/browser to the new NetworkConnectionTracker, which will work with the network service enabled. Bug: 868005 Change-Id: Ia81ebef073b72f9baa3e97550451ad92c4aac2aa Reviewed-on: https://chromium-review.googlesource.com/1157345 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#583811}
-
Eric Karl authored
Bug: 874703 Change-Id: I63bc492d44f230ced991d6525ae43ede1e6a8359 Reviewed-on: https://chromium-review.googlesource.com/1176826Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583810}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5f4cd74d2693..f956badf3dd2 git log 5f4cd74d2693..f956badf3dd2 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 hnakashima@chromium.org Add a way to save a barcode generated bitmap to a .png. 2018-08-16 tsepez@chromium.org Remove more optional args in core/ 2018-08-16 hnakashima@chromium.org Optimize rendering of two dimensional barcodes: deduplicate regions. Created with: gclient setdep -r src/third_party/pdfium@f956badf3dd2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:872907 TBR=dsinclair@chromium.org Change-Id: If58ebe0565280b1361422a9ced2f70af30a93c3b Reviewed-on: https://chromium-review.googlesource.com/1178247Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583809}
-
David Davidović authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1145066, which adds an STL-compatible interface to EnumSet and EnumSet::Iterator, replace all uses of the previous iteration interface with a range-based for loop. This allows eventual removal of the old interface altogether. Also, replace existing usage of |arraysize| with |base::Size|, since the former was deprecated. This is CL part 1 of 2. Bug: 860435 Change-Id: Ida43a641fd24f567be162ae5e18665e2ea7e39f6 Reviewed-on: https://chromium-review.googlesource.com/1146819 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583808}
-
Xianzhu Wang authored
The tests failed because of different graphics layer structures about ChildContainmentLayer and AncestorClippingLayer which are intentionally not created by BGPT, so rebaseline them. Bug: 854196 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96223cc733ff0a1e792d4660e8e667a7d9e17460 Reviewed-on: https://chromium-review.googlesource.com/1178628Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583807}
-
Siddhartha authored
R=twellington@chromium.org Change-Id: I074521c0835fe6d71cfa19fef359cd2f6bd42db9 Reviewed-on: https://chromium-review.googlesource.com/1178561Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#583806}
-
Chase Phillips authored
Bug: None Change-Id: I1e86c4a52bb3f0eca8c896b5e23664ab1ca1f505 Reviewed-on: https://chromium-review.googlesource.com/1178629 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583805}
-
Victor Costan authored
Change-Id: Iae148260df76be6b37e22ea4a95bdbd81e0e35b7 Reviewed-on: https://chromium-review.googlesource.com/1176971 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#583804}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6e5bf36ff50f..3394a73db973 git log 6e5bf36ff50f..3394a73db973 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 tobine@google.com Refactor of EGL SwapBuffers validation Created with: gclient setdep -r src/third_party/angle@3394a73db973 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I7f68c3ea7c114ece23c85bf2245218b57a138162 Reviewed-on: https://chromium-review.googlesource.com/1178626Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583803}
-
Javier Fernandez authored
We recenttly changed the track sizing algorithm so that it considers the offsets added by the Content Alignment properties. The change in r566412 introduce intermediate steps in the track sizing algorithm so that inline-axis Content Distribution accounts for the row tracks sizes computed in the next step. However, we were adding the Content Distribution offsets for any column track, but we should do it only for the tracks with spanning items. This error led to the mentioned bugs and this change fixes them. Bug: 871230, 871242 Change-Id: I8ac789ccacc2e5a51bfafd7820ed08e96a31e58b Reviewed-on: https://chromium-review.googlesource.com/1176803Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#583802}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74ed734d717a..b005087a8cac git log 74ed734d717a..b005087a8cac --date=short --no-merges --format='%ad %ae %s' 2018-08-16 titovartem@webrtc.org Add replacements for all FakeNetworkPipe ctors. 2018-08-16 jonasolsson@webrtc.org Reimplement rtc::ToString and rtc::FromString without streams. 2018-08-16 buildbot@webrtc.org Roll chromium_revision 7e9f692e..04aa516a (583557:583667) Created with: gclient setdep -r src/third_party/webrtc@b005087a8cac The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice941157d99c70c75b02170097319657ddd1e0ca Reviewed-on: https://chromium-review.googlesource.com/1178569Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583801}
-
Jun Choi authored
In order to prevent MacTouchId and BLE system UI dialog from appearing prior to user explictly selecting which transport type to use, ChromeAuthenticatorRequestDelegate should be able to "lazily" dispatch WebAuthN request to FidoAuthenticators. Add logic trigger request from embedder layer. Bug: 866601 Change-Id: Iec3e16c2c87423c7af101e529f1a12ade62652ee Reviewed-on: https://chromium-review.googlesource.com/1175418 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#583800}
-
Sophie Chang authored
Placing a vectordrawable as the android:drawable is not allowed, so we have to bind it in onBindView Bug: 874723 Change-Id: I20cf9856ca83bb5786da7223c828b9bb5679ba8e Reviewed-on: https://chromium-review.googlesource.com/1178311Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583799}
-
Ned Nguyen authored
This reverts commit 6090d226. Reason for revert: culprit CL is being reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1178841 Original change's description: > Disabling failing blink_perf.image_decoder stories on Win. > > Bug: 874810 > Change-Id: I11ff44a55b4f2b14b8ba0a4ab5bb4e0f54cd8ef8 > TBR: nednguyen@google.com > NOTRY: true > Reviewed-on: https://chromium-review.googlesource.com/1177882 > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583658} TBR=sullivan@chromium.org Change-Id: Ia80a8b6809d909fff687bd12cace06fe447eb141 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874810 Reviewed-on: https://chromium-review.googlesource.com/1178861Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583798}
-
Alexei Filippov authored
Color.parse is quite expensive, resulted in 7 seconds wait for a million entries. We can just cache parsed colors provided there are just few dozens of them. Also move gl.get* operations out of the main draw routine as they known to be expensive. BUG=874116 Change-Id: I6b02210a1dd1d2b9e8ef9d9931ee3eebd0087872 Reviewed-on: https://chromium-review.googlesource.com/1178579Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583797}
-
Miguel Casas authored
Sister CL to crrev.com/c/1176279 -- this CL folds V4L2SliceVideoDecodeAccelerator::DecodeSurface() into callers. This simplifies extracting CreateSurface() and SurfaceReady() into an interface, in turn allowing better unit testing. Bug: 875005 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I07d6934316cac629b2e78e2e96b66a19864bdd9e Reviewed-on: https://chromium-review.googlesource.com/1178322Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#583796}
-
Yue Li authored
Also removed the confirm reject screen upon UX's request. Bug: b/78190629 Test: Manual Test Change-Id: If2f97cb5e8302932fa96e0378ac3fd760d49feae Reviewed-on: https://chromium-review.googlesource.com/1176588Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#583795}
-
Aldo Culquicondor authored
The models are the means by which the UI share its state with other components. PlatformController should remain unknown to the UI. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48a917b2e144843173102494fe1b764cd30883f4 Reviewed-on: https://chromium-review.googlesource.com/1177894Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#583794}
-
Nick Harper authored
The documentation referred to RFC4913, which has nothing to do with IP addresses. RFC4193 appears to be the correct RFC to cite. Bug: 873490 Change-Id: I606f20af8027f252dcef90726032c7723f62d0de Reviewed-on: https://chromium-review.googlesource.com/1174962Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#583793}
-
Michael Spang authored
Instead of providing an object that creates fake framebuffers in tests, create fake GbmBuffers and import them into the fake DrmDevice. Reland: Fixup empty modifiers case for modeset buffers by moving it into GbmDevice. Bug: 869206 Test: ozone_unittests Change-Id: I2ba134a7e1556a4d177e6e9aaa5265f0c7f6e9b7 Reviewed-on: https://chromium-review.googlesource.com/1178308Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583792}
-
Peter Beverloo authored
We have no plans to standardize this for the time being, so let's remove it. Change-Id: Ia039368ca2e732bcbbee6acff94260b14c3bff0d Reviewed-on: https://chromium-review.googlesource.com/1163783Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583791}
-
Wenzhao Zang authored
This CL introduces a new checkbox that will be enabled only for users on the google.com domain. This checkbox is only shown if we detect that the google internal user is trying to file feedback related to bluetooth. This CL only introduces the UI changes. Once the platforms-side changes land to collect bluetooth logs for Google internal users, I'll send a follow on CL that gathers those logs and attaches them to the feedback report. R=afakhry@chromium.org Bug: 872403 Change-Id: I937ddf8002373a861fbe5252ce37570c9f2a2f63 Reviewed-on: https://chromium-review.googlesource.com/1166594Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583790}
-
Sergey Ulanov authored
AudioRenderer interface is being replaced with AudioOut. Updated //media and //chromecast to use the new interface. Also fixed a crash in FIDL interface handler. Bug: 873676 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib0f9963fb7b39033bb89a0945a4b8eb5616594cc Reviewed-on: https://chromium-review.googlesource.com/1175240Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583789}
-
Aaron Leventhal authored
Bug: 870020 Change-Id: Ic0173972f01d506d5e8b18b8c6de629ecc6b6a6e Reviewed-on: https://chromium-review.googlesource.com/1159188Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#583788}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ed63b1319414..3d85a23b6c18 git log ed63b1319414..3d85a23b6c18 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 dtu@chromium.org [dashboard] Update bug link in README.md. 2018-08-16 anthonyalridge@google.com Fix bug in dot plotter for labels with invalid characters. Created with: gclient setdep -r src/third_party/catapult@3d85a23b6c18 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ia44d9c9b4e22db9ddaba3aed62e7a44ee27ab4d3 Reviewed-on: https://chromium-review.googlesource.com/1178541Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583787}
-
Tessa Nijssen authored
Previously, -requestSuggestions would asynchronously reset |suggestions_| on a thread separate from the main thread. This caused issues were -createCandidateListItem could try to read |suggestions_| while it was being reset, causing zombie dealloc crashes. Now, -requestSuggestions resets |suggestions_| on the main thread, so the previous crashes cannot happen. Bug: 717553 Change-Id: I016b054673fe8d2bb9bcb6c644c90b3c83eef311 Reviewed-on: https://chromium-review.googlesource.com/1175223Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#583786}
-
Vikas Soni authored
Use a different api to create AImageReader which also requires a flag. This flag tells the usage of the images generated by AImageReader. If the images are going to be used by GPU as a texture, we need to set the usage flag as AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE. Bug: 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I871183dd4b9b8dfcd723b40dd2162998c3f3a601 Reviewed-on: https://chromium-review.googlesource.com/1176541 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583785}
-
Charlie Harrison authored
Bug: 834710 Change-Id: I447f01b540cb35dd941b045d4d2934d4990c2ae2 Reviewed-on: https://chromium-review.googlesource.com/1148460Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#583784}
-
John Budorick authored
TBR=bpastene@chromium.org Bug: 861983 Change-Id: I1bcaf4ee54ae676e8dc62aaca0cd76caee8a8b90 Reviewed-on: https://chromium-review.googlesource.com/1178578 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583783}
-
Peter Beverloo authored
Native notification platforms use default (or configurable) indicators, so if an extension wants to play their own notification sound they should have the ability to mute those. This property already was available for the Web Notification API. Bug: 872698 Change-Id: Ie183ec9b28ff5bb80c674cc81b4cb275442aac0b Reviewed-on: https://chromium-review.googlesource.com/1169050Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583782}
-
Tom Anderson authored
This is a reland of c463a13b This CL removes BrowserShutdownBrowserTest.ShutdownConfirmation on non-ChromeOS since the test is only meaningful on ChromeOS. Original change's description: > Repurpose the confirm-quit-bubble to a quit-instruction-bubble > > It was decided in [1] that the Ctrl+Shift+Q shortcut should be removed > altogether and replaced with a bubble giving an alternative way to quit using > the keyboard (similar to the "Press Alt+Left to go back" bubble). > > [1] https://docs.google.com/document/d/1mvTBrxD58GIsqFiqgiLCZiXy1iOtDpQx_Tp5OSuYWEU/edit?usp=sharing > > BUG=243164 > R=sky > > Change-Id: I47578d6b750c45fbc5d0a6e6ffe7e5f528dbe80d > Reviewed-on: https://chromium-review.googlesource.com/1173654 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583138} TBR=sky Bug: 243164 Change-Id: I376e9b31c071b0c08e7f5cbe9e2bbda22ee1f1ac Reviewed-on: https://chromium-review.googlesource.com/1178165Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#583781}
-
Steven Bennetts authored
Notes: * The browser tests access ash::Shell directly so do not currently run with mash enabled; they will need to be re-factored (along with many other browser tests) to fix this. * ShellDelegate::PreInit is required by window_tree_host_manager_unittest.cc. The test that uses it can probably just be removed; I will do that in a follow-up CL. Bug: 705713 Change-Id: I002ca4ce30c3a7131af4ec97916c3f0f652ec90b Reviewed-on: https://chromium-review.googlesource.com/1168391 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583780}
-
Andrew Luo authored
Bug: 868610 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8ae54ae93effd83a9197d22d36df9536a5dfa631 Reviewed-on: https://chromium-review.googlesource.com/1155969Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#583779}
-