- 17 Apr, 2019 40 commits
-
-
Corentin Wallez authored
BUG=chromium:852089 TBR=kbr@chromium.org Change-Id: I63ba202ac4eb937088ee471a84d8d49ef0a2334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571690Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#651886}
-
Chris Hamilton authored
This is another step in the path to migrating the PageSignal mechanism. BUG=931407 Change-Id: I3e0b7503e6cf90eb1b058aa2edee4c9363753e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571014 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651885}
-
yilkal authored
This is a reland of adde9d0e Original change's description: > Replace indicator icon to kite for users under parental supervision. > > Bug: 944118 > Change-Id: I6ac8ce83c6037a6c6db3b15a111414c68707c8aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548567 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650543} Bug: 944118 Change-Id: Ia7211da37a272825a4613568f1f10fa8e0091d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566764 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651884}
-
David Tseng authored
- renaming anchor -> start, focus -> end, to match new api semantics - add idl definitions for new selection* properties - fixup ChromeVox closure (check for undefined focusObject) - add TODOs where needed Change-Id: Icd1aeced5ed2b5a63207e75f150958e3b067a241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565110 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651883}
-
Brandon Wylie authored
Secondary benefit is adding drawables for rounded rect focused/ unfocused states which we can use for new feed buttons. Bug: 936052 Change-Id: If19842d9eb9be0404064373a74b31e6d66bfff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566220Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651882}
-
manuk authored
This is the 10th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. Ignoring `/` slashes and interchanging 'about' and the embedder about scheme (e.g. 'chrome'), the user text is always a prefix of builtin suggestions. Previously, ACMatchClassifications were constructed manually by comparing lengths of input and match texts while compensating for optional symbols ('/' and ':'). With this CL, we remove some of the minor duplicated logic regarding determining trailing styles and reduce the manual creation by using `ClassifyTermMatches`. We still create `TermMatches` manually, but `ClassifyTermMatches` will create `ACMatchClassifications` from the `TermMatches`, which is simpler than creating the `ACMatchClassifications` manually. Unfortunately, we can't use `FindTermMatches` to create the `TermMatches` because the builtin provider treats 'about' and the embedder about scheme interchangeably (except for 'about:blank'). This CL does not change the suggestion texts, scoring, or classification; it only dedupes computing the classifications. Bug: 366623 Change-Id: I528a54c8b94fdd6b8dccbb3a3370b21c9efb1dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572205Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#651881}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e72d09e780ce..99b17bbcf7c4 git log e72d09e780ce..99b17bbcf7c4 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 tomhughes@chromium.org lakitu-st: mark experimental due to failing builds Created with: gclient setdep -r src/third_party/chromite@99b17bbcf7c4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8006b0f17cb9fea109a093cba9f670cebe2e8bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651880}
-
Johannes Henkel authored
New Revision: 34bdcd1fb46ec80fb22908ee03fdb7cacf2575ac - SpanFrom for string literals - CBOREncoder fix for envelopes > 4GB Change-Id: Iee560b91f837149bfd6327aae5ea4280d61daa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572499Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#651879}
-
Emil A Eklund authored
Remove unused DrawText methods from Font and GraphicsContext. Also merge one of the templetized DrawTextInternal methods into the calling method. Change-Id: I9b19ad4b2d4cc9bcf462c25a38b92c17fa4bd693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572207 Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#651878}
-
Rohan Pavone authored
When no document element, returns no such element instead of "null" JSON object. Bug: chromedriver:2850 Change-Id: I2b9d962c43ce934de1336e07643a1909d306888c Test: webdriver/tests/get_active_element/get.py:test_missing_document_element goes from FAIL => PASS. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570690 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Auto-Submit: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#651877}
-
Xianzhu Wang authored
This reverts commit 07b1529d. We need to think more about the expected behavior. Original change's description: > Test offsetLeft/offsetTop of multi-line inline elements > > Bug: 953572 > Change-Id: If3160a817ad784ea7c48f8f5ed7717f6de1bbff3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570474 > Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651616} TBR=wangxianzhu@chromium.org,kojii@chromium.org Change-Id: Id017a3a0d7c8a4197d30c85fa7220e6e8ea8f160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572858Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651876}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db8bc8a9d46c..8d6e1e0bfd92 Created with: gclient setdep -r src-internal@8d6e1e0bfd92 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I168e2aa42e0909062f9f9facc46004da0f8b5a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572194Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651875}
-
Manuel Rego Casasnovas authored
Iframes with "contain: strict" are causing crashes in CompositingRequirementsUpdater::UpdateRecursive(). This patch disables the CompositingInputsRoot optimization for that case to avoid the problems. Similar to what we do in r650009 for sticky elements. BUG=953159 TEST=fast/css/containment/compositing-inputs-root-iframe-crash.html Change-Id: I1f14310e24570137759f8456072c0bd090639346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570170 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651874}
-
Avery Musbach authored
The present CL changes the duration of the animation where the divider handle morphs into a circle when dragging starts or back to its original shape when dragging ends. The desired duration is specified here: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#project-resizing Test: manual Bug: 953819 Change-Id: I79267c9a6d1d2451ed771068beb35593fb4724af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572519Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#651873}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/084712c40e18..054acd5a4ade git log 084712c40e18..054acd5a4ade --date=short --no-merges --format='%ad %ae %s' 2019-04-17 treehugger-gerrit@google.com Merge "Switch to just choosing a random file name rather then TempFile::Create()" Created with: gclient setdep -r src/third_party/perfetto@054acd5a4ade The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8d79a4409914260a95ddffc1b78b1ec89be0673e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572197Reviewed-by:
-
Katie D authored
Bug: 951549 Change-Id: Iaf9abb6078eead4a3933665b073a2a02cf49064e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565267Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#651871}
-
Nikita Podguzov authored
Bug: 848942 Change-Id: Ib3efeb2c0eb7d53c213d15621d5b97637c9bd94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557029 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651870}
-
Eric Stevenson authored
It's flaky: expected_touch_action Which is: 63 whitelisted_touch_action.value() Which is: 15 TBR: boliu@chromium.org Bug: 951513 Change-Id: If560777787a8ffa51660f4a170901692d2a3a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572361Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#651869}
-
Jonathan Metzman authored
This replaces the previous strategy of doing a dry run of the build, which broke the builders which expected the archives to be created. Bug: 952412 Change-Id: I77d4fa95c9dae1e248fed0e20fd460cfdd18f9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572547Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651868}
-
Jonathan Backer authored
Bug: 935980 Change-Id: I04b0f8b8dd93bc478edc628871620a2c80b13366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572098Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651867}
-
Mike Wittman authored
There may be value in distinguishing code executing in the embedded code range from code in the heap code range. The former consists exclusively of builtin functions compiled into Chrome, while the latter contains mostly web-created functions. Bug: 909957 Change-Id: Ia4516dfe26c89d8c7e3bd765dc976e5e5c221806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570810 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651866}
-
Jordan Demeulenaere authored
This CL introduces the AutofillAssistantSizeManager to expose the height of the Autofill Assistant feature to the CompositorViewHolder such that it is considered when computing the size of the view area. Change-Id: I23529c5d89bf8970b0cbe42f67b180ae361d5e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565007Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Calling GetPosInSet and GetSetSize during a tree update has been causing numerous crashes. This change forces GetPosInSet and GetSetSize to return 0 if the tree is updating; the update state is stored in a member on AXTree. Bug: 951263 Change-Id: I5efb8e3b86ff13ca15a49273cbc2b4d04c00d67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559163 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
Use component build for ClusterFuzz's AFL builds to reduce build sizes. This will cause some fuzz targets to break on ClusterFuzz. However, the fuzzer breakages are probably not worth the large amounts of space the builds take up as a result. Bug: 913631, 701825 Change-Id: I27d0667834f58d34cba7a0b0c44edc7f2a1e82f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566716 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Mike Wasserman authored
Bug: 953752 Change-Id: I3d0b13ca1bed4b7d1d2cd7c0677be1bffd698015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572196 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#651862}
-
Jonathan Metzman authored
Fuzzer seems to timeout with deferred forkserver, probably because it is creating threads early. Don't defer so timeouts go away. Change-Id: I45542998dda7be4937911cd3bead87fc914eccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570919 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3b2c6bfd4353..0f7a2330c026 git log 3b2c6bfd4353..0f7a2330c026 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jonahr@google.com Modify test result output from dEQP tests for visualization script. 2019-04-17 geofflang@chromium.org Implement GL_CHROMIUM_lose_context. 2019-04-17 syoussefi@chromium.org Vulkan: Clear surface images if emulated format Created with: gclient setdep -r src/third_party/angle@0f7a2330c026 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I90e5df905b75fdc5e76da5a3ea1d4c85470fc6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572189Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5155e09d1466..105d7c24c9b4 git log 5155e09d1466..105d7c24c9b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 bsalomon@google.com Add flag to map buffer flags in GrCaps to indicate whether mapping a 2019-04-17 borenet@google.com [infra] More work on chrome_release_branch 2019-04-17 mtklein@google.com Add clang-cl arm64 builds Created with: gclient setdep -r src/third_party/skia@105d7c24c9b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I62f45dc493b66b2d707c2509d1175c0c1e2b3b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572188Reviewed-by:
-
Kevin Ellis authored
Bug: 827616 Change-Id: I874cce34e52d53e8ec52799343f8da8e8a50a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569553 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651858}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3ece7f0b. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" c1940432 "[WPT/common/security-features] Merge subresource path construction" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: If9e98a2df4fc08b8e3f580c76cf485df5a34533a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572267Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651857}
-
Ryan Hansberry authored
Display the dialog title in HTML in order to inherit correct styling (in a manner consistent with dialogs like InternetConfigDialog), and set height to 375px, the height of its Settings webui dialog analog. Bug: 856565 Change-Id: I8b353d849804a4c3066f802fae30a60e33efa60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570693Reviewed-by:
-
Saman Sami authored
There are a few issues with current implementation of closing surfaces: 1) It rejects any CompositorFrame that comes to the fallback surface. I'm not sure this is a good idea, because even though the frame is not for the primary surface, it still allows us to have something to show for the next display frame. What we really want is activating the frame immediately so that an ack is sent back to the client and it is unblocked for the next frame. 2) Closing the surface currently only affects future CompositorFrames. If a pending frame already exists, it is not activated. 3) It only closes the first surface in the range. We should close all surfaces in the range other than the last surface. This CL replaces closing surfaces with a different mechanism that marks surfaces as fallback and prevents them from ever blocking. Bug: 938947 Change-Id: Ida86143427f9bad1bb323e6edd9b45116e813735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558452 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651855}
-
Nate Fischer authored
This modifies apk_operations to raise an error when trying to set CLI flags on user build devices. This is an exception if setting flags for WebView (WebView never supports flags on non-user builds), and is a warning for other APKs. For the "launch" command, this only warns if the user explicitly passed a value for "--args". This is to avoid spamming the user in the default case if they didn't intend to modify flags (i.e., we're clearing already cleared flags). This is a follow-up to http://crrev/c/1458369. Bug: 918727, 918221 Test: out/Default/bin/monochrome_apk launch url --args='one two three' Test: out/Default/bin/system_webview_apk argv --args='one two three' Test: Upload to gerrit > open file > click "gitiles" (to check markdown) Change-Id: Ida4f095ce26cc01ab64073addb04c987f4d0614a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568783Reviewed-by:
-
Roman Sorokin authored
Also switched to OobeBaseTest Bug: 952855 Change-Id: I3161b83da25041e4ca48df92a8409075c5039de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572122Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651853}
-
David Tseng authored
AXTree::GetSetSize will ignore this view when descending down the views tree to count tabs. Previously, TabStrip had an unknown accessibility role, which causes AXTree::GetSetSize to stop counting and not desecnd into the tab strip's children. Bug: 876404 Change-Id: Ib9e39f2c1ef0c4c3ef398775450015e2b3edc09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565082 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#651852}
-
Sidney San Martín authored
This relands the original change, fixing a use-after-free when BrowserWindowDefaultTouchBar outlives its profile. Original change's description: > This is a design tweak which also enables the back and forward buttons > to be placed separately. Existing customized Touch Bars which contain > the grouped item still work; see the code comment for details. > > I used Cocoa bindings for the buttons' enabled states instead of holding > pointers to them because I initially thought that the Touch Bar might allow the > group and individual buttons to coexist. Turns out no, but I kept the KVO > implementation because I like it. > > It also includes a couple of other changes that came up while writing > this patch and during code review: > > - The unit tests no longer look for a hard-coded list of items in a > specific order. Instead, they verify that BrowserWindowDefaultTouchBar > can create the items it claims to be able to create, and that no > known-valid identifiers have stopped working. > > - BrowserWindowDefaultTouchBar returns nil if it doesn't know about an > identifier, instead of returning an empty Touch Bar item. > > Bug: 937935 > Change-Id: I8cdc6347bc667b0a24fa24fe2c6a56661747ac98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534238 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649899} Bug: 937935, 945772 Change-Id: I77bf9b6d14bef875f271f8fbd4468e6cdc30434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568846 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Jonathan Backer authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1566685 Bug: 952231 Change-Id: Ifc193d8745fbe8ea6702b73adda6cb0f3b5a1943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572227Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651850}
-
Mike Wittman authored
Implements the Unwinder subclass necessary to use the V8 asynchronous unwind functionality with the StackSamplingProfiler. Does yet make use of the unwinder. Bug: 909957 Change-Id: I3974e0a4c2ed7eac36715d3deb84074b2c65af1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566371 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Mike Wittman authored
Applies the same IsProfilerEnabledForCurrentProcess() check to ThreadProfiler::AddAuxUnwinder() as is used for the other member functions, to avoid trying to set an aux unwinder on a null profiler. Bug: 909957 Change-Id: I1f131132d6bf021e3502d175b068854c98856f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570608 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/59a49bc5cdff..60caf55788c6 git log 59a49bc5cdff..60caf55788c6 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 fjhenigman@users.noreply.github.com Package and upload builds. (#595) Created with: gclient setdep -r src/third_party/shaderc/src@60caf55788c6 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6d625744ffb53b862fd6f04f34cc9661970e04bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572190Reviewed-by:
-
