- 10 May, 2018 40 commits
-
-
Chris Nardi authored
Document#selectedStylesheetSet/preferredStylesheetSet are non-standard methods that are only implemented by WebKit and Blink. Their standard versions are no longer in the spec. Remove them entirely from our implementation. Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/w1Bv7YZxAco Bug: 690609 Change-Id: I796a6bc0693934eb308a4fe59b52e4a9d1269e6f Reviewed-on: https://chromium-review.googlesource.com/1049051 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#557569}
-
Nate Chapin authored
This reverts commit 0817c1db. Reason for revert: Canceling and redirecting causes a variety of small, strange behaviors, revert while landing a better solution (https://chromium-review.googlesource.com/c/chromium/src/+/1053237) Original change's description: > Do partial redirect handling in the renderer process for sync requests > > Historically, blink has not received any intermediate resource loading > callbacks for sync requests. It simply blocked until the load finished > or failed, which meant that redirect security checks performed by blink > would be skipped (and in some cases we would try to reconstruct or do > a partial security check after the fact). SyncLoadContext allows us to > do more of these security checks before the redirect is sent. This > allows us to come closer to doing the correct thing for sync request > in general, and allows us to move some worker requests off-main-thread, > where before they had to proxy sync requests through the main thread in > order to get both proper redirect handling and the correct synchronous > behavior. > > This CL "cancels" sync requests on redirect. WebURLLoaderImpl then > notifies blink of the redirect, which sends FetchContext callbacks (but > not ResourceClient callbacks). This allows us to do things CSP checking > on redirect. If blink permits the redirect, WebURLLoaderImpl manually > follows the redirect by issuing a new sync request. > > ResourceClient callbacks aren't performed becuase sync requests have > historically not been associated with a ResourceClient. Doing so would > be a much large refactor, and would require careful handling to make sure > we didn't enter JS inside what is supposed to be a synchronous blocking > function. > > We therefore need to continue to perform a rudimentary CORS check in > SyncLoadContext, which blocks cross-origin redirects if the > FetchRequestMode was anything other than kNoCors. This revealed a couple > of XML/XSLT callsites that should have been setting a FetchRequestMode but > weren't. > > Bug: 706331 > > Change-Id: I4ed54cb3ccd119b8a5d192b077bef8d03745e67e > Reviewed-on: https://chromium-review.googlesource.com/1015237 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556546} TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,yhirano@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 706331 Change-Id: Id42378ac08f67861aac524ab618b782010970577 Reviewed-on: https://chromium-review.googlesource.com/1054108Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#557568}
-
Robert Ma authored
TBR=foolip No-Try: True Bug: 841809 Change-Id: I4355f56ff832b43f62cabf9de76f41bf60ebf94d Reviewed-on: https://chromium-review.googlesource.com/1054100Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#557567}
-
Olga Sharonova authored
Change-Id: Id6cb550886ea6aa8e3ae48c9a72e4ac70b8db038 Reviewed-on: https://chromium-review.googlesource.com/1054069Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557566}
-
Robert Phillips authored
This reverts commit 035c0c8f. Reason for revert: compile failures Original change's description: > Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits) > > https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 > > $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' > 2018-05-10 reed allow divide by zero > 2018-05-10 fmalita Validate readByteArrayAsData size > 2018-05-07 enne Add driver bug workarounds to GrCaps > 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. > 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization > 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" > 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. > 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) > > Created with: > roll-dep src/third_party/skia > BUG=chromium: 829614 > > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=egdaniel@chromium.org > > Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc > Reviewed-on: https://chromium-review.googlesource.com/1053760 > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#557555} TBR=egdaniel@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I8f3ada64dc671959da55bc34763a706bcd7cf86d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1054048Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#557565}
-
Leonard Grey authored
Bug: 840456 Change-Id: Idf022ee3493207ab64dd72d25a70f2527f557fad Reviewed-on: https://chromium-review.googlesource.com/1048068Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557564}
-
Guido Urdaneta authored
Bug: 823640 Change-Id: Iede7cc3d9a7b7f39b89810914dcda1cb61379cdc Reviewed-on: https://chromium-review.googlesource.com/1041865Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557563}
-
Ben Pastene authored
Also add a couple not-so-small gtests (base_unittests and net_unittests) to the fyi test bot. Current test pool has 20 bots. Will bump more if needed, but given how rarely I think analyze would trigger these specific tests, maybe not needed? Bug: 840967 Change-Id: Id71c7f0899790da95a8c3ff60ea62d3f831511ee Reviewed-on: https://chromium-review.googlesource.com/1053235Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#557562}
-
Rohit Rao authored
BUG=840381,839428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id20bd04c30c03bb98dbb9ac9c8c6013fc245b950 Reviewed-on: https://chromium-review.googlesource.com/1052904 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#557561}
-
Becky Zhou authored
Adds a method to enable show request that wants to show the specified dialog as the next available of a specific dialog type. Bug: 838280 Change-Id: I41ac8b427fe21b27343fddc5f7dbeaf137be0063 Reviewed-on: https://chromium-review.googlesource.com/1053387 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557560}
-
Sebastien Marchand authored
For use in incognito sessions. Bug: 773382 Change-Id: I5222eeb2de25c4b5a87e5a41b261d99cbea6de54 Reviewed-on: https://chromium-review.googlesource.com/1053180 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#557559}
-
Peng Huang authored
The logic in viz::Display is for using VSync for presentation callback, it is not right when we can get the presentation feedback from GLSurface. This CL fixes the issue. This CL also change the logic of GLSurfacePresentationHelper to make sure the presentation callback is run after SwapBuffers is returned. Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifad2088316982e328bf56ef6b9c3eab6f478bb6d Reviewed-on: https://chromium-review.googlesource.com/1051967 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557558}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7c3ff1311a45..d3f2c8e78346 $ git log 7c3ff1311..d3f2c8e78 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 kkinnunen win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain Created with: roll-dep src/third_party/depot_tools BUG=chromium:834656 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I73791492e502ea9d0dca607a646154eecdf735d9 Reviewed-on: https://chromium-review.googlesource.com/1053762 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557557}
-
Koji Ishii authored
When a word in 'nowrap' element fits but its trailing space does not, issue 561997 fixed not to wrap before the 'nowrap' element. The fix, however, creates a wrap opportunity even if 'nowrap' content follows. This patch ensures the fix is valid only if no content follows or autowrap content follows; i.e., only when we really have a break opportunity after the space. Ideally, the original fix should have been done when the line breaker reads the next item. But we have a lot of places that call FitsOnLine() without 'ExcludeWhitespace' option and probably some of them are not correct. To make the fix safer, this patch limits the original fix instead of cleaning up all FitsOnLine() calls. Change-Id: I78c499cc6c1d7c30261e031ec19124ae9d3fbcf1 Bug: 561997, 840755 Reviewed-on: https://chromium-review.googlesource.com/1053341Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#557556}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 reed allow divide by zero 2018-05-10 fmalita Validate readByteArrayAsData size 2018-05-07 enne Add driver bug workarounds to GrCaps 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc Reviewed-on: https://chromium-review.googlesource.com/1053760 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557555}
-
Ryan Sleevi authored
When/where appropriate, the following conversions are made: - Range based for-loops when iterating - constexpr base::StringPiece for string constants - [std::]begin() / [std::]end() when copying - base::size() as last resort Bug: 837308 Change-Id: I640ced508edb0b12f44534e0173a9d9402e627b6 Reviewed-on: https://chromium-review.googlesource.com/1043687 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557554}
-
Greg Kraynov authored
Bug: 841735 Change-Id: I8d87679e2c813b91a6c45981ef0cc0c73a90191e Reviewed-on: https://chromium-review.googlesource.com/1053808Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557553}
-
Greg Kraynov authored
Bug: 841735 Change-Id: I268a97109e95d435a3cb64e8d04f8741ebc60bda Reviewed-on: https://chromium-review.googlesource.com/1054028Reviewed-by:
-
Sebastien Marchand authored
This will be used as a part of the Site Characteristics Database to make sure that we don't record anything during incognito sessions. Bug: 773382 Change-Id: Ia4de800fde921ce04ce6612e80d34842b62ace8e Reviewed-on: https://chromium-review.googlesource.com/1053100 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Theresa authored
Remove a handful of feature flags that are no longer used. BUG=814528 Change-Id: Iaee99938d9aeac35c32477b590534a0359d62b12 Reviewed-on: https://chromium-review.googlesource.com/1053305Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557550}
-
Fernando Serboncini authored
Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic9ccf732ab6425c60fb3e2df4d53d239bde5d920 Reviewed-on: https://chromium-review.googlesource.com/1037921Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557549}
-
Devlin Cronin authored
Awhile back, we added logic to withhold all-hosts style permissions via sync if the user had withheld hosts on any machine. This was a mistake, since it resulted in the user being affected by an experiment across all machines, even if they only opted into the experiment on one. Remove the all_urls_enabled bit on the ExtensionSpecifics proto. A replacement will be added in a subsequent patch. We can't just re-use the existing one, because we need to prevent older machines from seeing the preference and automatically applying experimental behavior. Bug: 839681 Change-Id: I735b7005ca76b9abe3b61709083bb4f552d0a47f Reviewed-on: https://chromium-review.googlesource.com/1047850 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557548}
-
Kevin Bailey authored
A new file URL parsing routine was added in a previous CL (1025953) for detecting hash/pound refs in file URLs. This made file: schemes a bit of an exception. This CL removes that routine and leverages the existing routine, calling it from where the other URL types are parsed, treating file: schemes like the other schemes. Bug: 780835 Change-Id: Ic7f00b88e50801d00c609c1a92d00d1f1bf67808 Reviewed-on: https://chromium-review.googlesource.com/1043157 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557547}
-
Emily Hanley authored
Bug: 804982 Change-Id: Ib2f1de287654280bf24065f1873f6a901bcfc2e2 Reviewed-on: https://chromium-review.googlesource.com/1053800Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557546}
-
Jonas Olsson authored
Internally it uses a new, slightly simplified copy of MojoAudioInputIPC. Bug: 834702 Change-Id: I878ada69d82c72a431b7fdfe1905ae79b3d8963d Reviewed-on: https://chromium-review.googlesource.com/1041686Reviewed-by:
-
Theresa authored
ContextualSuggestionsMediator#removeSuggestions() tells the BottomSheet to hide and destroys sub-component coordinators, which unregister their views as model observers. Calling #removeSuggestions() before clearing the model ensures that views won't respond to model changes while the sheet is closing. This fixes a bug where the toolbar was blank while the sheet was closing. BUG=840579 Change-Id: Ia940c974b1d48b19073d5285176db72447b6b318 Reviewed-on: https://chromium-review.googlesource.com/1048876Reviewed-by:
-
Peter Wen authored
Add a new flag for generate_gradle.py, --native-target <gn target name>. This allows C++ editing when --all is either passed or implicit (by default). Starting with --native-target //chrome/android:monochrome in Android Studio Canary (3.2) will result in most of the C++ files being indexed and available both via the Android project view as well as the double shift "search everywhere" box. Switched maven URL to use "google()" instead, this works for all Android Studio 3.0+, which covers all of stable/beta/canary. Add specific AndroidManifest.xml to be used for the _all pseudo gradle module since Android Studio now requires minSdk to not be specified in the AndroidManifest.xml file. Bug: 841529,827294,840368 Change-Id: Ifdee12bf7f9e7faf81cabf92dbf4c5613eb89996 Reviewed-on: https://chromium-review.googlesource.com/1053117Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557543}
-
Philip Rogers authored
This reverts commit 0419866e. Reason for revert: This was not the cause of the test failures. Original change's description: > Revert "[CI] Use LFV::VisibleContentSize() over LFV::VisibleContentRect().Size()" > > This reverts commit bea7337b. > > Reason for revert: Might have caused https://crbug.com/841536 > > Original change's description: > > [CI] Use LFV::VisibleContentSize() over LFV::VisibleContentRect().Size() > > > > This is a small cleanup to use the size directly, if available, rather > > than creating the rect and then just getting the size. Found while > > working on https://crbug.com/838111 > > > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I678fc42b76bcda168b8e5f68fd9c357ad57dca42 > > Reviewed-on: https://chromium-review.googlesource.com/1050969 > > Commit-Queue: Philip Rogers <pdr@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557229} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Idd9c9621607afb909622119c2ef2f301342ff51d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1053148 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557318} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I1f9d2b9d1040fc18e104fe8e6346780bf5ad9078 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1054107Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557542}
-
sczs authored
-Deletes the following unused classes: BookmarkElevatedToolbar, LegacyBookmarkParentFolderItem, LegacyBookmarkTextFieldItem. -Creates a BookmarkUIConstants file. -Adds a Legacy prefix to BookmarkCells, to prepare for refresh cells. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I35662f194eaada4f95cbf46b636426cc98767ca4 Reviewed-on: https://chromium-review.googlesource.com/1049064Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#557541}
-
Rohit Rao authored
Model-related code moves into BookmarkHomeMediator. UI and cell-related code moves into BookmarkHomeViewController. BUG=840381 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5686c67a69c62aa8908b8e168d31a0f13c70e11e Reviewed-on: https://chromium-review.googlesource.com/1052887Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3f3bcb2..9c5f77a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic719fccf4080f0dbc73c9eab848e36810cbd3bfa Reviewed-on: https://chromium-review.googlesource.com/1053829Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#557539}
-
W. James MacLean authored
The MouseEnter/Leave logic in RenderWidgetHostInputEventRouter expects child frames to return a non-null GetParentView(), but children that are RenderWidgetHostViewGuests currently return null, causing the logic to fail. This CL fixes that. Bug: 835566 Change-Id: I0792772872e10134f4c79b8f929bc4271543f00e Reviewed-on: https://chromium-review.googlesource.com/1050613Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#557538}
-
Leonard Grey authored
Currently, we ensure that the bookmark bar view is always the first child view of its parent to ensure that toolbar inkdrops are drawn on top of it. Unfortunately, this breaks keyboard traversal order. This change implements |GetChildrenInZOrder| on the two views that host the bookmark bar: browser view and top container view. This ensures that the bookmark bar is painted first, removing the need to manipulate child view order. Bug: 712347 Change-Id: If8f2aabe816a86b7ec29ff41779783c0f05a6393 Reviewed-on: https://chromium-review.googlesource.com/1052854 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557537}
-
Thiemo Nagel authored
Having already enrolled the device is no reason for failing to obtain the serial number anymore (https://crrev.com/c/442464). At that occasion, also fix inconsistencies in the description of the serial number logic and append ForTest to the name of the kSerialNumberKey constant. TBR=emaxx Bug: 823724 Change-Id: Ic129f4e1141843b695e6f079d684bfd53bdb3810 Reviewed-on: https://chromium-review.googlesource.com/1051770 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#557536}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 177388b6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17246 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure TBR=markdittmer No-Export: true Change-Id: Id8ab2164087fde30653d51a0bed52efbc436260e Reviewed-on: https://chromium-review.googlesource.com/1053830 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557535}
-
https://webrtc.googlesource.com/src.git/+log/b4e0e50a2bbf..7f0a06955092 $ git log b4e0e50a2..7f0a06955 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I156138d5ceb5ffe35f8d9dabcfecc624f7824dd9 Reviewed-on: https://chromium-review.googlesource.com/1053747Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557534}
-
David Bokan authored
Most "scrolling" tests in Blink are in the fast/scrolling and fast/events directories, the latter due to testing touch, wheel, keyboard, etc. events. Many of these will use eventSender and so avoid the composited path entirely so they provide just some mildly useful main-thread scrolling coverage. Some do use gpuBenchmarking and are thus more useful. Bug: 836913,840017,841342,841423 Change-Id: Idc4c2fae7ee7a48f074df8b3df5a027a75c82f71 Reviewed-on: https://chromium-review.googlesource.com/1052823Reviewed-by:
-
Emily Hanley authored
Bug: 841757 Change-Id: I423f9dd3854eefdd5255f0a4524255820b0cbde5 Reviewed-on: https://chromium-review.googlesource.com/1053752 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#557532}
-
Greg Kraynov authored
It's getting moved to //base, so renderer.scheduler tracing category is inappropriate. Bug: 783309 Change-Id: I8280a218188f2de721f752f1c58cdf6555cb0943 Reviewed-on: https://chromium-review.googlesource.com/1052130Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557531}
-
Tibor Goldschwendt authored
Bug: 840931 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I7e1b336aeed1648fcbe01ae479f486e0b8ba5ac4 Reviewed-on: https://chromium-review.googlesource.com/1053065 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#557530}
-
