- 24 Aug, 2018 40 commits
-
-
Tonko Sabolčec authored
This CL includes: - Add build rule +components/prefs to os_crypt component. - Add a preference key creation. - Implement utility tool to get/set the preference. Bug: 791541 Change-Id: I50835a6edeb62aaef28566d08162accf7789c8eb Reviewed-on: https://chromium-review.googlesource.com/1183361Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Cr-Commit-Position: refs/heads/master@{#585760}
-
Khushal authored
If the same image is being displayed by multiple compositors, the decode tasks currently use the same ImageDecoder protected by a common mutex. This leads to janks in the case of animated images where the tasks from different compositors to decode the same image can not execute in parallel. For animated images in particular, using the same decoder also results in defeating the internal caching in the decoder. The decoder currently caches dependent frames assuming that a decode for frame n will be followed by a decode request for frame n+1. If different compositors use the same decoder and run different timelines for the same animation, the decode requests can run out of order and defeat this caching causing a re-decode of the complete dependency chain. To avoid this, assign a GUID to each compositor which is passed through to blink via the PaintImageGenerator callback for requesting a decode. This allows the ImageFrameGenerator to assign different decoders to each compositor, and also allow the decode work to run in parallel. R=chrishtr@chromium.org TBR=vmpstr@chromium.org Bug: 872753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I338b9a31550df1dcfaf777a3e8372d1828fa0043 Reviewed-on: https://chromium-review.googlesource.com/1185793 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#585759}
-
Alexandre Courbot authored
This method has no user besides its own unit test, and we want to remove all non-const methods from VideoFrameLayout. BUG=876986 TEST=built vdatest and Chromium. Change-Id: I5f332416c25a747685f2194989a61df225bb1159 Reviewed-on: https://chromium-review.googlesource.com/1186286 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585758}
-
Khushal authored
Bug: 876789 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie06484b957bd4d60b9377ad55f356280867acba6 Reviewed-on: https://chromium-review.googlesource.com/1187717Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#585757}
-
Yoshifumi Inoue authored
NOT READY FOR COMMIT To commit this patch, I need to do: - Rebaseline 9500+ layout files for linux, mac, win, since existing implementation doesn't conform the spec[1] - Fix DOM distiller bug[3] It depends on textContent(true) to have newline for <br> https://github.com/chromium/dom-distiller/issues/10 WebTextTest.testGenerateOutputBRElements should have spec complaint test expectation - Fix CrSettingsSiteDetailsPermissionTest.All change expectations to have <option>s This patch implements Element#innerText to conform the spec[1]. Pass rate of WPT is changed from 78 failures to 6 failures for 213 test cases. The design doc is https://goo.gl/VW9xxe. The differences of current implementations are: - No more leading/training newlines - No more trailing whitespaces - At most two newlines between sequences of <p> and <div>. - Contents of <select>, <optgroup> and <option> in result. - No newline for <br> for disconnected element. Note: Handling of <select>, <optgroup> and <option> aren't conformed with the spec[1] since the spec[1] requires to implement Element#innerText specific CSS handling, ::first-line, ::first-letter, text-transform etc, for contents of <option>. I filed the issue[2]. [1] https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute [2] https://github.com/whatwg/html/issues/3797 innerText for <select>, <optgroup> and <option> TBR=alexmos@chromium.org TBR=dpapad@chromium.org TBR=dmazzoni@chromium.org TBR=skyostil@chromium.org Bug: 651764, 859410 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I48a02db0347d8ebd189f3ef608b31a4a93d89e84 Reviewed-on: https://chromium-review.googlesource.com/1114673 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#585756}
-
Gauthier Ambard authored
This CL fixes an issue where the LongPress InProductHelp wasn't displayed after displaying the BottomToolbar help as the event was registered. This CL registers the bottom_toolbar_opened event when the tip is shown. It also fixes a couple a minor issues in the bubble presenter. Bug: 877004 TBR: nyquist@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id8c3906c6026ae84d1de09d9c953c2cea887f81d Reviewed-on: https://chromium-review.googlesource.com/1186410Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585755}
-
Kouhei Ueno authored
Before this CL, Signed Exchange parser implementation in Chromium expected the b1 format [spec-b1]. This CL switches the parser implementation to expect the updated specification which we will snapshot as the b2 format in near future, and deprecate support for parsing the b1 format. Overview: - The magic strings and version specifiers are changed from b1 -> b2. - RequestUrl was a part of cbor_headers in b1, but is now located in the prologue section. - As a result, SignedExchangePrologue is now split into two: {BeforeFallbackUrl, FallbackUrlAndAfter} - Signature message bytes are now encoded using custom binary format (was CBOR in b1) - cbor_headers no longer go through enc(dec(original_bytes)), fixes crbug.com/863499 Note: fallbackUrl redirect on parse fail (crbug.com/874323 ) is to be addressed in separate CL. [spec-b1] https://tools.ietf.org/html/draft-yasskin-httpbis-origin-signed-exchanges-impl-01 Bug: 803774, 863499, 876968 Change-Id: Ib172411e075472dcaae21af9c7460af5b5cf4e52 Reviewed-on: https://chromium-review.googlesource.com/1183053 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#585754}
-
Kent Tamura authored
This is a regression by http://crrev.com/579748. If we request opening multiple file choosers, and one of the corresponding blink::FileChooser object is deallocated before calling its OpenFileChooser(), ChromeClientImpl had a stale pointer. ChromeClientImpl should have Vector<scoped_refptr<FileChooser>> instead of Vector<FileChooser*>. Bug: 877269 Change-Id: I296e6ac83b858e1b74fecff87e7a2fa7f9b96765 Reviewed-on: https://chromium-review.googlesource.com/1188009Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c6514490e96..2a53275c38fb git log 4c6514490e96..2a53275c38fb --date=short --no-merges --format='%ad %ae %s' 2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c40974417610..221fa26170ae (4 commits) 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 herb@google.com Move mask rendering to its own routine 2018-08-23 herb@google.com Simplify lifetime of scaler context for remote cache 2018-08-23 bsalomon@google.com Add support for dynamic state GP textures in Vulkan backend. 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 bungeman@google.com Make create_test_font less global-ish. 2018-08-23 mtklein@google.com Revert "match sRGB primaries with skcms" 2018-08-23 reed@google.com don't recurse forever 2018-08-23 allanmac@google.com Missing Makefile 2018-08-23 allanmac@google.com Fix HotSort benchmark and typo 2018-08-23 fmalita@chromium.org [skottie] Guard against missing solid layer color property 2018-08-23 fmalita@chromium.org [skottie] Ref-counted ResourceProvider 2018-08-23 herb@google.com Make calling convention usable by remote cache 2018-08-23 halcanary@google.com SkQP: test_apk.sh tool 2018-08-23 mtklein@google.com match sRGB primaries with skcms 2018-08-23 robertphillips@google.com Switch GrTextTarget from drawPath to drawShape 2018-08-23 robertphillips@google.com Fold directFilterRRectMaskGPU into directFilterMaskGPU 2018-08-23 herb@google.com Introduce SkGlyphCacheInterface 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms e8e06f9724b0..5f03dc9abfb1 (1 commits) Created with: gclient setdep -r src/third_party/skia@2a53275c38fb The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I5fe039fb3cb19f7e13e663e453f2aab57523e4d0 Reviewed-on: https://chromium-review.googlesource.com/1187924Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585752}
-
Eriko Kurimoto authored
Trivial error Change-Id: I5c18977781576bf4353ca7154d24962f81e38a9e Reviewed-on: https://chromium-review.googlesource.com/1184730Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#585751}
-
David Jean authored
Added a function to remove all items from a section, so that only that section can be regenerated dynamically. Bug: 826094 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia873e56b0bbb8d9527b719d665ed536dddf83d41 Reviewed-on: https://chromium-review.googlesource.com/1186401 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#585750}
-
Hayato Ito authored
NOTRY=true TBR=yosin@chromium.org BUG: 877300 Change-Id: If8e8cc5af93f55e9a848d46fa6e1196990d62081 Reviewed-on: https://chromium-review.googlesource.com/1187845 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a1ed44d248a..a9a4168ab6e9 git log 7a1ed44d248a..a9a4168ab6e9 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 agrieve@chromium.org cmd_helper: Don't crash when logging command with None in arg list 2018-08-24 simonhatch@chromium.org Pinpoint - Summarize histograms if needed 2018-08-23 benjhayden@chromium.org Add a Material switch for V2SPA. 2018-08-23 eakuefner@chromium.org [TBMv2] Add legacy JSON converter Created with: gclient setdep -r src/third_party/catapult@a9a4168ab6e9 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843643 TBR=sullivan@chromium.org Change-Id: I41299c36589c788d8ad539502009a1c392258a1e Reviewed-on: https://chromium-review.googlesource.com/1187923Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585748}
-
Gustaf Ullberg authored
Bug: chromium:876979 Change-Id: I363a287773c84ab1cc1ddc8606ae9cb6e226938f Reviewed-on: https://chromium-review.googlesource.com/1186339Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#585747}
-
Yutaka Hirano authored
In addition to error handler (i.e., self.onerror), stop dispatching a error event for an event listener in a foreign world. Bur: 225513 Change-Id: I757dcfbefdd6b31711c29fe4f91ce7d7e764e992 Reviewed-on: https://chromium-review.googlesource.com/1187844Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c40974417610..d6781dce3d25 git log c40974417610..d6781dce3d25 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 jie.a.chen@intel.com Extend LinkProgramPerfTest to support compile only 2018-08-23 syoussefi@google.com Re-enable BlitFramebuffer tests 2018-08-23 fjhenigman@chromium.org Roll chromium DEPS. 2018-08-23 jmadill@chromium.org Optimize ValidateDrawStates. 2018-08-23 jmadill@chromium.org Add validation state change test for draw framebuffer. Created with: gclient setdep -r src/third_party/angle@d6781dce3d25 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849576 TBR=cwallez@chromium.org Change-Id: Idd1d828d80820efcdc78d6c57c0f51898365b770 Reviewed-on: https://chromium-review.googlesource.com/1188102Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585745}
-
Jun Choi authored
Currently when FidoDevice fails on AuthenticatorGetInfo command, we assume that the device supports U2F protocol and initiate U2F request. Prior to initiating request, check whether AuthenticatorGetInfo command failed due to any device communication error. If the failure was caused by device error, drop remaining requests on the device. Also, to prevent similar failures, always check for device state before dispatching consecutive requests to authenticators. Bug: 872293 Change-Id: I82d83975eec8177adb447e5e94711126884f5b5f Reviewed-on: https://chromium-review.googlesource.com/1168505 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585744}
-
Vlad Tsyrklevich authored
I missed deleting these unnecessary entries in https://crrev.com/c/1174912 The cfi-icall bot has been retired and we do not need to specify cfi_icall anymore as it is now enabled by is_cfi=true on Linux. Bug: 874112 Change-Id: I90b525714a2ce39eceb0c0d0bf06429b83721f4c Reviewed-on: https://chromium-review.googlesource.com/1184166Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#585743}
-
Eriko Kurimoto authored
Change-Id: I8494b52cd7a38d2b52184f4fb02030d3a05da776 Reviewed-on: https://chromium-review.googlesource.com/1187861Reviewed-by:
-
Tetsui Ohkubo authored
This CL replaces WiFi badges (e.g. captive portal, or secure network) to new ones. The icons are specific to ash so they are placed in ash/resources/vector_icons. TEST=manual BUG=876218 Change-Id: I48ee6d99fa6c704576c2f40dc9b0bf79cb5d672d Reviewed-on: https://chromium-review.googlesource.com/1184727 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585741}
-
Khushal authored
Currently ImageFrameGenerator can only be used for decoding from a single thread at a time, with the access to any decoder for this generator protected using the same mutex. This can result in janks where the same image is being animated by multiple compositors in the same process, since the decode tasks from these compositors can not execute in parallel. In order to allow multiple threads to use different decoders backed by the same generator, this change splits the piece in the generator which uses the decoder into a ImageDecoderWrapper. This makes it explicit that different decoders can be used concurrently, as long as the access is synchronized with a mutex per decoder. The change should be a no-op. R=chrishtr@chromium.org Bug: 872753 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib31ca739fbf858e0dc292dc9b47f9fd4a087956d Reviewed-on: https://chromium-review.googlesource.com/1185629Reviewed-by:
-
Wenzhao (Colin) Zang authored
This reverts commit 40b9105e. Reason for revert: affecting virtual keyboard UI in google3 (crbug.com/877302) Original change's description: > cros: Allow frame-less windows to show shadow > > The current code assumes that a frame-less window does not need shadow. > However, it's important for the CrOS wallpaper picker to remain > frame-less to support wallpaper preview in tablet mode (spec [1]), and > have a shadow in clamshell mode. It should makes sense to delete this > logic since wallpaper picker is the only component extension that needs > this behavior, and no current public apps are able to use the API. > > [1] https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 > > Bug: 835205 > Change-Id: I96c9b14806f8f03ea2278d11031a33b08e7a68e8 > Reviewed-on: https://chromium-review.googlesource.com/1135577 > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582036} TBR=tapted@chromium.org,benwells@chromium.org,wzang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835205 Change-Id: I4a840224924d691fd7545a8b6252368fe06161d7 Reviewed-on: https://chromium-review.googlesource.com/1187784Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#585739}
-
Matt Falkenhagen authored
In preparation for extending or modifying the test to test Client.url and resultingClientId for https://github.com/whatwg/html/pull/3891. Bug: 876223 Change-Id: I50e8b8c21c5f8639a24a9c2ec00df3ccafdc8ac8 Reviewed-on: https://chromium-review.googlesource.com/1184656 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585738}
-
Matt Falkenhagen authored
context_ can be null. No test added since there's no script cache map unittest. Bug: 877360 Change-Id: Ib95d89255b0706d13cb784d812cb984903aa0c4a Reviewed-on: https://chromium-review.googlesource.com/1188007 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585737}
-
Kunihiko Sakamoto authored
LocalFrame has |should_send_resource_timing_info_to_parent_| flag not to send timing info to parent except for the first navigation. This flag is cleared when the first timing is sent to parent, however this does not happen if iframe's first navigation was by back-forward navigation. For such iframes, we shouldn't send timings to parent at all. Bug: 876822 Change-Id: I128b51a82ef278c439548afc8283ae63abdef5c5 Reviewed-on: https://chromium-review.googlesource.com/1186215Reviewed-by:
-
Michael Lippautz authored
- AdvanceTracing: Removes the parameter for force finishing and just relies on the deadline (infinity) to finish tracing. - EnterFinalPause: Take a parameter indicating the embedder stack state. This is useful for followup work to avoid scanning the stack. Bug: chromium:843903 Change-Id: I5803947834ed38f8062cb7db819a7b98bd77ab30 Reviewed-on: https://chromium-review.googlesource.com/1186467Reviewed-by:
-
Yue Li authored
Bug: None Test: Manual Test Change-Id: I32479f1453ed23018bcde8e3180f114eb039973f Reviewed-on: https://chromium-review.googlesource.com/1186118Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#585734}
-
Lutz Justen authored
Changes affiliation test helper from a bunch of static methods to a class with two factory methods, one for cloud management, the other for Active Directory management. The former implementation was a bit hand- waving ("pass the same session manager instance into the two Set*AffiliationIDs functions", "you don't need fake_auth_policy_client for non-AD accounts"). The class is much cleaner. Internally, it doesn't rely on side effects ("we're probably in AD mode if the auth policy client has been started"). BUG=chromium:865969 TEST=tryjobs Change-Id: I4ba5e0f9e4b410532cd098cd5ae73f2156a58c83 Reviewed-on: https://chromium-review.googlesource.com/1168496Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#585733}
-
Alan Cutter authored
This CL ensures the TabHelper of a PWA WebContents is updated to indicate whether it has it's own "extension" window or not to ensure it gets cleaned up appropriately on uninstall. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354491&signed_aid=mELqu3AB-QBQpk1qojP7qg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354490&signed_aid=4RqFYkoMkmsndSMnrq5inA==&inline=1 Bug: 877009 Change-Id: I81e7888260a40df68f5e9a5443ea2a815b8a686f Reviewed-on: https://chromium-review.googlesource.com/1186388 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#585732}
-
Max Moroz authored
This reverts commit 1501aabf. Reason for revert: broke a build that was used for fuzzing: crbug.com/877063. Original change's description: > Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686. > > This change removes 6+ MB of binaries from the build tools bundle: > 3.7M lib/linux/libclang_rt.asan-i686-android.so > 2.5M lib/linux/libclang_rt.ubsan_standalone-i686-android.so > 80K lib/linux/libclang_rt.profile-i686-android.a > > It also can break some workflows, but as discussed in person, there is a good > chance that no one is using those libraries on i686 arch. > > > Bug: 866225 > Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3 > Reviewed-on: https://chromium-review.googlesource.com/1158708 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Max Moroz <mmoroz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579854} R=hans@chromium.org, inferno@chromium.org, thakis@chromium.org Bug: 877063 Change-Id: Ic5754458e6516dc25cf4cedaeb7eb9195faafbec Reviewed-on: https://chromium-review.googlesource.com/1187629 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585731}
-
Istiaque Ahmed authored
In case of an error where service worker script loading fails (e.g. when there is an attempt to load an extension service worker script after the extension has been uninstalled), the current code fails DCHECK if network stack calls OnComplete with error param right from mojom::URLLoaderFactory::CreateLoaderAndStart. This CL changes the DCHECK to apply only for non-error case. This should fix the flakiness of the test: ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload. Bug: 877218, 868183 Test: Repeated aforementioned test x 500 locally, no DCHECK observed. Change-Id: I1691771e466365477051f5ca1136f01f921a1ec8 Reviewed-on: https://chromium-review.googlesource.com/1187762 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585730}
-
Yoshisato Yanagisawa authored
Since Goma Canary builders are scattered to cr-buildbucket.cfg and is difficult to see, let me gather all the builders to one place. Bug: 874754 Change-Id: Ie8ca261cc28f734c4175d6fc07082429e0c026da Reviewed-on: https://chromium-review.googlesource.com/1188045Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#585729}
-
Sammie Quon authored
This is a reland of c40ba7f2. Added a missing ASH_EXPORT which was causing ash_unittests to fail. TBR=xiyuan@chromium.org Original change's description: > applist: Introduce HomeLauncherGestureHandler. > > Introduce swipe down gesture to homecher. This cl implements the design > at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# > > The design doc states to use a new ScopedClass but after a bit more > thought I think that would be more difficult especially once animations > are added. > > This should be behind a enabled by default flag, but I do not want to > merge too much during code review, so I will add the flag shortly > after this lands. > > Test: added tests > Bug: 872319 > Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 > Reviewed-on: https://chromium-review.googlesource.com/1184326 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585524} Bug: 872319 Change-Id: Ic3b2320e96cb1fd770ce60a5d48818e7ee78d21c Reviewed-on: https://chromium-review.googlesource.com/1187042Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#585728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa6aaad8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23216 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ibc8838d43dcf7a2f26468879347785e0bfe35b64 Reviewed-on: https://chromium-review.googlesource.com/1187896 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585727}
-
Han Leon authored
The legacy IPC struct traits of ServiceWorkerFetchRequest is no longer used anywhere, so we can just remove it then remove the whole file service_worker_messages.h. BUG=789854 Change-Id: I4d4e8ab30d1fca562d6b738aad394d1eb73935e4 Reviewed-on: https://chromium-review.googlesource.com/1187901Reviewed-by:
-
Stefan Zager authored
Since determining occlusion is much more expensive than computing clipping, throttle the frequency of IntersectionObserver notifications to no more than one every 100ms. BUG=827639 R=chrishtr@chromium.org Change-Id: I6675482041418c628dbddfd648319d18d871d38b Reviewed-on: https://chromium-review.googlesource.com/1175210Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#585725}
-
Alex Lau authored
Currently this is shown for all roots. Bug: 875380 Test: Tested on kevin. Change-Id: Ied92804c5a3936d458b38e84daf973c5928b3534 Reviewed-on: https://chromium-review.googlesource.com/1186206Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#585724}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce6a1cc587a7..367ed462b517 git log ce6a1cc587a7..367ed462b517 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tsepez@chromium.org Use pdfium::span<> in CPDF_Stream::SetData(). 2018-08-23 tsepez@chromium.org Pass unique_ptr<> to CFX_MemoryStream constructor 2018-08-23 thestig@chromium.org Fix GCC build with V8 disabled. 2018-08-23 rharrison@chromium.org Enable warnings for shadowed variables 2018-08-23 rharrison@chromium.org Fix shadowed variables 2018-08-23 hnakashima@chromium.org Remove CBC_BarcodeMatrix::m_matrixOut and just return the bit array. 2018-08-23 thestig@chromium.org Remove deprecated FPDFDest_GetPageIndex() API. 2018-08-23 tsepez@chromium.org Remove bool arg from CFWL_Widget::GetBorderSize(). 2018-08-23 hnakashima@chromium.org Swap width and height params in CBC_BarcodeMatrix constructor. 2018-08-23 npm@chromium.org Cleanup CPDF_TextPage::GetRectArray Created with: gclient setdep -r src/third_party/pdfium@367ed462b517 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ife89a1b2ceec8f4489fff9b0304d4f742460bde9 Reviewed-on: https://chromium-review.googlesource.com/1187096Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585723}
-
Nicolas Ouellet-Payeur authored
It lets us migrate policies from an extension domain to the Chrome domain. ExtensionPolicyMigrator is a callback that can be attached to a ConfigurationPolicyProvider. It is run after the policies are refreshed, but before OnUpdatePolicy() is triggered, and it can modify the PolicyBundle to migrate the policies to their new domain. See: https://docs.google.com/document/d/1_ZxQ4Rc7RIGT4NOfjhdaJJ2gSJCZIHgcwCOumjYD0Cs/edit Bug: 869958 Change-Id: I2da6cf08720e73ca3589cfeaac5094d9df2d8b5c Reviewed-on: https://chromium-review.googlesource.com/1158968 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585722}
-
Han Leon authored
BUG= Change-Id: I4ef96d8055825be72ac40bff03932a376bb018f4 Reviewed-on: https://chromium-review.googlesource.com/1187830Reviewed-by:
-
