- 10 Apr, 2018 40 commits
-
-
Daniel Cheng authored
Declaring move constructors and assignment operators noexcept allows STL containers to use moves instead of copies, which is generally more efficient. Previously, there were compiler issues that prevented this from working [1]. They seem to have mysteriously fixed themselves and testing on https://godbolt.org/g/TqfqtK seems to indicate that the previously highlighted problematic test cases now work. [1] https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ze4WJFg7RvU Bug: 706963 Change-Id: Ieb73b4c53ab4235838265f1d968d2a57aa34a737 Reviewed-on: https://chromium-review.googlesource.com/1003872Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549678}
-
John Abd-El-Malek authored
Update V4UpdateProtocolManager, V4GetHashProtocolManager and V4LocalDatabaseManager to use SimpleURLLoader. Also add a SharedURLLoaderFactory getter on SafeBrowsingService for IO thread users. Bug: 825242 Change-Id: Ib41699d932469b4bb92130103b5257509d6b2a36 Reviewed-on: https://chromium-review.googlesource.com/1002473Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#549677}
-
Robert Ma authored
The immediate issue this CL tries to fix is crbug.com/830629, which is fixed by using mac_chromium_rel_ng instead of mac10.12_blink_rel for rebaselining on Mac 10.12. After crbug.com/818301, the remaining *_blink_rel bots need to be replaced as well. (NOTE: mac_chromium_rel_ng is planned to be upgraded to 10.13 soon. When that happens, mac_chromium_10.12_rel_ng should be used for 10.12. We are using mac_chromium_rel_ng for now only because of capacity issues of mac_chromium_10.12_rel_ng.) Meanwhile, we take this chance to add support for LUCI Buildbucket as Buildbot (and its "master" concept) is being deprecated. Buildbuckets for each bot can now be specified in builders.json. The special treatment for android_blink_rel is also moved into builders.json to reduce the amount of magic in the code. Bug: 830629 Change-Id: I4c1777f93ff63ccd7bc35abaaea435eafd19e18c Reviewed-on: https://chromium-review.googlesource.com/1003132 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#549676}
-
Amirhossein Simjour authored
Cast dialog was enabled behind a flag in VR. It was a mistake since, the same flag is used to enable some other popups. We should enable cast icon once we VR can support this dilog. Bug: 822090 Change-Id: I6c414f85d7b24a0f5dfaea4d37d541268abb4556 Reviewed-on: https://chromium-review.googlesource.com/1006037Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#549675}
-
Joy Ming authored
Handle errors that occur before downloading, including the name being repeated/too long, the location being missing/full, etc. Some of the changes include: - Creating DownloadsLocationDialogType to indicate which type of error- handling dialog to display. - Re-routing DownloadTargetDeterminer to loop back and double check in the case that it was a user-confirmed "new" filename/location. Screenshots: Rename workflow: https://drive.google.com/file/d/1S4Pw8zXy-uZvotx3L8eNZgl2QMzaETfX/view Not enough space option: https://drive.google.com/file/d/1JiCVo5K4kEcGVtZQhdJ4sSrqEQNagdgB/view Bug: 792775, 825929 Change-Id: Ic981343eede2b10a84d383ad429f5ddcbccfd38c Reviewed-on: https://chromium-review.googlesource.com/982530 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549674}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39414498..42f2c717 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I286d3362a8cc93153b3c2400f751159cabafaa42 Reviewed-on: https://chromium-review.googlesource.com/1005575Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549673}
-
Ilya Sherman authored
Clarify that groups only have features automagically associated with them if they don't directly specify *any* associated features. The comment was previously worded for a single feature, and got only partially updated. R=asvitkine@chromium.org Bug: None Change-Id: I6cd7e79fb78112c990a5f9ed6d4ca0d59531f159 Reviewed-on: https://chromium-review.googlesource.com/1005798 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#549672}
-
John Rummell authored
Now that CDMs use mojo exclusively, remove the Pepper APIs that are now unused. BUG=772160 TEST=compiles Change-Id: I4161d7430f86f5033dd7997fb5f2cc4a04aefa22 Reviewed-on: https://chromium-review.googlesource.com/988254Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549671}
-
Evan Stade authored
ExtensionStorageMonitor. Bug: 793887 Change-Id: I877a8734b419054da94b307bab5389bada8aab62 Reviewed-on: https://chromium-review.googlesource.com/1000114 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549670}
-
Sunny Sachanandani authored
R=piman CC=zmo BUG=794735 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3919d0e62ed445ae1f254c4b106df721e2139d32 Reviewed-on: https://chromium-review.googlesource.com/1004001Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#549669}
-
Jay Civelli authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f34a90b21090..272be0ac4cae $ git log f34a90b21..272be0ac4 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 jcivelli Make OWNERS file not reference outside of this repo Created with: roll-dep src/third_party/ffmpeg Bug: 831242 Change-Id: I89e269c3b6db30de1318b70bfdc0ae84fcdf1f70 Reviewed-on: https://chromium-review.googlesource.com/1005630Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549668}
-
Samuel Huang authored
Supersize-archive requires one of '--apk-file', '--elf-file', or '--map-file' followed by filename. To simplify command-line interface for testing, this CL adds '-f' switch, which automatically identifies a given file (relies on external program 'file') to fit one of the above switches, Change-Id: I3806e27a8dbd5c260c1bda54339cef8ce9ae2f1d Reviewed-on: https://chromium-review.googlesource.com/1005729Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549667}
-
Alex Newcomer authored
Remove the the elipses in "Uninstall..." which is used in app context menus. Bug: 826410 Change-Id: Ia6a925b23314ac7ce72985414216a8a646c7b378 Reviewed-on: https://chromium-review.googlesource.com/1003375Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549666}
-
Bo Liu authored
Make BindingManagerImpl only be responsible for the LRU queue of connections and the corresponding moderate binding ref count. Lift up controls of all other bindings to ChildProcessLauncherHelper. More concretely, remove ManagedConnection and merged ModerateBindingPool directly into BindingManagerImpl. Moved the logic of whether moderate binding management is enabled to ChildProcessLauncherHelper as well. This is not a totally no-op refactor: * Visibility signals now work on "always foreground", ie non-sandboxed, connections. This makes non-sandboxed connections less special. Note this has no practical difference since non-renderer processes do not have priorities set currently. * Connection with strong binding can remain in LRU queue. This is just a consequence of making these two systems independent. * The "use" signal, in the LRU sense, is now when a connection gains strong binding only. Previously a connection is marked as most recent when strong or initial binding is dropped, which doesn't make much sense. For tests, essentially deleted a lot of tests that explicitly check binding state, and at the same time breaks layering. One clean up not yet done to make review easier is that the BindingManager interface can now be removed. Bug: 689758 Change-Id: I32489a809bee944fbe26f34ca1de06b4e65c310e Reviewed-on: https://chromium-review.googlesource.com/642058 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549665}
-
Nate Chapin authored
Bug: 829119 Change-Id: I8808486a29691cf0881864be000485322e5c2034 Reviewed-on: https://chromium-review.googlesource.com/996554 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549664}
-
Wez authored
- Disable ProcessUtilTest.LaunchWithHandleTransfer under Debug builds, since launching the child process is currently too time consuming. - Modifies that test to distinguish the child process failing to send data from the timeout case. - Disable SecurityTest.NewOverflow, which fails under Fuchsia/Debug builds due to the SDK exporting the wrong new[]. - Disable RTCRtpSenderTest.GetStats, which is part of a suite of tests which appear to be inherently flaky, but fail most often under Fuchsia. - Filter DataPipeTest.SendConsumerAndCloseProducer Bug: 793412, 828229, 827450, 831024 Change-Id: Icb655ca91881c3ff7059f333f0e22d9bf2d92468 Reviewed-on: https://chromium-review.googlesource.com/1003996Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#549663}
-
Anna Offenwanger authored
A small bit of cleanup work following on https://chromium-review.googlesource.com/c/chromium/src/+/949052 Change-Id: I52da7165e2c8f7edc664cbd025cbbcbdaccd7252 Reviewed-on: https://chromium-review.googlesource.com/1000332 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#549662}
-
Xiaohan Wang authored
See Bug for discussions on the new text. Note that I am not adding a trailing dot/period to the new text because even if I do, it'll be stripped and not showing up in the actual permission prompt. Bug: 721969 Test: Manually tested and inspected the new prompt. Change-Id: I609512b11991354bdb8954f3e63c6ac157f17927 Reviewed-on: https://chromium-review.googlesource.com/996769Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549661}
-
Ted Choc authored
BUG=813926 Change-Id: I896cd3f83c41202b0f97e5acfec0ee875c4bd065 Reviewed-on: https://chromium-review.googlesource.com/1005909Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549660}
-
Nicolas Pena authored
This change cleans up the remaining tests in http/tests/w3c/ directory in preparation to delete it. It moves some tests to external/wpt and removes other tests, which are duplicates: * test_user_timing_entry_type.html is duplicated by entry_type.any.js * test_user_timing_mark_exception.html duplicated by mark_exceptions.html * test_user_timing_method_exist.html is duplicated by user_timing_exists.any.js Bug: 498037 Change-Id: I1ba43eba81ed0a5d9e1e1a79aef11b9904556f69 Reviewed-on: https://chromium-review.googlesource.com/1002736Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#549659}
-
Anna Offenwanger authored
Adding a histogram to track how the user got into XR Presentation. Bug: 808589 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad597f74fe22afac5709ebee1525c0b342cc24a4 Reviewed-on: https://chromium-review.googlesource.com/999019 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#549658}
-
Erik Luo authored
This extends [Affects=Nothing] to mark attributes/accessors with getter callbacks that produce no JS-observable side effect. This also marks Node's isConnectedAttributeGetter as side-effect-free. Bug: 829571 Change-Id: I21211b477a95e51e10cade1ffbd0249171684d1c Reviewed-on: https://chromium-review.googlesource.com/999304 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549657}
-
Dale Curtis authored
This allows us to avoid a preload=metadata suspend if we know playback would start once we reach the HaveEnoughData state. There are still cases where the play() call might come in after Start(), but this should capture a significant chunk. In order to test this change, I've built up significant infrastructure inside HTMLMediaElementTest and WebMediaPlayerImplTest. The WMPI test can now fully start the media pipeline and execute up to the metadata state. This is sufficient for testing this feature and an improvement to the state of our existing WMPI tests. Note: Extending the WMPI tests required fixing up instances of const& base::TimeDelta usage by the MediaPlayerManager interfaces to avoid presubmit errors. BUG=827396 TEST=new unittests. Change-Id: I8b5c3dea1ecc3e3b519e2b26bfc45b9d9204fb81 Reviewed-on: https://chromium-review.googlesource.com/996632 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549656}
-
Nate Chapin authored
Bug: 829119 Change-Id: I6b85f4776e54fdc3f5cc036cfe46b6ef53e250b1 Reviewed-on: https://chromium-review.googlesource.com/1000518Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549655}
-
Nasko Oskov authored
The goal of this CL is to break down the TimeToReadyToCommit metric into cases where we perform cross-process navigation vs same-process one. This will allow us to analyze whether regressions are due to change of process or potentially other differences in code. Bug: 808114 Change-Id: Ic98c2f9f5b7a6a21ee44e34bc8668af61e4a0f9e Reviewed-on: https://chromium-review.googlesource.com/1003290Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#549654}
-
Daniel Murphy authored
Bug: 830909, 756447, 829125, 829141 Change-Id: Iaf467fbe9cf2c836bfcd761d558c3f7c0e7379a8 Reviewed-on: https://chromium-review.googlesource.com/1003281Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#549653}
-
Lukasz Anforowicz authored
This reverts commit a9d4f347. We verified that high-volume kills reported in https://crbug.com/831082 go away after reverting. Simple repro that would have resulted in a renderer kill before the revert: $ out/rel/chrome --disable-features=NavigationMojoResponse \ --user-data-dir=$HOME/.chrome-kill-x1 --site-per-process \ http://chromium.org Bug: 831082 Change-Id: Ibbb9b08862e4c611c7d8bd139b96970edbebf460 Tbr: kinuko@chromium.org Tbr: clamy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1005792 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549652}
-
Dave Schuyler authored
This CL adds some unit tests for search_suggestion_parser which previously had none. This set of tests can be expanded upon, this is just a start. Bug: None Change-Id: I445865beee434674e2d11c3d3cb9e708d19336ff Reviewed-on: https://chromium-review.googlesource.com/999297 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#549651}
-
Matthew Wang authored
Creating histograms for roam complete for FT and non-FT networks and for PSK and 802.1X authentication. This is a success metrics to show roaming reliability improvements from FT. Histograms are implemented in CL:957442. Bug: 791202 Change-Id: Ia9174e6239804187bd5c16445de6f6229f3e55a3 Reviewed-on: https://chromium-review.googlesource.com/972591 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549650}
-
Dominick Ng authored
This CL fixes a bug introduced during the refactoring of ArcNavigationThrottle to AppsNavigationThrottle where the intent picker could be shown multiple times during a redirect chain. If the user has ARC apps installed which handle all URLs (e.g. Chrome Beta/Chrome Dev), we could get into a situation where we show the intent picker but reset our internal state to be not showing. The fix is to only set the internal |ui_displayed_| state to false if the apps list sent back to AppsNavigationThrottle is empty. BUG=824598 Change-Id: I990d00d90665d362ee9e894ad71a71454e78ebea Reviewed-on: https://chromium-review.googlesource.com/1003812Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#549649}
-
mrefaat authored
Handle iTunes bundle URLs regularly, instead of launching storekit for them. The reason is StoreKit view controller doesn't present bundles correctly. Bug: 829302 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idcd6fd1ef42fd48550b589330ec3191484619a2b Reviewed-on: https://chromium-review.googlesource.com/1005443Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#549648}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. LocalSurfaceIdProvider is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I85aad90edc9d61ae1c2924d3bbc5fc92b3b9376b Reviewed-on: https://chromium-review.googlesource.com/1005801Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549647}
-
Jun Choi authored
Currently GetAssertionTask will return an error if sign in response received after user verification includes an user entity object. This is not entirely correct. CTAP spec[1] specifies that "user identifiable information" must not be present. This includes user image url, user display name, and user name. User key handle, however, is not part of user identifiable information. Thus user entity with only user key handle should be allowed. [1]: https://drafts.fidoalliance.org/fido-2/latest/fido-client-to-authenticator-protocol-v2.0-wd-20180305.html#authenticatorGetAssertion Bug: 780078 Change-Id: I9320646346a92838ade1dd41419808c89ed9f76d Reviewed-on: https://chromium-review.googlesource.com/1003389 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#549646}
-
Rayan Kanso authored
Update the database manager task wrappers to use the metadata proto directly. The following files were moved and slightly updated to make naming consistent throughout: * create_registration_task.(cc|h) -> create_metadata_task.(cc|h) * get_registration_task.(cc|h) -> get_metadata_task.(cc|h) The metadata to registration conversion logic was removed from get_registration_task.cc. Also added tests. Bug: 826257 Change-Id: I7a8cedf76df3b935ebeddf6536ba5cda639420db Reviewed-on: https://chromium-review.googlesource.com/993054 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549645}
-
https://chromium.googlesource.com/catapult.git/+log/1bae362e7789..2c59f678c7ed $ git log 1bae362e7..2c59f678c --date=short --no-merges --format='%ad %ae %s' 2018-04-10 eyaich Printing out full benchmark/story path in logs for ease of grepping. 2018-04-10 simonhatch HistogramSet - Merge by test paths in add_reserved_diagnostics. 2018-04-10 perezju [devil] Simplify condition for `ps` on Android O+ Created with: roll-dep src/third_party/catapult BUG=chromium:779634,chromium:686716 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If842962b8580606c939cbc1c597d5bcb8a9f507a Reviewed-on: https://chromium-review.googlesource.com/1005778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549644}
-
Theresa authored
Remove the toasts and Java-layer clustering used during prototyping. BUG=822945 Change-Id: I391c2eb051c448cf1c9df88a9039b25db04fffeb Reviewed-on: https://chromium-review.googlesource.com/1005502Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549643}
-
Xiaohan Wang authored
See screen shot at https://photos.app.goo.gl/gi8yNPJMhEePzOu62 For Protected Content icon update on Android, see https://chromium-review.googlesource.com/c/chromium/src/+/996754 Bug: 454980 Test: Manually inspected. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I299f31d185f7a927cc3c3596f8ff6ff91b5b9b61 Reviewed-on: https://chromium-review.googlesource.com/1003146 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#549642}
-
Kevin Marshall authored
Removing the "shell" capability allows packaged apps to load dynamic libraries from the package. In addition, it prevents the app from using any system-provided libraries, in favor of the package supplying all of its data and dynamic library dependencies. This CL includes the system libraries from the SDK's "dist" directory in packages built using the package() GN template. Bug: 823927 Change-Id: I7c0eaef08765f8119bec9a67d381014d07ba4606 Reviewed-on: https://chromium-review.googlesource.com/985474Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#549641}
-
Xiaoqian Dai authored
The CL has been merged back to M66. So revert this CL on tot. This reverts commit cf5e5473. TBR=xiyuan@chromium.org Bug: 827322 Change-Id: I9d5ca5abf7399318e5bf950c5e25d01bc2ff9093 Reviewed-on: https://chromium-review.googlesource.com/1005615Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#549640}
-
Greg Thompson authored
A change in Windows made absolute moves to coordinate 0,0 not work. It seems that moving to 1,1 (normalized) does the trick. 1,1 will round down to 0,0 for any display we care about. BUG=827549 Change-Id: I76fac0313901ba68bb35ed624c475aed23592029 Reviewed-on: https://chromium-review.googlesource.com/1004734Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#549639}
-