- 03 Aug, 2020 40 commits
-
-
Stephen McGruer authored
This builder was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2317705, but the builders.json config, which blinkpy's BuildersList class relies on, was seemingly overlooked. That broke the WPT importer (and any other use of BuildersList). Bug: 1112063, 1104846 Change-Id: I9d08cdde6992fd14147eedbd42ad38187c11b6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333747Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#794183}
-
Dominique Fauteux-Chapleau authored
Bug: 1110334 Change-Id: I88c2d767f16f50b6cf27207327921d2ff75787b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333026Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#794182}
-
Koji Ishii authored
When painting floating children, PaintFragment skips descendants of self-painting boxes, but FragmentItem did not. This patch matches PaintFragment logic. Bug: 1109565 Change-Id: I660053e149638bb8728e4405f2d562b795a918f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332093Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794181}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596451854-145f78432e49c7c6a87ca8a74d340c029916cf4b.profdata to chrome-win32-master-1596459406-112652fc3cbb93a8d59d2edad7ed0033698f8002.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Idaa32434e2b6b0a1a3eac7cce59bd3d3cbad19b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794180}
-
Adam Rice authored
Class content::WebSocketManager no longer exists. Remove references to it. Change-Id: I64570a2448aa66058fa850c62db2c8e36ac42ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326559Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#794179}
-
Sophie Chang authored
Bug: 1022626 Change-Id: I42f8d2c4260a60f35eaf9a30d883bbc98bb07db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333286 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794178}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: If5b14fc7d568eea73bc6519e7d922c43c306b213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292873Reviewed-by:
-
Egor Pasko authored
The individual tests: * do not share anything * do not have setUp() even * they create necessary state by themselves * cleanup is only closing handles This means batching (avoiding process creation and teardown between tests) should be safe. More documentation on batching can be found in Batch.java. We will know the time saved after looking at marshmallow-arm64-rel result_details. Currently the running time is ~22 seconds. For reference, the UNIT_TESTS batch can be run locally using: out/.../bin/run_mojo_test_apk -A Batch=UnitTests Bug: 989569 Change-Id: If72c5696a808e203b98f8c9b9e1cc12db7c957cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329636 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794176}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b656a010be5..c6f029c304ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I12075eccc0187814ed4ac8f8c3416a4d47e9e34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334667Reviewed-by:
-
David Trainor authored
This patch adds the functionality required for an IPH system to trigger one of three re-engagement notifications. The IPH changes are - - Starting ChromeTabbedActivity will be flagged as engagement. - Starting a CCT will check criteria and decide whether or not to notify the user about Chrome. The feature is integrated into Chrome through the two main RootUiCoordinators and is guarded by an overall feature flag (disabling all added code) in addition to the IPH feature configurations. This CL also adds a OneShotCallback, which makes it easier to get a single value back from an ObservableSupplier. Bug: 1108002 Change-Id: Ia23827337b325550ff16259d97d81bf223de3566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311827 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#794174}
-
Tamir Duberstein authored
Instead, wait for the first event to arrive. fuchsia.netstack.Netstack eagerly sends a synthetic event upon connection. It is necessary to take this approach because Netstack does not guarantee the ordering of events with respect to non-event FIDL calls. This is a known flaw in the API, the replacement for which is being developed in https://fxbug.dev/21154. Bug: 964161 Change-Id: I1a80e254f9ccddc150b256561bda82c3ac1eef42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331860 Auto-Submit: Tamir Duberstein <tamird@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#794173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6f029c304ca..b5aa09d7531b 2020-08-03 lalitm@google.com Merge "ui: only draw visible data in tracks" 2020-08-03 lalitm@google.com Merge "tp: cache computed columns in experimental slice layout table" 2020-08-03 taylori@google.com Merge "perfetto-ui: Remove separate scheduling category" 2020-08-03 hjd@google.com ui: Fix "Uncaught ReferenceError: window is not defined" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3769e44d2dbb5c778fc499d38e165aec4bc8a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335272Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib7cbb71865828acf58f92013def4dc34dd7aed9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293276Reviewed-by:
-
Thomas Lukaszewicz authored
Defines CrSearchFieldBehaviorInterface for CrSearchFieldBehavior such that uses of CrSearchFieldBehavior with the non-legacy class based Polymer3 syntax are parsable by the Closure Compiler. Bug: 1099917 Change-Id: Ic5257e6ca5f59860cebefdedea378905c3fd0fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333208 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794170}
-
Daniel Rubery authored
Since binary uploads don't use cookies, we can use the Profile's URLLoaderFactory and set the request to CredentialsMode::kOmit to prevent accidentally persisting user identifiers. Bug: 1049833 Change-Id: I6e73f5912283d3a2e94a01f0e288bb9f47ec9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327147Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#794169}
-
Jose Leal Chapa authored
Related frontend CL: https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303292 Bug: 1074732 Change-Id: Ic3998ce1c51d8dfc48243195b619b74afd57b020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259138 Commit-Queue: Jose Leal <joselea@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
-
Nodir Turakulov authored
Add an all-purpose "chromium:public" realm where everything is public. Change-Id: I60d98ff828063d024b98d153335a4a36a775c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335354Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794167}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98b332f2dbbd..01a0945e034b 2020-08-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I64bbc798cbf4cd8d414836e6d35f59f7cb04453b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335263Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the tests are passing when the Request Desktop by default flag is enabled. Bug: None Change-Id: Ic5bbb2b00acb61e075bf6d57aa63c1db8892f28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794165}
-
Richard Knoll authored
This hooks up the NotificationHandler with the NotificationManager to respond to notification clicks and close. Bug: 1102348 Change-Id: I300305a09ed651f488b286e8fcaf5d3f69ceb8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329539Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794164}
-
Min Qin authored
the Data directory could be a sim link in recent Android versions. So need to use canonical path when checking if a file is under it. BUG=1104628 Change-Id: I403b9582e09a799e5c51d2687ce4928dea8e7e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320071Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794163}
-
sczs authored
Calling stringValue on a NSString* crashes in iOS12 Bug: 1112103 Change-Id: Ice356b5a6da6e597fad850c3e5cb99e1f9fef52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332992 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#794162}
-
Mason Freed authored
These got missed the last time around, because they pass when the features are disabled. But they are all only testing WCv0 features, so they belong in the web-components-v0-only directory. Bug: 937746 Change-Id: Ifec22f31a69bf4358c4a4a9dfa5d54f7c3005db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335315 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#794161}
-
Omer Katz authored
This CL is dependent on https://chromium-review.googlesource.com/c/v8/v8/+/2327910/ Bug: 1108537 Change-Id: Ie2121ba8e1460a5979ceeba734ca3a516a63903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327672 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794160}
-
Richard Knoll authored
If a NotificationDelegate calls RemoveNotification in the Close handler we're currently ending up in an endless loop. Instead remove the Notification from the list before calling Close so the next call exits early and is a noop as expected. Bug: None Change-Id: I7ed211ba1bf78a33255211090bfbd11e986dfc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330019Reviewed-by:
-
Dan Harrington authored
Adding ContentSuggestions.Feed.LoadStepLatency.* UMA which record latency for individual steps in loading the feed. Bug: 1044139 Change-Id: I69350a8c9dcec1b0ee2c3260832d865e498bcbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332333 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#794158}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596434376-e66572c4bd7519ea423a67f597bf938ae289c1f8.profdata to chrome-win64-master-1596455409-191726fecbe6a9b7fc8fb41afab59db6a1bbda42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifec3ac3a0ca4e33dbed9717fc1f13639f2766020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335259Reviewed-by:
-
Clark DuVall authored
getPacProcessor() is an R API and was causing verification errors on lower API levels. This makes a big improvement to startup time: android-pixel2_webview-perf https://pinpoint-dot-chromeperf.appspot.com/job/171ac7ac920000 webview_startup_wall_time -3.2% android-go_webview-perf https://pinpoint-dot-chromeperf.appspot.com/job/164d5e22920000 webview_startup_wall_time -3.4% Bug: 1105096, 1111909 Change-Id: Icfafbf5f20936fe045171603267453ce3f8db266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328302 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/de0ed93bda63..963bc42f8719 2020-07-31 vapier@chromium.org OWNERS.build: add Stephane 2020-07-31 kevinruvalcaba@google.com Adding 2 data structures for the visualization project. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2c7e4dddd6cc39698196c9d9729e5b2900052461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335262Reviewed-by:
-
Ross McIlroy authored
We are now shipping 64-bit browser to Q+ devices. Pixel2 devices can be upgraded to Android Q (although the ones in the labs are still Android O) and so move these bots to 64-bit to represent what we ship. BUG=chromium:934251 Ignore-CQ-Freeze Change-Id: I69143018228b9df2cda9452c13eb1ff6c68ee905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316259 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794154}
-
Rune Lillesveen authored
Bug: 1111710 Change-Id: Id685b5150e6c7356009f48c248a30383750b9dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332720 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794153}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=danakj@chromium.org Change-Id: I0f5ef4346c5a8deff2813adfcfbf1e41c1802a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298864 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
-
Dan Harrington authored
Hooks up UMA action reporting for several events. We're using Android views to trace actions back to their originating stream slice. This is a bit complicated, but does work well. Some actions aren't yet possible to track from the client, and will likely require server changes. In the interim, I've added some UMA for ephemeral changes, which will give us an idea of how many total hide-story / not interested in actions are triggered. Bug: 1111101 Change-Id: Ia7ad821bed087d75ad43454644fedac9694e8152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329929Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794151}
-
Reda Tawfik authored
Bug: 1104132 Change-Id: I0e8356ce3cec6162a6367709121e887916916549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289978Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Cr-Commit-Position: refs/heads/master@{#794150}
-
Alex Ilin authored
Updating cookies from GaiaRemoteConsentFlow::OnEndBatchOfRefreshTokenStateChanges() is needed on ChromeOS to push new accounts added from the account manager. On Desktop, sign-in happens on the Web and a new account is directly added to getAuthToken's partition cookie jar. An extra update triggered from OnEndBatchOfRefreshTokenStateChanges might change cookies order in the middle of the consent flow and lead to a bug like https://crbug.com/1112343. This CL makes the cookie update in OnEndBatchOfRefreshTokenStateChanges executed only on ChromeOS. Bug: 1112343 Change-Id: Ica8c888a3572f406b8c282c17049ba9306bf7a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332192Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794149}
-
Dan Harrington authored
I've seen some crashes while debugging clank that appear to have been caused by calling this function from another thread, but the native crash fails to log the java callstack. I'm hoping this assert will help catch the problem closer to the source. Change-Id: I96b4b33a316de5c43c2a7f9a19aeb2e8a9c27fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332564Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794148}
-
Yuki Shiino authored
This reverts commit e1dce34f. Reason for revert: Most critically due to https://crbug.com/1112227 but not limited to. Original change's description: > bind-gen: Switch to the new IDL interface implementation > > Blink-V8 bindings team has been developing the new improved > Web IDL bindings system, and this patch enables the new > bindings implementation of Web IDL interfaces at build time. > > Note that other IDL definitions (buffer source types, > dictionaries, callback functions, etc.) are not affected and > the old bindings are still used for them. > > The new IDL interface implementation is not 100% compatible > with the old one, and we see the following changes/improvement > that are visible from author script. > > Behavioral changes: > - Cross origin attributes become accessor properties. > - Indexed/named properties' behaviors change. > - Legacy platform objects with indexed properties support > @@iterator property. > - Maplike supports size() operation. > - [NoInterfaceObject] removes 'constructor' property. > - Some of error messages change. > For these changes, new behaviors are better conforming to > Web IDL specification. > > Non-behavioral changes: > - Keep-alive-GC optimization is removed. > > For performance, there is no major difference in speed perf > and -17KB improvement in APK binary size. > > Pinpoint results > https://pinpoint-dot-chromeperf.appspot.com/job/1230bdd8920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14b5b5d0920000 > https://pinpoint-dot-chromeperf.appspot.com/job/12ca6424920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14e3aa48920000 > > Bug: 839389 > Change-Id: I9de8de3cc9e37b4ee46333c9270fe49bbdd69534 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081633 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793165} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839389 Change-Id: I797f9cde05ccd0132ff0fbe1a970634f8d152d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335214Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#794147}
-
Stephen Martinis authored
The freeze is now over! Bug: 1109980 Change-Id: If29ad7064c26090ff0e4a2ddc24c697f051f6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334807 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fce06b20005c..4b656a010be5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7fec564e38101024aad053eb62637bbd1ec4baea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334811Reviewed-by:
-
Kyle Horimoto authored
This CL fixes a crash which would occur when searching for cellular settings which was caused by a null |cellular_guid_| field. The issue is fixed by (1) ensuring that cellular search tags are only added when an associated cellular network exists, and (2) fetching *all* networks (not only active or visible networks) when responding to network changes. Bug: 1110200 Change-Id: I7e5f29a698cd38905025dd9cfc5364efd8a3abe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334402Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794144}
-
