- 04 Dec, 2017 40 commits
-
-
Fredrik Söderquist authored
Using the Length store directly should work fine most of the time, and avoids the fairly bloaty Length copy constructor and destructor pair. Some minor massaging of ValueForPositionOffset required, but otherwise straightforward. Change-Id: I1b1d0b14f3897fc4173eab123cc3b241b28c70d3 Reviewed-on: https://chromium-review.googlesource.com/806834Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#521473}
-
Mostyn Bramley-Moore authored
We have not supported valgrind for some time (it was never ported to the GN build IIUC, and has been obsoleted by ASan/MSan/TSan). Followup to https://chromium-review.googlesource.com/c/chromium/src/+/778881 BUG=791518 Change-Id: I3a03f033263e6477eddcc683b986635b6ff2c963 Reviewed-on: https://chromium-review.googlesource.com/805994 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521472}
-
Daniel Cheng authored
Change-Id: I36b10c7b37e0340c02e9106aec0ae94eaec864a2 Reviewed-on: https://chromium-review.googlesource.com/804737Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521471}
-
Ryan Sturm authored
It's an anti-pattern to have "using" for a namespace that contains methods that the code depends on. Bug: 678368 Change-Id: Icbfbceb35c2384fd6ae20c187d579f1df7913a90 Reviewed-on: https://chromium-review.googlesource.com/803619Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521470}
-
John Abd-El-Malek authored
That callback is going away as it's not compatible with network service. Plumb information about subresource responses starting from the renderer to WebContents instead. A followup will undo much of the code added in r519351 after this. Bug: 783981 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id04381daa669cb2ac05dcf0f5d7d890960c6c06b Reviewed-on: https://chromium-review.googlesource.com/804947Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521469}
-
Ovidio Henriquez authored
This change moves the IDL tests that do not use bluetooth_test into the wpt directory. BUG=509038 Change-Id: I6bced22bf6b14dd2581977a73ce0220a31dd4fe6 Reviewed-on: https://chromium-review.googlesource.com/804817 Commit-Queue: Ovidio Henriquez <odejesush@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#521468}
-
Yafei Duan authored
This CL is the fifth CL of implementing OfflinePageModelTaskified. It contains: - Hooking up consistency checks for temporary and persistent pages. - Related tests. - Updating temporary and persistent consistency check tasks to make them more similar in implementation. Bug: 753595 Change-Id: I7200ea8fbdcfb3f6914c494d0bc060504774a67b Reviewed-on: https://chromium-review.googlesource.com/786820Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#521467}
-
Justin Novosad authored
This bug was unmasked by this CL that re-enabled overdraw optimizations in GPU-accelerated 2D canvas: https://chromium-review.googlesource.com/c/chromium/src/+/800750 Crash happens on configuration that do not support the sync query extension. BUG=791608 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0da7be2f305d61881ba57d999329de2864d68ca5 Reviewed-on: https://chromium-review.googlesource.com/806678Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521466}
-
Christopher Cameron authored
The UI theme images will miss color conversion caching, resulting in repeated conversions and poor performance. Bug: 769677 Change-Id: Icfeafb9c9418cf03bfbfaae62cf98c5ad07e0f6d Reviewed-on: https://chromium-review.googlesource.com/806641Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#521465}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/0ddd5dc79696..cef20d4b2ff1 $ git log 0ddd5dc79..cef20d4b2 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Simplify code in CFX_ImageTransformer. 2017-12-04 thestig Refactor CFX_ImageTransformer down sample calculations. 2017-12-04 thestig Refactor CFX_ImageTransformer bicubic calculations. 2017-12-04 dsinclair Remove SetResultCreateNode 2017-12-04 thestig Refactor CFX_ImageTransformer bilinear calculations. 2017-12-04 dsinclair Remove CXFA_ValueArray 2017-12-04 dsinclair Cleanup ResolveObjects params and return 2017-12-04 dsinclair Cleanup CFXJSE engine and resolve processor Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I609f4022c510b4cd37641a3ec78d9a12a686e8c8 Reviewed-on: https://chromium-review.googlesource.com/806322 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521464}
-
Jiaquan He authored
It's not used. Bug: 733662 Change-Id: I3b69a62a9a53a2a732bc0ed461d593ab119cdddd Reviewed-on: https://chromium-review.googlesource.com/806747Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#521463}
-
Ryan Sturm authored
Bug: 599906 Change-Id: I6fba5554875a98f8f4e5e531891be62a18fff4c9 Reviewed-on: https://chromium-review.googlesource.com/803664 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521462}
-
Ryan Sturm authored
Bug: 773747 Change-Id: I01059b4f7e5b64821b2215136f217cf175d2160c Reviewed-on: https://chromium-review.googlesource.com/804148Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521461}
-
Christopher Grant authored
After additional discussion, it was decided that the texture should remain a private implementation detail rather than exposed class. This keeps the UI on track to have element render themselves directly, rather than through separate classes. BUG= R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iee191543884cda51605356da7215ec3c036c5734 Reviewed-on: https://chromium-review.googlesource.com/806575Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521460}
-
Quinten Yearsley authored
Change-Id: I76cccbcbf245d7dddf586f03f99360004431e738 Reviewed-on: https://chromium-review.googlesource.com/806636 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#521459}
-
Dan Sanders authored
Callbacks and mocks that are called on the media thread but act on the Pipeline must post that work. This CL fixes the cases where pipeline_integration_fuzzertest.cc calls test->FailTest() from callbacks. Bug: 790959 Change-Id: Iecfdb095dd9d213deffa24f44790b0617ace371a Reviewed-on: https://chromium-review.googlesource.com/804494 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521458}
-
Bill Orr authored
The passthrough command decoder has slightly different behavior than the validating command decoder, as they go through different ANGLE functions (glBlitFrameBuffer vs. glBlitFramebufferANGLE). This means that passthrough doesn't support GL_LINEAR interpolation mode, and is more strict about color formats. The immediate fix to unblock WebVR is to use compatible buffer format, and use GL_NEAREST. A subsequent change (crbug/790033) will reconcile the two behaviors to ensure consistancy. BUG=790785 Change-Id: I0ac98a923168823f9e6618fef9d6e6e0e974c777 Reviewed-on: https://chromium-review.googlesource.com/802244Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521457}
-
Fredrik Söderquist authored
Using Length::IsAuto() is more efficient (and generates significantly less code) than constructing a new Length and comparing with that. Also replace some open-coded "is auto" checks with said method, and simplify the surrounding code a bit. Change-Id: I974a28a0eef969b56557428eb019f7cf1dac18c1 Reviewed-on: https://chromium-review.googlesource.com/806170Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#521456}
-
Chris Mumford authored
Adding GetLastFileError() allows a base::File user to know the reason for an API failure. Previously the only error code that could be retrieved was by calling error_details after a failed open attempt. This method is similar to using errno or Win32's GetLastError(), and must be called immediately after the failed function call. Also, similar to the POSIX errno contract, base::File functions do not set errno=0 (or call SetLastError(ERROR_SUCCESS)). Bug: None Change-Id: I659b6963277b2b999019ad791275bf4fb7807909 Reviewed-on: https://chromium-review.googlesource.com/803736Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#521455}
-
Dave Tapuska authored
Devtools was not correctly handling input that is not generated by itself and invoking callbacks when the input wasn't actually processed. Add a modifier indicating content was injected using the debugger so that we can then query for that to determine if we should release the event. This is a stop gap solution until we can actually bind callbacks into the sending of events and devtools wouldn't need its own queues of callbacks. BUG=789869 Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 Reviewed-on: https://chromium-review.googlesource.com/804357 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521454}
-
Peter K. Lee authored
Continuation of http://crrev/c/802464 to test that Active, Inactive, and Background application states are interpreted correctly. Bug: 781361 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie86cfca571e8e0a4159a591d0d357a3458384483 Reviewed-on: https://chromium-review.googlesource.com/802618Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521453}
-
Chris Palmer authored
TBR=dcheng Bug: 789374 Change-Id: I68d41425e0cf376d1346546268fac60bd9a6dc3c Reviewed-on: https://chromium-review.googlesource.com/807184Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521452}
-
Dominic Mazzoni authored
Passing the wrong coordinates was causing it to scroll to the wrong place and sometimes bounce around. Adds a new browser test to ensure that calling scrollTo works as expected. Bug: 788696, 646117 Change-Id: Ia8014c9ee96eef14a60a7f4ddebeec02e2f15db4 Reviewed-on: https://chromium-review.googlesource.com/802235 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521451}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/d5f44c986038..f5be5bafa6f6 $ git log d5f44c986..f5be5bafa --date=short --no-merges --format='%ad %ae %s' 2017-11-29 geofflang StateManagerGL: Use dirty bits for program binding. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie71348cfd4615b8351935f75ae9ae23e32d6bed9 Reviewed-on: https://chromium-review.googlesource.com/806921Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521450}
-
Chris Palmer authored
Talk about the special powers of WebUI renderers, and not-yet-shipped features. Bug: 789374 Change-Id: I94e76ee58aec2ac0e5c8ca65cbf810e83f6c17e3 Reviewed-on: https://chromium-review.googlesource.com/798393Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521449}
-
Nate Chapin authored
This reverts commit ae15c135. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=791291 https://bugs.chromium.org/p/chromium/issues/detail?id=791316 https://bugs.chromium.org/p/chromium/issues/detail?id=791288 https://bugs.chromium.org/p/chromium/issues/detail?id=791348 https://bugs.chromium.org/p/chromium/issues/detail?id=791347 https://bugs.chromium.org/p/chromium/issues/detail?id=791450 https://bugs.chromium.org/p/chromium/issues/detail?id=791300 https://bugs.chromium.org/p/chromium/issues/detail?id=791522 Original change's description: > Make DocumentThreadableLoader a ResourceOwner > > It had a custom implementation to support use of RawResourceClientStateChecker. > Separate these. > > Bug: 790778, 640291 > Change-Id: Id8a29a5ad916429969b47a0258675437de284b55 > Reviewed-on: https://chromium-review.googlesource.com/802094 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521177} TBR=hiroshige@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790778, 640291 Change-Id: I15938754b57b8142f8d7e9c94f8aff9bdd8329ed Reviewed-on: https://chromium-review.googlesource.com/806794Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#521448}
-
Daniel Park authored
Prevents double tapping of a survey info bar to prevent any double click issues e.g. this crash Bug: 791076 Change-Id: Ifcb8961beaf4bcd1353eb1a121f51e2249de3809 Reviewed-on: https://chromium-review.googlesource.com/804751Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521447}
-
Morten Stenshorne authored
This test used to fail in Blink, because the default window width is 800px when running tests. The test assumed a slightly wider window in order to not produce a horizontal scrollbar in the test (while the ref would not produce any scrollbar that easily). Bug: 788337 Change-Id: I30e5c628ad584862bdbdf71140d228a552e12e74 Reviewed-on: https://chromium-review.googlesource.com/806196Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521446}
-
Rouslan Solomakhin authored
Before this patch, parsing non-unicode fingerprints resulted in a failed assertion when logging the string to terminal. This patch adds a check for non-ASCII input string. A non-ASCII string is not logged to terminal. After this patch, parsing non-ASCII fingerprints does not result in a failed assertion, because the non-ASCII fingerprint is not logged to terminal. Test: FingerprintParserTest.MustBeASCII Bug: 791584 Change-Id: I0317203c1dae5a048008df074fee77982838fa1c Reviewed-on: https://chromium-review.googlesource.com/806317 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#521445}
-
Helen Li authored
When we restart jobs with a different proxy configuration, we might have a delayed ResumeMainJob task in our task queue. When this ResumeMainJob() runs, we will crash because the old main job is deleted and we have a new main job. This CL cancels the ResumeMainJob task and adds regression test. Bug: 790776, 789560 Change-Id: Icd2bc9ec36c98c973f80e14541d9f68d0a046835 Reviewed-on: https://chromium-review.googlesource.com/805354 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521444}
-
Erik Luo authored
Bug: 667560 Change-Id: I99f69cf7105902a4f8c0bac38442ff058182338a Reviewed-on: https://chromium-review.googlesource.com/804675 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521443}
-
Charles Harrison authored
This doesn't properly plumb through the click closure, which might need some rethinking since we share the UI with framebusting. Bug: 661629 Change-Id: I8a38140eee2f314e98183fc0874af94dda15a626 Reviewed-on: https://chromium-review.googlesource.com/763909 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#521442}
-
Lei Zhang authored
Change-Id: Ib22c9ebe468065a572cf3d5a2ba61cbd3ed85698 Reviewed-on: https://chromium-review.googlesource.com/804752Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521441}
-
chrome://interventions-internalsThanh Le authored
Design doc: https://docs.google.com/document/d/1i7_1VkjJ2x86BXWocK4ZuEVq_DzdYRslt2ihJ2UdlZk Screenshot: https://drive.google.com/a/chromium.org/file/d/1qGcgcNF3vCjb0cjkkrO_Sox9OEOSQtXo Bug: 788872 Change-Id: Ib09a31a3914aa9b244e9e6117e1cc501a102e82c Reviewed-on: https://chromium-review.googlesource.com/791910 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521440}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bee6cacc5435..7ffbcf909d36 $ git log bee6cacc5..7ffbcf909 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 robertphillips Add unit test for SkDeferredDisplayLists (take 2) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ie17e899f94aa96c4dc8124fcbcd2fcd7b90b9d36 Reviewed-on: https://chromium-review.googlesource.com/806914Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521439}
-
Erik Luo authored
- Remove redundant Find/Previous buttons - Replace "Replace" checkbox with cool icon - 'Replace all' button is disabled when 'Replace' is also disabled Screnshot: https://imgur.com/a/gp0SZ Bug: 631163 Change-Id: I98f2ca5b8e504d13d85057a80fa5bb9cf60c6118 Reviewed-on: https://chromium-review.googlesource.com/769991 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521438}
-
Rintaro Kuroiwa authored
- With typemap to media/cdm/cdm_proxy.h types. - No methods are added yet. Bug: 785563, 641132 Change-Id: I9012cc81bb52be694d004673881aedad8b8abb09 Reviewed-on: https://chromium-review.googlesource.com/772863 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521437}
-
David Reveman authored
Camera: Take photo. Video: Capture video. Bug: 787673 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9f3a72991b6384533b6d5d031ab4e11ecf2e1b2 Reviewed-on: https://chromium-review.googlesource.com/804560Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521436}
-
Réda Housni Alaoui authored
- Full rewrite of the MediaFoundation implementation video part to use IMFCaptureEngine - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities - takePhoto triggers a still image capture with the highest available resolution without stopping the video stream thanks to IMFCaptureEngine TEST=adapted video_capture_device_unittest.cc and webrtc_image_capture_browsertest.cc; launch Chrome with --force-mediafoundation on Win8+ and capture video using e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ R=mcasas@chromium.org Bug: 730068 Change-Id: Ib8e7f475d8120a63dd08c7b215c1eaf2c6f3d800 Reviewed-on: https://chromium-review.googlesource.com/734042 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521435}
-
Wez authored
Bug: 789712 TBR: gab Change-Id: I16e059c18420a56e875c5564015531177bc213d3 Reviewed-on: https://chromium-review.googlesource.com/806815Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#521434}
-