- 02 Jun, 2020 40 commits
-
-
Alex Ilin authored
This CL adds a new set of tests for the reauth dialog. These tests check interactions with a Gaia Reauth endpoint that is imitated through an EmbeddedTestServer. The main "embedded/xreauth/chrome" endpoint operates in two modes: - In the default mode, the endpoint redirects to the "challenge" URL whose response can be controlled within the test by a ControllableHttpResponse. - If the "?done" query is present, the endpoint returns the HTTP_NO_CONTENT response that signifies a successful reauth. The CL also extracts common test code into test suite functions to reduce the code duplication and make the tests code more readable. Bug: 1045515 Change-Id: I89d4aac57ef25168def1341fb63b1a7498dcfa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225396 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#774205}
-
Joshua Peraza authored
Bug: 1082190 Change-Id: If7e19d39beb4def965c0cfebe87aabaefdc8faaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225274Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#774204}
-
Jordan Bayles authored
This patch effectively reenables the SessionDuration histogram for media remoting, by updating the expiration date to 1 year from now. I also added myself as an owner. Bug: 1053021, b/157478542 Change-Id: I2904ca1703b4414a1170c59f5fb522481486b507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223144Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#774203}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/11dd7183c4d2..2fbd57b6362a 2020-06-02 capn@google.com Regres: Test changes from external contributors if reviewed by Googler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2a90affd3cf2d9ef0d504dbaca413e88ce8f5fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774202}
-
Toby Huang authored
The browser test UserCloudPolicyManagerChildTest.PolicyForChildUser is flaky due to invalid OAuth tokens from FakeGaiaMixin. This CL fixes the root cause and re-enables the test. Bug: 1052604 Change-Id: Idaaed998e050e4b090513fabb7f8244330d55d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226337Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774201}
-
Henrique Nakashima authored
This moves it together with the rest of the glue code. Bug: 1072748 Change-Id: I89b310995af73243a59402a2e55ee9c82c7b8231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225358Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#774200}
-
Sammie Quon authored
These are used for perf tests, and there are no plans to remove those anytime soon. Test: none Change-Id: Iaf826786e4a0dbdef766581002bc2f97fe62b863 Fixed: 1088584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225577Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774199}
-
sczs authored
Creates a Discover provider for the Feed. Bug: 1085419 Change-Id: Ie057304dffefa3b3dba6b53cd9092da9ed559305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212441 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774198}
-
Etienne Pierre-doray authored
Still useful for ongoing experiment: crbug.com/1026785 Bug: 1089879 Change-Id: I6e3dbb99b038fd0ddf90d8d82beaf78529eec603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224647Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#774197}
-
Mohamed Amir Yosef authored
Instead of using a hardcode value for the icon size, this CL incorporates the line height of the small body text. Default in Harmony specs is 20. So this CL doesn't introduce any UI change in the default settings. Bug: 1044038 Change-Id: If2bd0f50ab93c85c07b77271f7614510426f0101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219902Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#774196}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 216407de. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I660ebcfaade8bdd4891e15d92a1b35ea44725b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774195}
-
Vincent Boisselle authored
There are corner cases where the stream object could be used when null which causes a null dereferencing exception crash. Bug: 1088440 Change-Id: I9281fa6d2cbf3216eebe1ea5c5ccbad8607463ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225838Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#774194}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/d7beb6099c3a..6dfe58d86e80 $ git log d7beb6099..6dfe58d86 --date=short --no-merges --format='%ad %ae %s' 2020-06-01 fayang Deprecate gfe2_reloadable_flag_quic_deprecate_draining_streams. 2020-05-29 dschinazi Fully support draft-28 transport parameters 2020-05-29 fayang Fix quicsession::willingandabletowrite to check connection level flow control for send control stream and qpack streams. protected by gfe2_reloadable_flag_quic_fix_willing_and_able_to_write. 2020-05-29 fayang Internal QUICHE change 2020-05-29 dschinazi Introduce ParsedQuicVersion static constructors 2020-05-29 wub Fix the bug where loss parameters are chosen but not applied in loss algorithms. protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src update flags Change-Id: I087108b0feac89fbaabdca3949b66911f066c4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225266 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774193}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. !! is used in situations where the pointer is assigned to or returned as bool, otherwise CheckedPtr's more costly implicit T* cast operator would kick in. !! isn't needed in boolean expressions. Examples here: https://chromium-review.googlesource.com/c/chromium/src/+/2226003 Bug: 1080832 Change-Id: I8ebc83be2e96bf1598dd25ef5ca07c98134ccffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226318 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#774192}
-
Moe Ahmadi authored
Autocomplete system provides the correct transition type to use when the user navigates to a match. This is ui::PAGE_TRANSITION_TYPED for URL matches and ui::PAGE_TRANSITION_GENERATED for other types which do not look like a URL. This allows for URL navigations from the NTP realbox to be correctly recorded in the history backend and for the most visited tiles to be updated accordingly. Bug: 1090004 Change-Id: I1af862bfe8b926ccc729dc340fe8384e5759101b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224020Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8abb5a5b05e8..70b11675ddaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fdoray@google.com,tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fdoray@google.com,tnagel@google.com Change-Id: Ib643a84a69c87d522a84baf20431f4d22fa7ca1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226614Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774190}
-
Nina Satragno authored
When sending getPinUvAuthTokenUsingUvWithPermissions, the permissions list is required [1]. Since we are only using UVToken for make credential and get assertion, and sometimes making a credential involves getting assertions, request those two permissions with every UVToken request. [1] https://drafts.fidoalliance.org/fido-2/stable-links-to-latest/fido-client-to-authenticator-protocol.html#permissions-list Fixed: 1086558 Change-Id: I572850efafb02ab9d292465379d385751adac101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220258 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#774189}
-
Paul Jensen authored
Bug: 1089566, 1088509 Change-Id: I8574ae101c5d59f4a083e74ebfce4e92db2a71df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225842 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#774188}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1e6a2f8f4a6ae67035c21da5a3a7aa351f2b3f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226633Reviewed-by:
-
Marijn Kruisselbrink authored
The code was deleted long ago, but these two histograms were accidentally not yet marked as obsolete. Bug: 1089492, 1089493 Change-Id: I0ef270f237e37831be72093fc39e5fed88586a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225487 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c5a213b20f9..1feb578b5252 2020-06-02 bpastene@chromium.org gn_helpers: Roll to b52227fd. 2020-06-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-02 niwa@google.com Replace setup_adb with setup_adb_vm 2020-06-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-01 morg@google.com Add -arc-r-userdebug board to unified lab names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ie2ec6f7e5e54dbc95388e1f70bce45d59d681048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226872Reviewed-by:
-
Ahmed Fakhry authored
BUG=1088581, 1088582, 1088580, 1088579 Change-Id: If475d043ed2ad56dad4de655357191cfd8d3e91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225582Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#774184}
-
Hesen Zhang authored
- Verify the prefs in scheduler unit test. - Add more coverage in TileServiceImpl. Change-Id: Ie9decd55081ad01f78c1f4dbce4f7d3bbd0bba39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226082 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774183}
-
Andrew Xu authored
This CL implements the two-stage app scaling. That is: if shelf buttons in size of |ShelfConfig::shelf_button_size_| cannot show without scroll, try |ShelfConfig::shelf_button_size_median_|; if shelf buttons still shows with hiding, apply |ShelfConfig::shelf_button_size_dense_|. Bug: 1019397 Change-Id: I208b2fcc6f6421d4331317030083aa92bd2bbefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223988Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774182}
-
Doug Arnett authored
Some browsertests count on kTranslateSubFrames being disabled by default. This disables the feature specifically for those tests to not count on default behavior. Change-Id: I5b9470b757ae922198e837011c672b19d8b1ebe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225751 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774181}
-
Benoit Lize authored
The histogram is no longer needed, the feature launched, its overhead is small enough, and not worth being recorded. Mark the histogram as deprecated, remove the recording code, and its unit test. Bug: 1088944, 942512 Change-Id: I9b10faa0eb696631f4a771eb69d120450e0b25a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226851Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774180}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09fe6260ed76..dad4850e5d7a 2020-06-02 ddrone@google.com Fix a bunch of typos If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic87f6993ba222d4c05cb19ff46cc5c6dd063b1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226873Reviewed-by:
-
Anders Hartvoll Ruud authored
We currently adjust the computed value of 'color' on the document element to simulate 'canvastext' behavior. However, there's an incorrect assumption that it's safe to adjust whenever there are no 'color' declarations in the cascade. During a transition, the base ComputedStyle is the destination style for the transitioning element, and on the final frame of the transition, the StyleEngine simply emits a copy of the base style, without adding any declaration to the cascade. This causes color- transitions on the document element to "snap back" to black (or white, depending on color-scheme) when the transition ends. This CL fixes this by adding an explicit value (CSSInitialColorValue) which represents this behavior to the cascade. The value is added only when computing the base style, which prevents incorrect adjustments on top of the final transition frame. Bug: 1087188 Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224222Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#774178}
-
Mark Cogan authored
The CL has the base iOS Chrome unit tests set the plist key for the UIScene APIs when the gn flags for multiwindow/scene startup are set. Change-Id: I278be41b16e26d1078c043f936b3febc65dde6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199144 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
David Roger authored
There are multiple styles for signin interception: - profile switch - enterprise - multi user These are not implemented yet, but this CL adds the logic to determine which one should be used. Bug: 1076880 Change-Id: Id90b558daa0dfb8f8b29feb5b1712d06b55e00bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218110 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#774176}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3bd1c1858f93..a0cf1eabb73e 2020-06-02 peah@webrtc.org Add peah as OWNER to common_audio 2020-06-02 kron@webrtc.org Reland "Add trace of enqueued and sent RTP packets" 2020-06-02 peah@webrtc.org Updating the Ooura FFT to take SSE2 usage specification in the ctor 2020-06-02 yinwa@webrtc.org Revert "Add av1 test running real video clips." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idcd2cc05da6df01a9b77f4bbf5e8cea3b2313c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226871Reviewed-by:
-
Owen Min authored
Extension with blocked required permissions should be blocked. Extension with manifest type that is not whitelisted should be blocked. These blockings have higher priority than installation mode. The function will be used by webstore API. Bug: 1083500 Change-Id: I477dbf7bf2084cfa93c432295f226fb2900ca179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204685 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774174}
-
Kevin Babbitt authored
Follow-up to https://crrev.com/c/2225334. Adds a test similar to other tests for accessibility hit testing. While developing this test I noticed that the point passed to BrowserAccessibilityCocoa::accessibilityHitTest is actually in frame coordinates rather than screen coordinates. Noted this in a comment. Bug: 1086819 Change-Id: I052a78d2bbef54662e171889080e7089c510653d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225818 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774173}
-
Chih-Yang Hsia authored
- Add a enum class DeadStreamDetection to AudioInputDevice constructor to control the detection of dead stream. - Don't use the detection for hotwording and keep using the detection for other streams. Bug: 961890 Test: Test assistant with DSP hotword device Change-Id: I5e9a54275bc6f1d39cc125b0a54aac540eaf1e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220417 Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774172}
-
Xida Chen authored
These histograms are already replaced by other histograms, but didn't mark as obsolete. Bug: None Change-Id: I64142a4df8818d6a886657925ce216035b3fdcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222898Reviewed-by:
-
Timothy Gu authored
Currently, window.event is implemented as a private symbol property stored on the Window JavaScript object itself. While doing so may have simplified memory management when the code was first written versus storing the event in C++, it does not anymore with Oilpan and unified heap. This also has no performance benefits, since each call to event() has had to jump through multiple C++/JS boundaries. The custom setter for Window.event was previous removed in r538391. This CL removes the custom getter. Bug: 236420 Change-Id: I67e862dda8c5a0248436ea90553fbf0b9b37aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225505 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jonathan Ross authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2225586 this test was suppressed. The core failure was identified as crbug.com/1085899 In https://chromium-review.googlesource.com/c/chromium/src/+/2225979 the root cause was disabled for WebGL conformance tests. So I am re-enabling the test to maintain coverage. TBR=kbr@chromium.org Bug:1088465 TEST=deqp/data/gles3/shaders/preprocessor.html Change-Id: Ibbe1b22d434dc092cb6c0808dad239e5cc681db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226770Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774169}
-
Becca Hughes authored
Add tests for clear-site-data which should reset the media feed. BUG=1053599 Change-Id: If539e178aad9c04c3891930420f9f7b8cbbe7a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225231Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#774168}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8729c26f..113bf7f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1972092e17ec655f7e75466431d912606df40473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774167}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8121e57ab51..a5ced794731b 2020-06-02 herb@google.com Move addOp to SubRun and rename 2020-06-02 mtklein@google.com trim down skia_select() 2020-06-02 mtklein@google.com Wsign-conversion for public headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I93cf78b50a9f7fe015e545f974e2b60a23422e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226613Reviewed-by:
-
