- 15 Aug, 2018 40 commits
-
-
Dan Elphick authored
Replace deprecated parameterless *Type*Value() methods with the *Type*Value(Local<Context>) equivalent method. Since these functions return a Maybe, use FromMaybe() on the return value to guarantee a return value even if the conversion could throw an exception. (In future many of these could be converted to use As<Int32>::Cast()->Value() if they had IsInt32 checks instead of IsNumber). This is the cast version of a chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1153247 Bug: v8:7786 Change-Id: I09a59a7de133ec429fa1aea1c5350e8af8bc81c3 Reviewed-on: https://chromium-review.googlesource.com/1174730Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583194}
-
Findit authored
This reverts commit a011e05f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 583132 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwMTFlMDVmMDAxYmVmMzkwOTk5MDYyM2FkZDU3ZGYwZWI5YTIwNDIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8223 Sample Failed Step: ash_unittests Original change's description: > Generalize AccessibilityPanel sizing > > Modify AccessibilityPanel sizing to be more flexible, and work for > both the ChromeVox panel and the SwitchAccess context menu. > > Also fixes a bug where ChromeVox Panel fullscreen goes offscreen when > Docked Magnifier is enabled. > > Bug: 864796 > Change-Id: Ib99150f68dcb332aa86a0cc72d7863d6e6b301f7 > Reviewed-on: https://chromium-review.googlesource.com/1167886 > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583132} Change-Id: Id70f8b9a1b1f7d0f089b38b26c085c773ef9dde1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864796 Reviewed-on: https://chromium-review.googlesource.com/1175462 Cr-Commit-Position: refs/heads/master@{#583193}
-
Yuki Shiino authored
https://heycam.github.io/webidl/#construct-a-callback-function This patch supports "construct" algorithm of IDL callback functions. The following WIP patch will be going to use this algorithm. https://chromium-review.googlesource.com/c/chromium/src/+/1170731 Bug: 873942 Change-Id: I3d58db6cb4cb23662593e2c96080668346a399a2 Reviewed-on: https://chromium-review.googlesource.com/1174079Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#583192}
-
Momoko Sumida authored
This reverts commit 2472878c. The following CL was reverted as a suspect for https://crbug.com/873015: crrev.com/c/1164876 This CL reverts the revert as the failing test is not related to CSSStyleSheet. The flaky test has been disabled in crrev.com/c/1171681 Bug: 873015 Change-Id: I54cefa72e4f82b1075550d6efb4a0ca8efe98383 Reviewed-on: https://chromium-review.googlesource.com/1174150 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#583191}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 53f90379. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22747 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I81c9d62cdbbfd15082eb71cd8bbeb83c2945a9b8 Reviewed-on: https://chromium-review.googlesource.com/1175543 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583190}
-
Hiroki Nakagawa authored
This test (OnDiskApp/NetworkContextConfigurationBrowserTest.CookiesEnabled/1) is now failing on the Mac10.11 bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28580 Noth that the Findit suspects the following CL is failing the test with 86% confidence: https://chromium-review.googlesource.com/c/chromium/src/+/1153630 https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/28580 At first, I tried to revert it but failed because of merge conflict: https://chromium-review.googlesource.com/c/chromium/src/+/1175601 Bug: 847555 Change-Id: Idf91c9f8595139dd1d9c667adc304e08d0e6083d Tbr: mmenke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1175585 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583189}
-
Khushal authored
The RasterInterface should be notified when accessing the GrContext, so it can make sure any state tracked in the implementation is reset if it could be modified by using the GrContext. We are already doing this for raster tasks in GpuRasterBufferProvider, also do this in upload tasks which use the GrContext for uploading images. R=ericrk@chromium.org Bug: 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2b5039f2a2f64fb6986181639b81597c741103a5 Reviewed-on: https://chromium-review.googlesource.com/1175415 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583188}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a66ea19e9d55..35fbbed72c49 git log a66ea19e9d55..35fbbed72c49 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@35fbbed72c49 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I44def4ab9ed56c6a414e404540fd7aff66a377ed Reviewed-on: https://chromium-review.googlesource.com/1175521Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583187}
-
Hiroki Nakagawa authored
This reverts commit 04509e6d. Reason for revert: Looks like this is failing the following test on the Mac10.12 bot: WebRtcAudioDebugRecordingsBrowserTest.TwoCallsWithAudioDebugRecordings See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14929 Original change's description: > Rename LogList to TextLogList where appropriate > > Help distinguish WebRTC event logs from textual logs. > > Bug: 775415 > Change-Id: I17b14cfc25ab0c70eecd905cd28bad77304c3b3f > Reviewed-on: https://chromium-review.googlesource.com/1174352 > Reviewed-by: Henrik Grunell <grunell@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elad Alon <eladalon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583036} TBR=avi@chromium.org,grunell@chromium.org,eladalon@chromium.org Change-Id: I90c270f52209fed5963f18bd4c64225dc7aebfb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415 Reviewed-on: https://chromium-review.googlesource.com/1175621Reviewed-by:
-
Stuart Langley authored
Team drives can have no ascii and path like characters in the name. Normalize the names to remove these. This will lead to a delta between what you see in the web app and what you see in the file manager for team drives with these names. Bug: 873920 Change-Id: I24fd8664cc64a62b9a1d5e72d0138c0792c449d9 Reviewed-on: https://chromium-review.googlesource.com/1174134Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#583185}
-
Stuart Langley authored
If the user has a large number of team drives, we fetch the list in batches. If this value is not set then we get a small amount per batch, resulting in many more calls to the server to get the list of drives, which degrades app startup performance. Bug: 874354 Change-Id: I82982a6decda3f4a342925b7b3d9872226938cd7 Reviewed-on: https://chromium-review.googlesource.com/1175520Reviewed-by:
-
Ramin Halavati authored
Preferences related to proxy config are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I2670d44b59443f1c26844612842402511d246e63 Reviewed-on: https://chromium-review.googlesource.com/1172133Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583183}
-
Dominic Mazzoni authored
crrev.com/c/1062661 made it so that any time an accessibility node changes, we re-serialize the entire CSS block it's contained in - while this fixed some correctness issues, it introduced a performance regression that's too significant to ignore. This change rolls back the fix for now until we can find a way to fix it that doesn't impact performance. TBR=dtseng@chromium.org Bug: 868830, 865621, 843746 Change-Id: I900a4e6ba796608974e881f091b99b0d45c09536 Reviewed-on: https://chromium-review.googlesource.com/1174851Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#583182}
-
Giovanni Ortuño Urquidi authored
ProcessAppOperations will need to include the URL of the app that was installed. To avoid having two distinct callbacks, this CL changes InstallCallback to also return the url. Bug: 864904 Change-Id: Ie296a90b4588c0d301c9a03d487433b9d56832b1 Reviewed-on: https://chromium-review.googlesource.com/1174589 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#583181}
-
Ramin Halavati authored
Preferences related to network time are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I7a37a22be09e21942e608b1f407b1d27704fa8fd Reviewed-on: https://chromium-review.googlesource.com/1172134Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583180}
-
Tatsuhisa Yamaguchi authored
This will prevent notification counter icon shown in white while in the OOBE screen, when the background of the icons are also bright color. Test: manual test Bug: 874021 Change-Id: I91cbbd1111b33d1a030b1d5aae2bdd884a1d487a Reviewed-on: https://chromium-review.googlesource.com/1175517Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583179}
-
Kyoko Muto authored
As the second step of implementing "Imperative Shadow DOM Distribution API", this CL make assign function to assign nodes to slot in manual slotting mode. This CL also introduces HeapVector for each slot to store the nodes that assign introduced. BUG=869308 Change-Id: I9b02a70f601364123fb565221d3def760408bc2a Reviewed-on: https://chromium-review.googlesource.com/1166925Reviewed-by:
-
Wenzhao Zang authored
This is a follow up for crbug.com/857221 Bug: 873594 Change-Id: I8a5ab4fd2762b48b0b1fdd3d2f9d499673658d6d Reviewed-on: https://chromium-review.googlesource.com/1175145Reviewed-by:
-
Ramin Halavati authored
Contextual Suggestions preferences are removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia1c68e786c3509905391651c9a95cf2d152bf5ea Reviewed-on: https://chromium-review.googlesource.com/1174117Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583176}
-
Dominic Mazzoni authored
TBR=dtseng@chromium.org Bug: 870661 Change-Id: If82429da90259c3af73c4fa424d3bba5e6a09a00 Reviewed-on: https://chromium-review.googlesource.com/1174862Reviewed-by:
-
tzik authored
This CL removes legacy base::Callback support from Mojo code generator, that is no longer used. Bug: 714018 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2928476e357136a7c7bbb57f83509c63fe45b321 Reviewed-on: https://chromium-review.googlesource.com/1152637Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#583174}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ided8d0c3fc6006e4296362d840a6f03aec093d1b Reviewed-on: https://chromium-review.googlesource.com/1175066 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583173}
-
Noel Gordon authored
Deleting a file or folder exercise different code paths in Files app. There is a test case for a folder (aka, a directory). Add a test case for deleting a file. Test: browser_tests --gtest_filter="*FilesApp*keyboardDelete*" Bug: 873915 Change-Id: I618f7808be3eab4f73a97068cd8298f05f464ed8 Reviewed-on: https://chromium-review.googlesource.com/1174588Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583172}
-
Eric Karl authored
We currently unlock pre-decoded images after 2 frames of any type. This doesn't always give callers a chance to use their images (if main thread is a bit backed up). Instead we should wait for the caller to actually use the image. Additionally, we drop images after 250ms to prevent excessive growth if a user fails to use images in a timely manner. See the linked bug for example traces which show the benefits. R=khushalsagar Bug: 869491 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd94709aad5c076b1ba295495eaab24dc893ebdb Reviewed-on: https://chromium-review.googlesource.com/1159203 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583171}
-
Xu Xing authored
Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic817611158f48229c031161e4c8a6e7ac949b918 Reviewed-on: https://chromium-review.googlesource.com/1161601 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
-
Adam Langley authored
Results written up at https://www.imperialviolet.org/2018/04/11/pqconftls.html Change-Id: Ic8a916104706af54314e8a426a44087804975358 Reviewed-on: https://chromium-review.googlesource.com/1128160 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#583169}
-
Mitsuru Oshima authored
I'll remove ui_scale parameters in a separate CL. Bug: 823922 Test: Removed/Updated unit tests. I kept a few tests which still makes sense. Change-Id: Ia0a4b34a1fba02823dabec7ac91c73220740221f Reviewed-on: https://chromium-review.googlesource.com/1175007Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
Bug: 873824 Change-Id: I2f205fdca015150805768ed7adf5d2ff31344927 Reviewed-on: https://chromium-review.googlesource.com/1174986Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#583167}
-
Ken Rockot authored
Adds a new NavigableContentsView type to the Content Service's client library. This is meant to be a platform-agnostic encapsulation of all business relevant to the display of renderered web contents (i.e. a navigated NavigableContents object) within a client application's UI. This also enables NavigableContentsView embedding on all desktop Aura platforms in addition to Chrome OS, which is the only supported platform before this CL. For non-Mash non-Chrome OS builds, NavigableContentsView usage is restricted to the browser process, where Content Service instances are hosted. Support for remote NavigableContentsViews will expand as support for the UI service expands. For testing, this enables --launch-in-process-simple-browser in all desktop Aura developer builds, running an in-process Simple Browser application which consumes NavigableContentsView to display web contents via the Content Service. The out-of-process version (--launch-simple-browser) still works on Chrome OS with Mash enabled. Follow-up patches will enable local NavigableContentsView usage on non-Aura platforms (e.g. Android, Mac, etc) so that we can start converting WebContents uses to NavigableContents uses. Bug: 855092 Test: Run chrome --launch-in-process-simple-browser (with DCHECKS enabled) on Chrome OS, Linux or Windows and watch it go! Change-Id: Id091017a1656f078ea87fa3a9d6a6f4049fb4f13 Reviewed-on: https://chromium-review.googlesource.com/1171668Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583166}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1164342495fd..52c721180793 git log 1164342495fd..52c721180793 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 tandrii@chromium.org Set explicit latest OWNERS for bot_update recipe_module. 2018-08-14 jbudorick@chromium.org bot_update: pull revisions from provided cfg if present. 2018-08-14 vadimsh@chromium.org [cipd] Check CIPD client hash against pinned SHA256 during updates. Created with: gclient setdep -r src/third_party/depot_tools@52c721180793 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:873186,chromium:870166 TBR=agable@chromium.org Change-Id: I2ffab4553b1e83615deebd280c90efcb6c1bfb8f Reviewed-on: https://chromium-review.googlesource.com/1175291Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583165}
-
Shu Chen authored
This cl also removes the unnecessary ModeIndicatorController, because 1) Init widget container can be done directly in ash. 2) ImeControllerClient has already listened to InputMethodChanged event. 3) The anchor bounds can be got via the IMECandidateWindowHandlerInterface. Bug: 738531 Change-Id: Ieee87fde776be2f33121da52293b886933106205 Reviewed-on: https://chromium-review.googlesource.com/1170717 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Scott Violet authored
This way the WindowPort can reach back into the Window during destruction. BUG=847992 TEST=covered by tests Change-Id: I70df1c9512086f9e834ab76fa430c94f5723f34d Reviewed-on: https://chromium-review.googlesource.com/1175133Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583163}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2363356f52f6..21e5e85a4976 git log 2363356f52f6..21e5e85a4976 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 fjhenigman@chromium.org builtools: Roll GN. Created with: gclient setdep -r src/third_party/angle@21e5e85a4976 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ic2068b89f21cb9060e9b4b7e5c29289a45b13efd Reviewed-on: https://chromium-review.googlesource.com/1175250Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583162}
-
Scott Violet authored
The OverviewButtonTrayTests need to set the keyboard devices *after* AshTestBase::SetUp() is called. This is is important in single-process mash as Ash is the one creating the Env that the keyboard devices us. In non-single-process-mash AshTestSuite is creating the Env these tests use. The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different enough for single-process mash that I created a separate test. Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with this test including Env::GetInstance(). NOPRESUBMIT=true BUG=847992 TEST=test only changes Change-Id: I0543db96ca9aa910340360d8da3e6aafcda34d7f Reviewed-on: https://chromium-review.googlesource.com/1174978 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
Bottom-botder was disabled (because it conflicted with another line). This Cl returns it back. Bug: 852049 Change-Id: I2bd0d2282114809f19e85bced6f821b1b8379aa7 Reviewed-on: https://chromium-review.googlesource.com/1171954Reviewed-by:
-
rbpotter authored
Bug: 871656 Change-Id: I7b258a191788051187ea2066072d41997953e45b Reviewed-on: https://chromium-review.googlesource.com/1174959Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583159}
-
Devlin Cronin authored
Currently, the ExtensionsSystem watches for application termination, and then forwards the notification along to the apps code. This causes a dependency between the extensions system and apps. Move the application termination observation to a dedicated KeyedService in platform_apps code, and remove knowledge of platform apps from the extensions system. Bug: 873872 Change-Id: I2dc6ae147acc4bad428542f5c5ed31154355304b Reviewed-on: https://chromium-review.googlesource.com/1173765Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583158}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b924003d3504..55ccb526913d git log b924003d3504..55ccb526913d --date=short --no-merges --format='%ad %ae %s' 2018-08-14 tsepez@chromium.org Remove optional argument from NewFXJSBoundObject(). 2018-08-14 tsepez@chromium.org Remove optional argument from GetVariablesThis(). 2018-08-14 tsepez@chromium.org Remove default args from CPDF_DIBSource::StartLoadDIBSource(). Created with: gclient setdep -r src/third_party/pdfium@55ccb526913d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4652a8ea4f767ed76094b09fce5ada5c2f03568f Reviewed-on: https://chromium-review.googlesource.com/1175249Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583157}
-
Keishi Hattori authored
WeakMember as part of a HashMap entry can cause unexpected clearing when incremental marking is enabled. This CL changes SMILTimeContainer::scheduled_animations_ to use a epehemeron instead. Bug: 870306 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8b653825de0bc683a5151576385716141c78c454 Reviewed-on: https://chromium-review.googlesource.com/1166753 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Chris Palmer authored
Bug: 817982 Change-Id: If8602db9f284873f037775f3a37bcac8e120b313 Reviewed-on: https://chromium-review.googlesource.com/1166456Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583155}
-
