- 21 Nov, 2017 40 commits
-
-
Yuwei Huang authored
These code are no longer used and can be removed. Bug: 786616 Change-Id: I81782e7935026d36c9d3207da4db11c80057e3bf Reviewed-on: https://chromium-review.googlesource.com/780585Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518365}
-
Julia Tuttle authored
Bug: Change-Id: I2412fd464a2efc2a5fe1900818804b636cc43d59 Reviewed-on: https://chromium-review.googlesource.com/779251Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#518364}
-
Yuwei Huang authored
The percentage of seeing a GLES2-only device is low but it's still safer to handle that, given that doing so requires only a few more lines. Bug: 787224 Change-Id: I63650f3ce4c2afe93492b81e30d7075d7007ebdc Reviewed-on: https://chromium-review.googlesource.com/780801Reviewed-by:
-
Andrey Kosyakov authored
Bug: 787173 Change-Id: Ia5d9aec2b96b5cfbfb25ff71d3a436a3575c16fd Reviewed-on: https://chromium-review.googlesource.com/782141Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518362}
-
Min Qin authored
BUG=778255 TBR=dtrainor@chromium.org Change-Id: I599eec2a7123584d4943171e15da326ec730325d Reviewed-on: https://chromium-review.googlesource.com/783275Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518361}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c11c947e..fdf73522 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib5a7e4de403a8a58e82b5fcce537e0fa4056991c Reviewed-on: https://chromium-review.googlesource.com/782459Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518360}
-
danakj authored
TextureMailboxDeleter has nothing to do with the now-defunct TextureMailbox, it just deletes textures. So name it so. While doing so we uncovered a use of base::ThreadTaskRunnerHandle::Get() in GLRenderer, which may not be the same task runner given to the compositor to run its tasks on, so change things to plumb in the task runner to GLRenderer. Then creators of GLRenderer do not need to make a TextureDeleter anymore, so have GLRenderer do that itself. While sorting this out, clean up the GLRendererCopier tests to not subclass GLRendererPixelTest, and make and destroy a GLRenderer. Instead subclass PixelTest and make only the things it needs. R=ccameron@chromium.org TBR=boliu Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I15a93b3f858fd52272341e19edf8e5ed989721dd Reviewed-on: https://chromium-review.googlesource.com/782403 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518359}
-
yiyix authored
This patch is aimed to reduce the running time of draw occlusion algorithm. In draw occlusion, quad++ is used to increase the iterator pointer to visit the next draw quad. In reality, the quad++ calls cc::ListContainer::Iterator::operator++ and creates a new Iterator which points at the next draw quad. As a result, quad++ is always the top 3 expensive line in draw occlusion. BEFORE: 91.61% viz::Display::RemoveOverdrawQuads(CompositorFrame) 32.21% cc::ListContainer::viz::DrawQuad::Iterator 29.26% cc::ListContainer::viz::SharedQuadState::end 7.42% cc::ListContainerHelper::PositionInCharAllocator 4.40% cc::ListContainer::viz::SharedQuadState::begin 4.23% gfx::Transform(SkMatrix44) 1.59% cc::ListContainer::viz::SharedQuadState::Iterator AFTER: 91.51% viz::Display::RemoveOverdrawQuads(CompositorFrame) 83.37% viz::Display::RemoveOverdrawQuads(CompositorFrame) 32.04% cc::ListContainer::viz::SharedQuadState::end 29.08% cc::ListContainer::viz::SharedQuadState::ConstIterator 7.54% cc::ListContainerHelper::PositionInCharAllocator 4.75% cc::ListContainer::viz::SharedQuadState::begin 4.35% gfx::Transform(SkMatrix44) 0.99% cc::ListContainer::viz::SharedQuadState::ReverseIterator ref: https://docs.google.com/document/d/1gM4h1ca2jDWdXbYa9yjC53m0sJzaT9skqbPGnfDsdyI Bug: 672929 Change-Id: I377ab3af3fdfa7e3d7ceb42dcfc2056de149424d Reviewed-on: https://chromium-review.googlesource.com/782063 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#518358}
-
Gurchetan Singh authored
CMAA makes graphics_WebGLPerformance go from 2 failures to 67 failures. These failures are triggered by GL errors: GL ERROR :GL_INVALID_FRAMEBUFFER_OPERATION : glFramebufferTexture2D Let's disable CMAA so we don't break WebGL on Tegra. BUG=b:67387379, chromium:787087 TEST=graphics_WebGLPerformance failures return to normal on Tegra NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iacaf76ee7a0c9c0f249075f6b65c0e53ace09552 Reviewed-on: https://chromium-review.googlesource.com/780430 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518357}
-
Mike Baxley authored
These Tools menu items are used in several tests. Remove the dependency of tests on tools_menu_constants.h. Bug: 787015 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5d6b180f86d2628737c96feed96245c095d374a Reviewed-on: https://chromium-review.googlesource.com/780051 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518356}
-
Eugene But authored
It is possible for WKWebView.URL to be empty inside webView:didCommitNavigation:. That's probably a bug, but WKWebView.URL does not represent last committed URL anyway, so it is safer to fallback to WKBackForwardList's currentItem when WKWebView.URL is nil. Using webView.backForwardList.currentItem.URL everywhere is not an option because that URL is not correct for WebUI pages loaded via loadHTML:. After dropping iOS 10 and switching WebUI to iOS 11's custom URL protocols it might be possible to use webView.backForwardList.currentItem.URL unconditionally. Bug: 784480 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c2cdb9fad425afec6756bc8e841389e979d066b Reviewed-on: https://chromium-review.googlesource.com/773621 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#518355}
-
Etienne Bergeron authored
The vector exception code used by chrome is incompatible with ASAN 64. The following patch is commenting out the code when ASAN is present. See comment in the code for details. R=rnk@chromium.org, siggi@chromium.org, inferno@chromium.org Bug: 783296 Change-Id: I8dbe192e658225840fe2249e99d9b84b518f558b Reviewed-on: https://chromium-review.googlesource.com/782399 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518354}
-
Philip Rogers authored
paint/invalidation/svg/js-update-stop-linked-gradient.svg: This test was recently updated which removed gradient stops: https://chromium.googlesource.com/chromium/src/+/e3276a9902608cd3930d2a1dad67d56b5ae98313 This patch updates the RLS expectation too. http/tests/devtools/agents-enable-disable.js (and virtual variant): This test is crashing on all platforms but the expectation was marked as timeout on just mac. plugins/mouse-events-fixedpos.html: This test is crashing flakily (see: https://crbug.com/786117). To make it easier to update the expectations file, a new section for flaky tests has been added. Bug: 781419, 786117 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Iba1f45b03a1ac2093c48a2cfcabf70c6f93a9d4d Reviewed-on: https://chromium-review.googlesource.com/779760 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#518353}
-
Peter Collingbourne authored
Running content_unittests on Android with CFI bad cast checks enabled [1] revealed two bad cast errors in accessibility: a bad cast from CountedBrowserAccessibility to BrowserAccessibilityAndroid in browser_accessibility_manager_android.cc:69 and from TestBrowserAccessibilityManager to BrowserAccessibilityManagerAndroid in browser_accessibility_android.cc:148. In the former case, the code from BrowserAccessibilityAndroid can easily be inlined into the caller, so this patch does that. In the latter case, the caller is accessing a field that is only present on BrowserAccessibilityManagerAndroid, so the fix is to derive TestBrowserAccessibilityManager from BrowserAccessibilityManagerAndroid on Android platforms. This change hopefully fixes the memory error that was detected by asan. In a followup I plan to attempt to re-enable these tests on Android with asan. [1] https://build.chromium.org/p/chromium.clang/builders/ToTAndroidCFI/builds/397/steps/content_unittests%20on%20Android Bug: 469376 Change-Id: I4560451ec276ab1057feac3ef906daf5fc045ca3 Reviewed-on: https://chromium-review.googlesource.com/780884 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#518352}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/03fd0356b4c9..378734c51221 $ git log 03fd0356b..378734c51 --date=short --no-merges --format='%ad %ae %s' 2017-11-20 jmadill D3D11: Lazy evaluation for draw call vertex params. 2017-11-20 oetuaho Remove unreferenced struct types from the AST Created with: roll-dep src/third_party/angle BUG=786535 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I6242b15e81048eee80e86cca5198bfbe8699a90c Reviewed-on: https://chromium-review.googlesource.com/782443Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518351}
-
Jose Dapena Paz authored
Avoid duplication of the g_type_init call and reuse the guard to call it only one time from AXPlatformNodeAuraLinux initialization. Bug: 784583 Change-Id: I4ef553f8f123f3c76a6610c7c94ac1e2e3363a47 Reviewed-on: https://chromium-review.googlesource.com/781760 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
This triggered a DCHECK in the OpenTypeVerticalData code since the fallback font did not have a HHEA table. It couldn't have, since the fallback font for the PUA U+F6DB codepoint was a Type1 font which was not filtered out correctly in the per-character fallback code path. Test: NoType1InFallbackFonts in font_fallback_linux_unittest.cc Bug: 785517 Change-Id: I79f0811625adb5dbc77fdd62db08d0be68606857 Reviewed-on: https://chromium-review.googlesource.com/781864Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#518349}
-
Kenneth Russell authored
When needed, during reallocation of a depth-stencil renderbuffer, create a new object and point all existing framebuffer objects to it. Apply this workaround on NVIDIA GPUs on macOS 10.13 and later. This works around an apparent bug in the graphics driver introduced in this release. This is a slight expansion of the earlier multisample_renderbuffer_resize_emulation workaround. Remove associated failure expectations. Also update the bug ID in the conformance expectations for a workaround applying to the same platform. BUG=775202, 786717, 784817 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I051009b17df1cb5dabe1b00fbdcc35008042eee9 Reviewed-on: https://chromium-review.googlesource.com/780211Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518348}
-
Elly Fong-Jones authored
Right now, this text is redundant with the infobar, although it will need to be re-added when this dialog is redesigned without the infobar. Worse, it is inaccurate in the "clear on exit" case of the Blocked panel. Bug: 610428, 787375 Change-Id: I653ff6790f1b141a71007df38c09f8e917fcfa6b Reviewed-on: https://chromium-review.googlesource.com/782661 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#518347}
-
xdai authored
- The recent destinations list number is bounded by print_preview.AppState.NUM_DESTINATIONS_. - The Recent destinations list will be ordered from the most to the least recent selected. This is a followup CL of https://chromium-review.googlesource.com/c/chromium/src/+/775578. See proposed change: https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0 Bug: 779591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1ea6d1af71199e7346335dcb20a02d698f1d8d0 Reviewed-on: https://chromium-review.googlesource.com/777703Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#518346}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cac381990140..0a3adc0b0ad8 $ git log cac381990..0a3adc0b0 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 update-skps Update SKP version 2017-11-21 brianosman Remove SkV8Example 2017-11-21 brianosman Remove expectations kruft from experimental 2017-11-21 brianosman Remove more iOS sample code 2017-11-21 brianosman Remove clutter from experimental Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I7c28d609895f3af1127685b2d2ac001a59c0a4ec Reviewed-on: https://chromium-review.googlesource.com/782381Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518345}
-
Jamie Madill authored
Bug: 786044 Change-Id: I289799d50bbca3adb8ed50f7fb7141ed600a910a Reviewed-on: https://chromium-review.googlesource.com/782405Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#518344}
-
Wez authored
As the first step to merging ScopedPlatformHandle into PlatformHandle to have a single, always-managed container for platform handles, we: - Replace ScopedPlatformHandleVectorPtr and PlatformHandleVector with vector<ScopedPlatformHandle>. - Replace PlatformHandle with ScopedPlatformHandle in some core APIs. - Use const& to pass handles to APIs without passing ownership, for both individual platform handles, and vectors. Bug: 753541 Change-Id: Id965dcf3770ef11bf36f78277fa7199ea779599e Reviewed-on: https://chromium-review.googlesource.com/742309Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#518343}
-
Peter Lee authored
This reverts commit 445feb54. Reason for revert: This will break on iOS 11.2 beta. Original change's description: > Calls decisionsHandler asynchronously > > This change is a precursor to a more extensive change where > ExternalAppLauncher API is changed to be asynchronous. > > This simpler change is to call the decision handler in the implemention > of WKNavigateDelegate method > webView:decidePolicyForNavigationResponse:decisionHandler: > asynchronously on iOS 11 and up. > > iOS 10 (and possible below) has a bug where JavaScript on the page would > not execute if the decision handler is called asynchronously. > > This change is to make sure that there are no other unforeseen > issues with calling decision handler asynchronously on iOS 11. > > Bug: 774736 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I7a6dfe637cb6be4ce5c7efe5824728b8f06b902a > Reviewed-on: https://chromium-review.googlesource.com/773570 > Commit-Queue: Peter Lee <pkl@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517129} TBR=eugenebut@chromium.org,pkl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774736 Change-Id: I007149ee9ef15d4187a76d66f90bc52d21ff09aa Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/782682 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#518342}
-
Qiang Xu authored
changes: - Move Is{Set}MonoAudioEnabled code to ash, the mono audio pref prefs::kAccessibilityMonoAudioEnabled is already moved to ash. - Remove audio_a11y_controller proxy, using CrasAudioHandler instance directly. Bug: 594887 Test: tested on device with/without --mash, the feature is working fine Change-Id: Ie1803f9e6a783b7bbd76305d91c5f81dcf83f916 Reviewed-on: https://chromium-review.googlesource.com/768338Reviewed-by:Jenny Zhang <jennyz@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518341}
-
Dave Tapuska authored
In TouchSelectionControllerClientAuraScaleFactorTest InsertionHandleCoordinates test the device scale factor is set. However the test sends input before the screen info is retrieved which adjusted the coordinates on the input router. This change adds the initialization of the scale factor immediately after the InputRouter is created. BUG=722928 Change-Id: Id2e8590a239b05530afc960e35f7d67a0a1aff7d Reviewed-on: https://chromium-review.googlesource.com/779884Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#518340}
-
Eugene But authored
TBR=sdefresne@chromium.org Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifb036c069fd34f3b7b59e613e8b1d130eb74e918 Reviewed-on: https://chromium-review.googlesource.com/782800 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Jonathan authored
We enabled viz_content_browsertests on the linux fyi bot over the weekend, with no new flakes nor failures appearing. This enables them as a part of the main linux test package. TBR=sky@chromium.org TEST=viz_content_browsertests Bug: 760181 Change-Id: If86e8e551bf007124aea88073a3f57b51fff27a3 Reviewed-on: https://chromium-review.googlesource.com/779221Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#518338}
-
Mehran Mahmoudi authored
Fix the bug for Bar Banner caused when orientation was changed. Bug: 786513 Change-Id: Icc098fc3b22eaa1ecf7977e30bb9c7d8294472b1 Reviewed-on: https://chromium-review.googlesource.com/780859Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518337}
-
Matthew Jones authored
If the Chrome Home promo is open in both windows in multi-window mode, enabling the feature will not work. The cause of this is the second promo being dismissed and detecting that the state had changed because of the first (thus resetting the state). This change checks the enabled state of Chrome Home when the promo is shown. If the state changed before the promo is dismissed, the promo does nothing. BUG=787330 Change-Id: I31fe4471640cc38c269cc5aaf02d9b9fc4b7a33d Reviewed-on: https://chromium-review.googlesource.com/782707Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I6a91e5cdeb9bd9a585c782eea1a5bf767f44147f Reviewed-on: https://chromium-review.googlesource.com/782705Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#518335}
-
Daniel Bratell authored
By using x11.h instead of X11 system headers we prevent spreading some common macros named None, Status, True, False, ... in the global namespace. These macros forced various workarounds in innocent code and made jumbo builds harder. This moves a lot of X11 configuration and defines from ui/event headers into ui/gfx/x/x11.h to make sure no code has to manually include X11 headers. Bug: 782184 Change-Id: Iab069db82d71cd27df395afefa34a54c252b874d Reviewed-on: https://chromium-review.googlesource.com/779144 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#518334}
-
xdai authored
See https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0 for proposed change: - Combine Local Destinations and Google Cloud Destinations to Print Destinations - Click on the "Manage..." link will direct the user to Chrome Print settings page - Add one row "Printers" under the "Printing" section of Chrome settings page on operation systems other than Chrome OS. Click on the "Printers" item will open the System native print dialog. Bug: 779591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I686719924aa956074345236be73a6cd3af44b530 Reviewed-on: https://chromium-review.googlesource.com/775578Reviewed-by:
-
Stefan Zager authored
We only need to convert to root layer content coordinates if we're calling into RootFrameViewport. BUG=711468 Change-Id: Iff2632078950350d00b3c1cee8741a9190fc07d6 Reviewed-on: https://chromium-review.googlesource.com/780201Reviewed-by:
-
Vaclav Brozek authored
If a CSV file contains a record with an invalid URL (such as ":") in the 'url' column, such record should be skipped. Bug: 786937 Change-Id: I59a6d85fd6ed099332b09d960784ad22190b94e3 Reviewed-on: https://chromium-review.googlesource.com/781919Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518331}
-
Jared Saul authored
Bug: Change-Id: I8df2791c1cd985023b3281d0a5179beb2328ecfb Reviewed-on: https://chromium-review.googlesource.com/780361 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518330}
-
Daniel Cheng authored
Bug: 786386 Change-Id: I28d5809389aa86ee274b17725ca5312d4b8bb3ae Reviewed-on: https://chromium-review.googlesource.com/776411 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#518329}
-
Rouslan Solomakhin authored
Before this patch, if payment method manifest for https://alicepay.xyz/webpay prohibits payment handler https://bobpay.xyz/app, Chrome would print: "Payment handlers from https://bobpay.xyz are not allowed to use payment method https://alicepay.xyz/webpay." in terminal (sometimes even twice). Web developers rarely look at the terminal, however. Even if someone found these messages in the terminal, they would be confused by the message terseness and why it's printed twice. This patch makes the message more descriptive and prints it in the developer tools console, if possible. In addition, the patch ensures that the message is printed exactly once per PaymentRequest instantiation. To enable access to the developer tools console, the ManifestVerifier now takes WebContents as the first parameter instead of the BrowserContext that was used before. After this patch, if payment method manifest for https://alicepay.xyz/webpay prohibits payment handler https://bobpay.xyz.app, Chrome would print the following message in developer tools console: "The payment handler https://bobpay.xyz/app is not allowed to use payment method https://alicepay.xyz/webpay, because the payment handler origin https://bobpay.xyz is different from the payment method origin https://alicepay.xyz and the "supported_origins" field in the payment method manifest for https://alicepay.xyz/webpay is not "*" and is not a list that includes https://bobpay.xyz." This behavior can be tested on: https://rsolomakhin.github.io/pr/apps/alice/ Bonus: Not instantiating a GURL from non-UTF8 strings, which have been known to cause GURL constructor crashes in fuzz tests. Bug: 787054 Change-Id: I113270173cbc6c89bf81b58f36a46da4d7adf6ec Reviewed-on: https://chromium-review.googlesource.com/779662Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518328}
-
Leszek Swirski authored
Seperate the logs for missing cache handlers when there is no ScriptResource, and ScriptResources with null cache handlers. Bug: chromium:769203 Change-Id: I7abc1f5330ca2666b9ed67ddf1b54947598c23ca Reviewed-on: https://chromium-review.googlesource.com/778544Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#518327}
-
Daniel Cheng authored
Change-Id: I0e98ec9ad1b886509f791dcb19a727a0e6f14bd2 Reviewed-on: https://chromium-review.googlesource.com/776316Reviewed-by:
-
