- 08 Mar, 2018 40 commits
-
-
Charles Harrison authored
This experiment ended a while ago, removing unused code and metrics Bug: 704117 Change-Id: I1149ef5efedf9e989fe957e4d7884a1296c64bc9 Reviewed-on: https://chromium-review.googlesource.com/955781Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541907}
-
Yuqian Li authored
Bug: chromium:817110 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2ccbca1f9ddc2f1073fd0532eb06fd335b98f0a Reviewed-on: https://chromium-review.googlesource.com/956034Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#541906}
-
Ken Rockot authored
Expose request body data to WebRequest listeners when Network Service is enabled. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I21d4a1baabd4f842a9af6a7442b070c4932b1b44 Reviewed-on: https://chromium-review.googlesource.com/954002 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541905}
-
Finnur Thorarinsson authored
This allows the user to manually opt into using Windows native notifications instead of Chrome's version of the notifications. Note: This flag is ignored on versions of Windows old enough not to support native notifications. Bug: 734095, 516147 Change-Id: Ic5475e6fa13e29207a5d417efc996f16fdf997db Reviewed-on: https://chromium-review.googlesource.com/955244 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#541904}
-
Eugene But authored
The crash happens because contextForPendingNavigationWithURL returns null navigation context and receiving code expected a valid context object. Navigation context only exists for main frame navigations and will be null for iframes. This CL updates the code to avoid dereferencing context pointer for iframe navigations. Bug: 801161 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd530f56ad1efc10a6f498118d63895c74b04b07 Reviewed-on: https://chromium-review.googlesource.com/953178Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#541903}
-
Hongchan Choi authored
Bug: 820110 Change-Id: I6402e7f40405a4c3a8cfa55a1aacedc3b7920912 Reviewed-on: https://chromium-review.googlesource.com/956095Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541902}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ib77b7a86351151cdb109fe86bbff291b1519f6c9 Reviewed-on: https://chromium-review.googlesource.com/953082 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#541901}
-
Donn Denman authored
This reverts commit 3364152a. Reason for revert: Broke the Android ARM64 builder (https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/28515) for some unknown reason. Original change's description: > [TTS] reland mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org > > Original CL: > > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-on: https://chromium-review.googlesource.com/952679 > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#541569} > Change-Id: I4da1704fe17fae6fe06d8a6167fbf9bc75a01303 > Reviewed-on: https://chromium-review.googlesource.com/956086 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541879} TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org,dcheng@chromium Change-Id: Ib49a16a10903e0b2ba52cf0e32e4f1883888b7b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754862 Reviewed-on: https://chromium-review.googlesource.com/956356Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541900}
-
Theresa authored
And fix up NTP tests. BUG=803095 Change-Id: I0b757c79ba6f0fe1b8a06cd7d4eaa700297b30ed Reviewed-on: https://chromium-review.googlesource.com/949090Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541899}
-
Mustafa Emre Acer authored
This tool scans for any screenshots (png only) associated with grd files and uploads them to Google Cloud Storage using upload_to_google_storage.py. upload_to_google_storage.py is a tool that maintains content addressed files. It stores files with their sha1 hashes as filenames. The storage bucket name used in the tool is tentative. For details, see the design doc at http://go/chrome-translation-screenshots#heading=h.cyt0azox2105 Change-Id: Ide06aa679489a65887df9c58948c8adde12d3eba Bug: 814901 Reviewed-on: https://chromium-review.googlesource.com/922686 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#541898}
-
https://pdfium.googlesource.com/pdfium.git/+log/507fb4ed09d5..a724cb2df9f7 $ git log 507fb4ed0..a724cb2df --date=short --no-merges --format='%ad %ae %s' 2018-03-08 hnakashima Move GetPopupPos from CFWL_Widget to subclasses that call it. 2018-03-08 dsinclair Remove unused constructor 2018-03-08 dsinclair Cleanup CPDF_SimpleParser 2018-03-08 dsinclair CPDF_InterForm::ResetForm always returns true Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idc5571d6124b9bee5b698abfd1a82c9f7117daaf Reviewed-on: https://chromium-review.googlesource.com/955898 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541897}
-
erikchen authored
The concept of "working set" is specific to the Windows memory model. * Windows-only files were modified to directly invoke the Windows API. * os_metrics_linux.cc was modified to use RSS instead [which is what they really wanted]. * Two iOS files were incorrectly using GetWorkingSetSize() to return a task's "resident_size" as a rough measurement for total memory usage. This is inaccurate, since it includes reusable memory [used extensively by libMalloc for freeing objects]. This CL changes those two files to directly invoke the relevant mach APIs, and to subtract out reusable memory. * Remoting was using GetWorkingSetSize on all platforms, but the concept is only well defined on Windows. * MemoryCoordinator was calling GetWorkingSetSize from dead code. The dead code was removed. Bug: 819289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I720e18ab483a9995982762cbd5ae1d045adfaa74 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/953723 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541896}
-
Dave Tapuska authored
The bulk of this change is to revert commit 0b15dad9. It isn't a direct revert due to a number of things. - The ScopedComPtr interface that was widely used in the old patch no longer exists. - A number of interfaces change slightly (ImeTextSpans) - unsigned/signed compiler warnings This code was abandoned a few years ago and removed from the repository because it only worked in the Windows 8 Metro Mode of Chrome. Once that mode was removed the supporting IME code was removed as well. The code in its current form is functional but has issues which will be addressed in follow up patches. It is desirable to move to TSF since there are additional APIs that work via this API. Like text writing. Functionality common to both input methods are placed in InputMethodWinBase. InputMethodWin will be renamed to InputMethodWinImm32 in a followup patch. This feature is currently disabled but can be enabled via --enable-features=TSFImeSupport. No functionality changes are expected with the Imm32 implementation. Inputing text using Pinyin seems to work; as well as disabling DLL injection (crbug.com/557798) allows the IME to work correctly with TSF. There is some broken support with this change in that keydown/up messages, arrow keys in the omnibox are not delivered. I intend to fix these in followup changes being that this change is intended to make a previously reverted change available under a command line flag. BUG=657623 Change-Id: I89eb1a7ba6b9f95525df6fa83be5d923a03323b2 Reviewed-on: https://chromium-review.googlesource.com/916534 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541895}
-
https://chromium.googlesource.com/angle/angle.git/+log/5242d5bf74d3..19fa1c6f8852 $ git log 5242d5bf7..19fa1c6f8 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 jmadill Return an Error from Framebuffer::syncState. 2018-03-08 jmadill Vulkan: Use RenderTargetCache in FramebufferVk. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I00a6a1214c19650755b302ce9c307ccc8302a886 Reviewed-on: https://chromium-review.googlesource.com/955900 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541894}
-
Wenzhao Zang authored
Bug: 819135 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I239dab7a7ee1c9394f73e2dc51b411ed7c708305 Reviewed-on: https://chromium-review.googlesource.com/954331Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541893}
-
Peter K. Lee authored
Final step 5 of cleaning up the provider API for MailtoHandlerProvider. Bug: 813821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie454be3b22237a493f943869287b283e1bfe5227 Reviewed-on: https://chromium-review.googlesource.com/956237Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541892}
-
Scott Violet authored
This updates device, extensions and one new one in components. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=dcheng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8f935cf88795b11a57728da10e830ffd88ce4885 Reviewed-on: https://chromium-review.googlesource.com/956006 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
As fix attempt to the test flakes has been landed in crrev.com/c/946848, this patch re-enables the test to see if the fix works. Bug: 814845 Change-Id: I2a9e0d98a172fc0cac7c0e87cc302acab04dc325 Reviewed-on: https://chromium-review.googlesource.com/942470Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#541890}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6009cbd. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13486 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=robertma No-Export: true Change-Id: I033e56672564886214422c5a25725ef3e0254b5b Reviewed-on: https://chromium-review.googlesource.com/956024 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541889}
-
Rob Buis authored
Fix errorprone NarrowingCompoundAssignment warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/NarrowingCompoundAssignment Bug: 801268 Change-Id: Ief55318e789176288962359566d708af51c7c890 Reviewed-on: https://chromium-review.googlesource.com/953181Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#541888}
-
Michael Spang authored
Crash dumps contain sensitive data. Bug: b/74372631 Test: kill -SEGV cast_shell and check for successful upload Change-Id: I2c3877477bd652708838124ae43d1e24766e8edf Reviewed-on: https://chromium-review.googlesource.com/955342 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541887}
-
Qiang Xu authored
changes: Enable the feature by default. Also fix the bug that window cannot be moved. display::CreateDisplayIdList is sorting using the first 8 bits, pass that comparator to std::upper_bound too. TBR=stevenjb@chromium.org Bug: 778438 Test: tested on device. Change-Id: Ic8b9df780f99f0466805f8857e2cb0414a163999 Reviewed-on: https://chromium-review.googlesource.com/954361 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541886}
-
Sebastien Marchand authored
This scripts lives in depot_tools. Bug: 759146 Change-Id: I3877d3b53ef2f91b34cebb61b04e6f285a006ae7 Reviewed-on: https://chromium-review.googlesource.com/911428 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#541885}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: Id129cea8341c14bd8da4b5374034423223f03859 Reviewed-on: https://chromium-review.googlesource.com/884063 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#541884}
-
Hongchan Choi authored
We missed this line when we add the tail processing change. Let's add it back in. Bug: 731518 Change-Id: Id90cade41f311309ef60f049094478de0ad4c19e Reviewed-on: https://chromium-review.googlesource.com/956318Reviewed-by:
-
Charles Harrison authored
This should speed up the wall time of these browser tests significantly h/t to jkarlin for discovering this issue. Bug: 819721 Change-Id: I5368234cd3ea729eb262af22233df496e1368c4b Reviewed-on: https://chromium-review.googlesource.com/953803Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541882}
-
Avi Drissman authored
BUG=714018 Change-Id: Ic6fa05a2ebd6ca21bd1b2a349a58f7a419a3465d Reviewed-on: https://chromium-review.googlesource.com/952991Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
-
Benjamin Pastene authored
Bug: 817779 Change-Id: I42fc05273e682c82b280b0cad051a129c2dd892b Reviewed-on: https://chromium-review.googlesource.com/954705 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
-
Donn Denman authored
Replaces the whole call chain for ShowUnhandledTapUIIfNeeded between Blink and Chrome/WebView with Mojo messaging. Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo that sends a Mojo construct of the same name to the Browser which has a service installed via a RenderHostFrame observer. All functionality should remain unchanged. NEW CODE: The CSTabHelper now creates an UnhandledTapWebContentsObserver that connects the Mojo service via UnhandledTapNotifierImpl. That Impl calls back through Java to the CSTabHelper to the CSManager to notify that a Tap has occurred. The CSTabHelper ignores these notifications when CS is disabled. The mojo message is only sent to the browser if the tap is unhandled and the other required conditions are met. UPDATED TESTS: Test notification is now done through mojo messaging, so we now only know if the tap was unhandled, not whether the page changed or other details about why the tap was unhandled. Updated the test page by adding nodes that do not trigger, and removed the mousemove handler since it's unrelated to tap handling. BUG=754862 TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org Original CL: Reviewed-on: https://chromium-review.googlesource.com/841544Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/952679 Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541569} Change-Id: I4da1704fe17fae6fe06d8a6167fbf9bc75a01303 Reviewed-on: https://chromium-review.googlesource.com/956086Reviewed-by:
-
Oleh Prypin authored
This should fix the builder. And there's no good reason to build all if chromium.webrtc doesn't. Bug: chromium:820041 TBR: machenbach@chromium.org No-Try: True Change-Id: Id581397d0c1821dd17a0b76df540128ad71028ab Reviewed-on: https://chromium-review.googlesource.com/955683 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#541878}
-
Steven Bennetts authored
Bug: 244951 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2dd6d733dff382548f1dc6e558ff5ae9973a209c Reviewed-on: https://chromium-review.googlesource.com/952957 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#541877}
-
Adam Langley authored
The second phase of the post-quantum latency experiment involves sending and receiving dummy data. We will deploy some number of public servers that will echo the padding extension and this change adds latency measurements for those cases. Since the latency of servers that support echoing the extension will be different from the latency of all TLS servers, we cannot use the existing, general latency histogram for this and our control group will send a 1-byte extension rather than no extension at all. Bug: 801302 Change-Id: I017324047f66f0889df247b6581670f44e9e5fb5 Reviewed-on: https://chromium-review.googlesource.com/954329Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541876}
-
Koji Ishii authored
Another round of the rebaseline from the bot result after CL:956162 and CL:956202 were landed. This series of rebaselines are probably from CL:933805 that rounds glyph positions when not sub-pixel positioning. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I13c41951f35129915a6eb939d965c10aa13be963 Reviewed-on: https://chromium-review.googlesource.com/954646 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541875}
-
Nico Weber authored
Bug: 792131, 728324 Change-Id: I3b2ebe4a2073b6a03193dac5c497dbd3c53fc06d Reviewed-on: https://chromium-review.googlesource.com/955726Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541874}
-
Roman Sorokin authored
Not used anymore. BUG=chromium:469980 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5837d0b26dfac93e6de456be2625877da24eb69 Reviewed-on: https://chromium-review.googlesource.com/951222Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541873}
-
Nico Weber authored
The C++ standard doesn't allow implicit conversion of function pointers (such as returned by GetProcAddress()) to void*. MSVC does accept that, and so does clang-cl (albeit with a warning). To fix the warning, just make LoadComBaseFunction() return FARPROC. Bug: 550065 Change-Id: I95eeed86c31d45358aabc31414435ae79a1a0e5c Reviewed-on: https://chromium-review.googlesource.com/955905Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541872}
-
Peter K. Lee authored
BUG=808113 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idba2b2dd7777db94281a766030edfa5ed3bef801 Reviewed-on: https://chromium-review.googlesource.com/954057Reviewed-by:
-
Geoff Lang authored
BUG=811828 BUG=811794 BUG=811791 BUG=811823 BUG=811871 BUG=811830 BUG=812108 BUG=811867 BUG=811817 BUG=811800 BUG=811826 BUG=811833 BUG=811805 BUG=811824 BUG=811793 BUG=811868 BUG=811783 BUG=811818 BUG=811788 BUG=811784 Change-Id: I29ae4adcb3bb63dbe58e8a3de0c5fbb80a356978 Reviewed-on: https://chromium-review.googlesource.com/953087Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541870}
-
Shimi Zhang authored
The original CL is http://crrev/c/923021, we split ClassRegister out from that CL. This is the rest part. Since Chrome uses SurfaceView for compositing, we will get nothing from the ContentView passed to |SelectionPopupController| in |HandleObserver|. In this CL, we are passing SurfaceView to HandleObserver from |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. We set a flag to |SelectionPopupController| to let it know whether we need to use SurfaceView. Bug: 805531 Change-Id: I2c732231dd161a92d73b29be7f1ab546140eb41b Reviewed-on: https://chromium-review.googlesource.com/953172Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#541869}
-
Sebastien Marchand authored
This reverts commit 69feeeb9 , as well as commit 182f8382 ("Fix 2 access violation in resource_coordinator.") There's also a few minor fixes to fix the presubmits: - tab_manager_delegate_chromeos.cc:144 : Bind -> BindOnce - tab_manager.cc: prepend the crbug urls with https:// - Fix a few minor revert conflicts caused by ddf2a4e4: - tab_manager.h: conflict in the "FRIEND_TEST_ALL_PREFIXES" declarations. - tab_manager_browsertest.cc: Conflict in the anonymous namespace at the top of the file. TBR: thestig@chromium.org Bug: 818454, 819973, 820065 Change-Id: I7c6307859d565769d239ef43c30fb50e5a797467 Reviewed-on: https://chromium-review.googlesource.com/955923 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#541868}
-
