- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..bd6bd346f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0f0e22dad88b80efa4a08878525aceb411330e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842519}
-
Elizabeth Popova authored
Using AutofillClock::Now was thought to be the cause of the flakiness of the credit card related tests and was replaced with base::Time::Now in [1]. However, the tests are still flaky, so this CL returns using AutofillClock::Now, which allows having deterministic clock in tests. [1]https://chromium-review.googlesource.com/c/chromium/src/+/2428986 Bug: 1108232 Change-Id: I052bb17926eda5537b7223f4d6c2c08432e3c215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613032Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#842518}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610431066-5d7d40ce59ba8e505b376b46e02fe57205cb3e46.profdata to chrome-mac-master-1610452567-9a68a195870106cae6c4ac4841f20ff7b185cdf9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I780ce3e3654500a92eec47ac109b47b2cafbb911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622607Reviewed-by:
-
Stephan Hartmann authored
|pending_messages_| is std::vector of std::pair values. libstdc++ does not allow to initialize std::pair with std::make_tuple(), use std::make_pair() instead. Bug: 957519 Change-Id: I822b379b34f2973c0ce9704b73370b1e2dc15a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621816Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#842516}
-
Adithya Srinivasan authored
Call console.log in an html file instead of calling it directly using evaluateInPage. Bug: 1165324 Change-Id: I3198139bd867b15f4f28724ded7d1767647b3197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622282 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842515}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610420273-f729673981a14d4f8cc70d6513013e1d16474c41.profdata to chrome-win32-master-1610441943-347418dd52d747baeeb402622c1d23998512f08e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia7e61bcbbc84df25e51301cc6e31b54f94b5471c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622599Reviewed-by:
-
Sergey Poromov authored
According to the latest UI strings, the notification message for paused/resumed by Data Leak Prevention screen captures should mention the application/website name. See: https://docs.google.com/document/d/1fqzX-QYidDKijMpPd8kaoFwg1zHAIGB7laD4tIBPzSk/edit Bug: 1150452, 1158743 Change-Id: I3482d47a42d12b5710aa647e8e3da09038558ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611258 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842513}
-
Yunke Zhou authored
Bug: 1151292 Change-Id: I104852ac093569248e1dc0ba5c04e728493f42d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623548Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#842512}
-
Nicolas Ouellet-Payeur authored
This patch only affects behavior when DestroyProfileOnBrowserClose enabled (it's disabled by default), and multiple profiles are open. Before this patch, starting a download and then closing the Profile cancels the download (if it's still in progress). The data is lost, and the download never completes. After this patch, Chrome waits for the download to complete, and *then* deletes the Profile object. This matches existing behavior (without DestroyProfileOnBrowserClose). App exit behavior is unchanged. Closing the last browser window asks the user for confirmation. Bug: 88586 Change-Id: I9abeff4e0c4f4fa5d45f2a757f7e7054a698cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613156 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842511}
-
Alice Wang authored
Remove the usage of setSignOutAllowedPreferenceValue when there is child account on device as child account is already handled with Profile.isChild() in AccountManagementFragment. Setting this pref here doesn't have any impact on code when there is child account. Bug: 1162231 Change-Id: I36fc4a30fbbd3ea05b260e2f2e714aa731f737bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617819Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842510}
-
Illia Klimov authored
ContentSettingsType::DEPRECATED_PLUGINS. TBR=engedy@chromium.org Bug: 1149878 Change-Id: I6d46920dd64f1e08f7565f4a6302a4732796b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613973 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842509}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bd6bd346f677..e3e59aac750e 2021-01-12 fmayer@google.com Merge "Remove fork mode." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibe9abdb668976cb64f09fd1978ecdc2494acb082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622600Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..bd6bd346f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I43c23cd6b5393d3b0b831e6f679ce3670b216dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624527Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610431066-b046cf295bac84ed9eefc440cb75a6df945c21fe.profdata to chrome-linux-master-1610452567-fdff272b709a6fb84edf0325fafb43e63f345a7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e7b632e128de451ca9828743c941b31d415761e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622605Reviewed-by:
-
Viktor Semeniuk authored
This change will be used by sync to match Compromised Credentials with PasswordForms when PasswordStore::InvokeAndNotifyAboutCompromisedPasswordsChange called. Bug: 1137775 Change-Id: I281bed54093f99f56b7ccdbddc263b07ee33dd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612973 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842505}
-
Tim van der Lippe authored
This test has been replaced by Karma tests in the DevTools repository. R=szuend@chromium.org Bug: 1050549 Change-Id: Ic257c7e74b5cdea66cac11f5231ec59a046d6063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621759 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Brian Salomon authored
This reverts commit d13a5081. Bug: skia:11019 Change-Id: I5a5fea66469037634c31e3c0710cd2b75915f6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596090 Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#842503}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72490734..2ce9752f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I71d6d2bfd0692e1dc88f5aff7fa8841201bf6bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842502}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1a3011cd912..469db8fabd5f 2021-01-12 rainhard@chromium.org Disable testPressEndAndHome on linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1165318 Tbr: sadrul@google.com Change-Id: I507eabd6da83e22b561277640efcdab39d6d683b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623832Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1165692 Change-Id: Ie4ae544d1814384af134080541a60a6778ccbc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623210 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842500}
-
Viktor Semeniuk authored
This change adds an API to retrieve the insecure credentials information for a specific password form primary key. Follow up patches will use this API to sync such information across devices. Bug: 1137775 Change-Id: I1c29809d53abdb0c501c00904dc506963b69beb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592996 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Autogenerated header portion: https://paste.googleplex.com/5925546069327872 Autogenerated cc file portion: https://paste.googleplex.com/5362596115906560 BUG=1113513 Change-Id: I237b6fe5744059296754d5dc93213c9b9d5ea83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616814Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842498}
-
Rune Lillesveen authored
Bug: 1146097 Change-Id: I73f285c2c8cc828ae11132ae3c57148670b30b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621813Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#842497}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. This is a follow up CL that allows usage of policy enforced update URL in chrome/browser/extensions/. Bug: b:175767492 Change-Id: Ib3904683fc3dcec0e4690e3c558a9346e859ae45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593101 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a60056fee789..7297ea89b095 2021-01-12 almuthanna@google.com Add E2E test for syntax highlighting test case 2021-01-12 janscheffler@chromium.org [JSDOC2TS]: Migrate web_audio If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic49458489c10dc62b2a8c4179bbf6b2c19934095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623830Reviewed-by:
-
Hiroki Nakagawa authored
Callers of GetPrerenderMode() don't have to know PrerenderMode. They just want to know if the render frame is used for prerendering (NoStatePrefetch). Therefore, this CL replaces GetPrerenderMode() calls with PrerenderHelper::IsPrerendering() for code simplification. Bug: 755921 Change-Id: Ibaf7ab7a2b1759a8f18d3a6488444f9edd832de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596285Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa6859ae9056..019ddccc581e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: Ib0262a202f935160db28fdadceed58319a347499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623831Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842493}
-
Hans Wennborg authored
The LLVM code keeps running into issues with the GCC version we've been using so far (5.3.0). Try a more recent version to hopefully get fewer problems. This was built on a Trusty machine, according to the recipe at https://bugs.chromium.org/p/chromium/issues/detail?id=929645#c9 Bug: 1164952 Change-Id: If5e015d011417bc5b9669829ceefae3266808e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622968 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842492}
-
Thomas Tellier authored
Bug: 1136092 Change-Id: Ibe736b6ad40c343c1a7b3d946328849916583a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601374Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#842491}
-
Ulan Degenbaev authored
They were marked as tentative because they were written before the spec. Now the spec is completed and the tests align with the spec. Bug: 1085129 Change-Id: Ieee736a0f54af97e6f0cf2d6bad3c0a7afec2738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620565 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842490}
-
Ian Kilpatrick authored
Bug: 1164135, 1164474 Change-Id: I8c74220ba1d613b3723c56a3c5960e2061f9d16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623675 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842489}
-
sauski authored
Extends the survey cooldown period to 180 days for both any survey, and any particular survey. Also moves the preference to be synced so that the survey cooldowns apply across synced user devices. Bug: 1110888 Change-Id: Ic04d18d9551b809ae4ee10fe7b174a1b60567a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599534 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#842488}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..bd6bd346f677 2021-01-12 skyostil@google.com Merge "tracing: Allow passing custom timestamp types into TRACE_EVENT" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id13b6c92fa67a4c8302b8e5e63ee4d6d749b9e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623032Reviewed-by:
-
Maksim Moskvitin authored
Significant part of components/invalidation was under syncer namespace, while other part was under invalidation namespace. This CL makes components/invalidation content consistently using invalidation namespace. This CL is a pure refactoring. Bug: 1031125 Change-Id: I37614c39c79b05cca457a2f8619d1f5bfdf1546d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617850Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#842486}
-
Rainhard Findling authored
This reverts commit db11bed9. Reason for revert: 1165728 Original change's description: > [Subresource Filter] Add content settings-based adjustment to WebLayer > > This CL incorporates Chrome's adjustment of subresource filter page > activation decisions based on content settings within WebLayer. To do > so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle > directly invoke the logic in question rather than having > ChromeSubresourceFilterClient do so. That change necessitates some > others, also made in this CL: > - WebLayer brings up ProfileInteractionManager. > - SubresourceFilterClient provides an accessor for > ProfileInteractionManager. > - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment > logic via a new Delegate interface rather than doing so via > SubresourceFilterClient. This interface is implemented by > ProfileInteractionManager in production while allowing for porting of > tests that provide custom (or nil) stub logic. > > We also add browsertests of this interaction in //weblayer. > > Note that this CL does not do any incorporation of the relevant *UI* > for content/site settings of ad blocking in WebLayer; that will be > followup work. > > This CL is a reland. The original CL was reverted as the introduced > tests were flaky. I have since debugged the source of the flake; the > fix is contained in the diff between PS1 and PS2. It turned out to be > a pre-existing problem in //weblayer's > subresource_filter_browsertest.cc that the new tests simply tickled: > I was holding the TestRulesetCreator in a local variable and sending > the temporary files that it creates to renderer processes, but it > destroys those temporary files when it is destroyed. D'oh! > > Bug: 1116095 > Change-Id: I25f5dca647761f652c9d5a2dfc41db1a4d7712b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622215 > Auto-Submit: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842429} TBR=blundell@chromium.org,csharrison@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic15653af6a972ec0f8e8e66d274bd99aeb8f6179 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621758Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842485}
-
Matthew Mourgos authored
This change implements the events added to the virtual keyboard private api. These events include onClipboardHistoryChanged and onClipboardItemUpdated. onClipboardHistoryChanged will notify api listeners whenever the list of items in the clipboard history has any changes. onClipboardItemUpdated will notify api listeners when an existing item in the clipboard history has changed, and will send the new data for that existing item. Bug: 1099318 Change-Id: If788cc2f168b14c43096a395ac9c1e1a03e0eed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595258 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842484}
-
Rune Lillesveen authored
Traverse child if we are updating container query dependent descendants even if the child is not affected. Bug: 1146097 Change-Id: I4beeee65b9c25469ef052abef75701f077f5cc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621757Reviewed-by:
-
Jack Franklin authored
https://crrev.com/c/2622193 removes Set#firstValue from the DevTools utils as it is not used in the codebase - this layout test is the only place to use it across Chromium, so I've rewritten it to inline the functionality. Bug: chromium:1050549 Change-Id: I86093d63aa9cf086fbc06092f8dcc4eb7c4b86f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623928 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842482}
-
Igor authored
The policy for device account is passed to Lacros through LacrosInitParams. The data is used by the new class, PolicyLoaderLacros. The implementationis based on prototype from https://chromium-review.googlesource.com/c/chromium/src/+/2353454 Bug: chromium:1114069 Test: Manual testing on the device Change-Id: Ifbd6c930ae4ce17ab85c808d8d7783e6c6fc7ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521121 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73995827981d..aa6859ae9056 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: Ib034281d18830581a2aeb7b659dec2338ac0e8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623829Reviewed-by:
-
