GitLab

Instead of logging full exception we log only message.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/889453006

Cr-Commit-Position: refs/heads/master@{#313735}

-[TabView drawRect:] was called repeatedly to unnecessarily update the glow
that is not changing or should not have changed.

1. Selected tabs don't have glow, so don't redraw on mouseMoved.

2. When dragging an unselected tab, the mouse point relative to the tab view
does not change, so no need to redraw the glow.

3. When a dragged unselected tab slides behind another tab, let the dragged tab
keep the glow instead of the tab in front of it (this is a behavior change).
I think this is the more correct behavior, and we never have to redraw tabs
while dragging.

BUG=452925

Review URL: https://codereview.chromium.org/882193003

Cr-Commit-Position: refs/heads/master@{#313734}

When removing copy requests from a LayerImpl to fulfill the request,
this changes the RenderSurfaceLayerList that CalculateDrawProperties
would output. In particular, the layer would no longer keep itself as a
render target.

Since we fail to do this, the layer becomes !HasCopyRequest(), but keeps
itself as a target in the RenderSurfaceLayerList. Then when we go to
draw again (due to an animation or the like?) we skip appending the
layer's RenderPass since the subtree is hidden, but the layer is still
in the RenderSurfaceLayerList because we didn't recompute draw properties
and the layer copy request was keeping the hidden layer in the list.

This cognitive dissonance causes us to use a null RenderPass as
the target_render_pass in CalculateRenderPasses, which causes a crash as
soon as the (hidden) layer tries to append quads to the null surface.

R=vmpstr, weiliangc@chromium.org
BUG=439649

Review URL: https://codereview.chromium.org/883123003

Cr-Commit-Position: refs/heads/master@{#313733}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7f8106..e9d57a2

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/891473003

Cr-Commit-Position: refs/heads/master@{#313732}

Move the "is popup showing" logic to the platform-agnostic
ExtensionActionViewController. This lets us:
- Have a slimmer platform delegate.
- Implement OnPopupShown/Closed pressed-state logic on mac.
- Add cross-platform popup browsertests.

BUG=429810
BUG=422381

TBR=sky@chromium.org (micro changes to page_action_image_view)

Review URL: https://codereview.chromium.org/869873008

Cr-Commit-Position: refs/heads/master@{#313731}

Since the toolbar frame now includes the proper padding,
icons are a little too eager to show after adjusting the
chevron.  Make them a bit more shy again (hide them if they
have >= 3px not displayed when adjusting the toolbar).

BUG=452475

Review URL: https://codereview.chromium.org/881573004

Cr-Commit-Position: refs/heads/master@{#313730}

Update HTMLViewer for de-clienting of Shell.

Update ServiceRegistryTest.java for de-clienting of MathCalculator.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/883843002

Cr-Commit-Position: refs/heads/master@{#313729}

This removes CrMallocErrorBreak, since in 64-bit mode, Libc's malloc already
makes this case fatal.

BUG=453141
R=mark@chromium.org

Review URL: https://codereview.chromium.org/889583003

Cr-Commit-Position: refs/heads/master@{#313728}

BUG=433787

Review URL: https://codereview.chromium.org/869073003

Cr-Commit-Position: refs/heads/master@{#313727}

Chrome OS needs a dependency on //components/onc

BUG=453451
TEST=compiles
NOTRY=true

Review URL: https://codereview.chromium.org/880393004

Cr-Commit-Position: refs/heads/master@{#313726}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/402448d..5d8388b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890533003

Cr-Commit-Position: refs/heads/master@{#313725}

Cache extension action icons so that they don't have to be
reloaded each time a new view is created (i.e., each time a
new browser or the new overflow menu is opened).

BUG=452958

Review URL: https://codereview.chromium.org/885443004

Cr-Commit-Position: refs/heads/master@{#313724}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce78944..c7f8106

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/885893002

Cr-Commit-Position: refs/heads/master@{#313723}

https://codereview.chromium.org/845663002

BUG=446216

Committed: https://crrev.com/217066c608ea473d2ac70e737c69ff11a0425d44
Cr-Commit-Position: refs/heads/master@{#313248}

Review URL: https://codereview.chromium.org/854203003

Cr-Commit-Position: refs/heads/master@{#313722}

BUG=

Review URL: https://codereview.chromium.org/880373003

Cr-Commit-Position: refs/heads/master@{#313721}

The initial addition to content/browser was needlessly broad.

Review URL: https://codereview.chromium.org/869873006

Cr-Commit-Position: refs/heads/master@{#313720}

R=henrika@chromium.org
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/884873005

Cr-Commit-Position: refs/heads/master@{#313719}

WebRTC 8176:8207
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..1a48d11

Libjingle 8174:8202
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43

This rolls in a revert of a breaking change in Chromium.

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/880553005

Cr-Commit-Position: refs/heads/master@{#313718}

Update the DeviceStatusCollector to no longer report network state. We will
re-enable this for M42 once we've added code to detect an auto-launched kiosk
session.

BUG=452968

Review URL: https://codereview.chromium.org/885853002

Cr-Commit-Position: refs/heads/master@{#313717}

R=asvitkine@chromium.org, vogelheim@chromium.org
BUG=chromium:399580

Review URL: https://codereview.chromium.org/886463009

Cr-Commit-Position: refs/heads/master@{#313716}

This is required for further refactoring (use in symbolize.py), as nm
doesn't provide the section name.

Also, some functions in symbol_extractor.py are not
used yet, they will in the next CLs of the refactoring.

BUG=452879

Review URL: https://codereview.chromium.org/886563002

Cr-Commit-Position: refs/heads/master@{#313715}

Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202 (patchset #2 id:20001 of https://codereview.chromium.org/885003003/)

Reason for revert:
Appears to have broken Mac browser tests:

 - WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams
 - WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs

[75316:29699:0129/074049:FATAL:overuse_frame_detector.cc(388)] Check failed: processing_thread_.CalledOnValidThread().
0   libbase.dylib                       0x0000000119eaf88f base::debug::StackTrace::StackTrace() + 47
1   libbase.dylib                       0x0000000119eaf8e3 base::debug::StackTrace::StackTrace() + 35
2   libbase.dylib                       0x0000000119f09076 logging::LogMessage::~LogMessage() + 70
3   libbase.dylib                       0x0000000119f080c3 logging::LogMessage::~LogMessage() + 35
4   libcontent.dylib                    0x000000012ce82cd5 webrtc::OveruseFrameDetector::TimeUntilNextProcess() + 245
5   libcontent.dylib                    0x000000012c8dfdfd webrtc::ProcessThreadImpl::Process() + 525
6   libcontent.dylib                    0x000000012c8df836 webrtc::ProcessThreadImpl::Run(void*) + 38
7   libcontent.dylib                    0x000000012c6ce390 webrtc::ThreadPosix::Run() + 288
8   libcontent.dylib                    0x000000012c6ce076 webrtc::StartThread(void*) + 38
9   libsystem_pthread.dylib             0x00007fff8fe5f899 _pthread_body + 138
10  libsystem_pthread.dylib             0x00007fff8fe5f72a _pthread_struct_init + 0
11  libsystem_pthread.dylib             0x00007fff8fe63fc9 thread_start + 13

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/2438

Original issue's description:
> Roll WebRTC 8176:8203, Libjingle 8174:8202
>
> WebRTC 8176:8203
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261
>
> Libjingle 8174:8202
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43
>
> TBR=kjellander@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8aa707b5aa26cead2ab4791672163337c92f904b

TBR=kjellander@chromium.org,tommi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/888593002

Cr-Commit-Position: refs/heads/master@{#313714}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9cc2f26..402448d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890563002

Cr-Commit-Position: refs/heads/master@{#313713}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/15e603d..ce78944

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/887663003

Cr-Commit-Position: refs/heads/master@{#313712}

Fixes indentation bug in test runner and switches from using os to
subprocesses.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/884403002

Cr-Commit-Position: refs/heads/master@{#313711}

This is fixing of crashes in libsecret when some of fields from keyring result are absent.

BUG=453218

Review URL: https://codereview.chromium.org/891463002

Cr-Commit-Position: refs/heads/master@{#313710}

If the profile is NULL, the code will hit the CHECK on line 389 anyway.

BUG=414332

Review URL: https://codereview.chromium.org/878143003

Cr-Commit-Position: refs/heads/master@{#313709}

This cl reland Queue commands to the Os to start a video device, originally reviewed in https://codereview.chromium.org/801363002. (patchset 1)
In patchset 2, the issue found in crbug/450382 related to patchset(1) is addressed. |Device| is made into a class and thread checks are added.

BUG=428891,450382,450226

Review URL: https://codereview.chromium.org/862063002

Cr-Commit-Position: refs/heads/master@{#313708}

Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.

Re-land with syntax errors fixed.

BUG=453020
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/875353003

Cr-Commit-Position: refs/heads/master@{#313707}

CookieMonster::AnyEquivalentCookie asserts that there are no multiple
cookies that are identical to each other. That is achieved by inserting / deleting
cookies carefully, but it goes wrong with WebSocket schemes.

CookieMonster::DoCookieTaskForURL for given URL loads cookies when
cookies for key = cookie_util::GeteEffectiveDomain(scheme, host) is not
yet loaded. When the task ends, it stores loaded cookies and marks the key as
loaded. cookie_util::GetEffectiveDomain consults
egistry_controlled_domains::GetDomainAndRegistry
when http or https schemes are given, whereas it doesn't when ws or wss
schemes are given.
Imagine we are about to load stored cookies for ws://www.example.com/
and http://www.example.com/. As written above, they have different keys:
www.example.com and example.com. So each of them is loaded and it breaks
the assertion.

BUG=370021
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/859663003

Cr-Commit-Position: refs/heads/master@{#313706}

WebRTC 8176:8203
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261

Libjingle 8174:8202
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/885003003

Cr-Commit-Position: refs/heads/master@{#313705}

BUG=none
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/865453003

Cr-Commit-Position: refs/heads/master@{#313704}

BUG=None
TEST=components_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/877423002

Cr-Commit-Position: refs/heads/master@{#313703}

* Fix the implementation of has_single_url() method.
It is incorrect to check is_valid() because the elements
vector can contain more than 1 item. And thus the
is_valid() check does not make sense, since it just check
if the vector is not empty, not that it just contains one element.

* Use is_valid() method when possible.
* Use has_single_url() method when it makes sense.
* Use data.size() to avoid a temp variable.

BUG=None
TEST=chrome still links and works as before, existing unit tests in components_unittests.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/870293002

Cr-Commit-Position: refs/heads/master@{#313702}

BUG=426316
TEST=manual

Review URL: https://codereview.chromium.org/882353002

Cr-Commit-Position: refs/heads/master@{#313701}

BUG=451959
TEST=manual

Review URL: https://codereview.chromium.org/878913003

Cr-Commit-Position: refs/heads/master@{#313700}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e5e7f1..15e603d

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/882393002

Cr-Commit-Position: refs/heads/master@{#313699}

Cr-Commit-Position: refs/heads/master@{#313698}

Revert of Don't refcount tracking id -> slot id mapping. (patchset #6 id:120001 of https://codereview.chromium.org/785753002/)

Reason for revert:
Reverting due to memory failures.

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/5041/steps/memory%20test%3A%20content/logs/stdio

{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
content.dll!content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent
content.dll!content::TouchEventQueue::FilterBeforeForwarding
content.dll!content::TouchEventQueue::TryForwardNextEventToRenderer
content.dll!content::TouchEventQueue::ProcessTouchAck
content.dll!content::InputRouterImpl::ProcessInputEventAck
content.dll!content::InputRouterImpl::OnInputEventAck
content.dll!InputHostMsg_HandleInputEvent_ACK::Dispatch<>
content.dll!content::InputRouterImpl::OnMessageReceived
content.dll!content::RenderWidgetHostImpl::OnMessageReceived
*!content::RenderWidgetHostViewAuraTest_TouchEventState_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/40143/steps/memory%20test%3A%20content/logs/stdio

UninitCondition
Conditional jump or move depends on uninitialised value(s)
  content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:240)
  content::TouchEventQueue::FilterBeforeForwarding(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:715)
  content::TouchEventQueue::TryForwardNextEventToRenderer() (content/browser/renderer_host/input/touch_event_queue.cc:445)
  content::TouchEventQueue::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/touch_event_queue.cc:436)
  content::InputRouterImpl::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/input_router_impl.cc:666)
  content::InputRouterImpl::ProcessInputEventAck(blink::WebInputEvent::Type, content::InputEventAckState, ui::LatencyInfo const&, content::InputRouterImpl::AckSource) (content/browser/renderer_host/input/input_router_impl.cc:576)
  content::InputRouterImpl::OnInputEventAck(InputHostMsg_HandleInputEvent_ACK_Params const&) (content/browser/renderer_host/input/input_router_impl.cc:483)
  _Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE (base/tuple.h:246)
Suppression (error hash=#675E7177BFE2BE12#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:_ZN7content15TouchEventQueue23TouchMoveSlopSuppressor11FilterEventERKN5blink13WebTouchEventE
   fun:_ZN7content15TouchEventQueue22FilterBeforeForwardingERKN5blink13WebTouchEventE
   fun:_ZN7content15TouchEventQueue29TryForwardNextEventToRendererEv
   fun:_ZN7content15TouchEventQueue15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
   fun:_ZN7content15InputRouterImpl15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
   fun:_ZN7content15InputRouterImpl20ProcessInputEventAckEN5blink13WebInputEvent4TypeENS_18InputEventAckStateERKN2ui11LatencyInfoENS0_9AckSourceE
   fun:_ZN7content15InputRouterImpl15OnInputEventAckERK40InputHostMsg_HandleInputEvent_ACK_Params
   fun:_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE
}

I haven't been able to reproduce this consistently locally, which is making it tricky to pin down. Once I have (or I've determined this patch isn't what's causing the failures), I'll reland.

Original issue's description:
> Don't refcount tracking id -> slot id mapping.
>
> Previously we tried to refcount the tracking id to slot id mapping.
> This broke in some circumstances where the number of press events was
> not equal to the number of release events.
>
> This patch switches to marking some touch events such that they don't
> modify the mapping, simplifying logic, and fixing a nasty bug.
>
> BUG=439051
> TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping
>
> Committed: https://crrev.com/47a823b565a4051e58d83a857738c0fb8417d9ac
> Cr-Commit-Position: refs/heads/master@{#313520}

TBR=sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439051

Review URL: https://codereview.chromium.org/869433007

Cr-Commit-Position: refs/heads/master@{#313697}

Without it the overhead of serialized ios simulator run is too big.

BUG=426870
R=sky@chromium.org, smut@google.com

Review URL: https://codereview.chromium.org/886463003

Cr-Commit-Position: refs/heads/master@{#313696}