GitLab

BUG=463459

Review URL: https://codereview.chromium.org/973813002

Cr-Commit-Position: refs/heads/master@{#318882}

TBR=machenbach

BUG=463436

Review URL: https://codereview.chromium.org/973063002

Cr-Commit-Position: refs/heads/master@{#318881}

Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/969053002/)

Reason for revert:
Speculative revert for issue 463436.

Original issue's description:
> Update V8 to version 4.3.15.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/32e6c72188d6b0b948d668afdc1cb209d44c2e70
> Cr-Commit-Position: refs/heads/master@{#318755}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/975713002

Cr-Commit-Position: refs/heads/master@{#318880}

Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/974813002/)

Reason for revert:
Speculative revert for issue 463436.

Original issue's description:
> Update V8 to version 4.3.16.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=machenbach@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/5d61006f40e3f14bbf8f2c60f698b051f8f84fd9
> Cr-Commit-Position: refs/heads/master@{#318874}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/978433002

Cr-Commit-Position: refs/heads/master@{#318879}

BUG=461604,435358
TEST=manual

Review URL: https://codereview.chromium.org/969403002

Cr-Commit-Position: refs/heads/master@{#318878}

BUG=None

Review URL: https://codereview.chromium.org/969353005

Cr-Commit-Position: refs/heads/master@{#318877}

We adjusted the leaderd dbus API to pass back an ObjectPath instead of
a string. Adjust the chromium bindings to match that.

BUG=453872

Review URL: https://codereview.chromium.org/972983003

Cr-Commit-Position: refs/heads/master@{#318876}

Component build was broken since 4a84927b, where
chromeos::device_event_log was moved  to components.

TBR=reillyg@chromium.org,derat@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/971363002

Cr-Commit-Position: refs/heads/master@{#318875}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/974813002

Cr-Commit-Position: refs/heads/master@{#318874}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu/+log/df1bf38..db16fd8

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/972953002

Cr-Commit-Position: refs/heads/master@{#318873}

This cl reverts back to the behaviour prior to https://codereview.chromium.org/795703003/. Ie, the security origin of the ancestors of a requesting iframe does not have to match in order to allow or deny a request.

BUG=448378, 456628

Review URL: https://codereview.chromium.org/969773002

Cr-Commit-Position: refs/heads/master@{#318872}

BUG=none

Review URL: https://codereview.chromium.org/968073004

Cr-Commit-Position: refs/heads/master@{#318871}

Revert of Fix crash in SimpleGeolocationProvider. (patchset #1 id:1 of https://codereview.chromium.org/973003002/)

Reason for revert:
This broke chromeos_unittests (see crbug.com/463499)

Original issue's description:
> Fix crash in SimpleGeolocationProvider.
>
> BUG=463150
> TEST=manual
>
> Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7
> Cr-Commit-Position: refs/heads/master@{#318866}

TBR=nkostylev@chromium.org,alemate@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463150

Review URL: https://codereview.chromium.org/974883002

Cr-Commit-Position: refs/heads/master@{#318870}

It is necessary because gles2_conform_supports depends on it and will
port it later.

Tested on Linux with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn gles2_implementation_no_check

BUG=None
TEST=see above
R=jbauman@chromium.org,dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/969603002

Cr-Commit-Position: refs/heads/master@{#318869}

BUG=463456
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/973793003

Cr-Commit-Position: refs/heads/master@{#318868}

Cr-Commit-Position: refs/heads/master@{#318867}

BUG=463150
TEST=manual

Review URL: https://codereview.chromium.org/973003002

Cr-Commit-Position: refs/heads/master@{#318866}

BUG=462483
NOTRY=true
TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/974833002

Cr-Commit-Position: refs/heads/master@{#318865}

This CL upstreams a small fork in ShouldShowAlwaysTranslateShortcut on
iOS, which is caused by a different UX on this platform.

Review URL: https://codereview.chromium.org/972123002

Cr-Commit-Position: refs/heads/master@{#318864}

This patch updates the dynamic lookup of NSS symbols to use
dlsym(RTLD_DEFAULT) instead of dlsym on the dlopen(NULL) handle.

The latter doesn't work if the binary that does the dynamic lookup was
loaded dynamically itself (as dlopen(NULL) gives access only to the
symbols loaded at the start of the program).

Note that RTLD_DEFAULT requires setting _GNU_SOURCE.

BUG=462203

Review URL: https://codereview.chromium.org/962593002

Cr-Commit-Position: refs/heads/master@{#318863}

Revert of Propagate audible state from player to the containing tab (patchset #16 id:310001 of https://codereview.chromium.org/896673003/)

Reason for revert:
This (Android only) change breaks the downstream Android test CastSwitchVideoTest#testNewVideoNewPageSameTab.

Reverting as Android Sheriff.

BUG=463445

Original issue's description:
> Propagate audible state from player to the containing tab.
>
> This is part 1 (chromium),
> part 2 (clank) is https://chrome-internal-review.googlesource.com/#/c/195455/
>
> This CL is only about propagation/plumbing.
> Neither the reporting of audible state my players nor the consumption
> (UI notification) are implemented.
>
> This patch creates a new object AudioMonitorAndroid and
> attaches it to MediaWebContentsObserver. The AudioMonitorAndroid
> maintains the audible state for the tab. It receives notifications
> from MediaPlayerAndroid objects and sends the resulting
> notification to the WebContents.
>
> BUG=414810
>
> Committed: https://crrev.com/6ad356d3e845ed9b67c5fb799b2ee8290f317268
> Cr-Commit-Position: refs/heads/master@{#318823}

TBR=qinmin@chromium.org,sievers@chromium.org,tedchoc@chromium.org,aurimas@chromium.org,timav@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=414810

Review URL: https://codereview.chromium.org/972973002

Cr-Commit-Position: refs/heads/master@{#318862}

Revert of Handle unpatched VS xtree header (patchset #3 id:40001 of https://codereview.chromium.org/965713002/)

Reason for revert:
This broke Win 8 GN builders:

ERROR at //build/config/compiler/BUILD.gn:804:30: Assignment had no effect.
        msvs_xtree_patched = true

Original issue's description:
> Handle unpatched VS xtree header
>
> BUG=
>
> Committed: https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b
> Cr-Commit-Position: refs/heads/master@{#318859}

TBR=brettw@chromium.org,tmoniuszko@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/972133002

Cr-Commit-Position: refs/heads/master@{#318861}

MidiManagerMacTest.MidiNotification was marked in
valgrind/gtest_exclude/media_unittests.gtest_mac.txt.

Remove the entry with some speculative fixes.
Since the problem can not be reproduced with the latest
valgrind on Yosemite.

If this patch is not enough, let's suppress it again.

BUG=462483
TEST=media_unittests --gtest_filter=MidiManagerMacTest.MidiNotification
TEST=valgrind media_unittests --gtest_filter=MidiManagerMacTest.MidiNotification  # does not hangup on yosemite

Review URL: https://codereview.chromium.org/971593002

Cr-Commit-Position: refs/heads/master@{#318860}

BUG=

Review URL: https://codereview.chromium.org/965713002

Cr-Commit-Position: refs/heads/master@{#318859}

Revert of gpu: introduce glCopySubTextureCHROMIUM (patchset #4 id:80001 of https://codereview.chromium.org/864513004/)

Reason for revert:
This broke telemetry_unittests and content_browsertests on Mac (see issue 463439)

Original issue's description:
> gpu: introduce glCopySubTextureCHROMIUM
>
> Introduce glCopySubTextureCHROMIUM to support immutable texture as well as to
> optimize WebGL texSubImage2D(video | canvas).
>
> This CL changes gl_renderer to use glCopySubTextureCHROMIUM because the
> destination texture is immutable.
>
> TEST=GLCopyTextureCHROMIUMTest
> BUG=443151
>
> Committed: https://crrev.com/fac6a2d44323ad51429ee728e241fe22242f5ebd
> Cr-Commit-Position: refs/heads/master@{#318855}

TBR=sievers@chromium.org,piman@chromium.org,kbr@chromium.org,zmo@chromium.org,scherkus@chromium.org,dongseong.hwang@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=443151

Review URL: https://codereview.chromium.org/972833004

Cr-Commit-Position: refs/heads/master@{#318858}

A recent CL caused a crash due to undefined order of evaluating arguments in
C++. An invalid pointer was causing a crash on G++ builds only.

TEST=Tested manually on a Chromebook.
BUG=462999

Review URL: https://codereview.chromium.org/977493002

Cr-Commit-Position: refs/heads/master@{#318857}

BUG=459462
TEST=check that ESC cancels selections on list/grid view, and that pressing ESC while renaming doesn't cancel selection.

Review URL: https://codereview.chromium.org/970103002

Cr-Commit-Position: refs/heads/master@{#318856}

Introduce glCopySubTextureCHROMIUM to support immutable texture as well as to
optimize WebGL texSubImage2D(video | canvas).

This CL changes gl_renderer to use glCopySubTextureCHROMIUM because the
destination texture is immutable.

TEST=GLCopyTextureCHROMIUMTest
BUG=443151

Review URL: https://codereview.chromium.org/864513004

Cr-Commit-Position: refs/heads/master@{#318855}

Cr-Commit-Position: refs/heads/master@{#318854}

BUG=458915
TEST=Select 2000 photos by Ctrl+A and check that UI responds in less than 500ms.

Review URL: https://codereview.chromium.org/973483002

Cr-Commit-Position: refs/heads/master@{#318853}

BUG=461888

Review URL: https://codereview.chromium.org/957123002

Cr-Commit-Position: refs/heads/master@{#318852}

This patch:
1) groups all tools for the audio and video quality tests per platform.
2) adds ffmpeg and zxing to the private tool bucket for all platforms.
3) updates the tests to the new tool locations.

This must land at the same time as a webrtc.DEPS CL which makes the
download step --recursive and --auto_platform for the private tool
bucket.

Left to fix:
1) The AQ test is still dependent on installed sox on mac/linux.

BUG=440387

Review URL: https://codereview.chromium.org/965403003

Cr-Commit-Position: refs/heads/master@{#318851}

This requires a few changes to how we evaluate pages during the saving process.

1) Instead of ignoring forms where there are more than 3 password fields, assume that those fields are not related to actual passwords. Also change the case of 3 passwords to assume that if the first and second password match, that the third is not related. I don't have statistics on this, but I have seen security questions that are entered into password fields much more often than I have seen a new password entered before and old password (which was the previous assumption).

2) Move change password detection to work on the submitted password form instead of the observed form. The submitted form is more likely to be identified correctly because we have additional data after submission. This failed on Macy's because we incorrectly assume that, given the number of password fields, one of them is a current password field during parsing.

3) Don't require HTML field attributes to match for signup forms. This is normally required because otherwise we can't fill the password we have just saved. However in the case of signup forms this doesn't matter because we don't want to fill on the same form again anyway.

BUG=452306, 451631

Review URL: https://codereview.chromium.org/944163003

Cr-Commit-Position: refs/heads/master@{#318850}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/115b8ac..b2c2289

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/972103002

Cr-Commit-Position: refs/heads/master@{#318849}

BUG=461668
TEST=manually checked

Review URL: https://codereview.chromium.org/967513003

Cr-Commit-Position: refs/heads/master@{#318848}

This CL adds the same handling with https://codereview.chromium.org/937343002

BUG=461694
TEST=check the repro steps manually

Review URL: https://codereview.chromium.org/969763002

Cr-Commit-Position: refs/heads/master@{#318847}

CL generated with data from dead-code analysis using
.../scythe:remove_dead_code #codehealth

Merge internal change: 87564533
https://codereview.chromium.org/973683003/

Change QUIC's PrrSender::TimeUntilSend to accept bytes instead of
packets.  No functional change.

Merge internal change: 87535917
https://codereview.chromium.org/972033002/

Discard acks from QUIC's UnackedPacketMap when the map is larger than
one half of its max size(2500).  Was previously 200.

Merge internal change: 87419283
https://codereview.chromium.org/977453002/

Remove TCP and BBR's max congestion window.  No practical change,
because Chrome's receive window is the limiting factor.

Adds kMaxReportedCwnd and kMaxReorderingForRtt as constants to replace
the max CWND in classes that used to rely on max CWND.

Merge internal change: 87346681
https://codereview.chromium.org/968923005/

Minor simplification to QuicSentPacketManager::PendingRetransmission.
No functional change.

Merge internal change: 87254408
https://codereview.chromium.org/969153002/

Log the QUIC SRBF (socket receive buffer size) as an int instead of
hex value.

Merge internal change: 87247898
https://codereview.chromium.org/974593002/

Minimally test a few things to keep them from Scythe. test-only change.

Merge internal change: 87171236
https://codereview.chromium.org/971493003/

Deprecate FLAGS_quic_limit_time_wait_list_size.

Merge internal change: 87059868
https://codereview.chromium.org/968323002/

CL generated with data from dead-code analysis using
.../scythe:remove_dead_code #codehealth

Merge internal change: 86999211
https://codereview.chromium.org/974563002/

Remove unused ability to disable flow control in QUIC

QuicFlowController::Disable() is no longer called. It was used when we
disabled flow control for the headers and crypto streams, and for old
versions which did not support connection level flow control. Now that
we are on QUIC_VERSION_23, we now use flow control on all streams and
all connections, so this is safe to remove.

Thanks to tgreer@ for the scythe code removal in cl/86835556, and
alyssar@ for noticing that the removal of the dead
QuicFlowController:Disable() meant we could remove substantially more in
this CL.

Merge internal change: 86960342
https://codereview.chromium.org/969053004/

Remove unnecessary virtual CreateQuicConnection method.

Merge internal change: 86947282
https://codereview.chromium.org/972783002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/968233004

Cr-Commit-Position: refs/heads/master@{#318846}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3094822..115b8ac

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/974763002

Cr-Commit-Position: refs/heads/master@{#318845}

This handles the case where
SearchResultTileItemView::SetSearchResult(SearchResult*) may be called
from a nested run loop while its context menu is showing. This cancels
the menu (it's for the old item).

BUG=462470
TEST=Right-click on a start page app to get its context menu. On another
machine (with the same profile), uninstall the app. Context menu should
disappear. Chrome shouldn't crash.

Review URL: https://codereview.chromium.org/969953002

Cr-Commit-Position: refs/heads/master@{#318844}

https://codereview.chromium.org/965943002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/971863002

Cr-Commit-Position: refs/heads/master@{#318843}