- 07 Nov, 2019 40 commits
-
-
John Rummell authored
QueryOutputProtectionStatus() should report that a MediaRecorder is capturing audio/video streams. This adds a test that sets up a MediaRecorder using getDisplayMedia() to provide the stream, and verifies that the query does detect it. ClearKey CDM updated to periodically query for changes, and if a network link is detected, generate a keystatuseschange event with a dummy key ID and status 'output-restricted'. Bug: 856276 Test: new browser_test passes Change-Id: I3f9f200dded6647ec9526d929b962b3ccfae1d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894356 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713670}
-
Vladimir Levin authored
A recent change for intrinsic-size forgot to update the enums.xml file. (crrev.com/ae891958) This patch updates said file. R=chrishtr@chromium.org Change-Id: I332d69cfdf1974e709bf6c9d3c14a998c51c38f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904498 Auto-Submit: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713669}
-
Matt Menke authored
Somehow managed not to delete it in when I removed it from net/BUILD.gn in https://chromium-review.googlesource.com/c/chromium/src/+/1869725. Bug: 934009 Change-Id: I1a85d090064e472e04d9f7d9767d6f5399a767b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903830Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713668}
-
Ionel Popescu authored
This CL removes the rounded corners and padding for select options to avoid exposing the underneath background of the select. The new behavior is validated by select-popup-appearance-basic.html and by new tests added in select-multiple-appearance-basic.html Bug: 1021227 Change-Id: I6e6c45fc6627187f18511e0409ca0e20e07e1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902525 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#713667}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/27a3d31d7a9d..d9ed1c2732ba git log 27a3d31d7a9d..d9ed1c2732ba --date=short --no-merges --format='%ad %ae %s' 2019-11-07 sugoi@google.com Prevent rasterizing fragments outside the framebuffer Created with: gclient setdep -r src/third_party/swiftshader@d9ed1c2732ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141999739 Change-Id: I281ee29a1bb2124be08fba5ad65fe00923530a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713666}
-
Hongchan Choi authored
As suggested in: https://chromium-review.googlesource.com/c/chromium/src/+/1903756 TBR=sky@chromium.org Bug: 1022319 Change-Id: I31474c0f0242ca5177ef2bfca9b2415c6448f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904543Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713665}
-
Chris Blume authored
SurfaceAggregator's call to AddColorConversionPass() currently happens on all platforms. But it should be a no-op on every platform except Windows. On other platforms, there is a proper gamma curve. But on Windows it is linear. This results in color values that are outside an acceptable threshold. That is why a color conversion is necessary. The intent was for this to only happen on Windows. This CL matches that intent by explicitly marking that function call as only happening on Windows. Change-Id: I66ebf3b42b84729e6062ff738c25d903aac2dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900286Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#713664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c5d494..29e8c96f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifab465b945682f6272f0f3f0ac38bb56a450cc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904668Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713663}
-
Takumi Fujimoto authored
Fix histogram names that got swapped around during a refactoring. Change-Id: I8f680a9c0ae28ab287656fea1981f26bd338f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904540 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713662}
-
Michael Crouse authored
This change allows the folder that an optimization guide store uses to persist its data on disk in. A future change will create a store with a folder for only the prediction model and host model feature data to be held. Bug: 1001194 Change-Id: I0f03fea562a69eb8ddc4ea3f7e69ee2f1a999162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904612Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#713661}
-
Donn Denman authored
Adds side-shadow assets to the Overlay in the new layout that already has rounded corners. These assets just add a shadow, so there are no dark versions needed, and we just have one side (using code to flip it for the other side). Binary-Size: +2K for the side shadow assets. BUG=1005975 Change-Id: I31ebf657b2e9f49822c5aeb525b655c91d9b81aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895924 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#713660}
-
Christopher Cameron authored
This is now in a good enough shape to turn on. The remaining work is to add tracking to ensure that we open the most-recently-used profile on launch. Bug: 982024 Change-Id: Ib6b922a1ebca043a6c8f8eb2ded2cd3c837cc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902866 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713659}
-
Jinsong Fan authored
Since ContentVideoView has been removed for a long time, kUseContentVideoView is no longer used. The CL removes it and related codes, replaces the switch::kUseAndroidOverlay by the switch::kOverlayFullscreenVideo everywhere. Bug: None Change-Id: I95e9d6ec33fd8027914770cd5224163018fd6399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890510Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#713658}
-
Rob Schonberger authored
This CL adds a featureparam for experimental updates of radius polynomial - and adds a parser for the string value. The parser is tested both via the factory and as a standalone - which is why it's placed in a separated namespace rather than the natural anonymous namespace. Bug: 1009290 Change-Id: I8d9edcd9c8267f6d85026f79bd30dc22cacefbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903108Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713657}
-
Matt Menke authored
An earlier CL of mine made each run parse the input string twice, which slowed things down enough to make libfuzzer (which already runs each input through the fuzzer twice) sad. Bug: 1019151 Change-Id: Iee963f40c9bf30a24a77961be4cef8ca64b3c20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903964Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713656}
-
Sara Kato authored
Bug: 904383 Test: manual (follow repro steps on bug, and observe expected behaviour) Change-Id: Ia60c2ec1a0891ca4c42a5b1ff79aff17aad06fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903175Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#713655}
-
Mike Dougherty authored
Bug: 987646 Change-Id: Ibdb5b6b7393fbdc3593c498d52f4d595872a3647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903839Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713654}
-
George Zhang authored
Remove unsigned int typecasts. Bug: 1012072 Change-Id: I05a38c48f3c5415b209d89c396ed3a25545d88f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902566 Commit-Queue: George Zhang <zhanggeorge@google.com> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#713653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e10964bf967..a942a9f9a235 git log 4e10964bf967..a942a9f9a235 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 vapier@chromium.org patch: drop chromeos/cbuildbot/git/fetch_count metric Created with: gclient setdep -r src/third_party/chromite@a942a9f9a235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I945abc5926b4e4fb85143fb2fbe19713d67609d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713652}
-
Alexander Nohe authored
We changed the focus ring on eject button activation to be hidden. This ensures consistency with other button behavior within the files app. We swapped the original eject button (<button>) for a cr-button, a polymer element. This simplifies the eject button implementation by removing a nested HTMLElement since the ripple effect is contained within the polymer element (<cr-button>). Bug: 1006198 Change-Id: I5fc60a28db9bbd8166420fe50ef89bd88facdc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830218Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713651}
-
David Grogan authored
There was a blank space before each test name when copying plain text report. Before: ` css3/flexbox/flex-flow-auto-margins.html` ` external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html` Now: `css3/flexbox/flex-flow-auto-margins.html` `external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html` Change-Id: I4195af5f95347754bcfabefed04c9ce3cd387993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904351Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713650}
-
Khushal Sagar authored
GLHelper assumes that the texture used in readback with it is always GL_TEXTURE_2D which is not the case for resources creates for canvas2d elements on mac using GL_TEXTURE_RECTANGLE_ARB. R=ericrk@chromium.org, guidou@chromium.org Bug: 1020796 Change-Id: Ic5a4b8e0ba5a0d61a8af43251438f5323b911fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902506 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713649}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I41bf85b61e1cf79dfe9e048da8d1a13c96f0f144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903618 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713648}
-
Brandon Wylie authored
When both the search engine logo and the identity disc are enabled, the urlbar placeholder text is clipped. This change removes the end padding of the location bar to prevent that clipping. Bug: 1019019 Change-Id: Ie02ef36f784a13a06e978cd7b8210c7ffbd36ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885556 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#713647}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic027fcccdc59257500b38649fceb4d6f656f766e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713646}
-
Caroline Rising authored
This will also cause the extensions button to highlight while a bubble is anchored. Bug: 987312 Change-Id: Id2b3e831dcceeb5ac47b929078f51ac3ebaecf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904492Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#713645}
-
Jay Harris authored
This updates the FileHandling API to be more in line with the explainer: https://github.com/WICG/file-handling/blob/master/explainer.md#example This means that sites can attach their launch handler whenever they like, and are guaranteed to handle each launch. Functionally, this replaces window.launchParams with window.launchQueue. In order to access launchParams, sites must now provide a launch consumer, which will be invoked with launchParams as the site receives them. Old: console.log(window.launchParams.files); New: window .launchQueue .setConsumer(launchParams => console.log(launchParams.files)); Note: This feature is behind the NativeFileSystemAPI and FileHandlingAPI flags, so this change doesn't effect live web APIs. Bug: 829689 Change-Id: I461bc68eef44283c54bd237cae7b550e2e3b2909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875891Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#713644}
-
Raymond Toy authored
Since the baseLatency value is fixed after construction, compute the value when the AudioContext is constructed and cache the value so that any queries just return the value from the slot. Bug: 1005150 Change-Id: I0a4b8c4fb42deb5721f0ecdce5a8bc3b3c4cb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903750Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713643}
-
Hongchan Choi authored
See details: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFBhc3N3b3JkTWFuYWdlckJyb3dzZXJUZXN0LkZpbGxXaGVuRm9ybVdpdGhIaWRkZW5Vc2VybmFtZQw TBR=dvadym@chromium.org Bug: 1022531 Change-Id: I6886d88aa677c1791510babfeefe605fb2bedd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904547Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713642}
-
Scott Violet authored
BUG=1018148 TEST=none Change-Id: Icb07328be04799cd4d7c87d4f07b47976aa33982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904501Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713641}
-
Jacob DeWitt authored
It is no longer needed, now that WebVR is gone. Change-Id: I7bfca2156c06a447439c42b08673e5d422daf628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893526Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#713640}
-
Trent Apted authored
This allows client code to type-check JS with (e.g.) js_type_check("closure_compile") { closure_flags = default_closure_args + [ "jscomp_error=strictCheckTypes", "jscomp_error=reportUnknownTypes", ] ... } for picking up a wide class of type errors that otherwise slip through. Note the maintenance cost of actually _landing_ a rule with `reportUnknownTypes` is probably too high. The purpose of this CL is to at least allow developers to temporarily add reportUnknownTypes to validate their own type coverage accurately in a chrome developer checkout. Suppresses: ../../ui/webui/resources/js/assert.js:**: ERROR - [JSC_UNKNOWN_EXPR_TYPE] could not determine the type of this expression 20: if (!condition) { ^^^^^^^^^ 26: const global = function() { ^^^^^^^^^^^^ 27: const thisOrSelf = this || self; ^^^^ 29: thisOrSelf.traceAssertionsForTesting; ^^^^^^^^^^ 30: return thisOrSelf; ^^^^^^^^^^ 32: if (global.traceAssertionsForTesting) { ^^^^^^ 37: return condition; ^^^^^^^^^ Bug: 1000989 Change-Id: I73564b17688df1b08d2a2eb6f78177dcde39faa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902182Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#713639}
-
Collin Baker authored
Bug: 1009122 Change-Id: Ibb162f7a9766083be5cdd17f40f88d6a049eb351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904611Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713638}
-
Andrey Kosyakov authored
Bug: 1022173 Change-Id: Ifa07c62fda098ba0cbdf7f62f50cf9a98b29876a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902475 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#713637}
-
Sean Topping authored
Updates the ownership model of CastWebView so that users "borrow" the CastWebView, returning ownership to CastWebService when the user goes out of scope. Web page lifetime can be extended beyond the lifetime of the user, facilitating smooth transitions between pages (no intermediate black screen) and simplifying logic for extended shutdown. Merge-With: eureka-internal/313200 Bug: internal b/77879457 Bug: internal b/130320237 Test: Start multiple apps in sequence, verify successful transition with no crashes. Change-Id: Ic03217ed6d3abb8a74d012c9d6b11bd1a8d92c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895504 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#713636}
-
Aaron Colwell authored
Temporary fix that creates an exception for 'no access' URLs like chrome-native://history. These URLs can cause a origin mismatch in the commit code because of slight differences between how url::Origin and blink::SecurityOrigin handle 'no access' URLs. This is intended as a low risk change that can be easily merged to the M79 branch. Bug: 1016711, 923144 Change-Id: I8ab833744f45ebfbc489118313c59d7bbfdaff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900358 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713635}
-
Thomas Guilbert authored
This CL adds the plumbing necessary in WMPI to initiate and complete a requestAnimationFrame call. For the moment, WebMediaPlayerClient doesn't do anything with the frame returned, but this will be updated in upcoming CLs. Bug:1012063 Change-Id: I99c951bf0d6317bb81986166e57ec250d47dc1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900350 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#713634}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d41eaf0f6ae..f0d1100a7149 git log 5d41eaf0f6ae..f0d1100a7149 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 lalitm@google.com Merge "trace_processor: fix test failure and swap around counter <-> counter_values" Created with: gclient setdep -r src/third_party/perfetto@f0d1100a7149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic8f4cc210e52d8a7de8af66fc67f61bbde32e63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713633}
-
Xiyuan Xia authored
This reverts commit e6093e9b. Reason for revert: The CL causes memory corruptions on linux-trusty-rel and msan bots, which triggers crash in random places (mostly in cc::Animation::DetachElement somehow). See https://crbug.com/1021553 Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version adds protected memory support to handle calling ATK methods > dynamically on the CFI bot. > > Original change's description: > > Reland "Fix emission of AtkValue property change signal" > > > > This version checks at runtime for atk_value_set_value during testing. > > This should allow the change to work on bots running trusty. > > > > Original commit message: > > > > > The introduction of text-change signals for the omnibox included a > > > regression that prevented the emission of AtkValue property change > > > signals. Fix this error and also add an implementation of > > > atk_value_set_value. The implementation is used in a test to verify the > > > correct behavior. > > > > > > The fix is that we correct the misuse of a logical operator and now > > > always try to emit AtkValue property change events when receiving the > > > kValueChanged event in AXPlatformNodeAuraLinux. > > Bug: 1015387 > Bug: 1017177 > Bug: 1017548 > > Change-Id: Iadaea4569944ad0a1be0e1211bbce4ed2c4f6935 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879255 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#710699} TBR=mrobinson@igalia.com,tikuta@chromium.org,jdiggs@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015387, 1017177, 1017548, 1021553 Change-Id: Ie661eeb75dd42ddff34e2ff04623bf2b9af30cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904504Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713632}
-
Will Harris authored
BUG=1016906 Change-Id: I601f1c1cc3f23c5598d5bedf3b22ad6fbf810cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904306Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713631}
-