- 30 Jun, 2020 40 commits
-
-
Himanshu Jaju authored
Bug: 1082305 Change-Id: I0018ce068d2820befccf5e69c833725940690bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273141 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784018}
-
Daniele Castagna authored
crrev.com/c/2220482 used the in_fence in OnPresentation to fill ready_timestamp. We incorrectly assumed that OnPresentation is always called after the in_fence is signaled. When that was not the case, a DCHECK was triggered. This patch fixes that, restricting the assumption that the in_fence is signaled to only when the presentation feedback is valid. Bug: 1100376 Test: DCHECK doesn't trigger when the screen is off Change-Id: If038c1aefa6c0dc2f7d87c10648b1577ff85e4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274098 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#784017}
-
Roman Sorokin authored
This CL adds more comments to UserType enum to better describe individual values. Fixed: 1082681 Change-Id: Ief87757e45b1c353f9752b8b8d4af804bcbabde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212278Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784016}
-
dpapad authored
Use a Polymer binding to pass down |docLength| and |pageNo| instead of programmatically updating the toolbar. Also update the old <pdf-viewer-toolbar> to use the same mechanism, for simplifcity. Fixed: 1100432 Change-Id: Ifbd6b0230094bd7e82861ed2d00cf1271cc727ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274185Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#784015}
-
Javier Ernesto Flores Robles authored
Prefixing the data will stop a problem caused by two instances of Chrome sharing the same data in the app group. Move to standardUserDefaults what doesn't needs to be shared. Bug: 1090397, 1094282 Change-Id: Id34b4ba8c22b39bb7d35c5c9094f574be341ca58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275892Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784014}
-
Sammie Quon authored
Follow up to crrev.com/c/2258687. That was originally done in cros shelf code as it was intended to be merged. Test: manual Bug: 1100467 Change-Id: Ibe54a8a95dd2aaeff515c221fd13c349488d2bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274669Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#784013}
-
Richard Knoll authored
This adds various new folders for WebUI resources to the watchlist for Nearby Share. Bug: None Change-Id: I561866d6e3b190e2b7d3b1c8ac926562fae6b445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274507Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a72bd10ae637..162e2b2eb46e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC parastoog@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058102 Tbr: parastoog@google.com,drott@google.com Change-Id: I7e0f05cca1437e28a529f0027c12ebd09139302a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784011}
-
Guillaume Jenkins authored
Moves BrowserDMTokenStorage to components/enterprise so it can be reused on iOS. Unit tests will follow in a separate change to keep the CL from getting too big. Bug: 1091929 Change-Id: Id2f854b004d70d593bc28e735b478251d3aec7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267645Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#784010}
-
Nate Fischer authored
This is a mostly mechanical renaming CL to change AwSafeBrowsingWhitelistManager to AwSafeBrowsingAllowlistManager (and related methods). Notable exceptions: * We inherit some "whitelist" methods from //components/safe_browsing/ types. This does CL does not change that layer. * This leaves the old name for the API stubs for the setSafeBrowsingWhitelist() Android/AndroidX API for a follow-up CL, as these are more complex to change. * This prefers "allowed" over "allowlisted" because "allowed" is already a verb. Fixed: 1097242 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest.* Test: android_webview_unittests -f AwSafeBrowsingAllowlistManager.* Change-Id: I1d8568e0de4da6d02aba18128feb0eb749f319ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274364Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784009}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/62f7f26355fd..b5d9bdb51608 2020-06-30 fmayer@google.com Pass const parameter by reference. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I43ef03f6119f28950807261bdda9b277fb5aedd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784008}
-
Samuel Huang authored
SuperSize-archive should have only one main input file, and this restriction was enforced in crrev.com/c/2263012. However, the CL broke diagnose_bloat.py, which mixes --elf-file with -f. This CL fixes the above by having diagnose_bloat.py use --aux-elf-file to specify ELF (instead --elf-file) if the main input is APK. Bug: 1040645 Change-Id: I2055def74e5e39446e62f89fb26aa1e5e3ec9c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276391Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#784007}
-
Sylvain Defresne authored
Create new directories //build/apple, //build/config/apple and //build/toolchain/apple to hold templates, configs and scripts shared by Apple platforms (iOS and macOS). This will allow to isolate platform specific templates, configs and scripts in //build/{ios,mac}, //build/config/{ios,mac} and //build/toolchain/{ios,mac} eventually making easier to change one platform without breaking the other. Move tweak_info_plist.{py,gni} to //build/apple as a first step to ensure that it is possible to move files without breaking the projects based on //build (webrtc, ios_internal, ...). Bug: 635745 Change-Id: Ieb9df43fc638891f3975495f87a9612e22bc3c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270464Reviewed-by:Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784006}
-
Ce Chen authored
flags. Bug: 1100311 Change-Id: I4d9a57d1ed6c5cf7c6543c3cd744fa98199bec03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273020 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#784005}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95c250c24769..8f3a83671a13 2020-06-30 michaelludwig@google.com Write SkSL visitor pattern and consolidate sampling analysis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I48017f7c1c2e9efc9deabaac5f83edfd42cb7ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276159Reviewed-by:
-
Katie D authored
AX-Relnotes: n/a Bug: 1085442 Change-Id: I388d048e85d27dcaf665b47ec376dddcd60e6ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270694Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#784003}
-
Peter Kasting authored
Callers who want a floating-point value should just use the functions in std::. Some callers working with gfx:: types can use more suitable transform functions. Other callers were trying to round an integral value. Bug: 1088346 Change-Id: I30c25052e9d994ae5883b4ab17756fff183164ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273805Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#784002}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I20e0e0a70d70fee80ec9a602592f55b5d71fb50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275352Reviewed-by:
-
Christopher Cameron authored
This format is broken under ANGLE. Mark it as an invalid format so that it doesn't get partially-used as happened in r783187, resulting in its revert in r783644. Bug: 1100599, 1092155 Change-Id: I8833960bc4e39a9761bfc6b966d17015a67fdf6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274723Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#784000}
-
Gauthier Ambard authored
The test is flaky. TBR=edchin@chromium.org Bug: 1100293 Change-Id: I818a1c577a114c65fa30393c478e449eaafe08d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275898 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#783999}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b5792cc4a19..3cb0985983c1 2020-06-30 mbonadei@webrtc.org Inclusive language in //media/engine. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b8da32180245718b12a83c71964f81bbaec4427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276165Reviewed-by:
-
Ghazale Hosseinabadi authored
In this CL, we count the number of visible submenu items. If there is no visible submenu item, we do not display an empty submenu. Bug: 1037837 Change-Id: I2a59537f3a989526d4f994f0d07eaea3e209876a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225512 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783997}
-
Leonard Grey authored
For some reason, when we set the window's frame directly in the move loop, frame constraints don't trigger right away (as they do during a window server drag). Instead, the frame goes wherever we told it to, then constraints kick in, so the window flickers back and forth between the constrained and unconstrained position. Since the real fix (window server drag in the move loop) is a ways off, let's directly constrain inside the move loop. Bug: 1099600 Change-Id: If71392f90453da868a09ef9f52a4589f9db25c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276291Reviewed-by:
-
Mikel Astiz authored
Everything under components/sync/syncable is dead code and can be removed. This marks the end of the pre-USS implementation of Sync, deprecated for some time now, and not exercised since the last Sync datatypes were migrated to the new codepath (USS) around M80. Bug: 923287 Change-Id: Ifefffa4b9e0332dd7655f063921ce32e5a8ffacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270078Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783995}
-
Nohemi Fernandez authored
UIApplicationDidEnterBackground / WillEnterForeground notifications continue to be sent in the scene-based lifecycle when all scenes enter the background or the first scene will enter the foreground. This patch reuses the app lifecycle notifications rather than manually computing the equivalent based on the scene notifications. Bug: 1097787 Change-Id: I028ae3551dd0f06c9e716c3deb6c02972a78d035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273098Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#783994}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/bae16b4df9d7..91904cdfde76 2020-06-30 cwallez@chromium.org D3D12: Simplify the mapping logic. 2020-06-30 cwallez@chromium.org Add Buffer::Get[|Const]MappedRange 2020-06-30 cwallez@chromium.org Buffer: Always use MappedAtCreation state when applicable. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iac6e7a0dff0722c5862686ede59afe74e3784db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276166Reviewed-by:
-
Richard Knoll authored
This component renders an indefinite spinner with a device name below to indicate transfer progress. The indefinite state is shown when waiting for the user to accept or decline a transfer. Bug: 1099710 Change-Id: Ie48b20c7ce04b64e5710670e5d92699dbc6e34f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272837 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#783992}
-
Francois Beaufort authored
This CL makes sure track photo settings are updated after new constraints are set on Android with Camera2. This was not the case, causing track settings in image capture to never be updated. Bug: 1100246 Change-Id: Ia39f44ac86fb637d8020768226b866c2d442d012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270565Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#783991}
-
Parastoo Geranmayeh authored
This reverts commit 56bfd87f. Reason for revert: causing crbug/1100948 Original change's description: > [PTZ] Measure prevalence of cameras supporting PTZ > > This CL adds metrics for how many users have cameras with PTZ > capabilities. This metric is triggered only when a permission prompt > would show up. > > Bug: 990185 > Change-Id: Icba513c14977ef1249ed68788fc91d5059b1c0c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273237 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783901} TBR=beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org,alexilin@chromium.org Change-Id: I20ad67145572820ef146e8c4c91ac50c5e41e308 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990185, 1100948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276392Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#783990}
-
Xida Chen authored
This CL converts base::Bind to base::BindRepeating in the browsing_data/ folder. This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I422fc1b84eb1a7ce3c1d28d8b5c3107da44e5ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276173 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Tien Mai authored
Split cells that have large amounts of data into smaller sizes so that excel can open them properly. Change-Id: I7075549ff1fc92006d25a60a198e81a5eb4c795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275374 Auto-Submit: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL converts base::Closure to base::RepeatingClosure in the browsing_data/ folder, it is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Ia594d7290c1b0c1f4c113ea5180cb9b8991ea4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275483Reviewed-by:
-
Nate Chapin authored
When I moved the implementation of OutgoingReferrer() from Document to LocalDOMWindow in https://chromium-review.googlesource.com/c/chromium/src/+/2258426, I removed a GetFrame() null-check. https://chromium-review.googlesource.com/c/chromium/src/+/2258955 uncovered that this because in certain situations we will give FrameLoadRequest a LocalDOMWindow that has been detached. This appears to happen when a window schedules a FormSubmission (presumably targeted at a different window), then is detached before the FormSubmission executes asynchronously. I haven't been able to actually trigger this in a test, though. Bug: 1100002 Change-Id: I5231d8cd33e03736c0fd6bad9bd490347b9662b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273758 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783986}
-
Lijin Shen authored
Add render tests for the component PromoDialog. Bug: 1090103 Change-Id: I492d513b9959f28f5c54bc61ffbfd7e58af9e1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272130Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#783985}
-
Richard Knoll authored
This is a reland of 5563bea3 Reverted in crrev.com/c/2276045 for failing on the linux-blink-cors-rel bots. Fixed by adding 'network::features::kOutOfBlinkCors' to the enabled list in featureList(). Original change's description: > [Nearby] Add dummy nearby-confirmation-page component > > This component will contain a confirmation screen when sending to > strangers that are not in the local contacts. The component is empty > right now and will be populated in upcoming CLs. > > Bug: 1099710 > Change-Id: I37325d2d75e897a0a9f8be0e6930bf0fd4305f02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270323 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783903} Bug: 1099710 Change-Id: I9b4283f54ac773e84de41872a080e8c03d51cdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275877Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#783984}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Iee92db7009af23d04aaf06a54b2109485f28778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274093 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
This was previously a helper function so it didn't need a null-check, but now it's public, so we need to check that render_accessibility_ is still valid. During teardown it's possible that render_accessibility_ is null but the corresponding BrowserAccessibilityManager still exists and could try to call AccessibilityHitTest. Bug: 1096265 Change-Id: I353b449ec44ec3adc7cd60d4615148505c13efa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271106Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#783982}
-
Julie Jeongeun Kim authored
This CL adds AX mode configuration for AtkUtilAuraLinuxTest that needs to access ATK object since we don't create ATK object if the mode is not enabled. On build bots, it's not failed as it works with other tests in the same process and the configuration is based on a process. But if it runs individually, it's not passed. So, this CL adds the configuration to the test. AX-Relnotes: n/a. Bug: 1100797 Change-Id: I6def01fef97c3f8b00b4130197c321d3625ed313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274624 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
This reverts commit b7a33c21. Reason for revert: possibly causing crbug/1100914 Original change's description: > [WebLayer] Reuse Chrome's InfoBarWrapper.java > > This CL eliminates //weblayer's copy of chrome's InfoBarWrapper.java in > favor of directly using the latter now that it has been componentized. > There were no substantive changes introduced in //weblayer and no > behavioral changes. > > Bug: 1099169 > Change-Id: Ie9cc819f17ce30bb66085cb05040ce11696725ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270554 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783894} TBR=blundell@chromium.org,cduvall@chromium.org Change-Id: I5f0fbec56bae167ccfb54ca9d9fd4b5f3fdf25ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276312Reviewed-by:
-
Clark DuVall authored
A couple changes need to be made to support using the Mirror protocol in WebLayer: - a new "source" attribute is added to the header, which can identify if the request is coming from Chrome or WebLayer. - a force_account_consistency param is added to AppendOrRemoveMirrorRequestHeader, so we can make sure the header is added even when the gaia ID is not available. This is important because WebLayer may need to enable account consistency for signed out users. Bug: 1054160 Change-Id: I4f4306a77b360212561e03e7e813809075dc2b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274958 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#783979}
-
