GitLab

The NSMenu tag for the "Customize User..." menu item was always 0 before this patch.  Add a new selector to ProfileMenuController and use that for the menu item.

Also, move the code for determining the index of the active profile into the AvatarMenuModel.

BUG=99621
TEST=See bug


Review URL: http://codereview.chromium.org/8230011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107089 0039d316-1c4b-4281-b951-d872f2087c98

Splitted from http://codereview.chromium.org/8231004/

BUG=none
TEST=existing tests should pass

Review URL: http://codereview.chromium.org/8339012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107088 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds JavaBridgeDispatcherHostManager, which co-ordinates injecting
Java objects into all RenderViews corresponding to a TabContents. The class is
owned by TabContents and manages one instance of JavaBridgeDispatcherHost for
each RenderViewHost.

Also adds TabContentsObserver::RenderViewDeleted().

BUG=96703

Review URL: http://codereview.chromium.org/8366034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107085 0039d316-1c4b-4281-b951-d872f2087c98

Touched:
* contentSettings
* contextMenus/basic
* browserAction/set_icon_path
* app_launcher
* devtools/network/chrome-firephp
* extension/isAllowedAccess
* news_a11y
* notifications
* omnibox/extension-docs
* pageAction/pageaction_by_url

As a drive-by, fixed the broken `contentscript_xhr` by changing to Twitter's
new API endpoint

BUG=92644
TEST=

Review URL: http://codereview.chromium.org/8309001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107084 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22024
TEST=tests pass.
Review URL: http://codereview.chromium.org/8332016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22024
TEST=tests pass.
Review URL: http://codereview.chromium.org/8351021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96915
TEST=


Review URL: http://codereview.chromium.org/8118030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107079 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107075 - Disallow wildcards from matching top-level registry controlled domains during cert validation.

BUG=100442
TEST=net_unittests:X509CertificateNameVerifyTest.*


Review URL: http://codereview.chromium.org/8362023

TBR=rsleevi@chromium.org
Review URL: http://codereview.chromium.org/8381032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107078 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=jchaffraix

Review URL: http://codereview.chromium.org/8382029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100442
TEST=net_unittests:X509CertificateNameVerifyTest.*


Review URL: http://codereview.chromium.org/8362023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8351010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107074 0039d316-1c4b-4281-b951-d872f2087c98

It should be fixed by http://trac.webkit.org/changeset/98192.

BUG=100661
TEST=none

Review URL: http://codereview.chromium.org/8332022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101424
TEST=


Review URL: http://codereview.chromium.org/8375036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=manual test; chrome --register-pepper-plugins="$SRC/out/Debug/lib.target/libppapi_example.so;application/x-ppapi-example" file:///$SRC/ppapi/example/example.html


Review URL: http://codereview.chromium.org/8369028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107071 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/8275031

BUG=none
TEST=bots
Review URL: http://codereview.chromium.org/8362021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107070 0039d316-1c4b-4281-b951-d872f2087c98

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244

Review URL: http://codereview.chromium.org/8374023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107069 0039d316-1c4b-4281-b951-d872f2087c98

The FullscreenExitBubbleView class was used in a previous version of the UI, but has since been replaced.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8351022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107068 0039d316-1c4b-4281-b951-d872f2087c98

- Revert 106847 (according to rniwa, it breaks standalone webkit/chromium builds)
- roll clang 142072:142664

BUG=none
TEST=none
TBR=hans

Review URL: http://codereview.chromium.org/8370009

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8382027

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8380034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107066 0039d316-1c4b-4281-b951-d872f2087c98

Add the target to build peerconnection native in libjingle.gyp.



TEST=Unittests



Review URL: http://codereview.chromium.org/8374014



TBR=ronghuawu@google.com
Review URL: http://codereview.chromium.org/8375044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107065 0039d316-1c4b-4281-b951-d872f2087c98

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244

Review URL: http://codereview.chromium.org/8374025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107064 0039d316-1c4b-4281-b951-d872f2087c98

- Generate STATE_CHANGED notification in the Add method instead of
  in other places which call Add.
- Generate STATE_CHANGED notification in ClearAll and Remove methods.
- Hook up the bubble close button action with code that calls ClearAll.
Review URL: http://codereview.chromium.org/8382010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107063 0039d316-1c4b-4281-b951-d872f2087c98

The current user custom spell check dictionary is shared among profiles. This should be per profile.

BUG=None
TEST=SpellCheckProfileTest


Review URL: http://codereview.chromium.org/8345034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8382021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107061 0039d316-1c4b-4281-b951-d872f2087c98

Supposedly we are delay-loading user32 so this should work.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8371012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107060 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107058 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo, yurys
Review URL: http://codereview.chromium.org/8351026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107057 0039d316-1c4b-4281-b951-d872f2087c98

- roll clang 142072:142664

BUG=none
TEST=none
TBR=hans

Review URL: http://codereview.chromium.org/8370009

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8382027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107056 0039d316-1c4b-4281-b951-d872f2087c98

In this mode, we issue queries as the user types, but don't show the preview.
The name HIDDEN seems more appropriate here, so I've usurped that name for this
trial, renaming the earlier one to SILENT (since it doesn't speak the queries
over the wire).

BUG=none
TEST=interactive_ui_tests InstantFieldTrial*

Review URL: http://codereview.chromium.org/8370020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107053 0039d316-1c4b-4281-b951-d872f2087c98

This happens when a handler is registered, where there is already a handler
with the same origin and scheme already registered. These calls should go
through the the registry and update the registered handler, and now do.

This was broken recently however the unit tests did not catch the problem,
because the key logic was in browser.cc. That logic has been moved into the
registry and a test added.

BUG=99926
TEST=Unit test added.


Review URL: http://codereview.chromium.org/8371023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107052 0039d316-1c4b-4281-b951-d872f2087c98

I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8351025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100898
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8359029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107050 0039d316-1c4b-4281-b951-d872f2087c98

gypi magic needs right incantation

BUG=none
TEST= waterfall green, specially safe_browsing_tests and sync_unittests
Review URL: http://codereview.chromium.org/8351017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78283
TEST=


Review URL: http://codereview.chromium.org/8124024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8387012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107043 0039d316-1c4b-4281-b951-d872f2087c98

I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98

It would happen if CreateClientCertificateChain() returns NULL.
Found by the clang static analyzer. Probably doesn't happen in
practice.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8308009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107041 0039d316-1c4b-4281-b951-d872f2087c98

Activate IRT building on ARM for NaCl.

In order for this to be on for real, the PNaCl toolchain still needs to
available

Since NaCl is still turned off by default on ARM, this code should be a no-op
for all other cases.

This also moves the compilation a step forward for ARM. 

There is a bootstrap dependency on memset on ARM - so SYSROOT on the
ChromiumOS chroot is required to gain access to libc.

R=bradnelson,robertm
BUG=http://code.google.com/p/chromium/issues/detail?id=61695
BUG=http://code.google.com/p/chromium/issues/detail?id=38909
BUG=http://code.google.com/p/nativeclient/issues/detail?id=135


Review URL: http://codereview.chromium.org/8375035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107040 0039d316-1c4b-4281-b951-d872f2087c98

Make the bookmark manager consistently reset the hash when starting to edit (so that when editing is complete, a new edit operation can still be invoked on the same element).

Disable the console diagnostics on navigateTo (to be consistent with the other disabled diagnostics in this file).

Make WebUI bookmark editing work on Mac (Mac was invoking the native UI directly instead of going through the BookmarkEditor class which decides which UI to show).

Make 'Add page' pre-populate the bookmark entry with the title/url of the current page (as for the non-webui behavior).  Note that based on UX feedback, we probably don't want to use the bookmark manager in this case at all, so we'll probably add a new dialog for this.  But I already had this ready and it's a step closer (removes a= from bookmark manager, etc.) so I'm still committing it for now. 

Make the certificate viewer non-modal to match the native version.

BUG=99205
TEST=Manual


Review URL: http://codereview.chromium.org/8314017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107039 0039d316-1c4b-4281-b951-d872f2087c98