- 28 Sep, 2018 6 commits
-
-
Jonathan Metzman authored
/OPT:REF is currently stripping the constructors needed by sancov clients (such as libFuzzer). Disable it for fuzzing builds until this issue is resolved on the Clang/libFuzzer side. Bug: 884545 Change-Id: I9c12295020e6a2efc2ade268b25a555975e71c85 Reviewed-on: https://chromium-review.googlesource.com/1249151 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594927}
-
Kyle Horimoto authored
This CL adds a page for the MultiDevice setup flow to OOBE when associated flags are enabled. Currently, page is a placeholder with no content except for two buttons which move the user to the next page in the OOBE/login flow. A follow-up CL will integrate the actual page logic into OOBE. Bug: 884061 Change-Id: Ie3bafefc736c25484e9b421648a090e9c1aa6906 Reviewed-on: https://chromium-review.googlesource.com/1223028 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594926}
-
Stephen Martinis authored
Use swarming mixins for webrtc experimental bots. Bug: 880973 Change-Id: I51e386a78f8616a94c9c8a0d67de5bdf096dfe2b Reviewed-on: https://chromium-review.googlesource.com/1246946 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#594925}
-
Owen Min authored
Five extnesions are whitelisted for enterprise.rerpotingPrivate permission. Bug: 882461 Change-Id: Ic81d5dbdd45110225ebcbe2fcfac5e8827a58fc5 Reviewed-on: https://chromium-review.googlesource.com/1216843Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594924}
-
Kyle Horimoto authored
The tag had already been closed, so the extra tag was unneeded. Change-Id: Ia933f018873167fa201c2d4fc3a1d2b4a0d39053 Reviewed-on: https://chromium-review.googlesource.com/1250056Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594923}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I3280a573a6d13c9dc386758b1c177e07bec84e7c Reviewed-on: https://chromium-review.googlesource.com/1247603 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594922}
-
- 27 Sep, 2018 34 commits
-
-
Shakti Sahu authored
This is a reland of e6f5eba3 Addresses a case of null handling and an incorrect check. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=carlosk@chromium.org Bug: 881499 Change-Id: I313f0b34e95c4761fe54d5aa4296fd60643ab888 Reviewed-on: https://chromium-review.googlesource.com/1250100 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594921}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ad0232dee5f5..6ff2f64702dc git log ad0232dee5f5..6ff2f64702dc --date=short --no-merges --format='%ad %ae %s' 2018-09-27 webmaster@khronos.org Update LICENSE Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6ff2f64702dc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I889399d2353f7face54ebb634845bdb87ad5d28d Reviewed-on: https://chromium-review.googlesource.com/1249516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594920}
-
Anand K. Mistry authored
The zip archiver component extension already handles lazy loading of the NaCl module, but it was also unnecessarily loading it on startup. BUG=889703 Change-Id: I7346a13d4a317cd62e6b7a0f3e41870b723be28e Reviewed-on: https://chromium-review.googlesource.com/1248343Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594919}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1814174dbc2e..c0e1056a6c8e Created with: gclient setdep -r src-internal@c0e1056a6c8e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia00ea5654a91c7e5dee53583509bad22fdba581b Reviewed-on: https://chromium-review.googlesource.com/1249520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594918}
-
Joshua Peraza authored
This reverts commit dbca191e. Reason for revert: It broke the build. Original change's description: > Package Crashpad's handler into various APKs > > For Chromecast, Content Shell, and non-monochrome Clank/Webview: > > The Crashpad handler is a standalone executable, packaged like a > loadable module and named libcrashpad_handler.so in order to not be > ignored by Android's APK installer. > > For Monochrome: > > The Crashpad handler is linked into libmonochrome.so. At crash-time > /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java > which loads libmonochrome.so and runs the native HandlerMain(). > > This strategy is not used for non-monochrome APKs (i.e. pre-N) because > on L, Android's loader is not yet capable of loading native libraries > from the APK. This is normally performed by the Chromium linker which > can't be used by CrashpadMain.java because /system/bin/app_process > doesn't initialize the process like a normal Android application > (specifically, no ContextImpl has been created, so any calls to e.g. > appContext.getApplicationInfo() will segfault). > > Binary-Size: MonochromePublic.apk increases in size by 100 KB. > ChromeModernPublic.apk increases in size by 203KB (587 KB > increase in install size because libcrashpad_handler.so is extracted > from the APK). Possible mitigations for this increase are TODO: > > For J, K: We could link the handler directly into libchrome.so and let > that be our handler executable. This would de-dup portions of libbase > that are currently linked into both libchrome.so and > libcrashpad_handler.so. > > For L, M: It might be possible to get the chromium linker (or Bionic's > linker on M) to dlopen libchrome.so from the APK for a trampoline > libcrashpad_handler.so to de-dup libbase. > > Bug: crashpad:30 > Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65 > Reviewed-on: https://chromium-review.googlesource.com/1150774 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594853} TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,halliwell@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: I585aea87e7d52fa51097ae9b00a38eddf3a25679 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:30 Reviewed-on: https://chromium-review.googlesource.com/1250134Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#594917}
-
edchin authored
The TabGridConsumer API makes no guarantee that an |-insertItem:| is called before a |-replaceItem:| is called. In cases where |-replaceItem:| is called with an unknown identifier, the consumer should ignore the call. When |-insertItem:| is called later, it is guaranteed to have the latest information. Bug: 889685 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56cfde3d400b8d6f93296bd9a0e21060dc3e9aa7 Reviewed-on: https://chromium-review.googlesource.com/1247424 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594916}
-
Xiaocheng Hu authored
The test was converted into testharness.js test in crrev.com/c/1246902, but its LayoutNG text dump expectation was left unremoved, causing failure. This CL removes it. Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2cef89f1097519991e1638b0972d3b930030b60 Reviewed-on: https://chromium-review.googlesource.com/1249517 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594915}
-
Alex Moshchuk authored
ChildProcessSecurityPolicy::CanCommitURL() is a security check that's supposed to tell whether a given renderer process is allowed to commit a given URL. It is currently used to validate (1) blob and filesystem URL creation, and (2) Origin headers. Currently, it has scheme-based checks that disallow things like web renderers creating blob/filesystem URLs in chrome-extension: origins, but it cannot stop one web origin from creating those URLs for another origin. This CL locks down its use for (1) to also consult CanAccessDataForOrigin(). With site isolation, this will check origin locks and ensure that foo.com cannot create blob/filesystem URLs for other origins. For now, this CL does not provide the same enforcements for (2), Origin header validation, which has additional constraints that need to be solved first (see https://crbug.com/515309). Bug: 886976, 888001 Change-Id: I743ef05469e4000b2c0bee840022162600cc237f Reviewed-on: https://chromium-review.googlesource.com/1235343 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594914}
-
Vladimir Levin authored
R=zmo@chromium.org, kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I66f54c28838b8935e250c6c42d5dfaff74df960a Reviewed-on: https://chromium-review.googlesource.com/1250050Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594913}
-
erikchen authored
The test depends on ordering of IPCs across unassociated Mojo channels. This ordering is not deterministic. Bug: 889952 Change-Id: I23f9d69a5b2fc3e43eefe4241a151ccf1f20cfc1 Reviewed-on: https://chromium-review.googlesource.com/1250008Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594912}
-
Nasko Oskov authored
This CL is part of adding precursor origin support to url::Origin which nick@ started in https://crrev.com/c/1028985. It changes the Mojo representation of url::Origin to use the nonce as an indicator for whether the origin is opaque or not instead of keeping a boolean. Bug: 882053 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If260a09a66cf62b870f15d52f5aabc27a3f73823 Reviewed-on: https://chromium-review.googlesource.com/1227393 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594911}
-
Sarah Hu authored
Currently button and eol states are pulled from C++ side. In some broken state, c++ does not provide any information and about page end up showing all 3 buttons and eol state at the same time. Bug: 883900 Change-Id: I70788e3c3634dd11586c515c89ef499409d155e5 Reviewed-on: https://chromium-review.googlesource.com/1247185 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594910}
-
Kyle Milka authored
Prevent two focus indicators on the back arrow by making the grey circle the tabbable element. Bug: 878341 Change-Id: Ib18aa4669d3f8ea39754bb2ecadafaf718fe3143 Reviewed-on: https://chromium-review.googlesource.com/1249834Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#594909}
-
Jun Choi authored
Replace the current string "To see your security key, it needs to be in pairing mode. Press the button on your key for at least 5 seconds." with the string "If your security key isn't listed, press the key's button for at least 5 seconds". Bug: 890004 Change-Id: Idef5ef4c390236079f261bc9bf23b9ebdca6d21e Reviewed-on: https://chromium-review.googlesource.com/1249490Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594908}
-
Devlin Cronin authored
In practice, Extension objects are pretty much always const. Update the native bindings unit tests to use const Extension objects, rather than mutable ones. This makes the tests consistent (and removes the need for a "mutable_extension" hack), and gets these ready for ExtensionBuilder returning a const Extension. Bug: 889925 Change-Id: I44e1100515b055f5452f3ef90871a23d587b3f07 Reviewed-on: https://chromium-review.googlesource.com/1249528Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594907}
-
David Benjamin authored
We're only shipping the final version in Chrome 70. The vast majority of incompatibilities will have been dealt with by then, but give some extra time for any non-compliance that only showed up then. Bug: none Change-Id: Icdfd6a4190813a77276b40c1b167d97e69532a6a Reviewed-on: https://chromium-review.googlesource.com/1244165 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#594906}
-
Wenzhao Zang authored
This is a workaround. The bug should keep open until a better solution is found. Verified on both eve (high PPI) and paine (low PPI). Also, "margin-bottom" is a no-op so it's removed. Bug: 889655 Change-Id: I424d1c15ba2ee15a62b098f5bffc28037707ef97 Reviewed-on: https://chromium-review.googlesource.com/1247193Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/beb0c946de6d..e8dd07969872 git log beb0c946de6d..e8dd07969872 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Vulkan: Make vk::FramebufferHelper the graph resource. 2018-09-27 jmadill@chromium.org Vulkan: Make Buffer/Image be CommandGraphResources. 2018-09-27 jmadill@chromium.org Vulkan: Move LineLoopHelper graph work into BufferVk. Created with: gclient setdep -r src/third_party/angle@e8dd07969872 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ic8baae6546c11c0bdcf3decb003fad8f6f9dee4e Reviewed-on: https://chromium-review.googlesource.com/1249515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594904}
-
Peter Kotwicz authored
This CL: - changes Context#startActivity() to use the app context. - sets the Intent.FLAG_ACTIVITY_NEW_TASK flag on the launch intent in order to address error when using app context Change-Id: Ie3091e9aafd50e95c1081376ac7ba4a51c1b1a7c Reviewed-on: https://chromium-review.googlesource.com/1244072 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594903}
-
kylechar authored
InProcessCommandBuffer is being used for the display compositor with OOP-D. Add trace events for key functions, similar to the existing traces in CommandBufferProxyImpl and [GLES2]CommandBufferStub, to help diagnose performance issues. Bug: 832243, 890013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I34b962b48ad4eb10b112a9c979056993868637a4 Reviewed-on: https://chromium-review.googlesource.com/1250043 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594902}
-
Vladimir Levin authored
Since we don't support MSVC, and since it seems that's the only compiler that causes inefficient packing, I think we can remove the presubmit check that enforces no mixing of unsigned and bool bitfields. R=pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I176bded0da8fe5430029044ff96ec497ee28b999 Reviewed-on: https://chromium-review.googlesource.com/1250051Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594901}
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. Bug: 819914 Change-Id: I3e6e5f83cff86beedbd76a406aa31c4eb84a0929 Reviewed-on: https://chromium-review.googlesource.com/1244835Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594900}
-
erikchen authored
Previously, there was separate logic for OZONE and X11. This simplifies the existing logic, while also adding support for mash. Change-Id: I0f652360457e27dcdcdcc4e3afb131626aa07429 Reviewed-on: https://chromium-review.googlesource.com/1246726Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594899}
-
Scott Chen authored
Original CL got reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1248142 Bug: 874122 Change-Id: I547e4c209ec35c6a0a19c67d6194663c1bf3e604 Reviewed-on: https://chromium-review.googlesource.com/1249908Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594898}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/56db013e24cf..377b26ec65be git log 56db013e24cf..377b26ec65be --date=short --no-merges --format='%ad %ae %s' 2018-09-27 srte@webrtc.org Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-27 srte@webrtc.org Makes new congestion controller work with rtp sender tests. 2018-09-27 srte@webrtc.org Removes deprecated functions from legacy SendSideCongestionController. Created with: gclient setdep -r src/third_party/webrtc@377b26ec65be The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie2fec3b353f108b4106e88f56c8a1012b1f4a528 Reviewed-on: https://chromium-review.googlesource.com/1249633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594897}
-
wutao authored
This cl revises the tab spacing in vertical mode to match the spacing in the wallpaper picker. Images before and after changes are uploaded in the bug. Bug: 889559 Test: manual. Change-Id: I33a73809a9c674b009c5fdf1f9367645d395af87 Reviewed-on: https://chromium-review.googlesource.com/1249818Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#594896}
-
dpapad authored
Bug: 875525 Change-Id: I2bc1181d19b7bc3841da6d7306c85983f6656927 Reviewed-on: https://chromium-review.googlesource.com/1249903Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594895}
-
Seth Hampson authored
This includes subclassing the QuicStream to be used by the RTCQuicStream web API. It is a very basic implementation for the stream, and does not include the functionality that will be needed for reaading and writing. Bug: 874296 Change-Id: I25b69c06986cd68728b966ec28b67684ace5a87b Reviewed-on: https://chromium-review.googlesource.com/1199765 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#594894}
-
Evan Stade authored
Use a pre-existing window property instead of ash::ShellObserver to observe overview mode changes. Bug: 854704 Change-Id: I4b178f892b7a30c6de6a4e5f8a8521133651e799 Reviewed-on: https://chromium-review.googlesource.com/1244890Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594893}
-
Mustaq Ahmed authored
Bug: 817027 Change-Id: I0a7e3fb3014017a07158225082aab19b51ccdf24 Reviewed-on: https://chromium-review.googlesource.com/1240199Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594892}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 093e5cfc. With Chromium commits locally applied on WPT: 16f78349 "Move target-in-different-window.html into wpt/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25393 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Iebeed982408d2dbc24baaeb5a81dbf2d65b8a034 Reviewed-on: https://chromium-review.googlesource.com/1249806 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594891}
-
Nate Fischer authored
No change to behavior. This adds real constructors to create a Java AwWebResourceRequest, and clearly documents that isRedirect is typically false due to a lack of information. This was proposed as as an alternate solution in https://docs.google.com/document/u/1/d/1f-uoNx4X8JvJeXwwRopPGlGSkLVyuUsDRkU1n3ykeGg/edit# Test: N/A Change-Id: Ia8c8c6a1ca53dd8c0265165640226585a742298f Reviewed-on: https://chromium-review.googlesource.com/1244837Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594890}
-
Dana Fried authored
Half of requested cleanup following text scaling issues with Windows Text Zoom accessibility feature. Removes calls to GetNonClientMetrics() sprinkled around the code, as well as most uses of the Windows LOGFONT struct outside of platform_font_win and its callbacks. The remainder of the cleanup will be in a followup CL, which will consolidate all of the fiddly scaling and other uses of LOGFONT into platform_font_win. Bug: 888788 Change-Id: Iff47d2037b6a70210bd1eb0f24ab2f0430c59f86 Reviewed-on: https://chromium-review.googlesource.com/1246824Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#594889}
-
Demetrios Papadopoulos authored
This reverts commit 1ef23c93. Reason for revert: Caused several styling breakages across WebUI surfaces, see https://bugs.chromium.org/p/chromium/issues/detail?id=890030 Original change's description: > Make :host account for its own pseudo-class specificity. > > Otherwise `:host div` is equally specific to `div`, which seems undesirable and > doesn't match any spec. > > Bug: 857415 > Change-Id: I0a012ada134acb022dab85c3912b33ac5d0bd1dd > Reviewed-on: https://chromium-review.googlesource.com/1238445 > Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594745} TBR=emilio@chromium.org,futhark@chromium.org,andruud@chromium.org Change-Id: I98ce78a982a1d71356f18ec60a01e9616d5f9eec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857415 Reviewed-on: https://chromium-review.googlesource.com/1250054Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594888}
-