GitLab

This reverts commit d84a0fe3.

Reason for revert: performance regression crbug.com/950549

Original change's description:
> Reland "Do not create PrefetchGCMAppHander in reduced mode"
> 
> 
> Reason for reland: Original cl always created prefetch service when full
> browser starts to make sure to create gcm handler. Unfortunately, this was on
> the critical path, thus a performance regression. There is also a crash that
> seems to be caused by the original cl where the gcm driver is created twice.
> 
> In this new version of the cl, the PrefetchServiceFactory uses
> FullBrowserTransitionManager to register a callback when full browser is
> loaded, however, the callback is not registered if prefetch service is never
> created, thus solving the performance issue (also, clearer I belive).
> 
> > Original change's description:
> > > Do not create PrefetchGCMAppHander in reduced mode
> > >
> > > If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the
> > > prefetch service a closure to create the gcm app handler on demand.
> > >
> > > This cl also changes the signature of the getter for PrefetchGCMHandler in
> > > PrefetchService to require a profile to be passed in. This ensures that:
> > > 1) the getter can only be called in full browser mode (there is no profile in
> > > reduced mode).
> > > 2) if PrefetchGCMHandler hadn't been created yet, then it can be
> > > created on demand using the aforementioned profile.
> > >
> > > Bug: 934337
> > > Change-Id: I7e813f425e0ba8687f9b519b4300fa7eec014929
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737
> > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > > Reviewed-by: Xi Han <hanxi@chromium.org>
> > > Reviewed-by: Jian Li <jianli@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#640470}
> 
> 
> Bug: 934337, 944952, 943271
> Change-Id: Id4cf79cfc09998d946d2ec0685294aa553f02fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538779
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647321}

TBR=carlosk@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 934337, 950549
Change-Id: Ib5088fce99ec425d26e3cd756145db6f5b289567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564534Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651802}

Bug: 943491
Change-Id: I24fb4c0bb8ed7aacdde17509e89b145035f38f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568188
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651801}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3aad3e9228b3..21712068feee


git log 3aad3e9228b3..21712068feee --date=short --no-merges --format='%ad %ae %s'
2019-04-17 zoddicus@users.noreply.github.com Validate that SPIR-V binary is encoded as little endian for WebGPU (#2523)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@21712068feee

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iac7fe715afd97ac24fb90935faf24231bdbad37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572184Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651800}

Also, replace disabled_text_color with default_text_color_tertiary

Bug: 951231
Change-Id: I95b148c6372bb4f20d0c32d7317058130be0eb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570185
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651799}

Previously the notification on Windows doesn't have an image on the left.
Add Chrome logo to be the image.

Previous: https://screenshot.googleplex.com/czHKUPwf9Bu
Now(image will change base on channel):
https://screenshot.googleplex.com/p3oeicKOEf5

Bug: 952428
Change-Id: Ibc972b977806d8f8c2e4b44fa852f12dd40a0827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565448
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651798}

In order to avoid rendering inconsistencies between static and variable
fonts on Windows, run variable fonts through Skia's DWrite backend when
the system's DWrite version supports it.

As the test, use a default typeface to probe and ask for the variation
axis parameters of the current instance. If Skia return -1, it means, it
was unable to access the API for retrieving variations axes
information. If that's the case, we need to use FreeType, otherwise use
DWrite.

While we do not have bot coverage for Windows 10 RS3 ourselves, Skia
does test DWrite variable font support, so I believe it's okay to land
that, our own bot coverage is tracked in issue 953520.

Bug: 953447
Change-Id: I9684f92004531d6bafef33aefafa3894e4c46203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569947Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651797}

Starting with commit a69ab67b ("Implement desktop UI for the WebUSB guard
permission"), it is possible to have an "Ask" option in
chrome://settings/content/siteDetails that can be chosen by users.

However, doing so (rather than selecting the "Ask (default)" option)
triggered two assertions that no longer seem to make sense:
* "Ask" as an option is no longer just for display;
* It can also be selected as a user preference rather coming only from
  extensions or a policy.

The assertion were being hit whenever the option was chosen as well as when
the site details page was reloaded, in which case the items loaded after the
WebUSB option were all blank.

Bug: 771703, 947112
Change-Id: Ic2c0bfe0d4cc1bccfe87c2fa756c7284e4883853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569926
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#651796}

This reverts commit d3b3ab90.

Reason for revert: Abandoning the effort to remove associated interfaces, so reverting changes which landed in support of it. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit#

Original change's description:
> [mojo-core] Add the concept of port slots
> 
> Ports are the two-way relocatable messaging endpoints used as a backing
> for Mojo message pipe handles. Each port is essentially a message-
> receiving queue, and the mutual independence of each port's queue is
> fundamental to a port's ability to be relocated efficiently and thus be
> suitable to support message pipes.
> 
> This CL introduces the concept of "slots" on an individual port,
> effectively allowing for messages in the port's queue to be routed to
> different consumers referencing the port. Messages are now sent on a
> specific slot by the sender, and received on a corresponding peer slot
> on the peer port. If multiple messages are received for different slots
> on a port, they still must be read (and are still only exposed) in
> sequential order.
> 
> This is a precursor to supporting shared message ordering across
> multiple independent message pipes in Mojo, a feature which will
> ultimately replace the bindings concept of "associated interfaces".
> 
> See bug for design doc link.
> 
> Bug: 941809
> Change-Id: I84e6f35831d918178e9eb2cc32c8701d1808e4e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538778
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#648299}

TBR=rockot@google.com,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 941809
Change-Id: Ia25c1fc965d508a37eeee8900604a601547c0a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572225
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#651795}

This reverts commit d6d91a56.

Reason for revert: Abandoning the effort to remove associated interfaces, so reverting changes which landed in support of it. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit#

Original change's description:
> [mojo-core] Introduce PortAttachment
> 
> This is a simple refactoring CL which replaces the list of PortName
> values in a UserMessageEvent with a list of PortAttachment structures.
> This new structure type is a PortName and an optional SlotId, allowing
> for internal Mojo serialization to signal that a serialized message pipe
> handle should be encoded as a spliced-in slot on the transmission pipe
> rather than as an actual port transfer.
> 
> No functional changes are made here, this is just groundwork to reduce
> churn in a follow-up CL.
> 
> See bug for design doc link.
> 
> Bug: 941809
> Change-Id: Id1c33a1fd81cf3879c350a3a241ef0791ef60ad3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542304
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648417}

TBR=rockot@google.com,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 941809
Change-Id: Id9b4999e60c18713121d262b22b1fc32dd0b2f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572299Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#651794}

MseBufferByPts is enabled by default in trunk (in M75). This change
removes the field trial configuration.

BUG=760264,807793,771349

Change-Id: Iee62ba1e9d62b2a5196985e124dbd9c78ac40add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570772Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651793}

Wrap frame lookup and creating a new window into a single API
that relatively closely tracks the spec at
https://html.spec.whatwg.org/#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name

In addition to better matching the flow/ordering of the spec, this
change fixes a bug where we would sometimes convert a navigation
targeted at _top or _parent into a new window if the source frame
couldn't navigate the target frame.

Bug: 944213, 914587
Change-Id: I5bbede0b557bdb9b0dc19155959d9c2bfd8e4941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569967
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651792}

TBR=olivierrobin@chromium.org

Bug: None
Change-Id: Ic8a9344bb5ccd6c22c9ee6d4f6d784beb44f9dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570915Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651791}

https://skia.googlesource.com/skia.git/+log/e88d4382e1cf..5155e09d1466


git log e88d4382e1cf..5155e09d1466 --date=short --no-merges --format='%ad %ae %s'
2019-04-17 egdaniel@google.com Revert "added more SPIR-V RelaxedPrecision decorations"
2019-04-17 jvanverth@google.com Make Metal render loop more stable
2019-04-17 mtklein@google.com roll clang_win
2019-04-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-17 robertphillips@google.com Reland "Revert "Simplify SkTypeface::charsToGlyphs API to require UTF32 input""


Created with:
  gclient setdep -r src/third_party/skia@5155e09d1466

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ia2d97f43820e4c46a26f9de4b65529b3db50062a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651790}

https://android.googlesource.com/platform/external/perfetto.git/+log/7342ae0bd748..854d22feaf4b


git log 7342ae0bd748..854d22feaf4b --date=short --no-merges --format='%ad %ae %s'
2019-04-17 fmayer@google.com Roll trace_to_text for heap_profile.


Created with:
  gclient setdep -r src/third_party/perfetto@854d22feaf4b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:130665360
TBR=perfetto-bugs@google.com

Change-Id: Id2ef8f27fd08efbeb3f5f24fbd8e4d244bdd5864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572079Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651789}

This CL adds a boolean topsites parameter to the
LookalikeUrlNavigationSuggestionsUI feature. When enabled, the interstitial
will be displayed for both site engagement and top domain heuristics. When
disabled, it will only be shown for the site engagement heuristic.

Bug: 951555
Change-Id: Idd8f5f47b3b4185ff5256d6982096ba135756988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570078
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651788}

For some reason this fixes the crash, although the other layout checks
in NativeRoleIgnoringAria() seem to be ok.

Bug: 945286
Change-Id: I2b2f9450a5a2e98f4a8c34169d86ef54aff74a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570820Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651787}

Change the characters that get written to the chrome_versions.txt output
file so that it can be read by the parser Omaha uses.

Bug: 953059
Change-Id: I219dd2360cacf6d9bed2316478d86e733c4dcb06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570699Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651786}

+ Hold InfoBarContainer in activity context
 - Not instantiating InfoBarContainer until tab is attached
 - Close all infobars before destroy
 - Clear Java side InfoBar object when closing InfoBar
 - Add icon drawable tint
+ Fix a number of leaks
 - Tablet and top toolbar HomeButton holding on to HomepageManager
   Observer
 - ReaderModeManager delegate holding activity implicitly on native
 - BottomSheetController holding VrModeObserver
 - InputMethodManagerWrapperImpl holding activity

Bug: 934577, 934909, 934908
Change-Id: I73ddff2549a921bfff37897bb7aff5622471c6f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540080
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651785}

Bug: 736891
Change-Id: I9d53d847850288638a1fff51e348cfbcd3b64705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570540Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651784}

Many fixes have landed since this test was disabled. It's therefore
worth giving it a try and enable it again.

Bug: 889505
Change-Id: Iedf8ae64a002ea508f8304c67248c68d5e88cd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572339Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651783}

Change-Id: I39b60fb4607ee1e6b1987abf89c4f9e39a90d181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564586
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651782}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58da6c5b..fd3e5e3a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I96320a2bf1f746f57475af0cee622c31ef527fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572223Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651781}

Bug: 811351
Change-Id: I60104b8ec57aa86a8472bab631ca61c5d011d7ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565989
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651780}

Bug: 937907
Change-Id: I4341c58bc0f0dc22938d4e58711827b033ec1965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565627
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651779}

Looks like it's now flaky on several Linux and Win10 bots as well.

TBR=masonfreed@chromium.org

Bug: 953725
Change-Id: I28513be624f25dd9a04c2f4864a545d2d6f5d946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570913Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651778}

Bug: 950431
Change-Id: Ic7ddbefa4be3644bd088a2d19e1bdb698e60326a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571121
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651777}

This cl moves sync consent tests to the normal chromium build target.

Made fixes to the sync consent tests:
 * Added FakeGaia mixin to allow the call to ShowSigninScreenForTest to
   complete.
 * Updated the OOBE JS API call for updating language locale.
 * SyncConsentPolicyDisableTest now waits for user session to start
   because OOBE flow can finish before the Waiter started, causing the
   Waiter to wait forever.

Moved the is_official_build_ flag in WizardController to static scope
because a new WizardController instance is created as part of the login
flow. This meant that setting is_official_build_ to true during the
test would be overriden when the new WizardController instace is
created.

Added a helper function ForceOfficialBulidForTesting to WizardController
that temporarily overrides is_official_build_ during the execution
of a test.

Removes some WizardController friend classes that only needed access
to the private is_official_build_ flag.

TBR=antrim@chromium.org

Bug: 952388

Change-Id: I5bd87ef4a21b4a265bdde94656fc2380c770473a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570215
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651776}

This is a reland of 328f5578

Issue was: When run_policy is changed during
execution of GetWork() under lock, it is possible that the DCHECK
GetNumAwakeWorkersLockRequired() >
GetDesiredNumAwakeWorkersLockRequired()
triggers.

Fix: The DCHECK was a sanity check based on an assumption no longer true,
so remove DCHECK. TestCanRunPolicyLoad was improve to always trigger
the DCHECK when present.

GetDesiredNumAwakeWorkersLockRequired() was also modified to always
return at least the number of workers currently running a task.

Fix: GetDesiredNumAwakeWorkersLockRequired returns at least num_running_tasks_.

Original change's description:
> Reland "[TaskScheduler]: Simplify sequence preemption logic."
>
> This is a reland of 5d4c05db
>
> Problem: PlatformNativeWorkerPool::RunNextSequenceImpl expects sequence
> returned from GetWork() to be non-null and DCHECK.
> Solution: Handle null sequences by skipping RunAndPopNextTask.
>
> Original change's description:
> > [TaskScheduler]: Simplify sequence preemption logic.
> >
> > This CL removes preempted sequences from TaskTracker,
> > removing need for CanScheduleSequenceObserver and
> > simplifying shutdown.
> > A CanRunPolicy enum is used instead, specifying whether
> > or not tasks at a given priority can run.
> > When CanRunPolicy is updated, wakeup workers needs
> > to be done as appropriate.
> >
> > In addition, Shutdown was split in 2 phases start + complete
> > to allow caller (TaskScheduler) to update CanRunPolicy after
> > shutdown was started.
> >
> > This CL was recycled from:
> > https://chromium-review.googlesource.com/c/chromium/src/+/1478007
> > I took ownership because simplifying Sequence lifecycle
> > will simplify implementation of job API.
> >
> > TBR=gab@chromium.org
> >
> > Bug: 889029
> > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161
> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#648346}
>
> Bug: 889029, 950383
> Change-Id: I1f64517d312e65fb59ae235373b4f4d504da87dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557861
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649399}

Bug: 889029, 950383
Change-Id: I306bf7119034fcd3b917946f1f561344374bb718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564791Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651775}

This is significantly faster (about 80x in some quick testing).

Also remove the now unused x509_util_mac IsSelfSigned function.

Bug: 410574
Change-Id: I60cfc40d5f5a5dab419566836555cb4828148c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570768Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651774}

The CL implements a new feature policy hidden behind the flag
FeaturePolicyForSandbox. The policy is the feature policy counterpart to
the sandbox flag 'allow-downloads-without-user-activation'. This policy
is used to help migrate sandbox flags implementation on top of feature
policies.

PA: https://github.com/w3c/webappsec-feature-policy/issues/289

TBR=alexmos@chromium.org

Bug: 812381
Change-Id: I234bb0486313ab350827315843db22525c2ceaac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538966Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651773}

In Android Q calling UsbDevice.getSerialNumber() when the calling
application does not have permission to access the device will throw a
SecurityException.

Bug: 952956
Change-Id: I2c335f39b528ea0e72eede46f98291d21bfe284c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571005
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651772}

Submit this after all bots have generated new reference images for these
tests.

Bug: 899399
Change-Id: Ib3a48a5955796e9e3638b11a6176bb8e935ebfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568387
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651771}

Bug: 914587
Change-Id: Ic851c6ad1d8e78af40f6bb8df3d310ed5c472e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570232Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651770}

This will hopefully increase the chance of a test flake on the fyi bot
so I can test out the failure reporting changes I'm making.

Bug: 923426
Change-Id: Ibfda3b2af9f9240cfc72c5544ff56dfc2aa5c6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572259
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651769}

https://chromium.googlesource.com/angle/angle.git/+log/20a716319262..3b2c6bfd4353


git log 20a716319262..3b2c6bfd4353 --date=short --no-merges --format='%ad %ae %s'
2019-04-17 spang@chromium.org Vulkan: Implement glImportMemoryFdEXT


Created with:
  gclient setdep -r src/third_party/angle@3b2c6bfd4353

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I98284c36d5ea84dc173255081b7acb0ff1f6d08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572178Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651768}

Reserve the space needed for an accessory view in each CBD items,
so that text labels don't reach the far right end of a cell, and
therefore cell selection doesn't result in text label width shrinkage.

Bug: 935346
Change-Id: I6c13d82c3eb45555710447040de49550410650a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571411
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651767}

Currently WorkerThreads have a SequenceManager on top of the
MessageLoop provided by base::Thread. This patch removes that
duplication which was also causing a test to flake.

There is really no need to use base::Thread, moreover it makes it hard
hard to trigger shutdown and to make sure that initialization and
destruction happen on the worker thread. So to have better control we
use a base::SimpleThread instead.

This patch has the small side effect that the thread name of
WorkerThreads has now the tid as a suffix (imposed by the SimpleThread
api).

Bug: 934088
Change-Id: Ib771a5e2c756a0e8a02e6eed00a78da5d794e633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552812
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651766}

A policy message arriving on the UI thread may be bound to a contents that no
longer exists, but in some cases the contents may still exist but have been
renavigated. The LastNavigationId allows dropping policy messages that are
only relevant to a particular navigation. This helps in migrating users of
PSG/PSR/PSO away from that functionality.

BUG=931407

Change-Id: I9182bd8fb558ff27d1a70917159d5eef4b99ccef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571008
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651765}

This reverts commit a67d4d6f.

Bug: 953476
Change-Id: I26daaa894110219d2f35573d4f0c520deade9245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572219Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651764}

Bug: 935032
Change-Id: Ifebd7227120d90b9388fd9491b9a307a82a0991a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571545Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Commit-Queue: Alan Wink <alanwink@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651763}