- 21 Oct, 2020 40 commits
-
-
Regan Hsu authored
Note that OnShouldShowSetupRequiredUiDismissed() was added for the debug UI control which will be added in a later CL. Bug: 1106937 Change-Id: I0b4915827ec690d3f639177d1189fac74da0220f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488613 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819460}
-
Alex Turner authored
While attempts to get src:local font data (including failures in those attempts) are currently instrumented, it is possible to determine local font existence through other means. In particular, FontFace.load() on a FontFace object with a src:local attribute can be used to do this. (The lookup will succeed if the font exists and result in a network error otherwise.) We therefore instrument any attempt to determine a local font's existence by a unique name lookup. We include attempts to lookup the font's data as that would also reveal existence. Bug: 1136959 Change-Id: I7dcd900c541b3c9e20df353f7fe890b4e9352260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477453Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819459}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e2cbcc956588..45b6de9149c1 2020-10-21 cwallez@chromium.org Dawn infra: update the primary branch to "main" 2020-10-21 cwallez@chromium.org Trivial grammar fix in README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ie44647bd74ffb4ac0a5283455be3d7509699ae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819458}
-
Toni Barzic authored
Removes overview enter exit types that are only used for old tablet mode gestures between home screen and overview: kSlideInEnter, kSlideOutExit, kSwipeFromShelf. Note that kSwipeFromShelf is still being referenced from home launcher gesture handler, but these calls are being removed, too (and are not reachable if IsDragFromShelfToHomeOrOverviewEnabled). BUG=1137452 Change-Id: I31730aa30f0c198538b25a15739d5b4f36078ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482423Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819457}
-
Ryan Sturm authored
This functionality serves a prefetched response from the search prefetch service when the search terms match from the prefetch vs the current navigtation. Bug: 1138643 Change-Id: Icf326fff7e29158d7c197bab8fdb39f6eb30539f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487875 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#819456}
-
Akihiro Ota authored
This change adds an output rule for the mark role. If needed, follow-up patches can build off of this change to support associated aria-details elements. We also add tests to confirm behavior, using sample code provided by the Docs team. This change also adds a check for non-existent braille strings in Msgs.getMsg(), since ChromeVox hits the following error without it: "Invalid ChromeVox message id: role_content_insertion_brl" 'marked content'. Fixed: 1126131 Change-Id: If588b3d018ddcab272a265bb63eb4c6119352781 AX-Relnotes: ChromeVox announces elements with role=mark as Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422252 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819455}
-
Peter Kvitek authored
Adding this switch to headless browser tests ensures that proxy related tests are not affected by a platform specific system proxy configuration service. This fixes HeadlessProtocolCompositorBrowserTest.BrowserSetInitialProxyConfig issues when running on Windows. Bug: 1134929 Change-Id: Ib245a4fe660eacaab944521a56ed9f2d1f525b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489779Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#819454}
-
Ryan Sturm authored
This introduces a few basic checks, but does not robustly handle all corner cases. This also does not handle serving the response, but rather just storing it. Bug: 1138639, 1138640 Change-Id: I9e1698156e717754541a9e18f1316c42326b9949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486454 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
-
Dom Schulz authored
It was only used in manifest install of SWAs, which is being deleted in the parent branch. Bug: 1085274 Change-Id: I8c053f82b4e5186c7336d731b8deafa3dbbb95ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485760Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: Ie6ee8bfd51acc8317a0ba243d5924f5f87d39359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489501Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819451}
-
Roberto Moura authored
The tab grid's new tab button is covered by the BVC when the tab grid is visible and the thumb strip feature is enabled. Nudge the new tab button by a distance equal to the height of the BVC that remains visible when the tab grid is showing. Bug: 1094335 Change-Id: I54d7aa20633e109cf41b6bfe46866cecb23584aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487320 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#819450}
-
Jacob Kopczynski authored
Bug: 1114563, 1140587 Change-Id: I8f9fc6c41923e439ff148120fd3b3465f4ceacae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490662 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#819449}
-
Peter Boström authored
This reverts commit 81f2d6be. Reason for revert: Relanding without ChromeCleanerDialog changes. Original change's description: > Revert "Use set_fixed_width() in c/b/ui/views dialogs" > > This reverts commit a9b6d2bd. > > Reason for revert: Causing builder to fail. First fail was 8 changes after this. > > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 > > Original change's description: > > Use set_fixed_width() in c/b/ui/views dialogs > > > > Does not address subfolders which will be done in separate chunks. > > > > Bug: 1128500 > > Change-Id: Id3caa97d0d59b4700b888c5bca5f89f69d4c64d1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485148 > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Auto-Submit: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819061} > > TBR=ellyjones@chromium.org,pbos@chromium.org > > Change-Id: I0d03cb731d03bf7ba11d836769bd2513c25f1366 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1128500,1140866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489380 > Reviewed-by: Fergal Daly <fergal@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819259} TBR=ellyjones@chromium.org,pbos@chromium.org,fergal@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1128500 Bug: 1140866 Change-Id: Ica91e35d28972e2bff2ecd963b387d86f4975878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490329Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819448}
-
dan sinclair authored
This CL does a combined roll of spirv-tools and headers to deal with new enum additions. Change-Id: I6a97855ff72f67e906ba22ad5a080c9c2b57ebe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490241 Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: dsinclair <dsinclair@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819447}
-
Peter Kasting authored
Bug: 772945 Change-Id: I58e8a596aeeca4a78b981600170c134b52c3a214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#819446}
-
Esmael El-Moslimany authored
Relanding crrev.com/c/2469401 The issue involved the string ID change. I'm reverting that change and will follow-up with change the string IDs. Revert "Revert "WebUI NTP: add recipe task module"" This reverts commit 54354dde. Bug: 1138011 Change-Id: Ifb657544605eb55f44494dc791b7c5945a3116a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488391 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819445}
-
rbpotter authored
Bug: 1132403 Change-Id: Ia84ffd754058cd44ac0f2210837838c8a1fb5a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488394 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819444}
-
Clark DuVall authored
Component build uses cr.so libraries for DFMs instead of partitions. These will just be included as shared libraries in the base module. Bug: 1126301 Change-Id: I6b7090d0443e809c545d12176058affecd3e0cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490330Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819443}
-
Owen Min authored
Extension request only report only contains - profile id - extension request. But not - extension list - policies info Profile name and sign in user info only added on CrOS. Bug: 1137964 Change-Id: I76bc72acde86f149ac090d839d159ddb56b6bb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485276Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819442}
-
Ramin Halavati authored
Updates the DCHECKing when regular profile is destroyed to ensure no renderer process host is alive for any off-the-record profile. Bug: 1033903 Change-Id: I4971d68f6f958fcace723b3515b3ed44f8753866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478989Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819441}
-
Henrique Ferreiro authored
Internal is not a component in Monorail. The correct one is Internals. Change-Id: I8992e0f06dd876253d385f47f68889972fc6b44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489502Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819440}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01771c17f1d6..07829f27ec5f 2020-10-21 bsalomon@google.com Revert "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 johnstiles@google.com Migrate additional FPs to `return` instead of `sk_OutColor`. 2020-10-21 johnstiles@google.com Wrap built-in symbol tables when a switch statement is cloned. 2020-10-21 bsalomon@google.com Perform bounding rect-relative calcs in full float in GrRRectBlurEffect 2020-10-21 johnstiles@google.com Create a basic IRNode pooling system. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138810 Tbr: egdaniel@google.com Change-Id: Ieb6e35312e3171cdc45b992aec6ea63f3228ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489670Reviewed-by:
-
Sebastien Lalancette authored
The previous approach only allowed pasting the additional text in text boxes on iOS 12 (not the URL). Also, by having the text as first item, Chrome's omnibox was offering to search for the additional text rather than selecting the second pasteboard item (the URL). The fixes were to put the URL item first (omnibox fix), and also offer a plain text version of it (iOS 12 fix). Bug: 1136043 Change-Id: Ia104f50694982eaeea9651c9f4cf613f487e0a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490240 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819438}
-
Nicolas Ouellet-Payeur authored
Don't run DestroyProfileOnBrowserClose logic if Background Mode is enabled, i.e. wait for the entire browser to exit before destroying the Profile object. Bug: 88586, 566835 Change-Id: I593d5537fc494bab1cd435b65cfc57075d92cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476173Reviewed-by:
-
Mario Sanchez Prada authored
As a precursor to crrev.com/c/2412309, this CL adds a new C++ struct, along with the relevant mojom traits for typemapping, that will now be used for IPC between the browser and renderer processes instead of directly using the blink.mojom.RendererPreferences mojo struct. This is needed in order to migrate PageMsg_SetRendererPrefs to Blink (see CL 2412309) since, even thought that message will now be received and handled inside Blink itself, it's still necessary to pass it back to //content/renderer as it's still needed in several places such as RenderView and //content/renderer/loader, and having the mojom struct only would cause trouble because we can't simply pass a Blink variant of that struct into //content. Having this C++ struct and its corresponding typemapping solves this problem since Blink will no longer receive the Blink variant of the mojo struct but just a blink::RendererPreferences, which can now be passed to //content/renderer for as long as it's still needed. Bug: 1102442 Change-Id: Id79fc6117c6b6a091644f41619aa6467550705cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445499Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#819436}
-
Peter Boström authored
Replaces pbos@ who no longer claims specific ownership to this directory with jkrcal@ whom he's pulled into every conversation about this code. Bug: None Change-Id: Iadee667490306ab72093811276243ef4c0a757c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490326 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819435}
-
Akira Baruah authored
Unsent metrics logs get trimmed if they're larger than a preset size. This change implements a new UMA metrics histogram called "UMA.UnsentLogs.DroppedSize" to record the size of each of these trimmed logs. Also adds a unit test case for a similar existing histogram that measures dropped log counts. Bug: None Test: metrics_unittests Change-Id: If6ed17a2a1327c2bd3d3a9da16926b91e72a6f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482322 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
-
Jeffrey Kardatzke authored
These are changes that are intended to be somewhat generic for Chrome OS protected media playback and are required by the initial VAAPI integration. These calls will be made from within the Chrome VAAPI code. The corresponding change in Chrome OS is here (internal): http://crrev.com/i/3349775 BUG=b:153111783 TEST=Builds, also verified with full prototype Change-Id: I4ce0274f932b61db2162e05ba06e95ccd83103d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486116 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819433}
-
Eric Seckler authored
This moves the majority of AndroidBatteryMetrics from chrome/ to components/, so that we can reuse it for WebView/WebLayer in the future. The only aspect that remains in chrome/ is the detection of the app's visibility state, since this will have to be done some other way for WebView. Bug: 1102048 Change-Id: Ia8391fd5efd80411ac970c559cdf5db988ba9ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485794 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819432}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 591099 Change-Id: I2e166ff4851f3d0fc84e1cf2ef797886d4992471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490245Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819431}
-
Kuo-Hsin Yang authored
vovoy@chromium.org would take over the code review for Chrome OS tab manager from cylee@chromium.org. Change-Id: I9743e6d3b152467467b20e70fd96cb2b9b2929b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489112Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819430}
-
Anton Bikineev authored
The CL enables PCScan when 1) PA-Everywhere, 2) --enable-features=PartitionAllocPCScan. and makes sure that it's enabled after FeatureList is initialized. Bug: 11297512 Change-Id: Ibcf21a503cdf0cb1a085629ab77d4e87061f8fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473637 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Roberto Moura authored
The drop shadows helps contrast thumbnails when they overlap one another, i.e. during transitions between thumb strip and tab grid mode. Bug: 1127604 Change-Id: I23b55172d112461ed63e6087203dbf780dcd1728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487126 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3169c31f1f0e..f80cfd667638 2020-10-21 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6e9546745d3a21fd1cce05b26dd8d21077ec20ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489752Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819427}
-
Peter Wen authored
Chrome makes use of these APIs. Rather than adding @SuppressWarnings for the RestrictedApi check for all classes that use these APIs, add a chrome-specific suppression for just these ones that are false positives. Bug: 1139442 Change-Id: I95dbf4ed84908a12242e31b103386fecee88a128 Fixed: 1139442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487846 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#819426}
-
Sergey Ulanov authored
ExternalVkImageSkiaRepresentation uses ExternalSemaphorePool to re-use semaphores. OutputPresenterFuchsia converts image semaphores to Zircon events and shares them with Scenic. Scenic waits for these events, but never resets them. As result the semaphores are often re-used in signaled state. This CL disables semaphore re-use on Fuchsia to avoid issue. Bug: 1140719 Change-Id: I9154535b59262d60cd602c7711315673cf2bad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487879 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819425}
-
Bill Budge authored
- Uses Blink getter to get actual cross-origin-isolated state. - Sets flags correctly. Bug: chromium:923807 Change-Id: I54101e10d89ef9b3e373f98eda2509cc97d38529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489924Reviewed-by:
-
Avi Drissman authored
Unlike a code signing cert, where a self-signed cert will not work, and where Apple provides both a development and a deployment cert, for the installer package a special cert is required, and a self- signed cert is a very good idea because Apple does not provide a development installer cert, just a deployment installer cert. Expand the documentation, and include a link to a Stack Exchange answer that describes how to make such a self-signed cert. Also, tweak the Google-internal link for the code signing development cert, as that is now where it can be found. Bug: none Change-Id: Idf8db4f14322a775c640180c19719a62feac5e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488026 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819423}
-
Mihai Sardarescu authored
Use std::make_unique to create unique pointers for BookmarkBubbleSignInDelegate. Bug: None Change-Id: Iabffb64eed63a554f4def7a0f2c1f68de38ec765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490043 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#819422}
-
Peng Huang authored
SkiaOutputSurfaceImpl::SubmitPaint() not always submits painting tasks to GPU. So sync token returned by it is not always valid. Fix the problem by renaming it to EndPaint() which will not submit tasks to GPU anymore and not return sync token. It also adds a new method Flush() which will submit pending tasks to GPU thread and provide a sync token. Bug: 1139697 Change-Id: I34fdd5e325ac2425399a9fc98ffcaa6052cddc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488302 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819421}
-
