GitLab

Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.

This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).

This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.

BUG=635619

Review-Url: https://codereview.chromium.org/2899413002
Cr-Commit-Position: refs/heads/master@{#476354}

This CL fixes crashes in extended desktop mode caused by incorrect
parenting of the cursor surface, as well as cases where the cursor
was captured with an incorrect transform or hotspot:

  1) The mouse enters a display with a different DSF or UI scale.
  2) The internal display is not the primary display.
  3) The display is rotated.

It also adds a TODO for an accessibility regression.

BUG=631136
BUG=642894
TEST=caroline: Cursor parenting and scaling is correct for each display.
TEST=caroline: Cursor on rotated displays has correct orientation.

Review-Url: https://codereview.chromium.org/2780623002
Cr-Commit-Position: refs/heads/master@{#476353}

This patch moves offline page scheduling for pre-M OSs to
background_task_scheduler component and removes a lot of code
in the process:
* switches offline page handling in ChromeBackgroundService to
  reschedule
* removes ChromeBackgroundserviceWaiter
* removes subclasses of BackgroundScheduler (responsible for
  scheduling on different OS versions)
* Moves useful code from BackgroundOfflinerTask to
  OfflineBackgroundTask
* Simplifies BackgroundSchedulerProcessor (and removes
  namespace for interfaces)
* Updates the tests for classes mentioned above.

BUG=699261

Review-Url: https://codereview.chromium.org/2830843002
Cr-Commit-Position: refs/heads/master@{#476352}

For moving GpuMemoryBuffer resource allocations to worker context, we
need to create image ids on the worker context but destroy them on the
compositor context. Image ids are already unique across contexts on the
client but the service was tracking image ids per decoder. This CL makes
image tracking work across all contexts in a channel by moving image
manager to the gpu channel.

Bug: 514819
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I27f05ba24421fefb8b6e4e7636a3fb9a6f605ef1
Reviewed-on: https://chromium-review.googlesource.com/518548Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476351}

This CL enables Image Capture browser test in Mac and Android; this test
needs a real-ish camera, so it's only part of the webrtc infra, which is
run explicitly in "large bots" [1].

Also git cl format restyled the code a bit.

[1] https://build.chromium.org/p/chromium.webrtc/waterfall


Bug: 656810
Change-Id: Iadc2fa1b4b5b56c3e06288b73e452a40e15b3426
Reviewed-on: https://chromium-review.googlesource.com/521263Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476350}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/861d4a174136..c294424b587e

$ git log 861d4a174..c294424b5 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 perezju [systrace] Use large_output=True when collecting atrace data

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id9541437d4ef441e5ab4c5f5c58eb677dc134623
Reviewed-on: https://chromium-review.googlesource.com/521422
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476349}

Adds a standalone APK that, when run, simulates a Daydream View NFC tag
scan. This is so that Telemetry can enter the VR browser without making
any modifications to Chrome, e.g. a flag.

Bug: 726906
Change-Id: I37a430c98b08dc41363fdc02b3486193b9e26fa6
Reviewed-on: https://chromium-review.googlesource.com/517682Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476348}

BUG=716055

Review-Url: https://codereview.chromium.org/2919553002
Cr-Commit-Position: refs/heads/master@{#476347}

https://pdfium.googlesource.com/pdfium.git/+log/e858aa4b70db..a64cd6c86438

$ git log e858aa4b7..a64cd6c86 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 dsinclair Remove unused Locale code
2017-05-31 tsepez Be less trusting of MaybeLocal<> return types from V8 To* methods.
2017-05-31 tsepez Missing one unowned_ptr in ccodec_progressivedecoder.h

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I5724167552c757df9951af6619c894a637d578f1
Reviewed-on: https://chromium-review.googlesource.com/521204
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476346}

BUG=712224

Review-Url: https://codereview.chromium.org/2905733002
Cr-Commit-Position: refs/heads/master@{#476345}

https://skia.googlesource.com/skia.git/+log/baf41bd1c8d9..c6912f712f34

$ git log baf41bd1c..c6912f712 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 mtklein make SkColorFilter::onAppendStages() pure
2017-06-01 robertphillips Remove GrSurface-based surfaceContext factories from GrContextPriv
2017-05-31 ccameron Ensure SkPictureImageFilter::onFilterImage doesn't double-convert color
2017-06-01 reed fix and test colorfiltershader
2017-06-01 robertphillips Update more GrOps to split-opList world

Created with:
  roll-dep src/third_party/skia
BUG=728332


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I3396532654f54234d1bf8774470df6435539a50a
Reviewed-on: https://chromium-review.googlesource.com/521242Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476344}

Two changes:

f5b27d17 Make CalendarAstronomer public
ae18d608 Fix a typo with astro.h

TBR=jshin@chromium.org
BUG=726654

Review-Url: https://codereview.chromium.org/2914933002
Cr-Commit-Position: refs/heads/master@{#476343}

Crash reports for Android show several Java exceptions being raised inside 
Android camera APIs. These exceptions are undocumented, and are likely to be 
caused by bugs in the (potentially vendor-customized) Android code.

With this CL, we catch the most frequently reported exceptions in order to fail 
gracefully instead of crashing.

Bug: 707320
Change-Id: Ie4013b65fc87995909c5ac3ed85e0c81dd31b3ca
Reviewed-on: https://chromium-review.googlesource.com/517270Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476342}

Bug: 
Change-Id: I011930ad3dc3f4281ebed4cb903399e0aa997225
Reviewed-on: https://chromium-review.googlesource.com/520703Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Devdeep Ray <devdeepray@google.com>
Cr-Commit-Position: refs/heads/master@{#476341}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2890163003
Cr-Commit-Position: refs/heads/master@{#476340}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2888993003
Cr-Commit-Position: refs/heads/master@{#476339}

This makes JSONReaderTest.* pass (and probably a bunch of more) as they
can now find their test data.

Bug: 706592
Change-Id: I0afe36e95a18bd7d49db6c53ae1fc863bd8a2a43
Reviewed-on: https://chromium-review.googlesource.com/520498
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476338}

- Adds an instance of RCS to V8PerIsolateData
- Logs RCS table in RenderThread::Shutdown (behind a flag)

Bug: 724542
Change-Id: I496c76c4e79ba5011b90b512c2bd02cd5b6056a2
Reviewed-on: https://chromium-review.googlesource.com/517562
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476337}

TextIteratorTextNodeHandler used to store the full iteration range, and
have comparisons between |text_node_| and |start/end_container_| scattered
in the class to decide the offset range on |text_node_| from which text
should be emitted.

This patch changes it that:
- TextIterator, when calling HandleTextNode(), compares the current text
  node with the start and end containers to decide the offset range on it,
  and pass the offset range to TextNodeHandler
- TextNodeHandler no longer stores the full iteration, but only the offset
  range passed from TextIterator.
- TextNodeHandler no longer decides the offset range by itself, but uses
  the passed-in offset range directly.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2913673004
Cr-Commit-Position: refs/heads/master@{#476336}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/35b77a36..4bb4a24e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2921623003
Cr-Commit-Position: refs/heads/master@{#476335}

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50 cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests

Unrelated presubmit script errors:
owners.SyntaxErrorInOwnersFile: /usr/local/google/git/chrome/chromium/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file.

NOPRESUBMIT=true

[1] https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/gtest/gtest-param-test.h?q=gtest-param-test.h+package:%5Echromium$&dr=C&l=1190

Review-Url: https://codereview.chromium.org/2906763005
Cr-Commit-Position: refs/heads/master@{#476334}

That way, Showcase and CSChromium can opt-out of Roboto and get San Francisco.

BUG=694948
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2912863005
Cr-Commit-Position: refs/heads/master@{#476333}

The #if guards on the function which records the linux distro are different to the guards on the function call. This results in the function being unused in the ozone build, which is a warning (turned into an error) causing the build to fail.

The fix is simply to unify the conditions of the #if guards.

BUG=724244
R=thomasanderson@chromium.org,rkaplow@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng

Review-Url: https://codereview.chromium.org/2917483002
Cr-Commit-Position: refs/heads/master@{#476332}

With PlzNavigate, the RenderFrameHost associated with a navigation is
known only at commit time. For this reason, in
ServiceWorkerHandler::OnWorkerVersionUpdated(), client's process_id(-1)
and route_id(-2) are invalid. They will be set to something meaningful
as soon as ServiceWorkerProviderHost::FinalizeInitialization will be
called with PlzNavigate, but it's too late.

The solution with PlzNavigate is to use a WebContentsGetter instead. In
this way, there is no need to know the RenderFrameHost.

BUG=725818
TEST=http/tests/inspector/service-workers/service-workers-redundant.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2917643002
Cr-Commit-Position: refs/heads/master@{#476331}

Will be used in mojoifying input messages.

BUG=722928

Review-Url: https://codereview.chromium.org/2915783003
Cr-Commit-Position: refs/heads/master@{#476330}

This change implements ImageData::CropRect() that crops the image data object to the given rectangle and flips if needed.

BUG=716136

Review-Url: https://codereview.chromium.org/2849643002
Cr-Commit-Position: refs/heads/master@{#476329}

Bug: 646711
Change-Id: I818eccf03f7b963004ee1464ba2504896a8272cf
Reviewed-on: https://chromium-review.googlesource.com/517676Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476328}

Ash is changed that LOGGED_IN_NOT_ACTIVE is treated as
a non user blocking state so that browser windows during user
sign-in are can be activated before login screen is dismissed.
However a side effect of that is modal dialog under this state
will be placed in SystemModalContainer instead of
LockSystemModalContainer and causing the issue. The CL skips
LOGGED_IN_NOT_ACTIVE during app launch so that dialogs created
during the app launch are placed to the correct container.

BUG=727951

Review-Url: https://codereview.chromium.org/2915943002
Cr-Commit-Position: refs/heads/master@{#476327}

Shift the welcome screen contents up to allow for correct spacing when
the full screen size is too small to align the contents in the center
and the bottom button with the button on the next screen.

BUG=721916

Review-Url: https://codereview.chromium.org/2914013002
Cr-Commit-Position: refs/heads/master@{#476326}

R=rch@chromium.org

Review-Url: https://codereview.chromium.org/2914223002
Cr-Commit-Position: refs/heads/master@{#476325}

The original version of this test would only pass if the service worker
did *not* intercept the XHR request. That behavior conflicted with the
Fetch and Service Worker specification and with the test's documentation
itself. Update the test to pass only if the service worker intercepts
the request.

In addition:

- Update URLs to suitable values for the Web Platform Tests project
- Add "use strict" directives to script bodies
- Increase precision of "cleanup" logic scheduling
- Re-name files to adhere to precent set by existing WPT tests
- Catch and report errors within Promise chain rather than relying on
  implicit reporting of uncaught errors.

BUG=688116, 602051
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2907443002
Cr-Commit-Position: refs/heads/master@{#476324}

The setting is only saved when the "Done" button is tapped, so
update the test to confirm this.

BUG=724030

Change-Id: Ia274bd3cf4058c766ef8dfa0b2e05279d34021e5
Reviewed-on: https://chromium-review.googlesource.com/521108
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476323}

Bug: 718063
Change-Id: Ib8a33d8eb2f931a50303b2efd0692755cf8e5ebf
Reviewed-on: https://chromium-review.googlesource.com/520725Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476322}

Using wpt-import in Chromium 3543d97c.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/136

Background: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Note to sheriffs: If this CL causes a small number of new layout
test failures, it may be easier to add lines to TestExpectations
rather than reverting.
Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: Ie7007ae595b681df80870b9bc4a9b759dfc8c24c
Reviewed-on: https://chromium-review.googlesource.com/520464Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476321}

BUG=661478

Review-Url: https://codereview.chromium.org/2908393002
Cr-Commit-Position: refs/heads/master@{#476320}

This CL revises adds metrics for stability instrumentation
collection on crash. The metrics can be used to estimate unclean
shutdown coverage in combination with postmortem collection (see
https://crrev.com/2883103002).

Additionally addresses a todo: sets the persitent allocator state to
deleted on crash.

BUG=620813

Review-Url: https://codereview.chromium.org/2910003002
Cr-Commit-Position: refs/heads/master@{#476319}

https://pdfium.googlesource.com/pdfium.git/+log/5be0b291bce2..e858aa4b70db

$ git log 5be0b291b..e858aa4b7 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 wileyrr Fix content generation to only generate dirty page objects.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If672b84ee0b34f4fc73f93fcf9722f83ce615469
Reviewed-on: https://chromium-review.googlesource.com/521223
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476318}

This CL was also going to fix a race condition in the existing implementation when SetTaskRunner() was used but the test-only failures caused by tests having long-lived
with the status quo are proving hard than expected to fix. The race is no worse than
before by making this code sequence-friendly (and generally healthier). Will fix
race in a follow-up CL.

Of note in this CL:
 - Patch set 1 is https://codereview.chromium.org/1433373003
   so looking at diff from 1 might be less work (especially for tests).
 - (not true anymore, postponed to race fix CL:)
   The Timer's delayed task now always lives on the sequence it was started from
   (and even SetTaskRunner() was used, a task is posted to it when the delay
    expires instead of having the Timer's delayed task live on it -- this solves
    the aforementioned race condition).
   - This required adapting tests for MediaCodecLoop and UploadProgressTracker.

BUG=587199, 552633, 678592, 684640, 675631

Review-Url: https://codereview.chromium.org/2491613004
Cr-Commit-Position: refs/heads/master@{#476317}

Bug: 726334
Change-Id: If9232ab19e8bd3e39732aa7ee5944b6d6e9298bb
Reviewed-on: https://chromium-review.googlesource.com/520042Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476316}

https://codereview.chromium.org/2367923002/ tries to change
build/config/mac/plist_util.py to fails if some variables
have no value while performing substitution.

Fix invocations of plist_util.py when building Chrome on iOS
to allow the change to plist_util.py.

BUG=650345

Change-Id: Ibbd38373d851bb418e0328f5113342cdbc3604e9
Reviewed-on: https://chromium-review.googlesource.com/521106Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476315}