GitLab

It is a dependency of Leak Canary, which I'd like to add next.

BUG=505909

Review URL: https://codereview.chromium.org/1261873003

Cr-Commit-Position: refs/heads/master@{#374846}

This CL changes the layout of the Language and Input
settings to more closely match the current mocks.
This CL also:
- makes .list-items 40px high at minimum
- removes languages_page.css

BUG=512479

Review URL: https://codereview.chromium.org/1691633002

Cr-Commit-Position: refs/heads/master@{#374845}

Revert of [libphonenumber] Change DEPS to track new github mirror, uprev library (patchset #6 id:200001 of https://codereview.chromium.org/1674373003/ )

Reason for revert:
Needs some tweaks to build on clang/win, see comment 24. (Checked with mathp on chat.)

Original issue's description:
> [libphonenumber] Change DEPS to track new github mirror, uprev library
>
> Changes to build files and include paths.
>
> BUG=585286,585244
> TBR=tedchoc

TBR=rouslan@chromium.org,tedchoc@chromium.org,mathp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585286,585244

Review URL: https://codereview.chromium.org/1687243002

Cr-Commit-Position: refs/heads/master@{#374844}

BUG=82385,579202
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/1688803004 .

Cr-Commit-Position: refs/heads/master@{#374843}

Trying to make things clearer with the following renames:

- Start -> OnSyncStarting
- FinishStart -> ReadyToConnect
- OnConnect -> ConnectSync
- Stop -> DisconnectSync

BUG=584486

Review URL: https://codereview.chromium.org/1671773002

Cr-Commit-Position: refs/heads/master@{#374842}

Changes to build files and include paths.

BUG=585286,585244
TBR=tedchoc

Review URL: https://codereview.chromium.org/1674373003

Cr-Commit-Position: refs/heads/master@{#374841}

gn's tool("solink") has two settings for the output of the rule:
link_output and depend_output. link_output is what targets depending
on a shared_library are linked against, and depend_output is what
is used for the ninja dependency.

On POSIX, this is used to implement a component build optimization:
If a shared library is linked but its public interface doesn't change, then
it's not necessary to relink its downstream dependencies. To implement
this, depend_output is set to a text file that contains a description of all
public symbols of the shared library. The link step first links and then
checks if the new public symbols are different from the old contents of
the file, and only then does it overwrite the TOC file. This allows ninja's
restat optimization to work.

However, downstream dependencies need to link against the actual .so
file on the link line `ld -o foo libinput.so`, so link_output needs to be set
to the .so file.

On Windows, link.exe writes a .lib and a .dll file when it creates a .dll file.
The .lib is only written when needed with incremental links, so if
depend_output is set to the .lib then the restat optimization works there
too. And downstream dependencies also need to link to the .lib at
link time, so in Windows both depend_output and link_output must
be set the the .lib file.

So far, so good. However, `gn desc runtime_deps` is used to print what files
need to be copied to swarming bots to run an executable, and that currently
looks at link_output. On POSIX that's ok, but on Windows that ends up
copying the .lib instead of the .dll.

This patch adds a third setting "runtime_link_output" which can be set
to the output of the solink tool that must be present at runtime. It defaults
to link_output (which does the right thing on POSIX), but it can be set to the
.dll file to make `gn desc runtime_deps` do the right thing on Windows.

This is needed to make swarming work in component builds on Windows.

BUG=354261, 498033
R=dpranke@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/1690843002 .

Cr-Commit-Position: refs/heads/master@{#374840}

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1684973002

Cr-Commit-Position: refs/heads/master@{#374839}

BUG=558575

Review URL: https://codereview.chromium.org/1682993002

Cr-Commit-Position: refs/heads/master@{#374838}

Remove AsyncResult::RESULT_FAILED_DIRECTORY. It's not used anywhere other than some code to communicate it to the webapp (where it's also not used).

Review URL: https://codereview.chromium.org/1687543004

Cr-Commit-Position: refs/heads/master@{#374837}

The site was added to the list in 2012. It became stale and the new site owner asked for it to be removed.

BUG=527947
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1681083005

Cr-Commit-Position: refs/heads/master@{#374836}

RendererImpl and MediaSourceDelegate wait for CDM to be available to start initialization if any stream is encrypted. Since CDM is available, we can simply pass the CdmContext down and thus avoid the SetCdmReadyCB/CdmReadyCB/SetCdm round trip.

Also decoder initialization will not be associated with CdmAttachedCB any more. Instead, we'll only handle it in RendererImpl and MediaSourceDelegate based on the result of audio and video Renderer/Decoder/DecryptingDemuxerStream initialization.

This CL is part 1 where all decoders/renderers are fixed. In the next CL (part 2), DecryptingDemuxerStream and MediaSourceDelegate will be fixed.

TBR=alokp@chromium.org,bbudge@chromium.org
BUG=580250
TEST=Updated unittests.

Review URL: https://codereview.chromium.org/1666653002

Cr-Commit-Position: refs/heads/master@{#374835}

Add a generic required_field_trials to FeatureSwitch that takes the
place of a singular field_trial_name. When deciding whether to enable or
disable a feature with field trials, all field trials will be queried
(though short circuiting can occur):
- If user is in "Enabled" group for all field trials, then enable
feature.
- If user is in "Disabled group for any field trials, then disable
feature.
- Otherwise, fall back to default value.

Change the MR FeatureSwitches to depend on the EAR field trial. Per
discussion, we will change the interpretation of MR field trial to
be "X% of users that have EAR field trial enabled".

BUG=541315

Review URL: https://codereview.chromium.org/1680823004

Cr-Commit-Position: refs/heads/master@{#374834}

Revert of Native SSID extraction moved to platform code on Android (patchset #8 id:140001 of https://codereview.chromium.org/1633733005/ )

Reason for revert:
Causes instant crash on Android KK, L, and M.

Original issue's description:
> On Android, move Wifi SSID extraction to a Java implementation
>
> On some Android devices, the device will restart right
> after the browser is launched. This is due to a kernel bug on
> these devices when using the Linux GetWifiSSID implementation,
> which causes a kernel panic and device restart.
>
> To avoid this, a Java-based implementation is used for Android
> devices, which avoids this. Examples of affected devices include:
> HTC One S
> Lenovo A820
> Asus ZenFone 2
> MediaPad 10 FHD
>
> R=bengr@chromium.org,rch@chromium.org
> BUG=555067
> TEST=Take the problem device, install browser and start it, wait for
> 10 seconds. Make 10 experiments, cleaning data before each run.
> Device should not reboot.

TBR=bengr@chromium.org,rch@chromium.org,rsleevi@chromium.org,ripp@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=555067

Review URL: https://codereview.chromium.org/1688103002

Cr-Commit-Position: refs/heads/master@{#374833}

BUG=NONE
TEST='gn check out/<DIR> ash' passes; ash target builds/runs as expected.
R=sky@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1684933002

Cr-Commit-Position: refs/heads/master@{#374832}

This was caused by relying on the default implementation of
IsInteractiveSetDefaultPermitted(). This CL also replace this
function with an explicit member variable.

BUG=583317

Review URL: https://codereview.chromium.org/1657933003

Cr-Commit-Position: refs/heads/master@{#374831}

This change hides the fullscreen button for videos in Reader Mode
and uses an empty implementation of ContentVideoViewEmbedder in case
it is somehow triggered. This is a temporary measure until a proper
fullscreen handler can be implemented.

BUG=581943

Review URL: https://codereview.chromium.org/1674753002

Cr-Commit-Position: refs/heads/master@{#374830}

BUG=510614
TEST=manually

Review URL: https://codereview.chromium.org/1673703002

Cr-Commit-Position: refs/heads/master@{#374829}

If you convert a 64-bit pointer directly to a 32-bit or smaller integer
then VS 2015 guesses (not unreasonably) that it might be an accidental
pointer truncation. The standard fix is to use a double-cast, to a
pointer-sized integer and then to DWORD.

This fixes a C4311 "pointer truncation" warning introduced by
crrev.com/1225183003

Warning C4312 (conversion from int to ptr of greater size) is suppressed
in this project but adding double-casts for the reverse conversion keeps
the code symmetrical and allows us to enable C4312 in the future.

BUG=440500

Review URL: https://codereview.chromium.org/1684963003

Cr-Commit-Position: refs/heads/master@{#374828}

This also fixes a small bug in the histogram recording of TabStripModelStatsRecorder::ActiveTabChanged() I spotted while doing this.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1675483002

Cr-Commit-Position: refs/heads/master@{#374827}

Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

BUG=none

Review URL: https://codereview.chromium.org/1685023002

Cr-Commit-Position: refs/heads/master@{#374826}

As described in crbug.com/524582, we observed a reduction in power
consumption when this format is used to display videos directly using
the WindowServer.

The downside of this format is that a conversion from YUV to RGB will
be performed on the GPU using GL when the VideoFrame has to be used
from GL.

BUG=524582

Review URL: https://codereview.chromium.org/1686443002

Cr-Commit-Position: refs/heads/master@{#374825}

This CL implements an explicit capture API that will be used for popups.

This is a split of the review: https://codereview.chromium.org/1605773004/
Where this review encompasses only the Window Server functionality. The client lib code is just stubs for compilation. Full implementation of the client will follow in a separate review.

TEST=EventDispatcherTest.SetExplicitCapture, EventDispatcherTest.ExplicitCaptureOverridesImplicitCapture, EventDispatcherTest.CaptureUpdatesActivePointerTargets, EventDispatcherTest.UpdatingCaptureStopsObservingPreviousCaputre, EventDispatcherTest.DestroyingCaptureWindowRemovesExplicitCapture
BUG=533161

Review URL: https://codereview.chromium.org/1677513002

Cr-Commit-Position: refs/heads/master@{#374824}

BUG=558738
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1690483002

Cr-Commit-Position: refs/heads/master@{#374823}

BUG=524582
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1688623002

Cr-Commit-Position: refs/heads/master@{#374822}

The FYI 'Chromium Mojo Android' bot is failing the apptests step:
https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android
..."MojoRunnerApptests.apk is neither a directory nor file"...

Also add other apptest targets from mojo:tests.

BUG=NONE
TEST=FYI bot gets closer to passing apptests step.
R=sky@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1683063003

Cr-Commit-Position: refs/heads/master@{#374821}

SQLite's Pager structure is for internal use only, whereas sqlite3_file
is a documented interface available to SQLite clients or extensions.
Where Pager accesses the page cache with fallback to the disk file,
sqlite3_file only accesses the disk file.  This should not have
significant performance impact (recover.c only reads a given block
once), but the new version may not see modified pages in the page cache.
For this reason, a shared lock is taken to guarantee that the on-disk
format matches anything in the cache.

BUG=584407

Review URL: https://codereview.chromium.org/1677193003

Cr-Commit-Position: refs/heads/master@{#374820}

After fixing the TODO, this test should fail with the current code, but will pass once http://crbug.com/585876 is fixed

Review URL: https://codereview.chromium.org/1683313002

Cr-Commit-Position: refs/heads/master@{#374819}

The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed,
but the flakiness seems not directly related to [1].
This CL temprarily disables the test to reland [1], because [1] fixes race
conditions.

[1] https://codereview.chromium.org/1641853003/

BUG=585026, 581565

Review URL: https://codereview.chromium.org/1680923003

Cr-Commit-Position: refs/heads/master@{#374818}

Initialize various compoments that chromeos expects (e.g. dbus, bluetooth etc.)
so that ash can launch correctly inside mus.

BUG=585141

Review URL: https://codereview.chromium.org/1685313002

Cr-Commit-Position: refs/heads/master@{#374817}

Reland of https://codereview.chromium.org/1683823002/

This improves build concurrency a little bit.

BUG=none

Review URL: https://codereview.chromium.org/1687723002

Cr-Commit-Position: refs/heads/master@{#374816}

This patch enables Oilpan data structures in the debug visualizers.
Since Oilpan was enabled by default, some m_ptr needs to change to
m_raw.

Review URL: https://codereview.chromium.org/1672483004

Cr-Commit-Position: refs/heads/master@{#374815}

R=sky@chromium.org, benwells@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1685883003

Cr-Commit-Position: refs/heads/master@{#374814}

Some other ones on this bug may be obsolete.

BUG=431213
TBR=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1683303003

Cr-Commit-Position: refs/heads/master@{#374813}

BUG=487937
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1663053006

Cr-Commit-Position: refs/heads/master@{#374812}

These were timing out for potentially two reasons:

  1. 50000 iterations takes a long time to run in Debug builds. We
     should investigate why this slows down so much over time.
     Bug 585909 is filed for that.

  2. If sending a message failed in a non-fatal way (e.g. EAGAIN) we
     were dropping the handles. Since this can happen flakily,
     the tests could block indefinitely waiting for handles that
     would never arrive.

This CL fixes the handle dropping problem and reduces the test to run
500 iterations of 50 handles each.

BUG=585784
TBR=sammc@chromium.org

Review URL: https://codereview.chromium.org/1686243002

Cr-Commit-Position: refs/heads/master@{#374811}

The animated-path-inside-transformed-html.xhtml suppression was
temporarily removed for http://crrev.com/1511113004.

BUG=581355
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/1688003003

Cr-Commit-Position: refs/heads/master@{#374810}

MaxScrollOffset is removed from LayerImpl so that updating scrolling info
does not need to touch LayerImpl unless a non-fast scrollable region is met
(this is also planned to be removed from LayerImpl when hit testing list
is available).

ScrollTree now stores information about layer bounds, scroll clip layer
bounds, bounds_delta and inner/outer viewport container/scroller layer info.

Also needs to push page_scale_factor to TransformTree when updated.

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1675963002

Cr-Commit-Position: refs/heads/master@{#374809}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1683913003

Cr-Commit-Position: refs/heads/master@{#374808}

BUG=585964

Review URL: https://codereview.chromium.org/1691613002

Cr-Commit-Position: refs/heads/master@{#374807}