GitLab

When N-up feature is enabled, we need to pass the pagesPerSheet
value to the pdf plugin, so that it can compute the number of
Nup pages and append appropriate number of blank pages.

In printing, 2-up, 3-up, or more generally N-up refers to a page
layout strategy in which multiple pages are composited onto a
single page.

Bug: 775999
Change-Id: Id8efc03c997ed7e2c643ec53f80747c2efa4719b
Reviewed-on: https://chromium-review.googlesource.com/1148989
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578345}

Adding user event data type to sync on iOS. Available only if unified
consent is enabled.

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8c01a40dd10e2aa61df65cad9ddfa6bb8881774
Reviewed-on: https://chromium-review.googlesource.com/1150140
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578344}

This is a reland of https://chromium-review.googlesource.com/1126244
which was reverted because it promoted a legacy bug which triggered
a 2D keyboard in VR mode.

The keyboard accessory is not enabled in VR mode.
There is a test to ensure that resetting that the sheet doesn't
trigger the keyboard unnecessarily anymore.

Original change's description:
> This CL causes the accessory sheet to close when a user selected a valid
> filling suggestions.
> There is no indicator of the negative case yet (i.e. error during
> filling).

TBR=rouslan@chromium.org

Bug: 856026, 857592, 865749
Change-Id: I71abca9366cfa96789ffe7538204f5435332e4ac
Reviewed-on: https://chromium-review.googlesource.com/1146361
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578343}

Bug:867836
Change-Id: I8fb770d92f6a87bc3a69e56d019341d58e7781b0
TBR=kouhei@chromium.org, ksakamoto@chromium.org

NOTRY=true

Change-Id: I8fb770d92f6a87bc3a69e56d019341d58e7781b0
Reviewed-on: https://chromium-review.googlesource.com/1151615
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578342}

Added tests for:
- object, embed,
- font
- style
- redirect
- report
- xslt
- sharedworker
- worker
- serviceworker
- track
- audio, video tests are unstable and will be available in my GH repo (https://github.com/mtrzos/wpt/tree/sec-metadata-media/fetch/sec-metadata)

Bug: 860710, 860715
Change-Id: I177dfe39629fb704e4e66a90981c279f4d8d8eb1
Reviewed-on: https://chromium-review.googlesource.com/1129238Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578341}

This CL is adding a trigger that randomly collect a sample memlog report.
These reports are used to compare high-memory usage reports with
common memory usage reports.

R=erikchen
BUG=867921

Change-Id: I2a05e0dac1184f34ffc32978cbcfc41170a5b665
Reviewed-on: https://chromium-review.googlesource.com/1151406
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578340}

Move all the UMA logging logic into a separate util file.
And make all relevant enums to enum classes.
No behavior changes.

Bug: 854314
Change-Id: If6035cc1ee86faa4f1aaf003318f72dc44660814
Reviewed-on: https://chromium-review.googlesource.com/1145768Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578339}

It is very common that iframes get clipped by a container on the
web. We previously marked any clipped iframes to require the slow path.

This CL checks if all transforms applied to an iframe preserve
isothetic alignment so that we can use a single accumulated clip
region as the hit test rect.

Bug: 825817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide233736b1cd375bc1b96172a3fa4cba5afc9a42
Reviewed-on: https://chromium-review.googlesource.com/1000135
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578338}

This object will be in charge to fetch the passwords for Manual Fill.
A Passwords Mediator will be the delegate and owner of it.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7e15656c4d9979aff5c86d79bab7a42e5161408b
Reviewed-on: https://chromium-review.googlesource.com/1148813Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578337}

The target chrome/installer/linux:calculate_deb_dependencies is broken
in the cros chrome-sdk shell build because is_linux is true in addition
to is_chromeos.

This change prevents the linux installer from being enabled when
is_chromeos is true.

R=gab@chromium.org

Bug: 867013
Test: none
Change-Id: I1596177528c35a4670fad52e62d56ad0ba104a16
Reviewed-on: https://chromium-review.googlesource.com/1150443Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578336}

Adds automated versions of VR manual tests involving Incognito tabs.

Bug: 861925
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I197b2940755ec92d648c35fb77a1f213e2b402f5
Reviewed-on: https://chromium-review.googlesource.com/1134508Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578335}

Change-Id: Ife1da1c63b1c2cd2b373c2aa6e349e82e1c6ee7b
Reviewed-on: https://chromium-review.googlesource.com/977949Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578334}

This CL implements the functions to load the data of the model type. In
particular, the function GetAllDataForDebugging() unblocks writing
unit-tests for further changes.

Bug: 853688
Change-Id: I6705ed3fd76b83fc59538c2d9e5b4f4a12b57436
Reviewed-on: https://chromium-review.googlesource.com/1151298
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578333}

This code changes no behavior. It's simply in preparation for changing
the autofill dropdown in the next CLs.

Change-Id: I682c245d728c8bf3e8d5c57139b02e28a326111a
Reviewed-on: https://chromium-review.googlesource.com/1147428
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578332}

https://skia.googlesource.com/skia.git/+log/f3ac64df1741..b5093bc9ede3


git log f3ac64df1741..b5093bc9ede3 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 benjaminwagner@google.com [infra] Add Metal to no_upload.
2018-07-26 robertphillips@google.com Maybe fix numStencilBits TSAN crash
2018-07-26 caryclark@skia.org avoid uninitialized under fuzzer


Created with:
  gclient setdep -r src/third_party/skia@b5093bc9ede3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:867314
TBR=benjaminwagner@chromium.org

Change-Id: I8b846218bf68424526b235de8dc3e9c415b76257
Reviewed-on: https://chromium-review.googlesource.com/1151212Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578331}

to point to the histogram with the higher maximum

Bug: 856467
Change-Id: Ie16d5190e008c7188ef4c9e4c60ef56a1c62d21f
Reviewed-on: https://chromium-review.googlesource.com/1148885
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578330}

The is just testing that ServiceConnection::BindModelProvider returns
successfully. The Mojo invitation won't go anywhere beyond the no-op
FakeMachineLearningClient D-Bus client.

To make this test compile, I had to fix an #include from an
overlooked file rename in an earlier CL ...

Bug: 863794

Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b
Reviewed-on: https://chromium-review.googlesource.com/1139942
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578329}

If SetFirstSetupComplete was called before engine initialization,
we'd record wrong UMA histograms and called DataTypeManager::Configure
with wrong configure reason.

The Yandex Browser wants to able to do this because in some signin scripts,
for example corporate browser, user do not need to change sync channels.
In this scenario RequestStart and SetFirstSetupComplete calls happpens
simultaneously.

Bug: 867451
Change-Id: Iec326c542476adf42c291cf2e002fc52e0a7b99d
Reviewed-on: https://chromium-review.googlesource.com/1150175
Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578328}

TimeZoneMonitorLinuxImpl is a ref counted type, and its first reference
used to be made by base::Bind implicitly. The reference was passed to
|file_task_runner_| and released on the task destruction.

However, if the PostTask failed or the posted task ran soon before
the ctor of TimeZoneMonitorLinuxImpl has finished, the instance is
destroyed immediately, and `new TimeZoneMonitorLinuxImpl` returns
a stale pointer.

This CL adds a static constructor to move the problematic ref
count manipulation out of the constructor.

Bug: 866456
Change-Id: I5000cfa493cabe8858f20517328fe1d6e27795ff
Reviewed-on: https://chromium-review.googlesource.com/1150959Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578327}

//chrome/browser/profiling_host/chrome_browser_main_extra_parts_profiling.cc
includes chrome/common/chrome_switches.h, which needs an generated
//chrome/common/buildflags.h, but corresponding BUILD.gn entry doesn't
have the deps to the //chrome/common target that generates buildflags.h.
As the result, chrome_browser_main_extra_parts_profiling.cc may be
compiled before buildflags.h is generated, and that causes a flaky
build failure.

This CL adds a necessary target to chrome/browser/profiling_host deps to
deflake the build.

Change-Id: Ia1938e682a1f4dd5a52d4d00993d0877000532ce
Reviewed-on: https://chromium-review.googlesource.com/1151044Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578326}

Don't need OS_CHROMEOS since this is only built on chromeos.

Bug: 777356
Test: this is the test.
Change-Id: I3088890e2ff8e5d11da1a487517c68c8e1eec720
Reviewed-on: https://chromium-review.googlesource.com/1144438Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578325}

Change-Id: Ib70d478a65996cadb1abe1c23b19197010215fec
Reviewed-on: https://chromium-review.googlesource.com/1150733Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578324}

I had created TestEventInjector in hopes of being able to get rid of
EventInjector, but that isn't possible. We rely on event injector for two real
world cases: autoclick (an a11y feature that can generate mouse clicks) and
for telemetry. Both of these need event injection enabled in production code.

The telemetry and autoclick cases don't care about being notified when
processing is completed, so I introduced a special function for this case. I
am doing this because the code needed to verify an event has been processed is
non-trivial, and I would like to avoid running it when possible.

BUG=852439
TEST=none

Change-Id: I2691151ffaa9b6519f7462582d0f1aadd2010850
Reviewed-on: https://chromium-review.googlesource.com/1150503
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578323}

https://aomedia.googlesource.com/aom.git/+log/0415f2e501a2..ef95278f79fa

$ git log 0415f2e50..ef95278f7 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 yunqingwang Add config flag to only enable normal tile mode
2018-07-25 debargha Add config flag to limit decoding profile
2018-07-24 wtc Add oss-fuzz test cases for invalid_file_test.cc.
2018-07-24 wtc Document how to make a new test data file public.
2018-07-24 ravi.chaudhary SSE2 optimization of aom_highbd_comp_mask_pred
2018-07-24 yuec Turn on wavelet energy modulated deltaq
2018-07-06 jimbankoski new aq variance
2018-07-24 ddvfinite Fix Visual Studio 12 build Error
2018-07-23 ddvfinite Refactor: remove useless include file
2018-07-13 niva213 lbd loopfilter 6,8,14 performance improvement
2018-07-20 ravi.chaudhary Enable tile-row based multi-threading in Encoder
2018-07-23 ravi.chaudhary Fix encoder multi-threading mismatch for superres
2018-07-20 ranjit.tulabandu Optimize interpolation filter selection
2018-07-18 ddvfinite Opt blend_a64_mask
2018-07-23 binpengsmail Speedup find_tx_size_rd_info
2018-07-20 weitinglin Fix the quality boost ratio between ALT2 and ALT in AOM_Q mode
2018-07-16 weitinglin Apply pyramid structures on GF length >= 4
2018-07-15 debargha DNN RD Model simplification and improvement

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=johannkoenig@google.com

cmake flags

Bug: 867619,867620
Change-Id: I9802b6b9beb8a827cb94b78083d6da94bf93e085
Reviewed-on: https://chromium-review.googlesource.com/1150903Reviewed-by: Urvang Joshi <urvang@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Urvang Joshi <urvang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578322}

Currently service_worker.mojom defines a [Native] mojom struct
content.mojom.PlatformNotificationData using the legacy IPC struct
traits for the native struct content::PlatformNotificationData.

However, there is already existing a mojom struct
blink.mojom.NotificationData which is typemapped with
content::PlatformNotificationData, it's exactly fit to our needs, so,
this CL starts to use blink.mojom.NotificationData then removes
the [Native] content.mojom.PlatformNotificationData and the
corresponding legacy IPC struct traits.

BUG=789854

Change-Id: I20549a8feb3575341661b92a5993bf758e6174e1
Reviewed-on: https://chromium-review.googlesource.com/1149714Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#578321}

This CL discards the pre-existing CanvasResourceProvider instance
if it is not of the right size when pushing a WebGL animation
frame.

BUG=866855

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibfa8924102dfcd2815a6010b0b9ada6c37fdd5ab
Reviewed-on: https://chromium-review.googlesource.com/1148685Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578320}

Both of these PerfBenchmarkTests have hard coded expectations of the number of
enabled features. This however causes these tests to fail whenever the
telemetry_perf_unittests suite is ran for any feature that is also controlled by
--enable-features.

This prevents properly running the suite while bringing up new features.

This change disables the tests on linux where we've been trying to run the suite
for VizDisplayCompositor.

However these tests can fail on any platform and should be revisited to verify
the flags that the test cares about.

TEST=PerfBenchmarkTest.testVariationArgs,
PerfBenchmarkTest.testVariationArgsReference

Bug: 844863
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I3cdd534fc63475c75f94e6e6a16e644efaa21779
Reviewed-on: https://chromium-review.googlesource.com/1151103Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578319}

Blacklisted credentials are special PasswordForm instances saved in PasswordStore, which record the user's choice never to store credentials for a given site.
When PasswordFormManager asks for all stored forms for a given PasswordStore::FormDigest(scheme, realm and origin), it suppresses all saving functions as long as there is at least one entry marked as blacklisted.

In particular, saving more than one blacklisted entry for a given scheme/realm/origin combination has no additional effect compared to just one. Nevertheless, duplicates could have been created by older versions of Chrome, and their frequency is measured by the PasswordManager.BlacklistedDuplicates histogram.

To avoid potentially confusing the user by copies of the blacklisted entries and also to avoid potential bugs when deleting just one blacklisted entry would keep the site blacklisted, this CL makes the PasswordStore prune duplicated blacklist entries on start-up.

Bug: 862930
Change-Id: I48d8919139c50c267053244573b70b246e9e99b2
Reviewed-on: https://chromium-review.googlesource.com/1140158
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578318}

Expose as IA2_ROLE_INTERNAL_FRAME, and do not used STATE_SYSTEM_READONLY or FOCUSABLE.

Bug: 867015
Change-Id: I310c3dc3fa1cede34b54d66a35c23ca4345b1ebd
Reviewed-on: https://chromium-review.googlesource.com/1148785
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578317}

This is a follow-up to CL:
https://chromium.googlesource.com/chromium/src/+/1fff44ec70ab202add6f06e6f8603637d265ccc4

BUG=789232

Change-Id: I703333249b0c06642647842b2c735424b795447f
Reviewed-on: https://chromium-review.googlesource.com/1150721Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578316}

Create new recordings for pages in pathological mobile sites to ensure
current sites are used for the rendering benchmark. Update URL for espn
and add login for linkedin.

Bug: 852530
Change-Id: I3f30d1b4daf7c4a850f8f759129f27be01a1751a
Reviewed-on: https://chromium-review.googlesource.com/1148949Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#578315}

Now that it's been a week since pages in top_real_world_desktop were
refreshed, remove the old pages. Also delete expectations for replaced
pages.

Bug: 852530
Change-Id: I3a702e877a56fe94a47add8b2254774d9c93fa28
Reviewed-on: https://chromium-review.googlesource.com/1150680Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#578314}

Displaying favicons with clear background, shrinking down to 16pt, and
changing default icon.

Bug: 860245
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I75e75d0bb21784441561e79a623002fdc2c95ae8
Reviewed-on: https://chromium-review.googlesource.com/1151111
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578313}

This replaces most remaining ThreadTaskRunnerHandle/SingleThreadTaskRunner
by SequencedTaskRunnerHandler/SequencedTaskRunner. There are some places
that actually need thread-affinity (e.g. network stuff), or where it makes
sense (UIModelWorker which is specifically for running on the UI thread).

One remaining place I'm not sure about is WeakHandle.

Bug: 846238
Change-Id: I704406fbf2c462537971eda0102c40626503b793
Reviewed-on: https://chromium-review.googlesource.com/1151296Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578312}

It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY
macro to define the global variable from which the key of a
WebContentsUserData is derived. The key is now derived from a static
local variable in WebContentsUserData::UserDataKey().
See https://chromium-review.googlesource.com/c/chromium/src/+/1093015

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 589840
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie374511b52899d367e12c89f8f78e7717b4d6b6f
Reviewed-on: https://chromium-review.googlesource.com/1150219Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578311}

It is no longer to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro
to define a global variable from which the key of a
WebContentsUserData is derived. The key is now derived from a static
local variable.

This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Bug: 589840
Change-Id: I7c899d2cfdb3a5c38f6d9a136b474c19f6370c71
Reviewed-on: https://chromium-review.googlesource.com/1150287Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578310}

https://webrtc.googlesource.com/src.git/+log/6031e69d34ff..17aff35e1dea


git log 6031e69d34ff..17aff35e1dea --date=short --no-merges --format='%ad %ae %s'
2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for sdk/ (part 1).
2018-07-26 nisse@webrtc.org Add missing include of stdint.h in MIPS code.
2018-07-26 hta@webrtc.org Add API to report "interesting" usage patterns to PC client


Created with:
  gclient setdep -r src/third_party/webrtc@17aff35e1dea

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:866792
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iea50bc810d2af73a791ecb4ce508258083db91a4
Reviewed-on: https://chromium-review.googlesource.com/1151249Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578309}

This reverts commit dab9cc04.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Picture-in-Picture: show buttons when the mouse is hovering.
> 
> This is fixing a Windows specific bug where the ENTER event isn't fired.
> 
> Bug: 867646
> Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9
> Reviewed-on: https://chromium-review.googlesource.com/1150892
> Reviewed-by: apacible <apacible@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578212}

TBR=mlamouri@chromium.org,apacible@chromium.org

Change-Id: Ied59d027a5fb261ac3c436dacf2ba074e05dc773
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867646
Reviewed-on: https://chromium-review.googlesource.com/1150703Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578308}

Prior to this CL, SurfaceDependencyTracker read activation_dependencies
from the pending CompositorFrame's CompositorFrameMetadata. This meant
that it had to look up already resolved dependencies. It's more efficient
to use the remaining dependencies set tracked in Surface directly. The code
is also more compact and easier to read.

In the first attempt to land, the CL iterated over activation_dependencies
as they were changing. This resulted in a crash. The solution is to
copy over the set before iteration.

Bug: 672962
Change-Id: I3264f75b3fc71d7cd0368a63fcd38f7afcaf1cb0
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1148226Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1150675
Cr-Commit-Position: refs/heads/master@{#578307}

Bug: 867719
Change-Id: I8f1368e86194c1732a7b7abb232cb137ea4ccf96
Reviewed-on: https://chromium-review.googlesource.com/1150978Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578306}