GitLab

Bug: 1160723
Change-Id: I5c12e4a0034f52aff475959832b0857ecbaf1525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625530Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843137}

Roll Chrome Win64 PGO profile from chrome-win64-master-1610538373-76fca52980f687d249587bbfe52df46587227f16.profdata to chrome-win64-master-1610549866-1e248feef781fb0cfb48b77513413e45541eeb72.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I25754d6f46baae1b6fa2efd83403f7b34049467e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843136}

Visit https://crbug.com/1163553#c12 for the context.


Bug: 1163553
Change-Id: Ib9ae405f1bfeb2bff552836cc83101d88d330ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611572
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843135}

Preparation for bundling the PDF Viewer's resources, step 2/3.

 - Add a pdf_viewer_wrapper.js top-level file, necessary to make tests
   work in both optimized_webui true/false modes
 - Update all PDF Viewer tests to import dependencies from the new
   file
 - Minor tweaks to keep Print Preview working, while using the same
   c/b/r/pdf/main.js file

Bug: 1163956
Change-Id: I92dde642f94edbcf08ff72c9cdb5c11bd9f7e8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625334
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843134}

This CL allows a copied image to be shrunk in order to fill the
contents area of a clipboard history menu item.

Bug: 1165286
Change-Id: I4ce2ce415021b04db4b5de67815791e5e052103f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627434Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Auto-Submit: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843133}

Now the placeholder image's bounds are smaller than the available
drawing area. It brings white lines around the placeholder image, which
might be caused by the rendering code (note that we draw the placeholder
image through gfx::Canvas's APIs) The specific reason is unknown yet,
still under investigation. Given that the paddings of the placeholder
image are not really needed, they are removed by this CL.

Bug: 1163621
Change-Id: Ibe309ea5044ab2c411917bb4ffd9d58c9d33bc5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627433
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Auto-Submit: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843132}

Bug: 959776
Change-Id: Id86d44b6fd42a06a072f73381ecc78b4a5905336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627159
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843131}

https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie6c59ffb0d15c5f0ac84cfafddbb703956048679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843130}

Create behavior which is responsible for initial focus on the screen.

Bug: 1165730
Change-Id: If9cf77761acd4a405202ead87cfb3caf952f338c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622394
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843129}

Refactored NTP offset starts negative because of the way the content
suggestions header are added on top of the feed. Fixes header
synchronizer by using additional offset property to compensate for the
negative offset.

Bug: 1114792
Change-Id: I62d2be34444d705e8ad7fd862ded80e9e947b783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626830
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843128}

Device attributes are used by the extension API
enterprise.deviceAttributes. This API is in the process of being
replaced by a new Web API. In both cases, we need to add a crosapi to
support this API in Lacros.

This CL adds plumbing for the five methods in
enterprise.deviceAttributes. From a security perspective, the Lacros
implementation checks that the profile is the "main profile" -- which is
to say it's affiliated with the log-in ash-chrome proifle. The ash
implementation of the crosapi then checks that the profile is a regular,
sign-in profile that is affiliated with the device. These security
checks mimic the security checks for the existing ash implementation of
enterprise.deviceAttributes.

Change-Id: Ic4bd2ce88041a3bc7b2af94fa52fef2f0722aac7
Bug: 1164523, 1165882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623722
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843127}

There are cases where the IME tries to replace the characters that
are in the middle of grapheme cluster and in those cases
|VisiblePositions| adjust the positions to not be at the middle of
grapheme clusters. Thus this ends up replacing/duplicating characters
in many languages such as Devanagari, Tibetan, Burmese etc.
In this patch we are using the |SelectionInDOMTree| instead which has
the correct node and offsets which is used to place the positions in
the middle of grapheme cluster and perform the composition operation
correctly. Also added logic to not remove the existing TypingCommand
when a composition is in-progress.

Bug: 621394, 1020371

Change-Id: I6472ce2e2e34b43ec3e385a2874dee29a158f5ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619002
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843126}

Introduced packager_vars.star so that properties will be the shared
between CI and matching try builders.

Also reorg the following builder to use a similar starlark structure:
* android-androidx-packager
* android-avd-packager
* android-sdk-packager

Bug: 1132368
Change-Id: I8001cfa818c2e647cc513e46a2f166fbe1e253df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625271
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843125}

Motivation:
Currently, we allow all mime-types except for pdf as Payment Handler
pages. This exposes payment handlers to the vulnerabilities of certain
less-maintained mime-types. Since "text/*", "image/*", "video/*",
javascript, xml, json could satisfy a majority of use cases, this CL
allowlist the supported mime-types for payment handlers.

Before, we disallowed the "application/pdf" mime-type for
payment-handler pages.

After, we allowlist the following mime-types for payment handler pages:
* text/*
* image/*
* video/*
* application/javascript
* application/xml
* application/json

Before, we applied the throttle to mainframes.

After, we apply the throttle to all frames.

Bug: 1165367, 1165392
Change-Id: Ie69e296dc2c287c38a10ed08c1c40527f941ee47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622871
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843124}

Adds additional timing metrics for the mute notifications feature:
- How much time passes before the user takes an action on the
  notification
- How long a screen capture session lasts
- How much time passes from start of a session until the user reveals
  notification content again

Bug: 1131375
Change-Id: I70e99cfe5f5726c4372930df84b3a90c37970629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617942Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843123}

Bug: None
Change-Id: I39c221fd574b9d19fe0d9cbabf81769644823e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627142Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843122}

Bug: 1155308
Change-Id: I6dc2ef187ccd5ab06b6b9b27b9d6ee2880ca8489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617203Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843121}

Switch to PartitionAlloc for malloc() on Android. According to dev
experiments, this is either neutral or a win for memory, performance and
stability, with the exception of median GPU process footprint, which
regresses by a small amount, but is being addressed.

Note to sheriffs: If something breaks in this range on Android, this CL
                  is a likely culprit.

Note to perf sheriffs: This is expected to move a lot of performance
                       metrics, in both directions.

For details, see linked bugs, and for performance data from experiments,
https://docs.google.com/document/d/1asZy8Dy0m97AECTTU2jTbgwc-mwI9BLOMVYKKiQAp04/edit
(Google internal).

Bug: 1121427, 998048
Change-Id: Ice8d5c65e814a3086d121f8e8641f874d6b9e68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625869
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843120}

We make a few simple changes to help diagnose the crash occurring in
https://crbug.com/1162157:

1) Reset the URL loader and stream parser before invoking the callback
   to ensure we stop streaming before any callback side effects occur.
2) Add a CHECK to OnDataReceived() to ensure the stream parser is not
   null. Will change to DCHECK when the crash is resolved.
3) In the stream parser, use the native StringPiece methods to get
   the underlying data and string length.
4) Add additional VERBOSE logging to ReceiveMessageExpress.

I'm skeptical that these changes will fix the crash, but they will
help eliminate some possibilities.

Bug: 1162157
Change-Id: Ic1eef5c4bf0d047c66420aad29cbd3d93992ba05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627564
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843119}

Back in https://crrev.com/c/2485936 a new flag in ExtensionSettings
policy was added. Since name of the flag was changed during the
discussions, unfortunately, in parsing code and in policy scheme it
landed with different names (override_update_url vs
update_url_enforced).

This CL fixes this.

Bug: b:177419604

BYPASS_POLICY_COMPATIBILITY_CHECK=update_url_enforced is the wrong name for the flag and wasn't used anywhere

Change-Id: I3df2247f0a75d8737425dba1d4ceb88763326693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627319
Auto-Submit: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843118}

This metrics is being adding to show trends in user behavior when
accessing the reading list. We want to find out whether the user is on
the NTP (where the bookmarks bar is always visible) and the status of
the bookmarks bar pref (shown/hidden) when a user accesses the reading
list.

Bug: 1163938
Change-Id: Ie846717e1dca5b217f234d35ef74213623ccf665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622990
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843117}

A new tracing category was introduced in https://crrev.com/c/2595436.

Bug: chromium:1084929
Change-Id: I9327c3375dfd65727f6d5a81bf1efcf51eda90cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627398Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843116}

A small change in ConnectorsService is required to make this test config
work. When checking analysis/reporting settings, 2 things are required
to obtain settings: a policy set to a valid value and a DM token (from
the browser or the profile). The previous implementation checked the DM
token first, meaning the blocking BrowserDMTokenStorage::RetrieveDMToken
call would trigger on multiple tests and crash them (see patchset 1
failures for examples of this).

The solution is to simply switch the
order of checks and read the policy first. This is also a valid
optimization of Connectors logic, as reading prefs is faster than
potentially reading the DM token from local storage.

Change-Id: Ie1026b57cf7a4fd66663530ec2a77a72f21d6d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623812
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843115}

Previously, when DestroyProfileOnBrowserClose was enabled, the last-used
profile could get deleted. This would leave Chrome in a state where no
profiles were loaded at all, but the Chrome process is still alive.

Some codepaths assume that GetLastUsedProfile() returns a loaded
Profile. This patch makes AppController hold a ScopedProfileKeepAlive
when there's only 1 Profile loaded. This prevents that Profile's
deletion, so GetLastUsedProfile() works as expected.

Bug: 88586
Change-Id: I128933003cd708500457ddf8d55b8dfecbcab29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593749
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843114}

Was missed on a prior expectations update.

Bug: angleproject:5499
Change-Id: I7dbfc0061daf03ca149345f00b620a35095c9d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625992
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843113}

Bug: 1144151
Change-Id: Ie836759be36fc86e9a3b15b2ee2b6c086bc2f890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625227Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843112}

We are still getting useful data from these. Pushing the deadline of
Canvas.TextMetrics.SetFont and OffscreenCanvas.TextMetrics.SetFont
by another year.

Bug: 1165020, 1160818

Change-Id: Ifa9124c3ceb383d5b15064c2eb8cb42443982339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622098Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843111}

There are actually two issues fixed by this CL. The first is the tab
strip reappearing after backgrounding/switching dark mode. This happens
because the BVC currently just sets the hidden status when revealing the
thumb strip and when the trait collection changes, so unhiding on trait
collection change overrides the hiding from revealing the thumb strip.
This is fixed by tracking these two separately in the tab strip
controller and using both to determine the overall hidden state.

Second is the thumb strip breaking on backgrounding. This happens
because I slightly misunderstood the UIGestureRecognizerDelegate.
-gestureRecognizerShouldBegin: doesn't necessarily mean WILL begin, so
the |currentRecognizer| should only be set once the pan gesture
actually begins.

Fixed: 1166020, 1165984
Change-Id: I177231f8be13fbc372358b2648a5a0d0a15d7f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626390Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#843110}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41a30fd36cbe..d8d98e1b9627

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mpearson@google.com,fdoray@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1165897
Tbr: mpearson@google.com,fdoray@google.com
Change-Id: Ia76c499bd1f4c780cf7d723045defe0f86dcdb57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627621Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843109}

https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..59abfbcd2b03

2021-01-13 lalitm@google.com Merge "tp: don't propogate constraints on tables with left/outer span join"
2021-01-13 hjd@google.com Merge "ui: Limit bug filing links to 8kb"
2021-01-13 fmayer@google.com Merge "Dynamically decrease sampling rate when buffer fills."
2021-01-13 treehugger-gerrit@google.com Merge "tp: strip on all Android targets"
2021-01-13 treehugger-gerrit@google.com Merge "tp: remove unnecessary stripping script"
2021-01-13 treehugger-gerrit@google.com Merge "traced: add statsd instrumentation"
2021-01-13 fmayer@google.com Merge "Make names of malloc hooks / preload more descriptive."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ie746ac95cc14ba1c1123fac03a40a59dfec3bf86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627617Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843108}

This would help developers understand how costly the TPM ownership
process is in real life.

For the corresponding ChromeOS change, see CL:2619438.

BUG=b:176463814
TEST=build ok.

Change-Id: I1bde763f3d776c16abc86ab4ddb4d340f37c3159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619359Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Leo Lai <cylai@google.com>
Cr-Commit-Position: refs/heads/master@{#843107}

Bug: 1154370
Change-Id: Idba34c7fdf87f561747fc9ca7d37656aaffe2886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626125
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843106}

Credit cards can now be saved to the account for all signed-in users
(no Sync required), so promoing Sync after a credit card save doesn't
make sense anymore. This CL deletes the code for that promo.

Bug: 1139330
Change-Id: Ie2512fd8239a9ee05682c29a4ddaba1717220061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618338
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#843105}

https://crrev.com/573558 accidentally reversed the polarity of a test
such that loading of an XML document by the XSLT processor would stop
if a chunk parsed successfully instead of stopping if the chunk failed
to parse.

This CL corrects the break condition.

Bug: 1165774
Change-Id: Ic37c7f9939e1357bf816810f23169603c43cdd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625089
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843104}

In this CL, when the mouse click on the main button or the delete button
is canceled, the menu selection is refreshed by:
(1) Select the menu item hovered by mouse if any; otherwise,
(2) Select the root menu item to cancel the selection on a child item.

Bug: 1165999
Change-Id: I86bebc2b1dc08665a98da366a6a6bdb9fab532d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625798Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843103}

Bug: 1101837
Change-Id: I21f981c1b5c154ca68d3e310653a9485d7e903ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617847
Commit-Queue: James Cook <jamescook@chromium.org>
Owners-Override: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843102}

With use_thin_lto, needs_stack_alignment is false, so `defines`
wasn't, uh, defined when adding PREFIX to it.

Bug: none
Change-Id: I08ddd80386fce17bfd5b135b6a075d7f3bd0cf12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626774
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843101}

The previous fix http://crrev/c/2562059 isn't very correct:
1) It introduced menu flickering because the icons could be set after
   the menu is already showing.
2) Even after a pre-warming, the second #loadDrawableAsync() call could
   still be slow, so the icons doesn't show sometimes.
3) An internal Android framework change made the situation worse that
   sometimes the menu item won't send the intent. Because the menu item
   can change its icon from null to an actual drawable, but the
   framework code made the assumption that the menu item won't change.

This fix moves the icon loading work to the same background task for
the smart text classification task, after we get the classification
result. In this way we could have a deterministic
icon loading result while not violating the strict mode rule.

Fixed: 1129211
Change-Id: I7c35d8221bf57bd8ed68295f797d5bd6871dbae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626461Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843100}

This will call WebMeasureMemory randomly after a page load, and discard
the results, to check for crashes. It is controlled by an experiment
feature ("StressTestWebMeasureMemory") that will only be enabled for
some Canary users.

Also removes some unused headers from performance_manager_lifetime.cc.

Bug: 1085129
Change-Id: I32f24d4bf35032dea26b672a4fa899c5bf182cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627360Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843099}

Bug: 1081222
Change-Id: Ifc710417bd6a26b72de1168f06820fab1df7d127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612951
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843098}