GitLab

TBR=dtrainor@chromium.org

BUG=673279

Review-Url: https://codereview.chromium.org/2569013004
Cr-Commit-Position: refs/heads/master@{#438130}

Previously, last_visit_date metadata has was removed by
BookmarkSuggestionProvider via ContentSuggestionService::ClearHistory()
which only works on Android. This CL makes the removal platform-
independent. It aims at simplicity to make is easier to merge to M56
(and does not fix the pre-existing TODO).

The data is collected outside of BookmarkSuggestionProvider (by a tab
helper). Previously, the tab helper was only instantiated on Android.
Since M56 the tab helper is created and we thus collect the data on all
desktop platforms as well. For this reason, we also need to fix the
browsing data removal.

BUG=673268

Review-Url: https://codereview.chromium.org/2566123002
Cr-Commit-Position: refs/heads/master@{#438129}

We display various visual tab indicators but there is no corresponding indicator for accessible labels. The updated accessible label is in the format of:

Page title - Tab status

For tabs in incognito this is a format:
Page title - Tab status (incognito)

BUG=635610

Review-Url: https://codereview.chromium.org/2497373003
Cr-Commit-Position: refs/heads/master@{#438128}

The proposed spec for BudgetAPI defines the return value for getBudget
to be a Promise that resolves with a sequence<BudgetState> while the
current interface used a FrozenArray.

This patch updates the code to match the proposed spec. The implementation
works with either version, and this is covered by existing LayoutTests.

BUG=672112

Review-Url: https://codereview.chromium.org/2571573002
Cr-Commit-Position: refs/heads/master@{#438127}

The tests in these cases can pass only if Quit is called before Run, or
if Run is never called at all. If this is guaranteed to hold true, then
RunLoop is not needed (such as in timer_unittest.cc). Other cases (where
it is not guaranteed) are tests that can crash occasionally.

BUG=668707

Review-Url: https://codereview.chromium.org/2571473002
Cr-Commit-Position: refs/heads/master@{#438126}

This implements heap compaction for the Blink GC infrastructure
(Oilpan), compacting the arenas of the BlinkGC heap which are most
susceptible to becoming fragmented during actual use.

Fragmentation is a real problem and a growing one while browsing anything
but static pages: the amount of unused, but allocated, memory is
fluctuating higher over time.

To avoid leaving increasing amounts of unused holes in our heaps,
heap compaction will periodically squeeze out the unused portions,
packing together the live objects. The heap pages that are then
left as unused, are subsequently released and returned to the OS.

Due to a fortunate property of Blink heap collection types, providing
such compaction is within relatively easy reach. Experiments show that
the arenas which hold such collection objects ("backing stores") are
the ones that develop fragmentation the most & persistently. While not
a complete heap compactor of all Blink GC arenas, it addresses the
fragmentation problem where it is most pressing. More can be done, later.

Explainer / design document:

 https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU

R=haraken
BUG=672030

Review-Url: https://codereview.chromium.org/2531973002
Cr-Commit-Position: refs/heads/master@{#438125}

https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/d0c70649064f..3166d8be97c9

$ git log d0c706490..3166d8be9 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 tobiasjs Fix unit tests expecting no output when a microdump is suppressed.
2016-12-10 mpercy Fix sign-compare compiler warning in MicrodumpWriterTest
2016-11-23 vapier crash_generation: fix bad call to close

R=primiano@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2568713004
Cr-Commit-Position: refs/heads/master@{#438124}

DOMWindowProperty::frameDestroyed is now equivalent to ContextLifecycleObserver::contextDestroyed.
This CL does the replacement for InstalledAppController.

BUG=610176

Review-Url: https://codereview.chromium.org/2571513003
Cr-Commit-Position: refs/heads/master@{#438123}

Resolved a TODO: The testing::variations::VariationParamsManager
replaces a mock.

In order to enable Feature-associated params, the tested RequestBuilder
needed to be mocked. Since CL 645447, Feature-association works now and
exposing implementation details and mocking is now unnecessary.

BUG=634892

Review-Url: https://codereview.chromium.org/2552813005
Cr-Commit-Position: refs/heads/master@{#438122}

BUG=460722
NOTRY=true

Review-Url: https://codereview.chromium.org/2569173002
Cr-Commit-Position: refs/heads/master@{#438121}

Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade.

TBR=miguelg@chromium.org

BUG=673385

Review-Url: https://codereview.chromium.org/2571773002
Cr-Commit-Position: refs/heads/master@{#438120}

R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=539572

Review-Url: https://codereview.chromium.org/2565383002
Cr-Commit-Position: refs/heads/master@{#438119}

BUG=666756
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2572683002
Cr-Commit-Position: refs/heads/master@{#438118}

Reland of strict transmission of external exp ids to signed in users. (patchset #1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users. (patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
>
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
>
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuilds=100
>
> e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/35779
>
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
>
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> > TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
>
> TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
>
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2575483002
Cr-Commit-Position: refs/heads/master@{#438117}

This allows significant cleanup of CSSCursorImageValue, so do that too.

Intent-thread:

 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/r0lnh5Rw23M

TBR=timvolodine@chromium.org
BUG=650598

Review-Url: https://codereview.chromium.org/2522443002
Cr-Commit-Position: refs/heads/master@{#438116}

TBR=changwan@chromium.org

BUG=673588

Review-Url: https://codereview.chromium.org/2574713002
Cr-Commit-Position: refs/heads/master@{#438115}

We're deprecating DOMWindowProperty, which is now equivalent to ContextLifecycleObserver.
This CL replaces DOMWindowProperty with ContextLifecycleObserver in PresentationController.

BUG=610176

Review-Url: https://codereview.chromium.org/2569963003
Cr-Commit-Position: refs/heads/master@{#438114}

The test has been flaky on Linux/ChromeOS.

TBR=msramek@chromium.org

BUG=624836

Review-Url: https://codereview.chromium.org/2569083002
Cr-Commit-Position: refs/heads/master@{#438113}

Check each second for the loading of the page.
It must reach 25%, 50% then 75%.
If one test fails, load distilled version.

BUG=673658

Review-Url: https://codereview.chromium.org/2572583003
Cr-Commit-Position: refs/heads/master@{#438112}

And, also include noto-cjk

BUG=None
Test=None

Review-Url: https://codereview.chromium.org/2540343003
Cr-Commit-Position: refs/heads/master@{#438111}

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645

Review-Url: https://codereview.chromium.org/2565983002
Cr-Commit-Position: refs/heads/master@{#438110}

This patch splits MockResourceClients into MockResourceClient and
MockImageResourceClient, because MemoryCacheTest and ResourceFetcherTest
just need MockResourceClient and do not want to depend on
MockImageResourceClient that has a dependency to ImageResource.

BUG=655920

Review-Url: https://codereview.chromium.org/2559703002
Cr-Commit-Position: refs/heads/master@{#438109}

The ScopedFocusNavigation class, which is used internally for
keeping state of traversing next/previous focusable element in a
scope, could become inconsistent state that the current element
of the scope does not point to the element that is being traversed.

Specifically, such situation happens when
nextElementWithGreaterTabIndex() and previousElementWithLowerTabIndex()
are called. These functions moves the current pointer within the
whole scope and when the function finishes, all elements are
exhausted and the current pointer will be null, while it can
return some element inside the scope.

Therefore, in findFocusableElementRecursivelyForward() and
findFocusableElementRecursivelyBackward(), both of which
has a loop

  while (found) {
    ...
  }

and inside the loop, the following pattern

  found= findFocusableElementInternal();
  continue;

can be affected by this inconsistency, because
findFocusableElementInternal() can end up calling those
problematic functions.

This CL also refactors the ScopedFocusNavigation class a bit,
to hide these traversal state within the class, and it now
exposes only "findFocusableElement(forward or backward)" API
for traversing.

BUG=671428

Review-Url: https://codereview.chromium.org/2562753003
Cr-Commit-Position: refs/heads/master@{#438108}

1. if transformList is the empty string,
 set in to the string "matrix(1, 0, 0, 1, 0, 0)".
2. Parse transformList by following the syntax description[1].
 if parsing failed, throw SyntaxError.
3. Set is2D to false if the <transform-list> consists of any 3D
 Transform functions. Otherwise set is2D to true.
4. Transform all <transform-function>s to 4x4 matrices.
5. Post-multiply all matrices from left to right.
6. Return the result of invoking create a matrix of type
 DOMMatrixReadOnly or DOMMatrix as appropriate.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-transformlist
[1] = https://drafts.csswg.org/css-transforms-1/#svg-syntax

BUG=388780, 660819

Review-Url: https://codereview.chromium.org/2516973002
Cr-Commit-Position: refs/heads/master@{#438107}

exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that already is associated with a device configuration object.

BUG=670247

Review-Url: https://codereview.chromium.org/2567903003
Cr-Commit-Position: refs/heads/master@{#438106}

No generated code is changed
spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode

BUG=662005

Review-Url: https://codereview.chromium.org/2570433004
Cr-Commit-Position: refs/heads/master@{#438105}

Today, we accidentally add dynamically added inline stylesheets in the
navigator view. They are displayed as "(index)" styles, and bring in
confusion.

This patch makes sure we don't create a UISourceCode for stylesheet
unless it have a url.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2565343003
Cr-Commit-Position: refs/heads/master@{#438104}

This is a preparation step for typed events, which will not inherit from Common.Event.

BUG=none

Review-Url: https://codereview.chromium.org/2562453003
Cr-Commit-Position: refs/heads/master@{#438103}

The function is unused now. It was used in PrerenderLocalPredictor before, which
was removed at http://crrev.com/325673.

BUG=none

Review-Url: https://codereview.chromium.org/2569763002
Cr-Commit-Position: refs/heads/master@{#438102}

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman

Review-Url: https://codereview.chromium.org/2571713002
Cr-Commit-Position: refs/heads/master@{#438101}

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659

Review-Url: https://codereview.chromium.org/2573473002
Cr-Commit-Position: refs/heads/master@{#438100}

We rarely handle all attributes in a loop.
Instead, we have filters to iterate only on accessors,
on data type attributes, so on.
It is very confusing to have all attributes in a
variable in .py and filter them in .tmpl files.

This CL applies such filters in pre-process in .py
and uses more descriptive names in template contexts.
It keeps 'attributes' for some usages, which are
to be replaced.

This is a refactoring in template engine, so it
does not change generated code.

BUG=650150

Review-Url: https://codereview.chromium.org/2568403002
Cr-Commit-Position: refs/heads/master@{#438099}

BUG=635908

Review-Url: https://codereview.chromium.org/2566203002
Cr-Commit-Position: refs/heads/master@{#438098}

Reason for revert:
Test is no longer flaky.

Original issue's description:
> Disable flaky test
>
> ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
> detected to be flaky by chromium-try-flakes.
>
> TBR=lizeb@chromium.org
>
> BUG=673028
>
> Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab
> Cr-Commit-Position: refs/heads/master@{#437907}

TBR=asargent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673028

Review-Url: https://codereview.chromium.org/2575453002
Cr-Commit-Position: refs/heads/master@{#438097}

Chrome build fails when use_ozone is true.

R=sky@chromium.org, warx@chromium.org
BUG=496681

Review-Url: https://codereview.chromium.org/2562233002
Cr-Commit-Position: refs/heads/master@{#438096}

Cr-Commit-Position: refs/heads/master@{#438095}

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2552163003
Cr-Commit-Position: refs/heads/master@{#438094}

BUG=555132

Review-Url: https://codereview.chromium.org/2566873002
Cr-Commit-Position: refs/heads/master@{#438093}

These were added & used on the CrOS side, but not documented here.

BUG=599960

Review-Url: https://codereview.chromium.org/2572633002
Cr-Commit-Position: refs/heads/master@{#438092}

TBR=nasko@chromium.org,waffles@chromium.org
BUG=672652

Review-Url: https://codereview.chromium.org/2565853003
Cr-Commit-Position: refs/heads/master@{#438091}