- 25 Sep, 2018 40 commits
-
-
Vladimir Levin authored
When we specify will-change: opacity, it is a hint to the browser that opacity will change. In order to make this perform well, we should induce an effect node so that we don't have to repaint when the opacity actually changes. This patch makes it so. R=pdr@chromium.org, wangxianzhu@chromium.org Bug: 886389 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If0979d48f322564d61ad8434eb4435fc8e8f2602 Reviewed-on: https://chromium-review.googlesource.com/1240993 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594115}
-
Stephen Chenney authored
The paint team has no insight into what proportion of the Blink complete main frame time is spent in Blink lifecycle operations vs. script required updates vs. other tasks. This CL adds metrics that will allow for identifying the proprtion of main frame time taken by various operations. Bug: 869966 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc73dc6efd1aef5e65df647bc48de84384dba0c8 Reviewed-on: https://chromium-review.googlesource.com/1179995Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#594114}
-
James Cook authored
AXAuraObjCache::GetOrCreate(View* view) can return null if the View is not yet associated with a Widget. The shortcut viewer creates a ScrollView that creates a FocusRing before the ScrollView is attached to the Widget. Do what AutomationManagerAura does in this case and just don't send accessibility event updates for these unattached views. Bug: 889121 Test: added to views_mus_unittests Change-Id: Ica14908778e45b9b4ee06077bd31c92fb7dfca62 Reviewed-on: https://chromium-review.googlesource.com/1244456Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be0a57bc9068..29788f1ac1da Created with: gclient setdep -r src-internal@29788f1ac1da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib23f9c4362ab5ea4dbd10bbbcdef4830dd57bdb1 Reviewed-on: https://chromium-review.googlesource.com/1244162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594112}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b36a4816a546..299bdfe75173 git log b36a4816a546..299bdfe75173 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Update AMD suppressions. Created with: gclient setdep -r src/third_party/angle@299bdfe75173 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ica8d861ce6d637b976fe7f9eda34a66ff48cb4a0 Reviewed-on: https://chromium-review.googlesource.com/1244139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594111}
-
Ryan Sturm authored
This reverts commit bc94af5f. Reason for revert: <INSERT REASONING HERE> Original change's description: > Updating blacklist/README.md > > This reflects changes in > https://chromium-review.googlesource.com/c/chromium/src/+/1225095 that > added Bloom filter to the blacklist component. > > Change-Id: Icfb9e266a54c88c5306811feec07d30df0a63680 > Reviewed-on: https://chromium-review.googlesource.com/1225491 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591204} TBR=dougarnett@chromium.org,ryansturm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I3c7417dd04e78e437928b432b7100d21c92631de Reviewed-on: https://chromium-review.googlesource.com/1244400Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#594110}
-
Tanya Gupta authored
R=ramyan@chromium.org Change-Id: I72f5f094f4f637d324c1fbbd66cdbc39f4327f6f Bug: 882691 Change-Id: I72f5f094f4f637d324c1fbbd66cdbc39f4327f6f Reviewed-on: https://chromium-review.googlesource.com/1241837Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#594109}
-
Jared Saul authored
This also blocks presubmits on CL 1236291, so I'm resolving it separately beforehand. Tested that local and upload credit card save still both work correctly on Linux. Bug: 852562 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6a01f8215e235c3d4bb265a0f471d653cb02c517 Reviewed-on: https://chromium-review.googlesource.com/1237615Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#594108}
-
Sarah Hu authored
Bug: 853869 Change-Id: Ic4891374c8903090b768a7c312767d2131e21c14 Reviewed-on: https://chromium-review.googlesource.com/1132528 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#594107}
-
Lei Zhang authored
Change-Id: Ie933e1e1690b3dbd6cef7599c59492fbeeaf8cf9 Reviewed-on: https://chromium-review.googlesource.com/1244157Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594106}
-
Eugene But authored
This makes iOS consistent with other platforms that use reload transition type to avoid incorrect increase for typed count. Bug: 888011 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7fe963391c00c077bd41bd3235e93396046939ce Reviewed-on: https://chromium-review.googlesource.com/1243573 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594105}
-
Ken Rockot authored
Incoming messages are stored in a std::vector which we never shrink when popping off elements. This means its capacity may be allowed to grow indefinitely, which is bad. This CL adds a check when popping messages off the queue, calling shrink_to_fit() if the operation results in the queue crossing an arbitrary size threshold (multiples of 512 elements). Bug: 888665 Change-Id: Ie2b89a2104bcd6d3eece29c339e297cdadbd837b Reviewed-on: https://chromium-review.googlesource.com/1241561 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594104}
-
Ian Clelland authored
This CL handles the features which are trivially migratable from calling (Deprecated)IsFeatureEnabled on Frame to calling the equivalent method on Document. Bug: 888668 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If7c548afd9974f83c86cbcb9876cb51654bb3267 Reviewed-on: https://chromium-review.googlesource.com/1243365 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594103}
-
Erik Luo authored
- Use ArrowLeft/Right to expand/collapse console.group's and traces (console.trace, console.error, console.warn) - Click listener for Groups now added to each message element. Bug: 865674 Change-Id: Ifa8156d8f0a01a541e40a5cf84aaa59a4a0329f9 Reviewed-on: https://chromium-review.googlesource.com/1237614Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#594102}
-
Xiaohan Wang authored
CdmAdapter is the host of the library CDM. To investigate CDM related issues, especially subtle timing-related issues, it's better to have better logging in CdmAdapter. Bug: 883003 Change-Id: I13d5f34ea370f3802f8e8beff84e4c9df0dbd8ca Reviewed-on: https://chromium-review.googlesource.com/1238823Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594101}
-
Maxim Kolosovskiy authored
This CL doesn't add second form signature calculation. What should be included in the second form signature is to be researched more. See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1221248 Bug: 552420 Change-Id: I79c9d27995233943fb704bec5268f97941475c21 Reviewed-on: https://chromium-review.googlesource.com/1241155Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#594100}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d6aa1a2a00d..f18c297cfb74 git log 8d6aa1a2a00d..f18c297cfb74 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 egdaniel@google.com Revert "Add support for RGB config to Vulkan." 2018-09-25 robertphillips@google.com Add SkImage_Gpu::MakePromiseYUVATexture 2018-09-25 herb@google.com Extract code common to Renderer and GPU for Fallback Created with: gclient setdep -r src/third_party/skia@f18c297cfb74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ic68c5da4e46d14019c2d5a884db297d4dae26951 Reviewed-on: https://chromium-review.googlesource.com/1244161Reviewed-by:
-
Shimi Zhang authored
This function implementation was removed in http://crrev/c/998803, there is no need to keep this declaration in header. Bug: 722928 Change-Id: I52bde7169a7390f02f6ad2b1e69449456793891f Reviewed-on: https://chromium-review.googlesource.com/1244437Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#594098}
-
John Chen authored
Handle timeouts in session capabilities, according to W3C spec. Bug: chromedriver:1997 Change-Id: Ie0c4bb8add482fa175f3bfe40210cf9fb0077001 Reviewed-on: https://chromium-review.googlesource.com/1243576Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594097}
-
Robert Sesek authored
Bug: 832676 Change-Id: I46fbf0fe83cd2317bf299cf204b39c79cacb1419 Reviewed-on: https://chromium-review.googlesource.com/1243224 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594096}
-
Matt Reynolds authored
The Surface Pro 2017 is a hybrid laptop/tablet device with a detachable keyboard. The keyboard is a composite device that includes several HID devices, some of which are incorrectly recognized as gamepads. This CL modifies the RawInput data fetcher on Windows to filter out devices that match the IDs for the Surface Pro 2017 keyboard. It also adds a check to exclude any PCI HID devices since there are no known PCI gamepads. The problematic devices intended to be filtered by this CL are: \\?\HID#VEN_8086&DEV_9D3E&SUBSYS_00000000&REV_21&Col02#4&f87ce30&0&0004#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VEN_8086&DEV_9D3E&SUBSYS_00000000&REV_21&Col05#4&f87ce30&0&0004#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VID_045E&PID_0922&Col06#7&36425755&0&0005#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VID_045E&PID_0922&Col09#7&36425755&0&0008#{4d1e55b2-f16f-11cf-88cb-001111000030} BUG=881156 Change-Id: I04687ffc94c92c284928eaec28c1edc85d05bf33 Reviewed-on: https://chromium-review.googlesource.com/1211978 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594095}
-
Xiaoqian Dai authored
When a connected bluetooth mouse is disconnected, and if it was the only external mouse device, the Chrome OS device should enter tablet mode. And when a connected bluetooth keyboard is disconnected, and if it was the only external keyboard device and no internal keyboard device, the virtual keyboard should pop up. However, it's not the case currently. The reason of this issue is ui::InputDeviceEventObserver doesn't have knowledge of Bluetooth device status and then when a Bluetooth device got connected/disconnected, it doesn't send out notification to notify its observers about the change. And there is no map from an InputDevice to a BluetoothDevice, thus it's impossible to know if an InputDevice is a BluetoothDevice and its status. TabletModeController and VirtualKeyboardController are both only ui::InputDeviceEventObserver and thus don't behave correctly when a Bluetooth device status changed. This CL adds a BluetoothDevicesObserver to observe BluetoothDevices change. It's more like a temporary fix, and I *think* the more correct underlying fix is let DeviceDataManager and InputDeviceClient (the classes to manage InputDevices) to send out the correct notification. The device lists that DeviceDataManager maintains comes from DeviceManagerUdev, and DeviceManagerUdev can send out the correct ADD type DeviceEvent when a bluetooth device is connected, but can not send out DeviceEvent when a bluetooth device is disconnected. We probably should make DeviceManagerUdev supports BluetoothDevices change. Bug: 882541 Change-Id: I2e8e6f56fe2f898bcde84f0eea24d9f2a69c9a05 Reviewed-on: https://chromium-review.googlesource.com/1222991Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594094}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fed6e124109f..30dc6aaf878b git log fed6e124109f..30dc6aaf878b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 tsepez@chromium.org Add FxAlignToBoundary<>() template helper function. 2018-09-25 tsepez@chromium.org Introduce CodecModuleIface for progressive decoder modules. Created with: gclient setdep -r src/third_party/pdfium@30dc6aaf878b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I458ae9d3cb71637f5a503876a34b5623d224a648 Reviewed-on: https://chromium-review.googlesource.com/1244119Reviewed-by:
-
Weilun Shi authored
Disable Done button on custom link edit dialog when the url is empty or spaces only. Screencast: https://screencast.googleplex.com/cast/NTk2NTU5NzE1ODQwODE5Mnw3OWZhOGVmNi04Mg Bug: 886665 Change-Id: Ic674894e73ff8dc183af740505fdaa906e5241d9 Reviewed-on: https://chromium-review.googlesource.com/1243678 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#594092}
-
Joel Einbinder authored
The border was missing a pixel, and so didn't look like a solid line. https://imgur.com/a/jjEPH9g Change-Id: I647953188d2029670851201cb7b2d43e09cf37d1 Reviewed-on: https://chromium-review.googlesource.com/1244113 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#594091}
-
Fredrik Hubinette authored
When loading many media files, we normally end up having to wait for the first request for ALL media files to load before we can process the second request of the first media file. By limiting the number of parallel preloads, time-to-first frame should improve for all but the last media file. However, this feature is checked in behind a feature flag, so that we can run some expriments on it before turning it on by default. Bug: 884820 Change-Id: Ib0c366325d82fb59e6ad896bf985b1e828143a82 Reviewed-on: https://chromium-review.googlesource.com/1228486 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594090}
-
Simeon Anfinrud authored
This is no longer used. Bug: None Test: build cast_shell_apk, run junit tests Change-Id: I13f98d7b6c3b03d3d76bc5578e7436d854b0153d Reviewed-on: https://chromium-review.googlesource.com/1236281Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594089}
-
Chris Lu authored
[ios] Ensure MDCAppBarViewController's view matches the width of PaymentRequestPickerViewController's view. Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: If17ea9de20fec0463e918aea4f401427c3572bc5 Reviewed-on: https://chromium-review.googlesource.com/1239008Reviewed-by:
-
Nico Weber authored
We generally should use consistent optimization settings across platforms. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I79cd892056dcfa7338109deb9f689afac2b56072 Reviewed-on: https://chromium-review.googlesource.com/1244021Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594087}
-
Wez authored
Previously this method of creating an SkTypeface was not-implemented under Fuchsia, but that was changed during the refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1238540 We restore OS_FUCHSIA as a platform on which this method is not- implemented, to avoid the SkFontConfigInterface::RefGlobal() reference breaking our Debug builds. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-fyi-x64-dbg Bug: 816445 Change-Id: Ib14023478e65a8b9c59886a579d60a5be7e00aff Reviewed-on: https://chromium-review.googlesource.com/1243571Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594086}
-
Scott Graham authored
Bug: None Change-Id: I721c75e75ae0ec95667749f673578221747cbbea Reviewed-on: https://chromium-review.googlesource.com/1244156 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594085}
-
Jonathan Backer authored
When there are multiple windows open with viz, each window has it's own InProcCmdBuffer. If we do a memory dump with multiple windows, we will fail DCHECKs on calls from VizProcessContextProvider::OnMemoryDump because we will have multiple CommandBufferHelpers in the same process with the same ring_buffer_id_. https://cs.chromium.org/chromium/src/gpu/command_buffer/client/cmd_buffer_helper.cc?rcl=9c52bb1d0f58d02879f4373f5db09aa625c590a7&l=365 This CL makes the transfer buffer IDs generated by InProcCmdBuffer unique within a process and avoids the failing check. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I204098af24c6148c1abe71724dbc5b176ee1a29f Reviewed-on: https://chromium-review.googlesource.com/1243672Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594084}
-
Avi Drissman authored
GetParentWidgetAndEvent can fail to find a widget; if so, don't call through a null pointer. BUG=883700 Change-Id: Ifa4430fe7cc7c83da9e21fa478e15b59498138ec Reviewed-on: https://chromium-review.googlesource.com/1244019Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594083}
-
Jani Hautakangas authored
Introduce Ozone Wayland IME integration. Implements Ozone Wayland specific LinuxInputMethodContext and adds possibility to integrate it with various Wayland text input protocols. Patch also introduces new SetSurroundingText function to LinuxInputMethodContext that is internally called by InputMethodAuraLinux on caret bounds change. This CL: - Implements Ozone wayland specific Linux input method context interface and integrates it with zwp_text_input_v1 protocol. - Introduces new runtime flag --enable-wayland-ime to enable this feature (by default false). - Makes Wayland IME working with InputMethodAuraLinux. - Adds surrounding text support (kudos to msisov@igalia.com). Bug: 791920 Change-Id: I168d4a266bff6e62acce69edf943469e05e575ac Reviewed-on: https://chromium-review.googlesource.com/1193872Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#594082}
-
Liquan(Max) Gu authored
Initially the events in EventTiming class are pointers, this CL is to change them to references, since reference is safer to use. Bug: 850144 Change-Id: Ia13ef944c143a7bed8096c1faf370163bfa95aaf Reviewed-on: https://chromium-review.googlesource.com/1244102Reviewed-by:
-
Jeremy Roman authored
sheriffing: disable vr_pixeltests:UiPixelTest.DrawVrBrowsingMode,GlTestEnvironmentTest.InitializeAndCleanup in msan builds Bug: 889186 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I673acc7c696802c8c5b29b9e9f4b279c12e0b858 Tbr: acondor@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1244364Reviewed-by:
-
erikchen authored
Switch to an atomic variable to ensure that getter and setter do not have a data race. Bug: 859155 Change-Id: Ib5ab1968cc8e25ab363fb4ed0b3f2e756d9cc984 Reviewed-on: https://chromium-review.googlesource.com/1240634 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594079}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4396b5dbaad5486719a3a3230858ced6cfdb3642 Reviewed-on: https://chromium-review.googlesource.com/1244096Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594078}
-
yiyix authored
Enabling FrameMetrics caused 5-20% regression on rendering. (ref: https://bugs.chromium.org/p/chromium/issues/detail?id=876709). One of many reasons is that square root calculation took too long. In this cl, I implemented Newton's method to approximate the square root value. I ran perftest on a Nexus 4 device and got the following result: average of running square_root using std::sqrt: 1601-01-01 00:00:23.160 UTC average of running square_root using fastsqrt: 1601-01-01 00:00:10.629 UTC Conclusion: It's 2.3x faster with newton's approximation instead of standard library. I also ran perftests on linux desktop and got 3%-5% improvements. (perftests ref: https://chromium-review.googlesource.com/c/chromium/src/+/1222676) Bug: 881863 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5feebc32053650f338a92a2e1db6f4f67b20f995 Reviewed-on: https://chromium-review.googlesource.com/1225105 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
-
rbpotter authored
Make pages a dropdown, and only show the custom input if "Custom" page range is selected Bug: None Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c Reviewed-on: https://chromium-review.googlesource.com/1237241 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594076}
-
