GitLab

Every intervention report should have a human-readable id, as specified
in the Reporting spec.

https://w3c.github.io/reporting/#dom-interventionreportbody-id

Bug: 564071
Change-Id: I82d1237fe9b45f28691e0772abd6d9995833e1ee
Reviewed-on: https://chromium-review.googlesource.com/1129469Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574183}

https://skia.googlesource.com/skia.git/+log/2229b76258f7..4ec72f7cc745


git log 2229b76258f7..4ec72f7cc745 --date=short --no-merges --format='%ad %ae %s'
2018-07-11 ruiqimao@google.com added skeletal animation support to GPU backend


Created with:
  gclient setdep -r src/third_party/skia@4ec72f7cc745

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I3835858a733fb33db6c6626cc991633c077ae01c
Reviewed-on: https://chromium-review.googlesource.com/1133239Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574182}

This also removes mash_ash_unittests as it's no longer applicable.
There is a lot of cleanup that can happen, but I'm leaving that for
future patches in hopes of not making this one too big.

BUG=855767 842365 840391
TEST=covered by tests

Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb
Reviewed-on: https://chromium-review.googlesource.com/1131924Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574181}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8885d8b2..c3ce505d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iadfe747543fd01e9c2711b0f9f23c15d43bc17da
Reviewed-on: https://chromium-review.googlesource.com/1133121Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574180}

This is a reland of 1afbb0e4, tweaking
the DevToolsManager test to use quit-when-idle, to ensure that timeout
tasks have all had a chance to run before we quit each RunLoop.

Original change's description:
> Migrate //content unit tests off of QuitCurrent*Deprecated().
>
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: If5cf7d3dcda8dc411c6c90de31885dca683354d8
> Reviewed-on: https://chromium-review.googlesource.com/1130656
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574006}

TBR: boliu
Change-Id: I97a36101e145457d5ad9f99a4a0b83a55ab62f2d
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1133178Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574179}

Bug: 824487
Change-Id: I52782aed08ad8990585cccda751ddf42a61b9dbd
Reviewed-on: https://chromium-review.googlesource.com/1128175Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574178}

Bug: 861875
Change-Id: Ie6d0976b1e71a637b12c330323b876bfcb95cc27
Reviewed-on: https://chromium-review.googlesource.com/1130572Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574177}

Bug: 862505
Change-Id: I1bcb2019be64dbb91081e1f8d607aca4cb0fbdc5
TBR: apacible@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1133306Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574176}

Following bot results are included.
7708 7710 7714 7718 7725 7731 7736 7737 7748 7753 7766 7768
7779 7787 7789 7795 7800

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I761ca3f56c837bced01e481537c996cbe4c3ad7c
Reviewed-on: https://chromium-review.googlesource.com/1129600
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574175}

This CL only move only move some component build related targets into a
condition check without changing the config in the targets.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I9d32580da7b156e803b804f0179766e23373f842
Reviewed-on: https://chromium-review.googlesource.com/1122145Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Shenghuai Ji <shenghuai@google.com>
Cr-Commit-Position: refs/heads/master@{#574174}

Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/e2fg_-Ha-AE/discussion

Chrome Status Entry: https://www.chromestatus.com/feature/5712361335816192

Bug: 161072,862455
Change-Id: Ibdab33ae6dabe97b9f1fffeed413c09690e56bea
Reviewed-on: https://chromium-review.googlesource.com/1132384Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574173}

This CL ensures that a backspace is threated as a user gesture, so that
it causes the autofill popups to refresh.

Bug: 839518
Change-Id: Iaca3206c5da2b7ab35271bbeeb85b77c6d27bc09
Reviewed-on: https://chromium-review.googlesource.com/1130104Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574172}

https://android.googlesource.com/platform/external/perfetto.git/+log/8049055c4260..dc44083eeb40


git log 8049055c4260..dc44083eeb40 --date=short --no-merges --format='%ad %ae %s'
2018-07-11 taylori@google.com trace_processor: Handling of sqlite string conversion


Created with:
  gclient setdep -r src/third_party/perfetto@dc44083eeb40

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:80416541
TBR=perfetto-bugs@google.com

Change-Id: I764b09a155c719ce24ea80ac2f765c3ca354c4fb
Reviewed-on: https://chromium-review.googlesource.com/1133339
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574171}

This reverts commit 426a53b7.

Original review at
https://chromium-review.googlesource.com/c/chromium/src/+/1126519

TBR=majidvp@chromium.org

Bug: 853698
Change-Id: I8dce9db88ee4af68d5cf93e89ac15963f39f6da0
Reviewed-on: https://chromium-review.googlesource.com/1133125
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574170}

With "allow-start-service-manager-only" flag, we can start the service
manager without starting the remaining parts of the browser,
particularly the browser main loop. Later, we could start the full
browser with the service manager running. Currently, both code path go
through service_manager::main(). Therefore, we need to avoid calling the
initialization in service_manager::main() multiple times.

In this CL:
1. service_manager::main() checks its static bool flag to decide
   whether initialization should be called.
2. Plumbs the start-service-manager-only flag to the ContentMainRunner
   who starts the browser main loop.

This CL impacts Android only for now. It follows up CL:
 https://crrev.com/c/1093303.

BUG=854209, 846846

Change-Id: I7fcfb804ce7f3065da7df12947674344fe2f56d6
Reviewed-on: https://chromium-review.googlesource.com/1114077
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574169}

They are unused.

Change-Id: I5857cac266ddbe296188490817edc1aeb70a45d6
Reviewed-on: https://chromium-review.googlesource.com/1132294
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574168}

The Video Player app has a test, VideoPlayerBrowserTest.OpenSingleVideoOnDrive, that loads a script from ui/file_manager/integration_tests. This script would normally be blocked by the platform app's CSP. Update the app to use an explicit CSP allowing the extension's resource.

Bug: 861815
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idf10b0eea4e284ea4c3f0c624dc05c5a340fc4ed
Reviewed-on: https://chromium-review.googlesource.com/1132314
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574167}

The new value is consistent across platforms and is according to
MD2 spec.

Bug: 860273
Change-Id: I4b1f28a8f063f08fe99865580f5ac7085d8c27d6
Reviewed-on: https://chromium-review.googlesource.com/1131680
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574166}

This CL removes the initialization of TabManager by ChromeUnitTestSuite
before every Chrome unit test run. This will make it easier to
initialize metrics::DesktopSessionDurationTracker before TabManager in
tests that need to verify that Chrome usage (instead of wall time) is
used for tab lifecycle state transitions.

Bug: 775644
Change-Id: I01d05579964822c87ebc515cafdd25e08fdab661
Reviewed-on: https://chromium-review.googlesource.com/1132121Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574165}

Bug: 862588
Change-Id: Ie8733b4735fc481205c51858da88c82708f3482c
TBR: blundell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1133123Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574164}

These methods don't access member variables, so they can easily be
made static. Making these methods static will avoid having to initialize
TabManager and its dependencies in a bunch of tests.

Bug: 775644
Change-Id: I2ef567c855e34e234faad569126e752460cd2418
Reviewed-on: https://chromium-review.googlesource.com/1132094Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574163}

When we added kExperimentalUi, I added it to
views_mode_controller::IsViewsBrowserCocoa() but I didn't notice
that there was this other implementation.

The omnibox has a feature that uses features::IsViewsBrowserCocoa() and
I'd like it to trigger on kExperimentalUi. Let me know if there's some
reason why we'd expect these to give different answers. There are only a
handful of places that depend on the features:: version:

https://cs.chromium.org/search/?q=features::IsViewsBrowserCocoa

Bug: 862336
Change-Id: Ieffe5d13bb08c5c36994cef9ccc850ca4552c2b2
Reviewed-on: https://chromium-review.googlesource.com/1132430Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574162}

Bug: 832680, 830882
Change-Id: I7fc5145f1b1ce9fee9bff6470cc55cda578e2c64
Reviewed-on: https://chromium-review.googlesource.com/1127259Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574161}

This bug was found by the fuzzer. If a large int32 value is present for
a RelCode32 the result of mapping the location to its target results in
integer overflow or underflow as found by UBSAN.

In the particular example found by the fuzzer a value of 1292632068 is
read from the image. The result of |(1292632067 - 1) * kInstrUnitSize|,
where |kInstrUnitSize = 2| results in an overflow. This is only
possible for RelCode32 so we only need the fix there. The solution is
to check for overflow and if it occurs just to skip the reference. In
a regular DEX file these should be very rare if ever present.

I've tested the updated version on a subset of the corpus with no ill
effects.

Bug: 862095
Change-Id: Ifedeeaf1ae7e72a147421ecb917ec1751f4bb8d4
Reviewed-on: https://chromium-review.googlesource.com/1131225
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574160}

The original CL caused a test failure in
DetachToBrowserTabDragControllerTest.DetachToOwnWindow. This was due to a bug in
the test itself, which was generating an incorrect mouse-up event. This CL fixes
the test to delay generation of the mouse-up event until the new tab dragging
window has been detached.

> WebContentsView::Focus() is supposed to update the first responder of the
> Window, not make the window focused. The latter should go through
> WebContentsDelegate::ActivateContents().
>
> This logic is usually a no-op because the window receiving the call is the
> active window. But in the case where the user quickly switches windows, this can
> cause the old window to re-take focus.
>
> This logic was added in 2009 not because it had the right semantics, but to
> match the behavior of Windows: http://codereview.chromium.org/165492.
>
> Bug: 859614
> Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a
> Reviewed-on: https://chromium-review.googlesource.com/1124772
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573344}

Bug: 859614
Change-Id: I441a00ad015eb3559718b448fc42f98827beee35
Reviewed-on: https://chromium-review.googlesource.com/1132106Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574159}

Previously, TabManager::PerformStateTransitions() could be called
repeatedly and needlessly while a tab is being discarded:

- TabManager::PerformStateTransitions()
  Transitions a LifecycleUnit to PENDING_DISCARD.

- TabManager::PerformStateTransitions()
  Calls CanFreeze() to check if the LifecycleUnit can be frozen.
  CanFreeze() returns true even though the LifecycleUnit is already
  being discarded.
  Calls Freeze(), which transitions the LifecycleUnit to
  PENDING_FREEZE.
  Calls CanDiscard() to check if the LifecycleUnit can be discarded.
  CanDiscard() returns true.
  Calls Discard(kProactive) to discard the LifecycleUnit.
  ** Since a LifecycleUnit was discarded, another call to
  PerformStateTransitions() is scheduled immediately. **

- TabManager::PerformStateTransitions()
  Called repeatedly until the LifecycleUnit transitions to DISCARDED.

This CL fixes the issue by returning false from CanFreeze() and
Freeze() for a LifecycleUnit that is being discarded.

Bug: 775644
Change-Id: I4de25dfe7d569f61d0eef988b217203eeae6f006
Reviewed-on: https://chromium-review.googlesource.com/1132343Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574158}

This will allow us to see these events for all clients and not just
RenderWidgets. Also will make it work with OOP-D

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id7a65a0129d27821797f8a46408ece32c580fc3b
Reviewed-on: https://chromium-review.googlesource.com/1132323Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574157}

Also add a data dep that's necessary (but apparently not sufficient) for
cast_shell_browsertests to run on swarming.

Bug: 861753, 861843
Change-Id: Ib10a8589c1349ac70dc4d4358395af6b2867d16b
Reviewed-on: https://chromium-review.googlesource.com/1133201Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574156}

This is a reland of 6d48958d

Don't check acceptable scheme links since UrlUtilities.isAcceptedScheme()
was native function, libchrome.so had not loaded when handle intent.

Original change's description:
> Ignore Intent filters with wildcard hosts when handling links.
>
> If the Android device has a package installed that declares
> an Intent filter with `android:host="*"`, Chrome will launch
> the Intent picker UX whenever a person taps a link.
> This is a poor user experience. (Using `android:host="*"`
> arguably doesn't make much sense; normally, Intent filters
> would use `*` to match subdomains such as *.google.com.) Thus,
> skip Intent filters with such wildcard hosts when handling
> acceptable scheme links.
>
> R=dtrainor@chromium.org
>
> Bug: 841133
> Change-Id: I3cb14309ed53e0bd623ed0da59af6635391a8718
> Reviewed-on: https://chromium-review.googlesource.com/1053847
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564487}

Bug: 841133
Change-Id: Id2fd7f7364eb6c70280b29a1f71783a2ee89747b
Reviewed-on: https://chromium-review.googlesource.com/1096554Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574155}

The main changes were:
-converting LOG(INFO) to VLOG(1)
-Removing usages of Time::FromInternalValue

Bug: 830892
Change-Id: I117d6d605b5ca0b82ea7d509a127fbf316f483b0
Reviewed-on: https://chromium-review.googlesource.com/1130103
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574154}

This CL removes the autolayout constraints on the TabGrid button in the
toolbar and instead positions it using frames.

Bug: 862576
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5eda2cc58ee38228e40870f723315bc91ac6953f
Reviewed-on: https://chromium-review.googlesource.com/1133167Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574153}

The pref was gated on being in the Heuristic Model experiment, which
isn't necessarily the case anymore. The pref should always be registered when
the Heuristic Model is chosen.

Bug: 862229
Change-Id: I41fd77334edac643f43c638a6d56abc408242a53
Reviewed-on: https://chromium-review.googlesource.com/1131814Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574152}

This allows debug messages to print sandbox flags in a convenient binary
format, rather than outputting them as decimal numbers or 4-byte arrays.

This means that you can easily add debug statements for sandboxing code like:

DLOG(INFO) << "The sandbox flags here look like " << sandbox_flags_;

rather than having to cast:

DLOG(INFO) << "The sandbox flags here look like " <<
    std::bitset<32>(static_cast<int>(sandbox_flags_));

It also changes the test output from EXPECT_EQ failures from looking like:

../../content/browser/some_browsertest.cc:12345: Failure
      Expected: blink::WebSandboxFlags::kAll & ~blink::WebSandboxFlags::kScripts & ~blink::WebSandboxFlags::kAutomaticFeatures
      Which is: 4-byte object <6F-FF FF-FF>
To be equal to: root->child_at(1)->effective_frame_policy().sandbox_flags
      Which is: 4-byte object <FF-FA FF-FF>

to the more reasonable:

../../content/browser/some_browsertest.cc:12345: Failure
      Expected: blink::WebSandboxFlags::kAll & ~blink::WebSandboxFlags::kScripts & ~blink::WebSandboxFlags::kAutomaticFeatures
      Which is: 11111111111111111111111101101111
To be equal to: root->child_at(1)->effective_frame_policy().sandbox_flags
      Which is: 11111111111111111111101011111111

in which single bit errors can easily be spotted.

Change-Id: Ibc9020d67654c555e1c70dcb99829e2eb29d0b3c
Reviewed-on: https://chromium-review.googlesource.com/772320Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574151}

This CL increases |kMaxFieldsOnTheForm| to 100 in |FormStructure::IsMalformed|.
It allows to crowdsource more forms. See the bug for details. Later the
parameter will be increased even more and will be finchable.

UMA histogram is introduced to monitor the size of forms Autofill has to process.

TODO: Finch-controlled threshold and UKM metric.

Bug: 857454
Change-Id: I50c1382dd36e2c707cd34f1a4f139413d9ea6026
Reviewed-on: https://chromium-review.googlesource.com/1131457Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574150}

https://pdfium.googlesource.com/pdfium.git/+log/cbed949bee84..b1a4db5551ca


git log cbed949bee84..b1a4db5551ca --date=short --no-merges --format='%ad %ae %s'
2018-07-11 thestig@chromium.org Fix some nits in fxjs code.


Created with:
  gclient setdep -r src/third_party/pdfium@b1a4db5551ca

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I520096872b1ab632c4dc59d4c653620e08f0fc52
Reviewed-on: https://chromium-review.googlesource.com/1133238Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574149}

When discarding intrinsic block size for contain:size, we need to reset
intrinsic size to the border+padding sum (not zero), since
intrinsic_block_size_ is the size of the border box, not the content
box.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I29195a09a6d47b9e3c2a82da3be6f528aac25c68
Reviewed-on: https://chromium-review.googlesource.com/1133163
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574148}

Currently an instance of the input accessory view controller is created
per tab view the tab helper. This CL changes that to instead only have
one instance per BVC. This the first step to start adopting the new
coordinators architecture, which will be used in to present the manual
fill view controllers from the input accessory view. The next step
woould be fixing dependncies in order to move the coordinator to ui
folder.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id0cc93c57e18f51f0208c38ddcdf4e3b8e9e90ac
Bug: 845472
Reviewed-on: https://chromium-review.googlesource.com/1103126
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574147}

TBR=nednguyen@google.com
NOTRY=True

Bug: 757933
Change-Id: Ie817891643082472fc46805ef4a2ffe43356f2bf
Reviewed-on: https://chromium-review.googlesource.com/1133278Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574146}

This is passing at ToT.  The bug reference here looks like an old
or original import.  I wonder when this started working, but it
does not seem worth chasing down.

Bug: 706118
Change-Id: Ie8163cb204ed03f9ab04524400b84bb8d3e47232
Reviewed-on: https://chromium-review.googlesource.com/1132558Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574145}

This changes the interface such that saves can only performed via the
SaveCB. Internally the CB is weakly bound to the perf history so post
destruction saves are quietly dropped.

This unblocks re-landing
https://chromium-review.googlesource.com/c/chromium/src/+/1123687/1

The above CL will give incognito profiles a distinct
VideoDecodePerfHistory instance. Incognito profile's are rapidly deleted
when the last tab closes, creating a race condition for any per stats
that are inbound from video's on that tab. Now, using the SaveCB,
those late stats will be safely dropped.

Bug: 855631, 855215, 796280
Change-Id: Ia978dbca14d5584ca92301aee84020437a90311e
Reviewed-on: https://chromium-review.googlesource.com/1123396Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574144}