GitLab

Merges parts of Andreas Kling's http://trac.webkit.org/changeset/155217

"Out-of-line the three methods on FrameView that were operating on
Frames.  Most of the call sites were in FrameView.cpp so they will still
get inlined."

On my system, this reduces the number of build steps that run after
touching Frame.h from 528 to 442 and reduces compilation time after
touching Frame.h from 8.5 minutes to 7 minutes.

BUG=none

Review URL: https://codereview.chromium.org/23819041

git-svn-id: svn://svn.chromium.org/blink/trunk@157458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Along with http://crrev.com/23983017, this adds and makes use of
Renderer.AcceleratedFixedRootBackground UMA histogram.

Records three counts:
1. The total number of main frame scrolls.
2. The total number of main frame scrolls with an accelerated fixed root background.
3. The total number of main frame scrolls with an unaccelerated fixed root background.

R=hartmanng@chromium.org,asvitkine@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/23458035

git-svn-id: svn://svn.chromium.org/blink/trunk@157457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch rolls CodeMirror to @e0b0e32ed. This time we do not patch
CodeMirror to bring support for the long lines: instead, we rely on its
core functionality as it was recently improved. Experiments proved it
to be decent.

TBR=vsevik, pfeldman
BUG=

Review URL: https://chromiumcodereview.appspot.com/23496039

git-svn-id: svn://svn.chromium.org/blink/trunk@157456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These two are non standard IE extensions.

BUG=286321

Review URL: https://chromiumcodereview.appspot.com/23638009

git-svn-id: svn://svn.chromium.org/blink/trunk@157455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://chromiumcodereview.appspot.com/23766014

git-svn-id: svn://svn.chromium.org/blink/trunk@157454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=285766
R=alph@chromium.org

Review URL: https://codereview.chromium.org/23494034

git-svn-id: svn://svn.chromium.org/blink/trunk@157453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=285169

Review URL: https://chromiumcodereview.appspot.com/23537022

git-svn-id: svn://svn.chromium.org/blink/trunk@157452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It used to switch fillStyle for every bar. (N times)
With new implementation it will switch fillStyle K times
where K is the number of functions by drawing all the bars for one color in a sequence.

BUG=none
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/23533037

git-svn-id: svn://svn.chromium.org/blink/trunk@157451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://chromiumcodereview.appspot.com/23530041

git-svn-id: svn://svn.chromium.org/blink/trunk@157450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is basically extends RefPtr EnsurePtrConvertibleArg pattern to OwnPtr and OwnArrayPtr smart pointers.

Please look at the following example:

class BaseClass {};
class DerivedClass: public BaseClass {};

void foo(PassOwnPtr<BaseClass>) {}
void foo(PassOwnPtr<int /* or whatever type*/>) {}

void fooClientFunction()
{
    OwnPtr<DerivedClass> ptr = adoptPtr(new DerivedClass);
    foo(ptr.release());
}

before this change such snippet would have lead to "error: call of overloaded 'foo(WTF::PassOwnPtr<DerivedClass>)' is ambiguous". 
This CL solves the problem.

Review URL: https://chromiumcodereview.appspot.com/23531003

git-svn-id: svn://svn.chromium.org/blink/trunk@157449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Up to 10 ms backwards clock jumps has been seen on XP, 2 ms on Win7.

BUG=282620

Review URL: https://chromiumcodereview.appspot.com/23648005

git-svn-id: svn://svn.chromium.org/blink/trunk@157448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=240653
R=dstockwell

Review URL: https://chromiumcodereview.appspot.com/23451019

git-svn-id: svn://svn.chromium.org/blink/trunk@157447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman
BUG=285169

Review URL: https://codereview.chromium.org/23498020

git-svn-id: svn://svn.chromium.org/blink/trunk@157446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit dfc6e91da01f3573f34d386c1c7db40838db7296.

git-svn-id: svn://svn.chromium.org/blink/trunk@157445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add unsigned short to animatable factory to support outline-width. The
test animations/interpolation/outline-width.html no longer crashes when
run in the virtual/web-animations-css test suite and no longer overflows
to negative values (correctly clamps to unsigned short) so update test
expectations for that.

Change in behavior here to match Firefox's implementation and align with
the CSS spec (outline-width should not be negative).

BUG=257591

Review URL: https://chromiumcodereview.appspot.com/23548021

git-svn-id: svn://svn.chromium.org/blink/trunk@157444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://chromiumcodereview.appspot.com/23882010

git-svn-id: svn://svn.chromium.org/blink/trunk@157443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Additionally, add explicit keyword to constructor that takes one argument.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/24069002

git-svn-id: svn://svn.chromium.org/blink/trunk@157442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=286645
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/23536039

Patch from Laszlo Gombos <l.gombos@samsung.com>.

git-svn-id: svn://svn.chromium.org/blink/trunk@157441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to avoid bare static_cast<const Foo*> too.

BUG=none
TEST=none; no behavior change.

Review URL: https://chromiumcodereview.appspot.com/23680013

git-svn-id: svn://svn.chromium.org/blink/trunk@157440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TEST=layouttest fast/ime

Review URL: https://chromiumcodereview.appspot.com/23526025

git-svn-id: svn://svn.chromium.org/blink/trunk@157439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=286645

Review URL: https://chromiumcodereview.appspot.com/23600014

git-svn-id: svn://svn.chromium.org/blink/trunk@157438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Consider the case of the following HTML:
<div style="overflow:hidden; width: 100px; height: 100px" >
  <input id="input" type="text" size=10 value="any text here!"/>
  <button style="position:relative; top: 100px; left: 100px"/>
</div>

If ones starts a text selection by dragging the mouse from within the input
field, and continues to drag beyong the outer div boundary, the latter will
be scrolled no matter its overflow:hidden style.
That happens because when the autoscroll has started, it gets propagated up
to the current layer's parent layer, instead of the to current layer's enclosing
scrollable layer.

Patch fixes the issue by hardening the way scrolling is
propagated upwards when autoscroll is being performed.

RenderLayer::enclosingScrollableLayer method also got rewritten
in terms of RenderLayer tree traversing, instead of RenderObject tree.
The rewrite adds support for cross frame upwards traversal.

Test: fast/events/autoscroll-upwards-propagation.html

Corresponding WebKit commit: <https://trac.webkit.org/changeset/154382>

BUG=116655

Review URL: https://chromiumcodereview.appspot.com/23472005

git-svn-id: svn://svn.chromium.org/blink/trunk@157437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23956013

git-svn-id: svn://svn.chromium.org/blink/trunk@157436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since Promise will be implemented in V8-side in the
future, we add the following special conversion rules to the IDL code
generator like DOMString -> const String&, Promise -> ScriptPromise.

BUG=266700

Review URL: https://chromiumcodereview.appspot.com/23479016

git-svn-id: svn://svn.chromium.org/blink/trunk@157435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a use counter for the SVGSVGElement. This will not
over count SVG, as we just record usecounter information once per page,
not per element on the page.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/24000002

git-svn-id: svn://svn.chromium.org/blink/trunk@157434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds an assert that the "inner page" in an SVGImage has
loaded and does not have any pending subresource loads.

NOTRY=true
BUG=249037

Review URL: https://chromiumcodereview.appspot.com/22999031

git-svn-id: svn://svn.chromium.org/blink/trunk@157433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=261277
TBR=bokan@chromium.org

Review URL: https://codereview.chromium.org/24064003

git-svn-id: svn://svn.chromium.org/blink/trunk@157432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Causing ASSERT failures in debug.

> Remove lots of code related synchronously attaching
> 
> Now that we always lazy attach we can remove the hacks and special
> cases related to synchronously attaching.
> 
> BUG=276689
> 
> Review URL: https://chromiumcodereview.appspot.com/23606020
> 
> git-svn-id: svn://svn.chromium.org/blink/trunk@157422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23526031

git-svn-id: svn://svn.chromium.org/blink/trunk@157431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://chromiumcodereview.appspot.com/24021003

git-svn-id: svn://svn.chromium.org/blink/trunk@157430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to avoid bare static_cast<>.

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23828005

git-svn-id: svn://svn.chromium.org/blink/trunk@157429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MarkForLayoutOrParentResourceInvalidation can be called in SVG during
document teardown. This change skips that if the document is being
destroyed.

This is a merge of http://trac.webkit.org/changeset/155055 by
Andreas Kling <akling@apple.com>

BUG=285368

Review URL: https://chromiumcodereview.appspot.com/23531032

git-svn-id: svn://svn.chromium.org/blink/trunk@157428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to avoid bare static_cast<>.

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23757027

git-svn-id: svn://svn.chromium.org/blink/trunk@157427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows the CSSParser logic to be shared between ...
- Creating the keyframe from CSS
- Setting the keyText as a string from JavaScript

Also update StyleKeyframe to cache the string and vector representations of the keys.

This is purely an optimisation. No change in behavior.

R=apavlov

Review URL: https://chromiumcodereview.appspot.com/19037003

git-svn-id: svn://svn.chromium.org/blink/trunk@157426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like not to use vanilla static_cast<>.

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23606021

git-svn-id: svn://svn.chromium.org/blink/trunk@157425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't need the NodeRenderingContext in childShouldCreateRenderer or rendererIsNeeded,
we only need the node or the style so pass them explicitly. This makes textRendererIsNeeded
the only place we pass the NodeRenderingContext. Future patches should be able to clean that
up allowing NodeRenderingContext to only be the creator of renderers and not a multi-purpose
bag of things.

This also changes both methods to take a Node& or a RenderStyle& instead of pointers so
users of these APIs know the values can never be null.

Review URL: https://chromiumcodereview.appspot.com/23956012

git-svn-id: svn://svn.chromium.org/blink/trunk@157424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This flag does not seem needed, there's no apparent reason that frames
would want to do setNeedsStyleRecalc(LazyAttachStyleChange) but not
setAttached().

Review URL: https://chromiumcodereview.appspot.com/24066002

git-svn-id: svn://svn.chromium.org/blink/trunk@157423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that we always lazy attach we can remove the hacks and special
cases related to synchronously attaching.

BUG=276689

Review URL: https://chromiumcodereview.appspot.com/23606020

git-svn-id: svn://svn.chromium.org/blink/trunk@157422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Likely the same issue as the virtual compositing change.

BUG=287477
TBR=enne

Review URL: https://codereview.chromium.org/23451018

git-svn-id: svn://svn.chromium.org/blink/trunk@157420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to avoid bare static_cast.

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23714006

git-svn-id: svn://svn.chromium.org/blink/trunk@157419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=286645

Review URL: https://chromiumcodereview.appspot.com/23672027

git-svn-id: svn://svn.chromium.org/blink/trunk@157418 bbb929c8-8fbe-4397-9dbb-9b2b20218538