- 02 Dec, 2020 6 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/684460d29eb4..80cea4f5fc66 2020-12-01 vapier@chromium.org repo: only warn if update_depot_tools does not exist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148984 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If01705d42808ea2af515b378db3faad1b931be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568171 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832581}
-
Kenneth Russell authored
GpuProcess_one_extra_workaround and GpuProcess_disabling_workarounds_works have become flaky there too. Bug: 1154088 Change-Id: Ic07468cd98aa59dc616a9fdde82b24eb2b6d7c8f Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568638Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832580}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/494efc70ded6..8e0ff2457021 2020-12-01 tsepez@chromium.org Remove most remaining CFXJSE_Value from CFXJSE_FormCalcContext. 2020-12-01 tsepez@chromium.org Rework XFA_ResolveNodeRS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1d588370983459cd4d345965a43d763608348e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567748Reviewed-by:
-
Daniel Cheng authored
There are Android crashes where sending an orientation change event seems to encounter mutually exclusive facts: - WebLocalFrameImpl::GetFrame() should only return a non-null pointer if the LocalFrame is attached. - Furthermore, GetFrame() and GetFrame()->DomWindow() both return non-null pointers (though GetFrame()->DomWindow() returning non- null does *not* imply the frame is attached). - ScreenOrientationController is looked up as a a LocalDOMWindow supplement, using a non-null DomWindow(). - ScreenOrientationController is an ExecutionContextLifecycleObserver, and uses the DomWindow() helper to look up frames to iterate through. - DomWindow() should only return null once the associated LocalDOMWindow is detached - Yet DomWindow() returns null, contradicting WebLocalFrameImpl... Bug: 1154141 Change-Id: Id4e695a542c47dbd9263db6dcfc3718653bec242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566884 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832578}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3830d436c47..6f5151f6572b 2020-12-01 senorblanco@chromium.org Enable D* end-to-end tests on OpenGL ES backend. 2020-12-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from eac3c5bf5197 to 782f6a5e3e3c (50 revisions) 2020-12-01 senorblanco@chromium.org Disable some further C* end2end tests on GLES. 2020-12-01 senorblanco@chromium.org Enable most C* end-to-end tests on OpenGL ES. 2020-12-01 senorblanco@chromium.org Enable BufferTests on OpenGL ES. 2020-12-01 senorblanco@chromium.org Fix SSBO bindings in GLES backend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Id874878d53e59d053c104574ba0f5d06e012256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568385Reviewed-by:
-
Jason Lin authored
The camera notification/indicator is shown when PluginVM accesses camera now. Note that flags pluginvm-show-camera-permissions and vm-camera-mic-indicators-and-notifications need to be turned on. Bug: b/167491603 Change-Id: Ib2e3f7bc85531313811d2525ecac394aadee6e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557122Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832576}
-
- 01 Dec, 2020 34 commits
-
-
Moe Ahmadi authored
Previously only the realbox header text was unselectable. Making all text in realbox dropdown unselectable is more consistent with omnibox. Fixed: 1147142 Change-Id: Iade45c037e8e9208aba7ff0e708c985aa9ea97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566505 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#832575}
-
Chris Lu authored
IOSLaunchedBySearchInChromeIntent is being logged instead of IOSOpenByMainIntent. This change fixes that. Bug: 1154422 Change-Id: If77133adeceb18296e7fbc1f284c13348923793d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568650 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#832574}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id8edcc9b08c5ea5245b4f1a369f4017a87cfe53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568362Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#832573}
-
Yuheng Huang authored
This CL makes Tab Search shortcut (cmd+shift+A) available when the Tab Search feature flag is off. Bug: 1099917, 1153526 Change-Id: Ic5ba4e16cd458f4f0e5541a852435bd07ada610e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568151Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#832572}
-
Kenneth Russell authored
Unexpectedly started flaking badly recently on these platforms. Bug: 1154088 Change-Id: Ia232f78ca76cfa7ac6f1647b3773952ad768e5eb Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568368Reviewed-by:
-
zhiyuancai authored
Bug: 1146636 Change-Id: If26b394b21e60147f54494e5e7bfa9c897177f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568510Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#832570}
-
Gang Wu authored
Experiment enabled on canary and dev https://critique-ng.corp.google.com/cl/338608966 This CL prepares for beta rollout Change-Id: I0a7d69da22d9cf74f224f1704ff4605a9fa030b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565830Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832569}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/225d4f420c39..6035f4a5832a 2020-12-01 michael.liao@microsoft.com [Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093229 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f412403fead3ec040e0c85abed6732a55163084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566788Reviewed-by:
-
Lan Wei authored
The scroll-snap-type property should be set on <html> rather than <body>, because scroll-snap-type should not be propagated from body element to the viewport, we should use its value on html instead. Bug: 984438 Change-Id: I9b42289cc217ae3d9b4aafc69171a16087a24de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568433Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#832567}
-
Mohamed Heikal authored
This is a reland of 30310919 Original change's description: > Update bundletools to version 1.4.0 > > Bug: 1151352 > Change-Id: I2a117e5f6cb3bf1b08f7f9f68cea7e4a893db6fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553852 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830240} Bug: 1151352 Change-Id: Iee6b2dc1b263d5bf2cf28df46db8ca3bdb421f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568352 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832566}
-
Nancy Wang authored
Create the full restore service when the profile is ready. The full restore service must be called before 'NotifyUserProfileLoaded', because NotifyUserProfileLoaded notifies the ash to prepare the virtual desk restoration. However, the virtual desk restoration should be decided by the full restore service. So full restore service must be created before NotifyUserProfileLoaded is called. There is a full restore flag to control the full restore service: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/full_restore/full_restore_service_factory.cc;l=25 The flag is disabled currently, so before the feature is ready, no impact on the current implementation. PRD:go/cros-full-restore-prd Mock:go/cros-full-restore Design doc: go/chrome-os-full-restore-dd BUG=1146900 Change-Id: I21f68ce61166557eb24f69a2afbd8921fa091ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563192Reviewed-by:
-
David Van Cleve authored
We've now landed code that (1) Adds a generic //content-to-embedder API for requesting Trust Tokens issuance satisfied by on-device providers like system services (2) Expands the network service code responsible for the general Trust Tokens protocol flow to handle cases where issuance operations get delegated to on-device providers via NetworkContextClient This CL wires StoragePartitionImpl to bind a Mojo remote that can talk to the //content-to-embedder API (1), so that it can do something useful when it receives requests from the network service in step (2), rather than its current behavior of always failing the requests it receives. Test: Adds unit tests covering the new StoragePartitionImpl logic Change-Id: Iecd48e51ac827534fcac3073f0ce22bef4b2d8b4 Fixed: 1130273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493540 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832564}
-
Daniel Cheng authored
ConversionInternalsUI and ProcessInternalsUI don't need to be WebContentsObservers at all, since WebUIController already provides a RenderFrameCreated() override that is scoped WebUI-specific RenderFrameHosts. Bug: 1148682, 1149125 Change-Id: Iebef544d7fb7c8938d273c84279ce7e8b19f90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566889Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ifd76ac2aaab9e222a2e2ac15b61612517261018c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566786Reviewed-by:
-
Ben Pastene authored
crrev.com/i/3440720 allocates the machines for these builders. Bug: 1140727 Change-Id: Idb58c124a30f9535dd4b4a75aa2a40c4b2a54a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568166 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#832561}
-
Dave Tapuska authored
The test was accessing the device_scale_factor() on the LTH. device_scale_factor() will always be 1.0f when UseZoomForDSFEnabled is enabled and otherwise will match main_web_widget()->GetOriginalScreenInfo().device_scale_factor. Change to just use the original screen info device scale factor that doesn't change when DSF is enabled/disabled. BUG=1097816 Change-Id: I478efd19f39b9400d6e2165a67d3ede6ae463d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566071 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#832560}
-
Yury Khmel authored
This sends request to ARC Android to set dalvik memory params based on device's memory config. BUG=b:160760318 TEST=unit test added Locally on device, early tests show improvements in app loading and ARC boot time up to 5%. This feature is currently optional and is behind Chrome feature. Next data will be collected on real user using finch experiment and in-lab tests by adding separate testing variation for few reference boards that activates this feature. Change-Id: Iacb1a8c6ce874fe74152204a2e41a35bb2fa9da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560789 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#832559}
-
Lukasz Anforowicz authored
Bug: 1150940 Change-Id: Iadb1260fa89c4b9d3693cc0fbc5dcad7aab47535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550343 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id03a79fa1bdf2fd11d2d590bfcdba12a0e732eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565691 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#832557}
-
Aleks Totic authored
Bug: 958381 Change-Id: I49b9dee34db20f27d813f867c0397e111d26214b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568267 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#832556}
-
Gavin Williams authored
Show error toast when the user clicks "Show file location" to open the Files app but the saved scan file no longer exists at its original saved location. http://screen/Bufy35SXPNVM7Tp Bug: 1059779 Change-Id: Id8a08b37f1f957c26ad013f8463b3e8be4c2d338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566779Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832555}
-
Joel Hockey authored
Bug: None Change-Id: Ia9d5073828ad673231d1509fa8138474df21d4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567019Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832554}
-
Yue Li authored
Bug: 1129655 Change-Id: I64071441ebd50462e976e651d948cf29e197cd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567483Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#832553}
-
Lijin Shen authored
1. Refactor NightModeReparentingController to make it general and resuable. 2. Introduce a general tab-reparenting controller for ChromeActivity 3. Listen #onConfigurationChanged Bug: 1076228 Change-Id: I99ff52006de0e5a672441d46f2403bea4256fba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553145Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#832552}
-
Peter Wen authored
Prebuilt jars do not need the full classpath since they are either jars ready to be passed to ijar, or they just need a dep on a non-java target to unzip the jar from its aar. Previously header jars could depend on impl jars due to passing the full classpath for prebuilt jars, but this should not happen as it defeats the purpose of header jars being fast to compile. Added a regression test to ensure chrome_java__header doesn't depend on base_java__impl. Original CL: https://crrev.com/c/2567618 Fixed: - Added back missing transitive header deps. Tbr: cduvall@chromium.org Bug: 1154302 Change-Id: Ib1810ee0c4646d14e8e75372427594c456be8366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567628Reviewed-by:
-
Adrian Elder authored
Doing this to match other sizes and lengths it is compared with. Bug: 1150460 Change-Id: If20ecddb55527ca603a86dc9db2ba3a3a5f7ebcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568375Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#832550}
-
Lukasz Anforowicz authored
The NavigationRequest::OnRequestStarted has been empty since https://crrev.com/c/2551736 and the only non-empty override of NavigationURLLoaderDelegate::OnRequestStarted was in TestNavigationURLLoaderDelegate. This CL refactors the unit tests so they no longer depend on OnRequestStarted and then deletes this method altogether. Bug: 1150940 Change-Id: I9ff794db70e07915e6572fcd9fb96c0edb08ef23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551681 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This addresses two related problems. * An ImageBitmap's color parameters can be anything that is specified by an SkImageInfo. This is sort-of-smashed-into CanvasColorParams during serialization and deserialization. * The function ImageBitmap::CopyBitmapData implicitly does some sort of format and color conversion. In ImageBitmap::GetCanvasColorParams, replace the function with a GetSkImageInfo function (since that's what's used internally anyway). In ImageBitmap::Create, replace this function with one that uses a SkPixmap (since that's what the arguments are converted to). In ImageBitmap::CopyBitmapData, make the caller specify an SkImageInfo to indicate the desired target format. CanvasColorParams should be removed entirely from the serialization and deserialization code. This will be done in a follow-up patch. Bug: 1121448, 1150969 Change-Id: I66936823160098c6f60fcdce2d20abce828b5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567482Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#832548}
-
Daniel Murphy authored
This is a reland of d3cc95bb Original change's description: > [WebAppProvider] Test OS hook uninstallation calls & completion logic. > > This patch adds the virtual methods to the uninstallation path, and adds > corresponding tests for those in the unittests file. > > R=phillis@chromium.org > > Change-Id: I316145e6030d16ff3a28bf7fecb3d2cdbac940d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545864 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832087} Change-Id: Ie95af999acb33e2970dd2b9350ff9316cf6f7af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567820 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832547}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Add PrinterBasicInfo to the definitions. This will support forthcoming queries such as EnumeratePrinters and FetchCapabilities. Bug: 809738 Change-Id: I7a87e747a9b58f8e0f8460ecf85fb27466a0a8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438580Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832546}
-
David Tseng authored
Scenario: - two (or more) component extensions request binding of TtsStreamFactory - requests are received in TtsService - there is only one concrete Receiver instance - each request closes the connection to any previously bound TtsStreamFactory connections As a result, any previous connections will be closed prematurely e.g. before the extension can call createGoogleTtsStream. Fix this by keeping around all PendingReceiver instances and process them whenever we can. Specifically, once the extension creates a specific tts stream, process the next pending request for a factory. Test: manual. Observe errors without this change in some rare timing instances where an extension gets a tts stream factory but is disconnected before creating a stream. Observe no such error with this change. R=dmazzoni@chromium.org Fixed: 1131321 Change-Id: Ie0a2803fff809ada42038001fa015e1a6fb63e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561540 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832545}
-
Steve Kobes authored
These logs can now be viewed on official release builds with the flags: --enable-logging=stderr --vmodule=layout_shift*=1 This will make it easier to debug CLS issues for folks who may not have a Chromium checkout handy. Change-Id: Ic273684711b3dfd4e34827eca8cfe4deda744d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568351 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#832544}
-
Mike Reed authored
Skia now supports explicit controls over the sampling technique: - filtering: nearest, linear, cubic (only works with mipmaps:none) - mipmaps: none, nearest, linear (allows trilerp) See SkSamplingOptions.h Switching to these means skia no longer "changes" the technique based on heuristics (like the direction of the scaling): you always get what you ask for (more predictable). Need to rebaseline tests, as sometimes (e.g.) Skia used to treat "High Qualitty" (ala bicubic) as just bilinear when downscaling. The SkFilterQuality enum is deprecated: it is mapped as follows: kNone. : [ filter:nearest, mipmap:none ] kLow : [ filter:linear, mipmap:none ] kMedium : [ filter:linear, mipmap:nearest ] kHigh : [ filter:cubic, mipmap:none ] You can now specify these directly when you create an ImageShader. Specifying the enum in SkPaint is depcrecated, and will be removed. Bug: skia:7650 Change-Id: I5251b195fbc8ff7e71d3aa76fdc3dde139a35c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562751 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832543}
-
Noel Gordon authored
Comment only change. No-try: true Bug: 1145029 Change-Id: Ibca0b51f42857bf792b475ecd5361b9ccd045446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567240 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832542}
-
