GitLab

Readback doesn't have all its steps synchronized properly with
impl side painting enabled. This patch prevents the readback
commit from being swapped to screen and avoids using non-readback
commits for readback by adding a SynchronousReadbackState.

This patch also gives forced draws due to checkerboarding its
own ForcedReadback state that behaves independently of readback.

Previously readback and forced draws shared drawing mechanisms,
but we want readbacks to occur ASAP while we want forced draws
to occur inline with the normal frame scheduling.

BUG=276082

Review URL: https://chromiumcodereview.appspot.com/23503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221854 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED should
be fired on the appropriate node any time the accessibility tree changes
- previously we were only firing it in a few circumstances. That guarantees
tools like uiautomatorviewer won't see a stale accessibility tree.

BUG=286374

Review URL: https://chromiumcodereview.appspot.com/23481011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221853 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/18024002 for a similar example.

Note that this API doesn't work on UNIX, so we still need an in-app method of
opening a new window.

BUG=252881
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/23536033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282671

Review URL: https://chromiumcodereview.appspot.com/23890011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221851 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: https://codereview.chromium.org/23522018/

Last CL had a mid-air collision with r221762. It is now merged.

BUG=278913
TBR=asvitkine@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23857008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221850 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
- adds a seek_label option to media seek action. Seek label is used to name the trace graphs of seek measurements.
- makes element ID the default tracing label.
- adds page level skip_basic_metrics check to media measurements.
- fix buffering_time sec to ms bug.

Review URL: https://chromiumcodereview.appspot.com/23456012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242589
TEST=existing kiosk tests pass

Review URL: https://chromiumcodereview.appspot.com/23449023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221848 0039d316-1c4b-4281-b951-d872f2087c98

GTK message-pump defines its own observer, but it has the same name as the
message-pump observers used in other platforms. So rename the GTK version
to MessagePumpGdkObserver.

Also, GTK version of message-pump dispatcher is never used, so get rid of
that.

BUG=145600
R=piman@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/23537016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybot
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23935008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221845 0039d316-1c4b-4281-b951-d872f2087c98

Define _GLAPI_NO_EXPORTS for all platforms.

BUG=286467
R=kbr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221844 0039d316-1c4b-4281-b951-d872f2087c98

First ensure that main thread offscreen context is created after
on-screen context by keeping count of the number of compositors
that are initialized for hardware draw. Also release the compositor
thread offscreen context when the last compositor releases hardware
draw. Freeing the main thread context is still a TODO.

In software mode, still create StreamTextureFactory, but skip creating
StreamTextureProxy. WebMediaPlayerAndroid already works in this
mode, and it just means in-line video does not work in this case.
But video playback is still successful and user is able to enter fullscreen
to get working playback.

BUG=285349

Review URL: https://chromiumcodereview.appspot.com/23618031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221843 0039d316-1c4b-4281-b951-d872f2087c98

dont_override_profile, profile_type, profile_dir, extra_browser_args, extra_wpr_args moved to browser_options.

BUG=269131
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23749004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221841 0039d316-1c4b-4281-b951-d872f2087c98

This makes dragging an image to a folder save the contents, rather than
just saving a .url file.

R=sky@chromium.org
BUG=280238

Review URL: https://chromiumcodereview.appspot.com/23591026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compile with gcc.

Review URL: https://chromiumcodereview.appspot.com/23935006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221838 0039d316-1c4b-4281-b951-d872f2087c98

On Android, the user may disconnect from their Google account and reconnect multiple times within the same session. This case wasn't considered properly when developing the CloudPolicyInvalidator.

When the account is disconnected, the CloudPolicyCore is disconnected before the CloudPolicyStore is reset. When the store is reset, the invalidator unregisters for the policy object and makes a callback to indicate that invalidations are disabled. However, since the CloudPolicyCore is disconnected at this point, a crash is occurring because the code blindly attempts to use objects connected to the core.

Also, when the account becomes reconnected, the refresh scheduler is restarted. This caused the invalidator to be initialized again, which is unexpected.

The solution to these issues is to refactor the CloudPolicyInvalidator to support starting and stopping. The invalidator will listen to events published by the CloudPolicyCore to determine when to start and stop. The invalidator starts when the refresh scheduler starts and stops when it stops.

Also, when CloudPolicyInvalidator::Shutdown is called, outstanding weak pointers held in callbacks should be invalidated. This may not cause any issues since it is likely no messages are pumped on the thread in between the calls to Shutdown and the destructor, but should be fixed.

BUG=280345,272574,280536

Review URL: https://chromiumcodereview.appspot.com/23592017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221837 0039d316-1c4b-4281-b951-d872f2087c98

Reverting per the original change description.

> [temporary M30 fix] Disable dragging tabs with web contents modal dialogs displayed
> 
> The full fix for the crashes in the associated bugs in trunk is too
> risky to merge into M30. After discussions among kareng and sky, the
> best approach was to disable dragging of tabs while a web contents modal
> dialog is displayed, to prevent the crashes. This only affects Chrome
> OS and will be reverted after testing in Canary and merging to the
> branch.
> 
> BUG=275274, 274856
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/23698003

TBR=wittman@chromium.org
BUG=281831

Review URL: https://codereview.chromium.org/23814008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221834 0039d316-1c4b-4281-b951-d872f2087c98

Set accept_events to true when we create top level windowsin desktop AURA. This ensures that we don't end
up using WS_EX_TRANSPARENT when the actual window is created. This causes painting and flickering issues in AURA.
Will investigate that later.

BUG=282628
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23493022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221833 0039d316-1c4b-4281-b951-d872f2087c98

This removes the commandline used on Android and adds references
to each particular bug in the json workaround list.

BUG=280609
R=piman@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/23503038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221832 0039d316-1c4b-4281-b951-d872f2087c98

This allows the Watchdog app to look up history by day. It also gets rid of a redundant ReadData method (now wholly replaced by ReadFilteredData).

BUG=241672
R=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23980002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221831 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23936003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221830 0039d316-1c4b-4281-b951-d872f2087c98

- Computation of dropped frames now correctly accounts for multi-frame drops.
- A welcome side-effect is that variance of the percentage_dropped metric
  is reduced significantly.
- Heads-up for the perf sherrifs: percentage_dropped will increase quite a bit
  with this patch.

R=tonyg@chromium.org, nduca@chromium.org
BUG=264308

Review URL: https://chromiumcodereview.appspot.com/23998002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221825 0039d316-1c4b-4281-b951-d872f2087c98

Add UI elements for extension runtime (javascript) errors on the chrome:extensions page.  Include a stack trace and, if possible, links to the source code.

TBR=finnur@chromium.org
BUG=21734

Review URL: https://chromiumcodereview.appspot.com/23624002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221824 0039d316-1c4b-4281-b951-d872f2087c98

Move the role of handling browser item status from ChromeLauncherController
to BrowserShortcutLauncherItemController.

R=skuhne@chromium.org
BUG=NONE
TEST=browser_tests, unit_tests

Review URL: https://chromiumcodereview.appspot.com/23534022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272732
TEST=Try visiting any IDN site and confirm no punycode is shown in history.

Review URL: https://chromiumcodereview.appspot.com/22862006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221822 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/24054003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221820 0039d316-1c4b-4281-b951-d872f2087c98

Depends on: https://codereview.chromium.org/22912008/

R=vandebo

BUG=151701

Review URL: https://chromiumcodereview.appspot.com/23499006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221818 0039d316-1c4b-4281-b951-d872f2087c98

The file has exec bit set. This breaks the build.

> Added file to verify domain ownership.
> 
> R=kalman@chromium.org
> 
> Review URL: https://codereview.chromium.org/23583040

TBR=awatson@chromium.org

Review URL: https://codereview.chromium.org/23480047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221817 0039d316-1c4b-4281-b951-d872f2087c98

Signature changed with new roll.

BUG=239350
TEST=none
TBR=zhaoqin

Review URL: https://codereview.chromium.org/23626003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221815 0039d316-1c4b-4281-b951-d872f2087c98

Using libyuv for all platforms except Android and iOS. The implementation of OnIncomingCapturedFrame is #ifdef'ed.

BUG=282282

Review URL: https://chromiumcodereview.appspot.com/23870002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221814 0039d316-1c4b-4281-b951-d872f2087c98

Nothing to show in 'Other Bookmarks' when the folder is empty and not
visible in the bookmarks bar. So, prevent moving selection to the
hidden 'Other Bookmarks' folder to avoid a crash.

BUG=275284

Review URL: https://chromiumcodereview.appspot.com/22887030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221813 0039d316-1c4b-4281-b951-d872f2087c98

Configure Views constrained web dialogs to be closed when interstital
WebUI is displayed (e.g. for SSL warnings prior to page load). Affects
these dialogs:

 * print preview
 * SSL certificate viewer (Chrome OS only)
 * profile sign-in confirmation dialog

BUG=240575
R=sky@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/23819028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221810 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23814006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282464
TBR=ygorshenin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23571009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221808 0039d316-1c4b-4281-b951-d872f2087c98

This is direct port of the current content.  No editing yet.

R=eliben@chromium.org

Review URL: https://codereview.chromium.org/23463019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221807 0039d316-1c4b-4281-b951-d872f2087c98

Add -W to SHPINXOPTS to make warnings into error.

Add presubmit check that makes sure sphinx is happy
with the content.

Use 2 spaces to indent code.

Add a missing document.

Fix document links in examples.rst.

Use 'out' for build product data to be constent with
chrome and native_client.

Add 'all' target so that 'make' on its own will work
(I'm lazy)

R=binji@chromium.org, eliben@chromium.org

Review URL: https://codereview.chromium.org/23531031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221806 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/23583040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221805 0039d316-1c4b-4281-b951-d872f2087c98

The "dimmer" cannot be parented by the shelf, but it needs to overlay it. The existing OnBoundsChanged call will only detect size changes since the position relatively to its parent never changes. Therefore the shelf's window needs to be observed as well to get absolute location changes.

BUG=285415
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/24011002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221804 0039d316-1c4b-4281-b951-d872f2087c98

These assets where added when working on RequestAutoComplete dialog
and are no longer needed.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23536037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221803 0039d316-1c4b-4281-b951-d872f2087c98

We're seeing crashes in history::VisitDatabase::GetStartDate coming from
HistoryBackend::ExpireHistoryBetween where db_ is NULL. This change
mitigates this by two avenues: first_recorded_time_ is cleared when the
DB is closed (so that no other code that checks it blows up), and
GetStartDate is no longer called by ExpireHistoryBetween when db_ is
NULL.

Evidence suggests that this bug is responsible for browser crashes at
shutdown that result in a corrupt profile dialog on the next launch.

BUG=275916, 273832, 165282, 107613, 36588
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23861005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221802 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the scrollbar layer animation is triggered at the end of every scroll
gesture. However, as not every scroll gesture actually scrolls a layer, this may
trigger extraneous animations, e.g., when the user overscrolls, or presses and
lifts their finger without scrolling.  Only trigger the scrollbar animation at
the end of a scroll gesture if the gesture caused the layer to scroll.

BUG=285771

Review URL: https://chromiumcodereview.appspot.com/23978008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221801 0039d316-1c4b-4281-b951-d872f2087c98