- 23 Dec, 2019 40 commits
-
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: Ied1ae9172e4a4edf705effdfa14cfb900b128dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975721 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727260}
-
Caleb Rouleau authored
./generate_perf_sharding.py update-timing --waterfall all and commit the results. Bug: 1035696 Change-Id: I5e23afe802f14c5c979fb5f5fc0464df5c00dd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980168 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727259}
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=fdegans@chromium.org Bug: 1035620 Change-Id: I603710df4e6fabeee6dbe9804d7dcb0c016f8984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981055Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727258}
-
Demetrios Papadopoulos authored
Bug: 986596 Change-Id: I9bfc629fdc676c54baa885b568366d9bee5c624d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980178 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727257}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org Bug: 1036055, 1036636 Change-Id: I64c4aefd39cf55fc55eb8f4568821ee610a05f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981062Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727256}
-
Fabrice de Gans-Riberi authored
The test flakily times out. TBR=hta@chromium.org,fdegans@chromium.org Bug: 1033652 Change-Id: I030ba52b88fd758e8bdf0622be3315636d67c33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981049Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727255}
-
Andrew Xu authored
When enabling the hotseat flag, tests verifying the feature of dragging home launcher will fail because the verified feature is disabled in hotseat. This CL disables the hotseat flag for those tests. TBR=xiyuan@chromium.org Bug: 1032702 Change-Id: I2d87572337f2a9971ca5951f177269773bc076a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1435275Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727254}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org,bokan@chromium.org Bug: 1033381 Change-Id: Iec79c0683356f605105fd78dba00ce0d76ef8464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980974Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727253}
-
Richard Li authored
On Intel ICL platform with HDR monitor being connected, we have observed quite obvious wrong color when playing HDR video. The root cause is that sRGB is being used in GLRenderer::DrawYUVVideoQuad mistakenly. This CL fixes it by using the original HDR colorspace instead. Bug: 1033776 Change-Id: I7739c0afc4d623907571cda866a77c51c1f706e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966578Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727252}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/809437762d00..07f0f019e397 git log 809437762d00..07f0f019e397 --date=short --first-parent --format='%ad %ae %s' 2019-12-23 syoussefi@chromium.org Translator: Memory qualifiers on SSBO fields Created with: gclient setdep -r src/third_party/angle@07f0f019e397 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iff2670c76c4e5cfcc57041fcc0815d16045b2cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980159Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727251}
-
Clark DuVall authored
TextViewWithCompoundDrawables will be needed for the permissions dialog in WebLayer, but might as well move everything in the text/ dir since they might be needed later. Bug: 1030785, 1025609 Change-Id: I856713fdc220bd67f78e76b024d446b02bda732e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980164Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#727250}
-
minch authored
Bump up the splitview divider's resizable area from 64dips to 96dips. Bug: 1035126 Change-Id: If0cde6b8c95be47a0871780c8fe4fdd2972f24d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980960Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#727249}
-
rbpotter authored
Move multidevice page files that are unused by browser settings to chromeos/. Note: not moving browser proxy and constants, since these are used by site settings. Bug: 990132 Change-Id: I9864217b0a90eb7e2fb35a9a5a358841a555b650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979513 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727248}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df9071f57626..7cf4a2e19adb git log df9071f57626..7cf4a2e19adb --date=short --first-parent --format='%ad %ae %s' 2019-12-23 herb@google.com Remove unneeded refStrike() from SubRun Created with: gclient setdep -r src/third_party/skia@7cf4a2e19adb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I01d3733183e65e5d3742b956e05418b6710b0e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727247}
-
Kyle Horimoto authored
Because the wallpaper picker app uses the chrome.storage.sync API, it relies on OS app syncing to be enabled. Thus, this type does not have its own ModelType or UserSelectableOsType and instead is a one-off boolean value stored directly in user prefs. TBR=treib@chromium.org Fixed: 1031627 Change-Id: I6e1ea9e762cc964effd61f3cb6903e1f69c34ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977956Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#727246}
-
Andrew Grieve authored
Came upon this by chance. The first entry in these .zip files was: ../$target_name.d.stamp Change-Id: If540c4b67e2c74401146a98c647b88db9cd8ba0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980961 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727245}
-
Anastasia Helfinstein authored
TBR=dmazzoni@chromium.org Bug: 1036903 Change-Id: Icaee78e314f4a89a3c9b9230c968d8a12a14220e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980965Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#727244}
-
Demetrios Papadopoulos authored
Bug: 1036568 Change-Id: I5dfb2baab8429e712105ac2a0b5bf630403cb87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980211 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727243}
-
Gabriel Charette authored
Flakily crashes. Can't revert suspect. See bug for details. TBR=caseq@chromium.org Bug: 1036627 Change-Id: I5dd30e331d8e9dc9d6860528b2d2ccf942c0e6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980878 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727242}
-
Jian Cai authored
some toolchains may implement vcreate_u64 as an assignment to a vector causing a type mismatch: invalid conversion between vector type 'uint64x1_t' (vector of 1 'uint64_t' value) and integer type 'unsigned int' of different size const uint64x1_t LKJI____ = vcreate_u64(L | (K << 8) | (J << 16) | (I << 24)); (cherry-pick from commit b0e09e34) BUG=chromium:1036713 Change-Id: Id0559385826152df228efb4329cdaefb191de01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980129 Commit-Queue: Jian Cai <jiancai@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#727241}
-
Natalie Chouinard authored
Use java_files instead of sources in GN build templates in //remoting/android. TBR=joedow@chromium.org Bug: 1035074 Change-Id: I7786b905f26b9d9180eba01748218ad3ec2ea74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980970Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727240}
-
Fabrice de Gans-Riberi authored
autofocus-in-sandbox-with-allow-scripts.html consistently fails on the WebKit Linux Leak bot. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/8521 TBR=masonfreed@chromium.org,fdegans@chromium.org Bug: 1035582, 954349 Change-Id: Ic4f5b575a2acd72a328b955c0ed0c727c7d7a3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980963Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727239}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=csharrison@chromium.org Bug: 1035074 Change-Id: Id7037c06facb49213bd02a6697f86abfae9dcd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980952Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727238}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I92572cb2f02ed36718a2e2bb112061a3052369d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953735 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#727237}
-
Fabrice de Gans-Riberi authored
This reverts commit bcff0792. Reason for revert: Speculative revert due to svg/as-image/animated-svg-wrong-timesource.html failure. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/8508 for first failure. Original change's description: > Simplify SVGImage::ResetAnimation > > Now that SVGSVGElement::setCurrentTime(...) (or more specifically > SMILTimeContainer::SetElapsed) no longer trigger further updates when > the time container is paused, we can remove the "pending timeline > rewind" workaround. > When doing this also take the opportunity to fold CanScheduleFrame(...) > in SMILTimeContainer into its only caller and simplify a little bit. > > Bug: 998526 > Change-Id: I9ff3de1e8c4b28284bbf3ed27d128206ea7ee857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976410 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#726808} TBR=pdr@chromium.org,fs@opera.com,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998526 Change-Id: Ia0e5739e3a33d2e3c875d2f600b5f2e035701294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980902Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727236}
-
Kurt Horimoto authored
This implements the InfobarType => BadgeType conversion in a shared util target. Bug: none Change-Id: Ib7848c4b9ab79e7d9c605d6c6131c62b4327c8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974758 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727235}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=sky@chromium.org Bug: 1035074 Change-Id: I4242e06e1ddfdb63c6253237ce3e726fb6803883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980956Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727234}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1035074 Change-Id: Ib29bdd73006483c854ef34db3c6ec0fd5bb6d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980954 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727233}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=rbpotter@chromium.org Bug: 1035074 Change-Id: Id56a65abcbf40d811abc669c1cfa638154ae8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980753Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727232}
-
Maksim Sisov authored
1) It is possible to use ChromeOS Chromium builds and run them on Linux machines for development. However, we have made a lot of changes to Ozone/X11 recently, and it started to rely on XSync protocol that ChromeOS has never used (that is, DesktopWindowTreeHostLinux (not used on ChromeOS) listens to swap completions using CompositorObserver (previously, it was DesktopWindowTreeHostX11 doing it) and notifies X11 about swap completions with new sizes during interactive resizes). Previously, X11WindowOzone implementation did not use that extension and ChromeOS/X11/Ozone builds could be run fine on X11 and users could resize the native window without any issues. Now, the resizing operation either stucks or works with glitches. Thus, to fix that, just disable that extension for ChromeOS. 2) Linux/Ozone/X11 builds suffer from the same problem. However, they do listen for swap completions using CompositorObserver, but EGL implementation for Ozone/X11 is quite limited and most of the code is guarded with USE_X11 define. We need to fix that first and only then start to use XSync protocol. Otherwise, the swap results may be sent with delays of several hundreds of ms. Thus, to fix that, explicitly disable the extension for ChromeOS builds. Bug: 1036070, 1036285 Change-Id: I9bc3f5d042c6e8046aaa13bcff42508e433fad28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978740 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727231}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=jbudorick@chromium.org,pshmakov@chromium.org Bug: 1035074 Change-Id: I3423d3481c2baaaa7ccc1724051bdd30f5fb5dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980899Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727230}
-
Gabriel Charette authored
TBR=kevers@chromium.org Bug: 960944 Change-Id: I89ca42f4bca5935e9db9b7c0a68b92c05a364cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980877Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727229}
-
Gabriel Charette authored
TBR=alsan@google.com Bug: 1036054 Change-Id: Ie24ccf69dcece090f2a523d2ac85a80a7d8ba7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980754Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727228}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=asanka@chromium.org Bug: 1035074 Change-Id: Ic99cc6e64039396aa96c3144b8fe9667cac0084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980876Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727227}
-
Tom Anderson authored
This is a followup to [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1974901 TBR=sky Change-Id: I442ffe121378607bdc5e1b16c081b8d66b138955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980900Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727226}
-
Jeroen Dhollander authored
This is a temporary fix. The real fix will be to move away from the Content Service and back to |views::WebView|. This is tracked in b/146351046. - Embedded UI: - TAB and shift-TAB works for settings. - TAB and shift-TAB works for webview based Assistant response (to the query |weather|). - Open Settings, click on other window, click back on settings, verify TAB and shift-TAB still work. - Standalone UI: - TAB and shift-TAB works for settings. - TAB and shift-TAB works for webview based Assistant response (to the query |weather|). Bug: 145213680 Change-Id: If0f39d4911409f177fb1f93525205ad7392bdd35 Tests: Manually tested that: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979633Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#727225}
-
Maksim Sisov authored
For Metacity, we have a workaround which fixes unfullscreening issue. That is, we restore and maximize the window if the previous state before the fullscreen state was maximized. By that, we force metacity to leave the fullscreen. If we don't do it, it may end up in a fullscreen again. However, during our previous refactorings, a regression was introduced. Even though, we followed the same approach, the X11Window::Maximize method didn't directly call XWindow::SetFullScreen, but rather called X11Window::ToggleFullscreen, which resulted in recursive calls to the X11Window::ToggleFullscreen and crashes on X11 level. Also, this CL forces to use previous state when fullscreen is left as long as X server might not send a configure event and change our state. Thus, if it was maximized, set it to maximized. Otherwise, set it to normal as opposed to Unknown state set before. Also, we forgot to move the code that deals with restored bounds when a state change was triggered by X server. This CL restores that behaviour. PS: In a follow-up CL, I will make all state changes to be synchronous as we are doing now in Wayland. TBR=sky Bug: 1034791 Change-Id: I0725625148acf6602e7818823cb96b1d82ef9b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978637Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727224}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=tiborg@chromium.org Bug: 1035074 Change-Id: Icd179380bcba508e87cad272b6d5aee1f72f56b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980874Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727223}
-
Vikas Soni authored
Use the gles2 apis which are meant to be used with shared image mailboxes. We were using legacy mailbox gles2 apis till now here in VideoResourceUpdater::CopyHardwarePlane. It was fine since this code was only used by android video path which always creates shared image mailboxes and registers it with a legacy mailbox. Hence it works with both shared image and legacy gles2 apis. Updating this code in order to convert everything to shared images eventually and get rid of legacy mailbox system. Bug: 900973 Change-Id: I3b9c97f938cd4d15740cd1b6007eaae8f4ef2c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978907 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727222}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08c025c5..05d3b827 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I674dfa3452b0d2b625700e342de45d65f57b93fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727221}
-