- 17 Aug, 2018 40 commits
-
-
Leszek Swirski authored
This reverts commit 5912b768. Reason for revert: Seems to cause Scanner crashes Original change's description: > [v8] Re-post non-blocking ScriptStreamer tasks > > Posted blocking ScriptStreamer tasks can end up in a queue, and have > their Resource complete loading before the task even starts. When this > happens, these tasks will no longer block on network input, but they > will still be posted to the blocking task runner, which does not spin up > new threads if the running task is not blocked. When there are a lot of > small functions posted for streaming, this results in a slightly > paradoxical starvation, where the blocking task runner is processing > lots of no-longer-blocking tasks all in one thread, as it has no reason > to spin up new threads. > > To avoid this, if a streaming task isn't started before the resource > finishes loading, we can cancel this posted task, and instead post a new > non-blocking task to the non-blocking thread pool. This frees up the > blocking task runner to process only blocking tasks (and thus allows it > to spin up new threads for them). > > Bug: chromium:865098 > Bug: chromium:866868 > Change-Id: Iceb282582781109ade233366d1009c3be50db3a5 > Reviewed-on: https://chromium-review.googlesource.com/1174380 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583649} TBR=skyostil@google.com,gab@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,skyostil@chromium.org,altimin@chromium.org,leszeks@chromium.org Change-Id: Iffbab7a8994d12ffce53c6b5b76d19f4db79df0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:865098, chromium:866868, chromium:875162 Reviewed-on: https://chromium-review.googlesource.com/1179641Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#583995}
-
Yutaka Hirano authored
There are three ("follow", "error" and "manual") redirect modes, but among ThreadableLoader clients only FetchManager sends requests with a non-"follow" mode, so move logic for such requests to FetchManager from ThreadableLoader. This is good because this change removes logic effective even when out of blink CORS is enabled from ThreadableLoader. Change-Id: I808826c59db2db61e68051d85e5fec8e4ace91e7 Reviewed-on: https://chromium-review.googlesource.com/1175703 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#583994}
-
Tetsui Ohkubo authored
This CL disables date time settings button when WebUI settings and date time dialog are unavailable. For example, it will not be included in focus traversal on lock screen. TEST=manual BUG=860222 Change-Id: I54e4f1188596413fdfe0a4d826fbcec8cae85b6a Reviewed-on: https://chromium-review.googlesource.com/1177463Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#583993}
-
Alex Clarke authored
Updates the documentation as requested. Bug: 873317 Change-Id: Id1deb86475f93896935e7962350af7033b0246e9 TBR: pfeldman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1177397 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#583992}
-
Tanja Gornak authored
This CL implements routines for serializing and deserializing object ids, which simplifies the logic for storing topics which were already registered for. TBR: pavely@chromium.org Bug: 867402, 801985 Change-Id: Ie859cc87b8e9b3cff54ae2af0eeed68467af09af Reviewed-on: https://chromium-review.googlesource.com/1154921Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#583991}
-
Trent Apted authored
Bug: 867700 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7e0fbb902d969ded9c4713be217c5bff4cba3281 Reviewed-on: https://chromium-review.googlesource.com/1177210 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583990}
-
Jan Wilken Doerrie authored
This change implements skeletons required for WinRT's pairing logic. No actual functionality is added, this will be provided in a later CL. Furthermore, it moves the TestPairingDelegate class from BlueZ's tests into a standalone file. It also wraps the TestPairingDelegate in bluetooth_adapter_unittest.cc in an anonymous namespace to avoid ODR violations. Bug: 821766 Change-Id: If440153dff46476223a1b24dfab1a630fb2451a3 Reviewed-on: https://chromium-review.googlesource.com/1177715Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#583989}
-
David Roger authored
Bug: 807826 Change-Id: I77fc0e169536f86637f7501a6100566a50630f55 Reviewed-on: https://chromium-review.googlesource.com/1177708Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#583988}
-
Friedrich Horschig authored
With this CL, the view stubs (and the views) are moved out of the bottom container, which makes it possible (and necessary) to push up all visible content. This fixes: - the accessory overlaying page contents (esp. bad for fullscreen) - the accessory being pushed up by the keyboard (visual flickering) - clicking through the accessory This changes: - the bar isn't pushed up by bottom sheets (like download) anymore BUT instead pushes them up when the bottom sheet is opened Bug: 874257, 873591, 704070, 853745, 865964 Change-Id: I8185b1ac21aaaed3d7123855b8964a3f86c9845a Reviewed-on: https://chromium-review.googlesource.com/1177361Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583987}
-
Achuith Bhandarkar authored
Disable NetworkQualityEstimatorTest.TestTCPSocketRTT Bug: 875104 Change-Id: Ia7b691d7dbc66621e0df94447ac7d21969eecce7 Reviewed-on: https://chromium-review.googlesource.com/1179227Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#583986}
-
Mounir Lamouri authored
Bug: None Change-Id: Ibad2049d1d75c355ec695e4df4bcc9fe0adb7927 Reviewed-on: https://chromium-review.googlesource.com/1179000 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#583985}
-
Hwanseung Lee authored
When RemovedFrom called, ContainerNode object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91a80d4f49c80730791fe2dfa5f9977404b5bd48 Reviewed-on: https://chromium-review.googlesource.com/1179481Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#583984}
-
Koji Ishii authored
This is a reland of 902e5475 The original patch discovered where NGPaintFragment still in-use are destructed unintentionally. The problem has been there when LayoutNGBlockFragmentation runtime flag was enabled, but it did not cause many crashes fortunately. Re-landing after keeping all NGPaintFragment in use in r583980 (CL:1178081). Original change's description: > [LayoutNG] Store NGPaintFragment in LayoutObject > > This patch stores a one-way linked list of NGPaintFragment to > their source LayoutObject. Looking up the HashMap consumes > non-ignorable time during paint. > > This patch adds IsInLayoutNGInlineFormattingContext flag to > LayoutObject. This flag represents whether the object is in > LayoutNG inline formatting context, even if the object itself > is laid out by legacy. > > With the flag, the storage used for storing InlineBox in > LayoutText, LayoutInline, and LayoutBox are changed to union > to store the first NGPaintFramgent. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7dfd11fafa9b1527b8d77e1fa3a24abf0e7f551e > Reviewed-on: https://chromium-review.googlesource.com/1170726 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583633} TBR=eae@chromium.org, mstensho@chromium.org Bug: 714962 Change-Id: Ie7c000c918e22e24f378eb14ca68243ed0e7bfa8 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1178441Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583983}
-
Keiichi Watanabe authored
This reverts commit 3227909e. Reason for revert: This commit is originally a hack that should be reverted after CL:1134934 and other 3 related CLs are merged. See chromium:819930 for details. Original change's description: > V4L2SVDA: Add hack for shifting ChromeOS-specific control IDs > > This patch makes Chrome work before/after https://crrev.com/c/1134934 > (for chromiumos-overlay), https://crrev.com/c/1136336 (for v3.14) and > http://crrev.com/c/1134929 (for v4.4) are merged, which change > ChromeOS-specific controls' IDs to avoid cofliction with upstream. > > By calling QUERY_CTRL for new IDs, Chrome can detect whether the CLs are > already merged at run-time. If they are not merged yet, Chrome will use old > control IDs instead. > > This patch is needed because we cannot land the kernel change at the > same time as new Chrome build. After new ChromeOS build contains these CLs, > this patch should be reverted. > > Bug: 819930 > Test: Play VP8/VP9 video on veyron_jerry w/o CL:1134934 and CL:1136336 > Test: Play VP8/VP9 video on veyron_jerry w/ CL:1134934 and CL:1136336 > Test: Play VP8/VP9 video on kevin w/o CL:1134934 and CL:1134929 > Test: Play VP8/VP9 video on kevin w/ CL:1134934 and CL:1134929 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I293464d85c4ca28fd3413b89e77e242c0a7648c0 > Reviewed-on: https://chromium-review.googlesource.com/1134933 > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578981} TEST=Play VP8/VP9 video on veyron_jerry TEST=Play VP8/VP9 video on kevin Bug: 819930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I108024ef0c0e78f18efb43fdc389659a19cd63d7 Reviewed-on: https://chromium-review.googlesource.com/1154772Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#583982}
-
Ned Nguyen authored
NOTRY=true TBR=mythria@chromium.org,ulan@chromium.org Bug: 875159 Change-Id: I63d955c029460e138988fa7137c25ecc10d5335f Reviewed-on: https://chromium-review.googlesource.com/1179100Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583981}
-
Koji Ishii authored
This patch stores fragmented NGPaintFragment as a list linked from LayoutNGMixin. The code path doesn't run (break_token is always nullptr) in phase 1. But without keeping them, virtual/layout_ng_experimental will crash randomly when CL:1170726 caches NGPaintFragment in LayoutObject. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c7e4934dcb366d7dcb39412bf1aac40ebad7429 Reviewed-on: https://chromium-review.googlesource.com/1178081 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583980}
-
Donna Wu authored
This CL moves permission checking from device/usb/mojo directory to chrome/browser/usb. This is a preparation step for moving device/usb to service/device. BUG=699790 Change-Id: Ic30d6ff94b670950fcb2571d7036dd7c0f39a24b Reviewed-on: https://chromium-review.googlesource.com/1172154 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583979}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40adb3c41f2a..bc414ed5dec5 git log 40adb3c41f2a..bc414ed5dec5 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 reed@google.com clean up to more modeern conventions Created with: gclient setdep -r src/third_party/skia@bc414ed5dec5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6aa7125b7ec8c761da758c1acd966a01d6aa1e44 Reviewed-on: https://chromium-review.googlesource.com/1179328Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583978}
-
Sam McNally authored
Bug: b:110464348 Change-Id: I356c9411d76cbbc5d0cad51a4aad65eadd600c6b Reviewed-on: https://chromium-review.googlesource.com/1179118Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583977}
-
Toni Barzic authored
Introduces a class that will handle removing pre-installed demo mode resources when needed. First incarnation observes low disk space signal from cryptohome service, and removes pre-installed resources when low space is detected (provided that the device is not in demo mode). When demo mode resources get removed from disk, this is recorded in local state, to avoid future attempts to remove these resources. More logic for requesting demo mode resources removal to come. BUG=827368 Change-Id: I721d1995fa818fc2fc1d056e33ba513380bf441e Reviewed-on: https://chromium-review.googlesource.com/1173670 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583976}
-
Chris Blume authored
When a payload is compressed via zlib using a known-in-advance dictionary symbols that are distant can cause the compression output buffer to be overwritten. This patch applies a fix that comes from upstream: https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aaceab7c615f8020c531 That fix hasn't yet landed in the master branch. This will prevent us from generating those invalid payloads. BUG=874550 Change-Id: Ic421d7242450f866388c90cee67cbc48b92ed83c Reviewed-on: https://chromium-review.googlesource.com/1176284 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583975}
-
Stuart Langley authored
GetResourceEntryCallback is really on a once callback, and by processing multiple team drive entries in the loop we introduce a race condition that can cause a SIGSEGV in private_api_drive when the callback is fired multiple times. Followup work is to get the Deduplicated name for the team drive and store that as the path so that the lookup will only match once. Bug: 875140 Change-Id: I35e381aa82d7c34e200ddc44b085205115fadd86 Reviewed-on: https://chromium-review.googlesource.com/1179483Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#583974}
-
Noel Gordon authored
Bug reported these tests flaking on Mash, but these tests got disabled on all bots. Disable them on Mash, not everywhere. Tbr: xidachen@chromium.org Bug: 874954, 410163 Change-Id: I80eb7b2cb185063d2e3e752fa0ae47d39fc97035 Reviewed-on: https://chromium-review.googlesource.com/1179427 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583973}
-
Satoshi Niwa authored
Since the enum is not used yet, I changed int values for existing items. BUG=b:112571387 TEST=Presubmit passed Change-Id: I1d98cd961df80c455e996e24ea1d58b28574f57e Reviewed-on: https://chromium-review.googlesource.com/1179426Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#583972}
-
Oksana Zhuravlova authored
Change-Id: Id07bb2f1b8cc9c9a30b619b8f89ee6f41169f3f1 Reviewed-on: https://chromium-review.googlesource.com/1178243Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#583971}
-
Luke Halliwell authored
No longer needed now that media suspend is controlled by ContentRendererClient and mojo IPC instead of a switch. This system breaks if apps change render process (e.g. triggered by a cross-origin redirect). Bug: b/73820381 Change-Id: Ie81b5b6cbaa5ecca8d0693f0ff56fdc4aebebdd8 Reviewed-on: https://chromium-review.googlesource.com/1175441Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#583970}
-
Alexey Baskakov authored
Bug: 875042 Change-Id: I33dfb721ad6eeaa04509bb0c83ea92456cb52aaf Reviewed-on: https://chromium-review.googlesource.com/1179423Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#583969}
-
Ken MacKay authored
Bug: internal b/112555253 Test: cast_base_unittests Change-Id: I5ce9bb1ebd4bbf0d72ad6c8953e67a73f4a3f78e Reviewed-on: https://chromium-review.googlesource.com/1179367Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#583968}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0edb982602c6..40adb3c41f2a git log 0edb982602c6..40adb3c41f2a --date=short --no-merges --format='%ad %ae %s' 2018-08-17 khushalsagar@chromium.org fonts: Fix UAF bug in SkRemoteGlyphCache. 2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f0e3c19a0c02..3394a73db973 (2 commits) 2018-08-16 bungeman@google.com SkFontMgr::matchFamilyStyle can return nullptr. Created with: gclient setdep -r src/third_party/skia@40adb3c41f2a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:874740 TBR=kjlubick@chromium.org Change-Id: If4cc8762edc31471fb4ef02d5cf98200970fdc47 Reviewed-on: https://chromium-review.googlesource.com/1179324Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583967}
-
Hwanseung Lee authored
When DefaultEventHandler is called, Event object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 871637 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d3a838ab38393e786ae6cdd184baf4b94343613 Reviewed-on: https://chromium-review.googlesource.com/1175753 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#583966}
-
Ramin Halavati authored
Suggestions and Feed preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ibe4c2545c0d9bab6efd82f1d0972c22bec176c1b Reviewed-on: https://chromium-review.googlesource.com/1176804Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583965}
-
Ramin Halavati authored
ChromeOS Audio preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. This CL won't affect changes from Settings page. Bug: 861722 Change-Id: Id4f4bf82494188ac4501248ffdf4867187b77d3d Reviewed-on: https://chromium-review.googlesource.com/1176807Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583964}
-
Siddhartha authored
This CL sets up a preference for enabling startup tracing if needed. Early java tracing is enabled if the preference is set. This will be used by background tracing to setup startup tracing. BUG=859260 Change-Id: Idf2c6cbfb8c2a4d5e1765a1d2c3256abe69368fe Reviewed-on: https://chromium-review.googlesource.com/1159116 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#583963}
-
Eric Foo authored
Bug: 862864 Change-Id: Idacfb439011488cfb472907c480fb49a704e24fc Reviewed-on: https://chromium-review.googlesource.com/1173760 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583962}
-
Carlos Knippschild authored
I had local build errors requiring explicit constructors and destructor implementations of the PrefetchSuggestion struct but I forgot to add the .cc file containing them to the CL that introduced that class. This change fixes that mistake. TBR: skym@chromium.org, harringtond@chromium.org Bug: 841516 Change-Id: If81f9a3db128b9224d835af5cb7aa40959f093d3 Reviewed-on: https://chromium-review.googlesource.com/1179362Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583961}
-
Eriko Kurimoto authored
Reference https://chromium-review.googlesource.com/c/chromium/src/+/1158315 Bug: 821926 Change-Id: Iaf50ca97a9cceed98a915971b816ca7bdbcd515a Reviewed-on: https://chromium-review.googlesource.com/1172307 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583960}
-
Eliot Courtney authored
with it did not activate it. Bug: b/112629940 Test: Put app into PIP mode, it no longer was activated. Interacting Change-Id: I88cb307afe5a6aba573c27a5fc9d3f150c430649 Reviewed-on: https://chromium-review.googlesource.com/1175751 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#583959}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9faabc5fc371..21068062a038 git log 9faabc5fc371..21068062a038 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 tsepez@chromium.org Remove optionals in CXFA_LayoutPageMgr methods. 2018-08-17 tsepez@chromium.org Remove optionals from CXFA_NodeHelper::NodeAcc_TraverseSiblings(). Created with: gclient setdep -r src/third_party/pdfium@21068062a038 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic71642b01304c9737281e01af5f0fba09b738f54 Reviewed-on: https://chromium-review.googlesource.com/1179325Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583958}
-
Kai Ninomiya authored
This adds a new perf test case for camera-to-WebGL uploads. This new case is intended to detect the performance improvements being made in issue 867368. Bug: 867368 Change-Id: Ia8b05f422e15bb7625491ac10f33903dcc1c55d0 Reviewed-on: https://chromium-review.googlesource.com/1170033Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#583957}
-
rbpotter authored
The test is failing (flaky?) on Mac 10.12. Bug: 874976 Change-Id: I913c6d39d7650e8298cd83eb2236f0f0d027f5d1 Reviewed-on: https://chromium-review.googlesource.com/1178639 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583956}
-