GitLab

MSRVS only provided base::TimeTicks() (0) as frame timestamps for already
decoded frames. This interacted badly with MediaRecorder which received
non-monotonic timestamps.

Bug: 1048140
Change-Id: I9f351f6631154341fd07f5e3dbd429a4eff73a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033766Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#738129}

Bug: 1048173
Change-Id: I0746e310cec111661307b7fea7a0a3fcc2c73004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035672
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738128}

This adds UMA logging for various events during a Sharing WebRTC
connection to identify where the bulk of the transmission delay is spent
and to spot any issues.

Bug: 1021984
Change-Id: I4aea9307cfe0a028ebf29d6054d38cf2f54ee417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027338
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738127}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38e18be3132d..97c653589a1b


Created with:
  gclient setdep -r src-internal@97c653589a1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I863ea9a969927a57d49763b7b6c71cbd4d946cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036424Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738126}

This change removes AppendToString from BasicStringPiece's API.
Similarly to r736299 and r736749 AppendToString is not part
of std::basic_string_view's API and thus would block us from adopting
it.

Existing usages of `piece.AppendToString(&str)` are replaced by either
`str.append(piece.data(), piece.size())` or calls to base::StrCat and
base::StrAppend when these made sense.

TBR=dcheng

Bug: 752720
Change-Id: Ifb5019f221052cd6cc24dce6ce5f2bfbbb24d060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031034Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738125}

Fix the documentation of the "MaxInvalidationFetchDelay" policy to
contain the correct default value: it's 10 seconds, not 5 seconds.

Bug: none
Change-Id: I31a35c57b8c1694c85f97662f281826544335af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036052Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738124}

Before this change, sometimes an asynchronous state could appear where
the chip in the model was disabled while the chip in view was still
enabled.

Bug: b/148771795
Change-Id: I853819aa6046429ad0cd3a380713883f71084454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033771Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#738123}

This deletes the declaration of the
BrowserProcessPlatformPart::DisableDinoEasterEggIfEnrolled()
method, which is unused and has no implementation.

Bug: none
Change-Id: Idfc2743309b179ed0bd6ea308b4c7d4cb4fb2f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036051Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738122}

Sending messages to V8 goes through the following entities:

Browser
  -(IOSession) -> Renderer[IOThread]
     -- Can interrupt or not, depending on
        ShouldInterruptForMethod
  -(Session) -> Renderer[MainThread]
     -- All messages are non-interrupting

At two points it must be decided whether a message should
be interrupting: The first is on the browser side in
ShouldSendOnIO, and the second is ShouldInterruptForMethod in
the renderer's IO thread.

This CL modifies ShouldInterruptForMethod in the renderer
to handle all messages (except Runtime.evaluate) as
interrupting if they are received via the IOSession,
effectively letting the browser decide whether a message
should be interrupting.

This enables the browser to ensure that all messages
whitelisted in ShouldSendOnIO are interrupting for
non-workers, and that all messages for workers are
interrupting (since the browser sends them on the IO
channel).

So there are now 3 types of messages:

1) Sent on Session, non-interrupting. These are most
  messages to non-workers.
2) Sent on IOSession, interrupting. These are the
  whitelisted messages using ShouldSendOnIO in the browser,
  plus almost all messages for workers.
3) Sent on IOSession, non-interrupting. Right now this is
  just Runtime.evaluate, as it shouldn't interrupt running JS.

This, combined with flushing the notification queue after
sending a 'resumed' notification, will fix the referenced bug.

Bug: 1044989, 1044988
Change-Id: Icd6204fd0797d9594ade6f22fa895113d6b03bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027451Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738121}

Add browser tests for the chrome.certificateProvider.requestPin APIs
that verify that the active PIN dialog gets closed when its owner
extension gets disabled or reloaded.

Bug: 987629
Change-Id: I7e550325fcc089c3c05ca16f26437fed74f0fb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036071Reviewed-by: Igor <igorcov@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738120}

kWindowFrameText is not opaque (alpha < 1) and is not web compatible
with the initial value for the color property being Canvastext.

This matches what Safari does for Text and presumably will do for
Canvastext.

Bug: 1047472
Change-Id: Ibc14db48c730e109f5fea9e86f08e0075a69bcb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030957
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738119}

Log a UserAction when the tooltip in CookieControlsBubbleView is shown.
In order to listen for this event, an observer was added to TooltipIcon.

Bug: 1047118
Change-Id: I2e61ce1e689cf17d917da9c4101e3e65f8d7a45d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030170Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738118}

- Opens the Document picker without providing a directory URL to avoid the disappearance of the Cancel button.
The cancel button seems to be hidden when the Downloads folder is empty for obscure reasons and it magically appears if you go to the "recents" section.
By not providing the directory URL, at the first use of the document picker, the user will be in the "recents" section.
During the following uses, the document picker will open where the user closed it for the last time.
This view controller is provided by Apple so we can't do much.

Bug: 1046329
Change-Id: I7bea3c69f0a9317f9cddda9a59ad8a91e7d91863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030964Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738117}

Since the 'intrinsicsize' feature was removed [1], there's no reason to
have an IntSize (that is always set to either 0x0 or 300x150) in the
relevant elements. Remove the IntSize and use the various bools to deduce
the size instead. Also fold and remove the IsMediaElement(...) helper
since it's easier to just use knowledge at the callsites (in the various
element constructors).

[1] d1a6a720
    https://chromium-review.googlesource.com/c/chromium/src/+/1782660

Change-Id: Ie10bcd3725ab9993df274f5ed87f950284bc0609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029516Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#738116}

This CL re-writes a breakpoint web test using a new SourcesTestRunner
helper introduced in https://crrev.com/c/2027427.

This should not only prepare the test for the upcoming source map
asyncification but also reduce the overall flakiness of breakpoint
web tests.

R=sigurds@chromium.org

Bug: chromium:1032016
Change-Id: I48b7bd76f73e1c14773a7896697555798a677c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030168Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738115}

With this CL, the autofill dropdown shows a spinner that indicates that
it is waiting for more data. Like a separator, it's non-interactive.

The password autofill dropdown uses it to indicate that credentials from
the account store are being loaded (and maybe require a reauth).

Bug: 1043963
Change-Id: I173cf52ba1b6f57408af7bf9ee756600ff9e4b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033450Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738114}

This patch introduces the chrome.autofillAssistantPrivate extension API.
Note that this code is gated behind the compile time flag
enable_autofill_assistant_api and is hence not part of official builds
and tests.

It supports basic full e2e autofill_assistant flows and integration
tests for it.

We will add a custom "fyi" tryjob to keep our code green. This patch
includes a browser smoke test to exercise the new extension code.
More browser tests will be added as the skeleton is fleshed out
later.

Bug: 1015753
Bug: b/143736397
Change-Id: Ic727e589286bce8b7e43562642d711a6af89fe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975884
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738113}

ManagePasswordsState::GetCurrentForms() can return an empty vector. When
this happens, the infobar should display the username from the pending
credential since that is the only credential eligible for
password update.

This change also extracts the logic which determines the usernames to
display from the infobar and moves it to the delegate.

Bug:1045941

Change-Id: Idcc8a7149fa931b90d541dc0159e78151183f561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027472Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738112}

Children are now in the RenderFrameHost.

Change-Id: I002f7aefd5acabcab342617557525dac1a77be43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035647
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738111}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a2d408dea60..a9624b4d5d0b

git log 7a2d408dea60..a9624b4d5d0b --date=short --first-parent --format='%ad %ae %s'
2020-02-03 dnovillo@google.com Handle TimeAMD in AmdExtensionToKhrPass. (#3168)
2020-02-03 stevenperron@google.com Update CHANGES
2020-02-03 arseny.kapoulkine@gmail.com Implement constant folding for many transcendentals (#3166)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@a9624b4d5d0b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com
Change-Id: I73e3f2059f79a524f2c99498df4277619c2c928d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738110}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e86b28ffb81..540662253ea3

git log 5e86b28ffb81..540662253ea3 --date=short --first-parent --format='%ad %ae %s'
2020-02-04 johnkslang@users.noreply.github.com Merge pull request #2073 from tsuoranta/fix-memory-corruption

Created with:
  gclient setdep -r src/third_party/glslang/src@540662253ea3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com
Change-Id: Iec10ec1de9f958351a7ca493c4a5232b39417812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036426Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738109}

This allows common code to be factored out, and eventually allow the
same mount function to be used for re-mounting on login and mounting
policy pre-configured shares.

Bug: 939235
Change-Id: Id4c5bd518f505ccf33345325b8a9ada4198fc5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032467Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738108}

In QuicTransport::OnConnectionError, use ErrorIfNeeded() rather than
Error(). This is more correct in the case where the stream is already
errored for some reason.

BUG=1045931

Change-Id: I2c4a012f631238780890b88986e880cc242fdcf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032650Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738107}

"Dictionary" type is a deprecated type in Web IDL spec.  This CL
replaces it in RTCPeerConnection with "any" type, but has no web visible
behavior change.


Bug: 1047081
Change-Id: If2af5caa83568748bea1ca261930575d36db45f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029551Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738106}

The event OnEndEditingTextField seems to be redundant (esp. with focus
changes) and isn't correct in all cases: If users interact with native
UI like an autofill dropdown, the event will try to close this piece of
UI although this isn't always necessary.

This CL therefore removes the event which allows dropdowns to remain
open after interaction if they require it (e.g. see use case in linked
bug).

Bug: 1043963
Change-Id: I5c7a6ede34fb574bd3f91d4b16fbb4e2a78a8d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034527Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738105}

A SourceLocation built from the SourceLocation() constructor is enough
to represent a "missing" SourceLocation.

This is the way all users are handling a base::nullopt anyway:
~~~
source_location.value_or(SourceLocation())
~~~

There is no need to keep the optional. This patches remove it.

A future follow-up will mojoify CSPViolationParams and SourceLocation.

Bug: 1021462
Change-Id: I5eb0551ffffc30044b3a2d4df6a0300ef19e4a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035891Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738104}

This CL uses a newly introduced breakpoint decoration helper to stop
event racing when waiting for breakpoint decorations. Additionally this
CL also removes the race when waiting for a debugger paused event.

The test expectation is updated because:
  - The used helper also dumps all breakpoint decorations
  - The expected stack trace references the web test script itself.
    Moving the 'evaluate' in the test changes the line in the stack
    trace for 'test.js'.

R=petermarshall@chromium.org

Bug: chromium:1032016
Change-Id: I87ba97caff23508bd54b1a21c58ba0a9bf90197f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030901Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738103}

This CL removes a race in a web test where breakpoints get removed and
then the current breakpoint information is dumped. Instead of racing,
we properly wait for the debugger to confirm that the breakpoint got
removed before dumping the information.

Drive-by: Previously {removeBreakpoint} was also marked as async.
This is not needed and this CL removes async/await for
{removeBreakpoint}.

R=petermarshall@chromium.org

Bug: chromium:1032016
Change-Id: I836387085b4b3b8b85b2d035e8031efd4b54e0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033074Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738102}

Looks like there was an erroneous AddRef that would cause this
class to leak.

Bug: 1040128
Change-Id: I1d43e4708fa08cfac011fe6245780caefef571db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035869
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Steve Anton <steveanton@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738101}

This reverts commit bf165340.

Reason for revert: These tests are failing on Mac Debug (Intel) and
Mac Retina Debug (AMD)

Original change's description:
> Add gpu_dawn_integration_gtests to gpu_desktop_gtests and gpu_win_gtests
> 
> This adds dawn_end2end_tests to the following bots:
>   Linux Debug (NVIDIA)
>   Linux Release (NVIDIA)
>   Mac Debug (Intel)
>   Mac Release (Intel)
>   Mac Retina Debug (AMD)
>   Mac Retina Release (AMD)
>   Win10 x64 Debug (NVIDIA)
>   Win10 x64 Release (NVIDIA)
>   Win10 x64 Release (NVIDIA) Code Coverage
>   Win10 FYI x86 Release (NVIDIA)
> 
> On the main CQ, linux-rel, mac-rel, and win-rel will run the tests.
> Usually these tests will be deduped and noop -- unless a build change
> causes the test binaries to change.
> 
> Bug: chromium:1046362
> Change-Id: Ibcd059e262b6a28554bb06aad22a066b69b00953
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033758
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737865}

TBR=ynovikov@chromium.org,kbr@chromium.org,enga@chromium.org

Change-Id: I1c15080dd57ee06d8caa04a95e2524fc9b2c0bfa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1046362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036529Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738100}

This reverts commit c2f29f82.

Reason for revert: Not related to the failure.


Original change's description:
> Revert "macOS HDR: Don't disable GMBs when display is HDR"
> 
> This reverts commit bbd20716.
> 
> Reason for revert: Tests failing on Mac Retina bots.
> Bug: 1048497
> 
> Original change's description:
> > macOS HDR: Don't disable GMBs when display is HDR
> > 
> > We always want HDR videos to use GMBs on macOS.
> > 
> > Bug: 976426
> > Change-Id: I9cf36ef2d031ec99320dde8ce4599664df0fa6f4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034903
> > Reviewed-by: Miguel Casas <mcasas@chromium.org>
> > Commit-Queue: ccameron <ccameron@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#737866}
> 
> TBR=ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org
> 
> Change-Id: I8cdb03e8c0029923ce2afbe89f2596e2e03a0a77
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 976426
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035649
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738085}

TBR=horo@chromium.org,ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org

Change-Id: I2534dc8749474ed0f9c2898ad8ce95b346d5a162
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048497, 976426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037292Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738099}

Adding an entry in .gitattributes so that an entry for pdf files is
present.

Unable to trigger presubmit as changed pdf files cause the following
error:
Unified diff did not contain entry for file

More details listed in the bug.

Bug: 1046228
Change-Id: I5eebb360c48d57b87877c28673814fba955412e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024191Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738098}

This is a reland of 459e299a

The reland rewrites the "addBreakpoint" function in the
"testTwoBreakpointsResolvedInOneLine" test case by using the new
de-flaked helper for both breakpoints (that are on the same line).

Unfortunately, between revert and reland a change to depot_tools requires
JavaScript to be formatted now, so the reland contains lots of
formatting changes compared to the original CL.

Original change's description:
> Prepare breakpoint web tests for source map asyncification (4/5)
>
> This CL re-writes a breakpoint web test using a new SourcesTestRunner
> helper introduced in https://crrev.com/c/2027427.
>
> This should not only prepare the test for the upcoming source map
> asyncification but also reduce the overall flakiness of breakpoint
> web tests.
>
> This CL superseeds the current in-flight CL https://crrev.com/c/2022642
> which will be abandoned.
>
> R=sigurds@chromium.org
>
> Bug: chromium:1032016
> Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737714}

Bug: chromium:1032016
Change-Id: Ibed68e7b8c8494cd3cc6ea0d744ec9c42f7acb5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035375
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738097}

FuchsiaAudioRenderer implements TimeSource. That interface must be
thread-safe, so the fields used in the implementation are protected
with a lock. This CL contains the following fixes for the related code:
 1. Renamed state_lock_ to timeline_lock_: the lock is used for fields
    other than state_.
 2. Added SetPlaybackState(), which helps to ensure that state_ is
    mutated only on the main thread.
 3. Added GetPlaybackState(). It returns current state_ without
    acquiring the lock. This allows to avoid the lock in some cases.
 4. Fixed a DCHECK in FlushInternal() to allow kEndOfStream. That
    DCHECK was failing previously, see linked bug.

Bug: 1035635
Change-Id: I44077a0310635d3136873fb99093290ae74c8806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033928Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738096}

There were two issues with default values in structs:

1. We were generating the wrong expressions for struct constants and
   enums when specifying a struct field's default value:

Wrong:
namespace.StructName.Enum.Value
namespace.StructName.CONSTANT_VALUE

Correct:
namespace.StructName_Enum.Value
namespace.StructName_CONSTANT_VALUE

2. We didn't use the default value when encoding a struct.

Bug: 1040682
Change-Id: I8167f735df0cfef67c20ecbc2ca0b14861ba81da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010754Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738095}

The name and message got switched around. Includes a test.

This bug appears to have been introduced when this feature was added:
  https://chromium-review.googlesource.com/c/chromium/src/+/1697462

Bug: 1047753
Change-Id: Ieb8a3a0d46447007c2fc6f8d864b0f560a996fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033566
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738094}

This reverts commit 885420c7.

Reason for revert: Caused memory leak.
Bug: 1048536

Original change's description:
> Skip clipboard CSS sanitizer when there's no style sheets to sanitize
> 
> The clipboard CSS sanitizer has a side effect that, it may add
> additional inline styles to elements to match their computed style in
> the dummy document.
> 
> This isn't necessary when the markup doesn't have any style sheet to
> sanitize, in which case the side effects are undesirable and causes
> some regressions. Hence, this patch skips the sanitization when there
> are no style sheets.
> 
> Bug: 1047806
> Change-Id: I62e20fb5fe29d56bda9d86ca12499b7ffb1497e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036731
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738083}

TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org

Change-Id: If772ff5e756be2472bba906748fc838c0aabe574
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037173Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738093}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I105be2775c9f492e2fa682000f2d4f54d0088b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036787Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738092}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1ebb9c9e059..38e18be3132d


Created with:
  gclient setdep -r src-internal@38e18be3132d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I8b09d4b0f96a5fedba4d699c972d0418d6e3faa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037101Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738091}

Tweaks the mock app to mimic more of the "real" app in the way it
replaces the currently opened file on new launch/open requests.

Tests by loading a new test file of a different size, and adding a
robust way to ensure it has replaced the previous file.

Tested on both open-source and linux-chromeos-chrome bots.

Test: MediaAppIntegrationTest.MediaAppLaunchWithFile
Bug: 1023742, b/144866119
Change-Id: I8de32dc7ebc64e3fabf75e65be10fe79433fcb35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033011Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738090}