- 23 Nov, 2018 40 commits
-
-
Mounir Lamouri authored
Tested locally and everything is fine. Bug: 733494 Change-Id: I23f3cde42b14d2461fc94a391c6427d5c2aa9e1d Reviewed-on: https://chromium-review.googlesource.com/c/1263569 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610670}
-
Nicolás Peña authored
This CL moves the tests in http/tests/event-timing to external/wpt/event-timing. The slow image is change from php based to python based. The click is now handled by test driver. and setTimeout is replaced with step_timeout. Bug: 841224 Change-Id: I035c087550a2d9a67cda1aed88553c16967d04b6 Reviewed-on: https://chromium-review.googlesource.com/c/1349451 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#610669}
-
Liquan(Max) Gu authored
TextPaintTimingDetector and ImagePaintTimingDetector have the same codes to calculate the visual size of a rect. We can move this common part into PaintTimingDetector. This CL also refactor the logic in CalculateVisualSize for simplification. The new signature return the size value instead of the rect. By do this, we can save the logic of getting size from rect in RecordText and RecordImage. Bug: 869924 Change-Id: Icc2b88db90c1816e24f8ba7446ada701996fc652 Reviewed-on: https://chromium-review.googlesource.com/c/1348859 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610668}
-
Yoav Weiss authored
This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. [1] https://github.com/w3c/resource-timing/pull/168 Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80 Reviewed-on: https://chromium-review.googlesource.com/c/1345269 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610667}
-
Sam Maier authored
This reverts commit aaf0add8. Reason for revert: crbug.com/908131 Original change's description: > Reland "Introduce bundle-specific native libraries" > > This is a reland of 50ab16b8 > > Original change's description: > > Introduce bundle-specific native libraries > > > > This will allow native code to be stripped out of the main library > > when it moves to a Dynamic Feature Module. For now, the libraries will > > be identical. > > > > BUG=874584 > > > > Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913 > > Reviewed-on: https://chromium-review.googlesource.com/c/1332248 > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Reviewed-by: David Turner <digit@chromium.org> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608519} > > Bug: 874584 > Change-Id: I197543b47e1613f93164ebd6f9a4c9d84743e284 > Reviewed-on: https://chromium-review.googlesource.com/c/1344875 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610456} TBR=digit@chromium.org,yfriedman@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874584 Change-Id: I3a80af1de5e8e932c47262290449082d93cf0da5 Reviewed-on: https://chromium-review.googlesource.com/c/1349856Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#610666}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 128d9b67. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ic69b103830303e2d026e7436fdc89ace288c242d Reviewed-on: https://chromium-review.googlesource.com/c/1349461 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610665}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/43e8ebcaf284..17079a5cc1f2 git log 43e8ebcaf284..17079a5cc1f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 perezju@chromium.org [soundwave] Cleanup .gitignore Created with: gclient setdep -r src/third_party/catapult@17079a5cc1f2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903026 TBR=sullivan@chromium.org Change-Id: I3c4ceeafde37f60af2a24df14e5ff926eeaa932f Reviewed-on: https://chromium-review.googlesource.com/c/1349440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610664}
-
Mounir Lamouri authored
Bug: 906320 Change-Id: Ib746b529aa0be13d913a4ee08528e1f8b0d822d4 TBR: mythria@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349791 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610663}
-
Dan Elphick authored
Change deprecated v8::Handle to v8::Local. Bug: v8:8238 Change-Id: Ic6fcf5f8aba221d2c48f11502656df88b1b84a24 Reviewed-on: https://chromium-review.googlesource.com/c/1348470Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610662}
-
Peng Huang authored
Bug: None Change-Id: If5fc6dcdc8f5a24a5b34f9b2811f48fdd55a77aa Reviewed-on: https://chromium-review.googlesource.com/c/1349675Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610661}
-
Mounir Lamouri authored
Bug: 898546 Change-Id: I18f631b57d17eb9750ec37b1e7a00fa0d7d3cbea TBR: yvesg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349450 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/095cc6722fa5..9e71de132fbc git log 095cc6722fa5..9e71de132fbc --date=short --no-merges --format='%ad %ae %s' 2018-11-23 baldurk@baldurk.org Add cmake option to turn off SPIRV_TIMER_ENABLED (#2103) 2018-11-23 dgkoch@users.noreply.github.com Add basic support for EXT_fragment_invocation_density (#2100) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e71de132fbc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I08206fc9377d6acbc744a2b383c807f53092e101 Reviewed-on: https://chromium-review.googlesource.com/c/1349438Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfbb007cffb6..600375480473 Created with: gclient setdep -r src-internal@600375480473 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib65fe04fd228d71e78018f86c44118cb1188ccd0 Reviewed-on: https://chromium-review.googlesource.com/c/1349441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610658}
-
Mounir Lamouri authored
This reverts commit 97df93d4. Reason for revert: added test was falky, see crbug.com/908071 Original change's description: > Don't unmount zip files when canceling password input. > > BUG=808300 > > Change-Id: Ib37a53399efd57a9306e4b47630391c265825b90 > Reviewed-on: https://chromium-review.googlesource.com/c/1345692 > Commit-Queue: Anand Mistry <amistry@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610336} TBR=noel@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true Bug: 808300 Change-Id: If2c4d54fb70b57d33aeec55adc3404836345d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/1349752 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Alexander Shah authored
R=riajiang@chromium.org Change-Id: I1bce7704658f999daf6a7f177d02434661342992 Reviewed-on: https://chromium-review.googlesource.com/c/1349792Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Alexander Shah <zandershah@google.com> Cr-Commit-Position: refs/heads/master@{#610656}
-
Mounir Lamouri authored
This required to create a custom callback class as CallbackPromiseAdapter does not work well with dictionaries. This is also updating the media-capabilities.idl file in WPT, based on: https://raw.githubusercontent.com/tidoust/reffy-reports/master/whatwg/idl/media-capabilities.idl Bug: 907704 Change-Id: I13bb3c43a7461398f7866f033527bd3ce1bed140 Reviewed-on: https://chromium-review.googlesource.com/c/1347001 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#610655}
-
Chris Mumford authored
A speculative fix in ChunkedDataPipeUploadDataStream::ReadInternal which was being passed a null |buf| parameter and dereferencing it. The speculation is that ChunkedDataPipeUploadDataStream::OnHandleReady was being called before ChunkedDataPipeUploadDataStream::ReadInternal had ever been called. ReadInternal is what first sets |buf_| which is used by OnHandleReady. Moving the call to Watch() inside ReadInternal avoids this condition. Bug: 901116 Change-Id: Icda0f96454362b7f996e0fdc9440127f023d99ee Reviewed-on: https://chromium-review.googlesource.com/c/1334000Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#610654}
-
Andrew Grieve authored
I spot checked the last 10 builds on: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Android And it's been fine. I also checked locally that the .jar file has a hermetic timestamp for the file entry (via unzip -lv) Bug: 897970 Change-Id: Ifd38c3b7c197fbf2175cf16f462d56be31d1da2d Reviewed-on: https://chromium-review.googlesource.com/c/1349674Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610653}
-
Andrew Grieve authored
Bug: 897969 Change-Id: Ifef819c0308ffd5065e54915065cd8a586ba217f Reviewed-on: https://chromium-review.googlesource.com/c/1349749Reviewed-by:
-
Mustaq Ahmed authored
Also marks one currently untestable test. Bug: 906791 Change-Id: I17fd03f16e93244be80f9572db8c43e8e0b95678 Reviewed-on: https://chromium-review.googlesource.com/c/1347092 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afef11dc26bd..dfbb007cffb6 Created with: gclient setdep -r src-internal@dfbb007cffb6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7833ac596269b2efa28ef047a29adc95e1436666 Reviewed-on: https://chromium-review.googlesource.com/c/1349439Reviewed-by:
-
Mounir Lamouri authored
It's flaky on all platforms and is starting to flake on the leak bot. Bug: 891155 Change-Id: I1aa21d9232bc88e02cc8c17d08c0ee17dc08434e TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349453Reviewed-by:
-
Stephane Zermatten authored
Before this change, PromptAction only supported normal chips. This change adds support for displaying choice as scripts in buttons with highlights. The way this is done reproduces exactly the way buttons are configured for scripts, sharing the same logic and code. The idea is that it would help keep the two consistent. Bug: 806868 Change-Id: I82b3a49b1339e4aecd1c3dffabb826022fbac1e6 Reviewed-on: https://chromium-review.googlesource.com/c/1348050 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610648}
-
Dave Tapuska authored
Use wtf_size_t as opposed to size_t BUG=879657 Change-Id: If00143969f0c18bbfb54b6b602e5b915e756dd3b Reviewed-on: https://chromium-review.googlesource.com/c/1349750Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610647}
-
Dan Elphick authored
Value::ToObject(Isolate*) is deprecated because it doesn't force the user to check whether a result was actually returned. This changes MessageChannel::Create to use the Context version and calls FromMaybe on the result. This will return an empty Local if ToObject throws which would happen if its input was undefined or null (https://tc39.github.io/ecma262/#sec-toobject). Bug: v8:7279, v8:8238 Change-Id: I51c48350d1c50507d2dff6ef5c5a97cf2b03ddb5 Reviewed-on: https://chromium-review.googlesource.com/c/1344100 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Sami Kyostila authored
This story is also failing on Windows. It was previously disabled on Mac. NOTRY=True TBR=charliea@chromium.org Bug: 903417 Change-Id: I23d63c76f313dd18413d7d112a5fbfd44546ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/1349326Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610645}
-
Marc Treib authored
Consents have been moved to their own data type and thus have their own Sync bridge. Bug: 905639 Change-Id: Idf4a9ee11b74eac38f158a0135a4a1998f04fe2a Reviewed-on: https://chromium-review.googlesource.com/c/1349649Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610644}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1a5db00d4018..46505d3c656f git log 1a5db00d4018..46505d3c656f --date=short --no-merges --format='%ad %ae %s' 2018-11-23 fmayer@google.com Merge "profiling: Add convenience script to profile." Created with: gclient setdep -r src/third_party/perfetto@46505d3c656f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I37f20422725425d102463599455c7c7ad900ac66 Reviewed-on: https://chromium-review.googlesource.com/c/1349632Reviewed-by:
-
Mugdha Lakhani authored
Move the creation of ResponseReadyProperty to the contructor of BackgroundFetchRecord. This helps us simplify responseReady(). We can simply return the promise of the created ResponseReadyProperty every time it's called. Bug: 875201 Change-Id: Idfb97864ebbe57b770cad76d215f08177eda8175 Reviewed-on: https://chromium-review.googlesource.com/c/1349712Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#610642}
-
Tim Volodine authored
Currently flaky on KitKat phone tester bot. BUG=908118 TBR=twellington@chromium.org,eseckler@chromium.org NOTRY=true Change-Id: Id8a76dafef89d1f2098e1e9a0ebe8fd1b78c8b86 Reviewed-on: https://chromium-review.googlesource.com/c/1349654 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610641}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01b0845a..500be6dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0a123adfab356f6344725f4cd22050e15e34eea Reviewed-on: https://chromium-review.googlesource.com/c/1349671Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610640}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8d95114b66d..afef11dc26bd Created with: gclient setdep -r src-internal@afef11dc26bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8f20a2e4ae31493f98e7fa1cd3fee6c73579b6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1349631Reviewed-by:
-
Peng Huang authored
Bug: 906688 Change-Id: If53d2ad9420440a5b9cb214b2c23fd64168187b9 Reviewed-on: https://chromium-review.googlesource.com/c/1348862Reviewed-by:
-
David Jean authored
Bug: 907082,907001 Change-Id: I30d4a9f0a1463f3b500cefc255b4335bde790b37 Reviewed-on: https://chromium-review.googlesource.com/c/1348109Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#610637}
-
Dave Tapuska authored
This avoids a possible truncation warning. BUG=879657 Change-Id: I533c053523c8ade81bb54b55071d4d509e834cbb Reviewed-on: https://chromium-review.googlesource.com/c/1348970Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610636}
-
Boris Yusupov authored
to allow to migrate variations from master preferences to Local State Change-Id: I25cca8a8265e2fae57d5d0a13b053e577a9bba11 Bug: 907434 Change-Id: I25cca8a8265e2fae57d5d0a13b053e577a9bba11 Reviewed-on: https://chromium-review.googlesource.com/c/1344097 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610635}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I826a5cba05bb6c5f322ddde79eecd2f64a942045 Reviewed-on: https://chromium-review.googlesource.com/c/1349261 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610634}
-
Dan Elphick authored
Since all uses are preceded by IsInt32 checks, it's safe to convert all these uses to As<v8::Int32> casts. Bug: v8:7279, v8:8238 Change-Id: I6fadc29adf85294afaa4f7980353ab43add75771 Reviewed-on: https://chromium-review.googlesource.com/c/1349228Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610633}
-
Boris Sazonov authored
This CL adds isOperationInProgress and runAfterOperationInProgress methods to SigninManager and uses these methods in SigninHelper.validateAccounts. SigninHelper has been causing many test failures recently because it attempts to start resign-in before previous sign-out is finished. Tests for isOperationInProgress and runAfterOperationInProgress will be added in subsequent CLs, as they require significant amount of changes around SigninManager (it's not quite testable at the moment). Bug: 903657, 903658, 906188, 906193, 906788 Change-Id: I216e16874adef6a050df4796eab4eb55ddf6fa6c Reviewed-on: https://chromium-review.googlesource.com/c/1345069Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610632}
-
henrika authored
The GetMixFormat method retrieves a format descriptor that is in the form of a WAVEFORMATEXTENSIBLE structure instead of a standalone WAVEFORMATEX structure. The method outputs a pointer to the WAVEFORMATEX structure that is embedded at the start of this WAVEFORMATEXTENSIBLE structure. Note that, crbug/803056 indicates that some devices can return a format where only the WAVEFORMATEX parts is initialized and we must be able to account for that. This CL improves usage of WAVEFORMATEX/WAVEFORMATEXTENSIBLE by introducing a wrapper structure called WaveFormatWrapper. The idea is to avoid assuming that the underlying structure is extended when it actually isn't even if a WAVEFORMATEXTENSIBLE is used. Also stops using WAVEFORMATPCMEX in the utility to avoid assuming PCM format. Bug: 803056, 905969 Change-Id: I6a9fe3e23b3537df81f9d4ed610c12935668a253 Reviewed-on: https://chromium-review.googlesource.com/c/1335560 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610631}
-
