- 25 Jan, 2018 40 commits
-
-
Gabriel Charette authored
This is a reland of 2e4eab14. Doesn't appear to be at fault for crbug.com/803517 as suspected. Original change's description: > Reland "Make many base:: classes constexpr default constructible" > > This is a reland of d74c23a2 > Original change's description: > > Make many base:: classes constexpr default constructible > > Same CL but extracted scoped_refptr changes to separate CL. > > > > > Bug: 800760 > > Change-Id: Ib713771347283825ff53a8517b38a8abccd9d1bb > > Reviewed-on: https://chromium-review.googlesource.com/860157 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#528805} > > Bug: 800760 > Change-Id: Ia989d978f632075c21f11cd81687f52b9e2bd2ca > > TBR=dcheng@chromium.org > > Change-Id: Ia989d978f632075c21f11cd81687f52b9e2bd2ca > Reviewed-on: https://chromium-review.googlesource.com/863622 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528934} TBR=dcheng@chromium.org Bug: 800760, 803517 Change-Id: Ic987b883e6ccacaa0b2e26b55d875cf4b484a5cc Reviewed-on: https://chromium-review.googlesource.com/886323 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#531890}
-
kylechar authored
For not OOP-D, when destroying a viz::Display there is a sync IPC in CommandBufferProxyImpl::DisconnectChannel() that ensures the GL context/surface that draw to the platform window are destroyed. The platform window is destroyed after that sync IPC which ensures the GPU doesn't try to swap to a buffer that doesn't exist. Currently for OOP-D, HostFrameSinkManager sends an async IPC to the GPU process asking it to destroy the viz::Display. The browser process destroys the platform window after sending the async IPC. The GPU may try to swap to a buffer that doesn't exist and error/hang/crash. Add a sync IPC, only used in the case of root CompositorFrameSinks, that guarantees the GL context/surface are destroyed. This eliminates a big source of GPU hangs/crashes with --enable-features=VizDisplayCompositor. Bug: 777594 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I70e9b031e80de233856194f1beaa9377f332c3c0 Reviewed-on: https://chromium-review.googlesource.com/874724 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531889}
-
Raphael Kubo da Costa authored
Nullable<T> has not been used in the code since commit dc5d9051 ("Add PermissionDescriptor to the permissions Mojo interface"). R=mlamouri Change-Id: I31646df8e77abf5a271a27731215ef8e041208ec Reviewed-on: https://chromium-review.googlesource.com/885847 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#531888}
-
Gauthier Ambard authored
This CL fades out the primary toolbar controls during fullscreen progress. It doesn't change the location bar as it needs a special treatment. Bug: 804730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibaf8982f41c9b2e0841de6359db4f95436d39330 Reviewed-on: https://chromium-review.googlesource.com/883524 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#531887}
-
stkhapugin@chromium.org authored
Before this CL, BVC is Toolbar's delegate, which is a LocationBarControllerImpl's delegate. We would like for the LocationBarCoordinator to own LBControllerImpl fully. For this, the LocationBarCoordinator needs to become its delegate. However, the delegate is mostly forwarding commands to BVC. So after this CL: 1. BVC is the delegate for LBCoordinator. 2. BVC calls Toolbar methods for Toolbar to react to events in LB. 3. LocationBarCoordinator is delegate for LBControllerImpl. 4. Remove old TODO and related ivar in BVC. Bug: 785253, 244366 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a735ed60a54c040437a91ff225f0c6c31e0e799 Reviewed-on: https://chromium-review.googlesource.com/881165 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#531886}
-
Egor Pasko authored
Not sure which ones would be more useful for end metrics later, let's see. Bug: 760498 Change-Id: I46a878ebf3a65ed164fa8df95b2846ed04cbde83 Reviewed-on: https://chromium-review.googlesource.com/883449 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#531885}
-
Ioana Pandele authored
The alert is displayed after the user taps on the Export passwords... button. Change the message to comply with the latest mocks. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I778f5000f16b18c62f42bea4307a62a91ab079fc Reviewed-on: https://chromium-review.googlesource.com/886363Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#531884}
-
Mostyn Bramley-Moore authored
Change-Id: I07ce4c92bb0cb427f3cd2f1b18d48a0e15021de5 Reviewed-on: https://chromium-review.googlesource.com/883288 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531883}
-
David Bokan authored
This fixes the attached bug since the cause is that the XTest pointer is generating window crossing events (XI_Leave/XI_Enter) when implicitly capturing the pointer for the slave device. For physical devices, these events are generated only for the master pointer. This CL fixes it by letting the crossing events pass through the filtering checks applied by ShouldProcessXI2Event. pointer_device_lookup_ stores only the master pointers so this filters out the test slave. I haven't been able to determine what makes the XTest pointer but the fix makes sense since window crossing events only make sense on a pointer and in that case we should always use the master. Bug: 683434 Change-Id: Id96dacb6db49a95fae33105de2fcfe2b9f8d1b44 Reviewed-on: https://chromium-review.googlesource.com/883601 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#531882}
-
Vasilii Sukhanov authored
TBR=joedow NOTRY=true Bug: 805794 Change-Id: Ic54f541b8d5b3dd4905830fe39acd7dd42b9911c Reviewed-on: https://chromium-review.googlesource.com/886681Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531881}
-
Benoit L authored
This reverts commit 733c2818. Reason for reland: The initial change is actually an improvement, see the linked bug. Original change's description: > Revert "android: Don't parse /proc/self/maps to prefetch the library." > > This reverts commit ef6f0fb3. > > Reason for revert: Regressed startup performance. > See https://chromeperf.appspot.com/report?sid=9df0ec76b0fffc74931cc7bdcf44cd4d540f81bb34ccde3571c2211ec8360ee6&start_rev=531281&end_rev=531574 > > Original change's description: > > android: Don't parse /proc/self/maps to prefetch the library. > > > > This commit changes the behavior of the native library prefetcher to > > rely on sentinel symbols rather than parsing /proc/self/maps. > > > > Behavior changes: > > 1. This will make the code no longer prefetch .data (because we don't > > look for it in the mappings), neither the sections that are part of > > the same mapping as .text (for instance, .rodata when using > > ld.gold). This is intended. > > 2. As a consequence, the UMA metric > > LibraryLoader.PercentageOfResidentCodeBeforePrefetch will move, as > > both sides of the ratio will change, and the population will change > > slightly as well (since code is currently not correctly ordered on > > ARM64 and x86_64) > > > > - Removes the reliance on a somewhat brittle parsing of a file > > - Parsing /proc/self/maps costs ~50ms of CPU on a Nexus 5X (on a little > > core, as this is triggered from an AsyncTask) > > - Allows to only fetch part of the native library (in a forthcoming CL) > > > > Rationale: > > Change-Id: I0bb7b28af3c3bd4af5745e2ebcc1fbf283bcc0c1 > > Reviewed-on: https://chromium-review.googlesource.com/874470 > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Reviewed-by: Egor Pasko <pasko@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Matthew Cary <mattcary@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#531515} > > TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org > > Change-Id: I11d7cd7898d5f8d8fbebf391eba5fdaca154c08a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/886321 > Reviewed-by: Benoit L <lizeb@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531858} TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org Bug: 805883 Change-Id: Ida889088ec69c09f4dd95dd976174b5532811a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/886621 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#531880}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/be84b720c778..eeaa89d1f406 $ git log be84b720c..eeaa89d1f --date=short --no-merges --format='%ad %ae %s' 2018-01-25 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2e551f6bc..2d8e432a9 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I80a9bf8fe39e717d9568755c2dcaff2eaa659694 Reviewed-on: https://chromium-review.googlesource.com/885916 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531879}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: Idf979483eb3e66fbd151d2f8c0834d927b707c97 Reviewed-on: https://chromium-review.googlesource.com/874693Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531878}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/8ed653d1c4ea..b9b07eaf281a $ git log 8ed653d1c..b9b07eaf2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I62d00a18ff7b923b642ec6a45bc1c5c76bea89bb Reviewed-on: https://chromium-review.googlesource.com/886143Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531877}
-
Mostyn Bramley-Moore authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8bad8fbcce92bb46a926a7b8fa4e357ad7c052c Reviewed-on: https://chromium-review.googlesource.com/882321Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#531876}
-
Han Leon authored
This CL starts to move ServiceWorkerClientInfoPtr through impl of service_worker_client_utils rather than passing value of ServiceWorkerClientInfo struct. BUG=772793 Change-Id: I852efee05dfda6f86b0486912827c29b00071a9d Reviewed-on: https://chromium-review.googlesource.com/886141 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531875}
-
Mikhail Pozdnyakov authored
The sensor policy-controlled features should be checked in the browser process, in order to improve security robustness. This patch introduces browser-side feature policy check for both the Generic Sensor and the Device Orientation APIs. Bug: 796894 Bug: 795723 Change-Id: Idc9869d75bca70f3f9ee915101195c7cbee22587 Reviewed-on: https://chromium-review.googlesource.com/850699 Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#531874}
-
Sunny Sachanandani authored
key_silk_cases.Page26 was disabled by manually removing it from the StorySet. This is probably a relic of a time before story expectations were implemented. This CL disables the page using expectations. BUG=461127 Change-Id: I055b6bd78667a16b59120211698dd0281419e25e Reviewed-on: https://chromium-review.googlesource.com/884987Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#531873}
-
Ramin Halavati authored
Network traffic annotaiton is added to the socket write in WebSocketBasicStream::WriteEverything(). Bug: 656607 Change-Id: Id9ae38031afb9b8bd6485c1b6db8932a83527fa8 Reviewed-on: https://chromium-review.googlesource.com/877888 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#531872}
-
Xianzhu Wang authored
Single requestAnimationFrame doesn't do the expected work. Double requestAnimationFrames do. And we have runAfterLayoutAndPaint for layout tests for more accurate control. Change-Id: I19ece0ff7887d33736ebece79beb6495e4300bca Reviewed-on: https://chromium-review.googlesource.com/886142 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531871}
-
Mostyn Bramley-Moore authored
Fix courtesy of Fredrik Söderquist <fs@opera.com> Bug: 421909 Change-Id: I69f4f71eb534ebdb885d34ec645c668e9b2772fd Reviewed-on: https://chromium-review.googlesource.com/885808 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#531870}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9bb5cf9..5bc21ae5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifbe9a2666fde228161a85af26d97734d1e74e1de Reviewed-on: https://chromium-review.googlesource.com/886382Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531869}
-
Hajime Hoshi authored
This is part of efforts to replace non-per-frame task runners with other appropriate per-frame task runners in the renderer. Bug: 804694 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ifcbf610a71e87f5570c3c0b5ffcda97fe10bfc39 Reviewed-on: https://chromium-review.googlesource.com/886441Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531868}
-
Ramin Halavati authored
Network traffic annotation is added to socket writes of: jingle/glue/chrome_async_socket.cc jingle/glue/fake_ssl_client_socket.cc Bug: 656607 Change-Id: I01e083c9a7154a6fc5071839a4f26007e3717ea4 Reviewed-on: https://chromium-review.googlesource.com/885812Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#531867}
-
Kush Sinha authored
Child accounts on Chrome OS will be forcibly logged out if account reconciliation timeout is reached without a successful reconciliation. Other accounts will maintain their existing behavior. Bug: 795808 Change-Id: If7dc163e2d0921a7e360aed9673b235d1a2d9c7c Reviewed-on: https://chromium-review.googlesource.com/883285 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#531866}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8af6931d8777..9c4fd243124b $ git log 8af6931d8..9c4fd2431 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Iace4719648870ad5951663e0da058714afba8ed9 Reviewed-on: https://chromium-review.googlesource.com/885911 Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531865}
-
Gauthier Ambard authored
This CL changes the OmniboxPopup such as it doesn't need access to the toolbar view to be presented. Instead it only needs a pointer to its superview. The pointer to the view was used to present the popup above or below it to show the shadow between the omnibox and the popup or not. This CL changes it by adding the shadow if needed in the popup. It also removes the white rectangle recovering the place normally occupied by the toolbar during NTP animation (to avoid seeing the google logo moving up as the toolbar is hidden). To do that, the toolbar is directly shown if there are results to be displayed. Bug: 786940 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a8dea25702b4644f0f0c76fc34b01c1deaf6a88 Reviewed-on: https://chromium-review.googlesource.com/881182 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531864}
-
Andreas Haas authored
It can happen that WebAssembly.compileStreaming gets aborted when we are not allowed to execute JavaScript code, and therefore are also not allowed to reject the promise returned by WebAssembly.compileStreaming. This can happen e.g. when the Chrome tab gets refreshed, which aborts all downloads. With this CL we do not pass a reason to Abort if we are not allowed to execute JavaScript code. On the V8 side we can check the reason passed to Abort and do not reject the promise if there is no reason passed. The V8 side change is at crrev.com/c/876091 R=mtrofin@chromium.org Bug: chromium:803838 Change-Id: I55727f97fac38790cadc34ec5284131e13642f20 Reviewed-on: https://chromium-review.googlesource.com/876103Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531863}
-
Juan Antonio Navarro Perez authored
These do no longer work. Bug: 804863 Change-Id: Id0bfff21aa9d7fc4338a37bdfcdf9d820ce32ea5 Reviewed-on: https://chromium-review.googlesource.com/881321Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#531862}
-
Yoshifumi Inoue authored
This patch changes how editing forces legacy layout to the one added for form controls[1] to use legacy layout tree for nested editable, e.g. <div contenteditable> legacy layout tree <div contenteditable=false> non-editable block in editable block should be legacy </div> </div> This patch continues http://crrev.com/c/880542 [1] http://crrev.com/c/875511 Change form controls not to use LayoutNG Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I78d44fc82b3de5e647b67ee6aa7733db62e344b8 Reviewed-on: https://chromium-review.googlesource.com/880530 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531861}
-
Yuta Kitamura authored
This patch adds a new function to WebScheduler so that Timer can obtain the current virtual time without using WebTaskRunner::Monotonically- IncreasingVirtualTimeSeconds(). WebTaskRunner::MonotonicallyIncreasingVirtualTimeSeconds() is not deleted in this patch, though, because there are some tests using it and they deserve a separate patch. Bug: 794845 Change-Id: I21c2f7accc86c7216ee917e5c29bc0ad3ec44b07 Reviewed-on: https://chromium-review.googlesource.com/882703 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#531860}
-
Harald Alvestrand authored
Bug: 801642 Change-Id: Ib92b6d857d5add650a757618adb38d7c7ed5c8f7 Reviewed-on: https://chromium-review.googlesource.com/885801Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#531859}
-
Benoit L authored
This reverts commit ef6f0fb3. Reason for revert: Regressed startup performance. See https://chromeperf.appspot.com/report?sid=9df0ec76b0fffc74931cc7bdcf44cd4d540f81bb34ccde3571c2211ec8360ee6&start_rev=531281&end_rev=531574 Original change's description: > android: Don't parse /proc/self/maps to prefetch the library. > > This commit changes the behavior of the native library prefetcher to > rely on sentinel symbols rather than parsing /proc/self/maps. > > Behavior changes: > 1. This will make the code no longer prefetch .data (because we don't > look for it in the mappings), neither the sections that are part of > the same mapping as .text (for instance, .rodata when using > ld.gold). This is intended. > 2. As a consequence, the UMA metric > LibraryLoader.PercentageOfResidentCodeBeforePrefetch will move, as > both sides of the ratio will change, and the population will change > slightly as well (since code is currently not correctly ordered on > ARM64 and x86_64) > > - Removes the reliance on a somewhat brittle parsing of a file > - Parsing /proc/self/maps costs ~50ms of CPU on a Nexus 5X (on a little > core, as this is triggered from an AsyncTask) > - Allows to only fetch part of the native library (in a forthcoming CL) > > Rationale: > Change-Id: I0bb7b28af3c3bd4af5745e2ebcc1fbf283bcc0c1 > Reviewed-on: https://chromium-review.googlesource.com/874470 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531515} TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org Change-Id: I11d7cd7898d5f8d8fbebf391eba5fdaca154c08a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/886321Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#531858}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/50c5a55c..a9bb5cf9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifcb97dcfbe3b4eabb6c8a061ab4d6fa0abde46c8 Reviewed-on: https://chromium-review.googlesource.com/886061Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531857}
-
Sheng-Hao Tsao authored
This CL adds some command line parameters to jpeg_encode_accelerator_unittest to enable JEAPerf autotest. BUG=b:67488323 TEST=Verified that JEAPerf collects metrics successfully on eve. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie369b17302e6f6587e81126ed35d577e71e00d68 Reviewed-on: https://chromium-review.googlesource.com/874493Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#531856}
-
dpapad authored
Also removing paper-material, since the previous paper-fab version was the last usage of it. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic1ec8e70d5c5189ead7cb62c9e25f8f8dde5afee Reviewed-on: https://chromium-review.googlesource.com/883565Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531855}
-
Yoshifumi Inoue authored
This patch changes |LayoutObject::EnclosingBlockFlowFragment()| to strict by using |ChildrenInline()| instead of |HasNGInlineNodeData()| for detecting failures of layout operation which doesn't compute inline node data. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 714962 Change-Id: I14e724e06247c59e2f80a8a4db7dc1ef6e5433c7 Reviewed-on: https://chromium-review.googlesource.com/885542Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531854}
-
Andrey Lushnikov authored
This patch introduces AutomappingBinding, that has additional information related to the automapping process. For now, the automappingBinding has only "exact" boolean flag. In future, AutomappingBinding will be created for both successful and failed bindings, surfacing binding errors. R=dgozman Bug=805740 Change-Id: I6245a8b26ae278635add9ef7a46e60886d59bd29 Reviewed-on: https://chromium-review.googlesource.com/884989 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531853}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e99797e78121..62619cb4a9ae $ git log e99797e78..62619cb4a --date=short --no-merges --format='%ad %ae %s' 2018-01-23 sadrul tabs: Add a TBM metric for tab_switching. Created with: roll-dep src/third_party/catapult BUG=802104 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0fc3060a5238dcb88de1069b738a0b58a70ceb5c Reviewed-on: https://chromium-review.googlesource.com/886181 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531852}
-
dpapad authored
Also had to update paper-styles version 1.1.4 -> 1.3.1, and removed the deprecated and unused shadow-layout.html. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43fc909502ac321e3a6a512ca6b00c93a98abab2 Reviewed-on: https://chromium-review.googlesource.com/882446Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531851}
-