GitLab

Using wpt-import in Chromium fc035627.
With Chromium commits locally applied on WPT:
9e3affdd "Ship `referer` header length limitation."
3d4f72a8 "Worker: Add service worker interception tests for shared workers"
043af69d "WebSocket: stop removing an iframe in onerror from crashing"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I3edf68a57813623a3513df3a730f8d98a1859231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666460Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670368}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd4e0560a28b..90c38b08f83f


Created with:
  gclient setdep -r src-internal@90c38b08f83f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com

Change-Id: I2bd095d143967af95e8275a53b3e92edabd20454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666673Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670367}

When ServiceWorkerImportedScriptUpdateCheck is enabled, the update
code path changes. Update unit tests for this change.

Bug: 648295
Change-Id: I43637c8eebdc41a67dea43e5762ac6927c3a13ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597108
Commit-Queue: Ting Shao <ting.shao@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670366}

This CL adds support for file manager browser tests that have the
enhanced format dialog flag enabled.

Bug: 632988
Change-Id: I57d02530b8304487d5ff76c7a5538f379f86adb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662987Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670365}

This patch let |NeedsTrailingSpaces()| work around reading
dirty tree, by assuming the trailing space is not collapsed.

Bug: 976203, 946004
Change-Id: Iae191c48d055f6b37d03d762db02888bc2c4026d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666691Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670364}

BUG=419673
R=thestig

Change-Id: Ifac72300af82d25e0087ba6f69a4ed3c23f9b3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663675
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670363}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/353cbaa9..2d89d083

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Idf596cd97bd82c310648a4d50acb444f710d4d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666467Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670362}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I9b370127693c0c312b347cd049279ab8d8e2e609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666868Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670361}

R=dbeam,calamity

Change-Id: I8d5a4a2a6eabdfd9b4f7c1bf11b71084d053040e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666688Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670360}

Chrome status icons have a concept of both activation (usually left-clicking the
icon) and opening a menu (usually right-clicking the icon).  However, some
status notifier hosts open a menu on both left and right click.  To make sure
the user will always be able to run the activation action, explicitly add it to
the menu as an additional entry.  The behavior is the same as the
libappindicator codepath in libgtkui.

BUG=419673
R=thestig

Change-Id: Iffa26e0729cc91b7ea9875e6b87fba625a723c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663195Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670359}

I performed a quick codesearch audit from the PropertyMirror removal CL:
http://crrev.com/c/1603215/3/ash/public/cpp/mus_property_mirror_ash.cc#b75
kTitleShownKey is the only obviously unused property.

Bug: 961478
Test: No behavior change
Change-Id: I43fcd9d5968c4fba4aa8a4a2af45b5f9f9372366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666559
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670358}

This CL turns on the intent picker flag by default to launch in M77.

BUG=939205

Change-Id: I197cd05e6ab0545c7eaa9526600ef1b23bd0b756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666808Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670357}

This CL removes the unused variable camera_orientation_.

BUG=None
TEST=run CCA on DUT

Change-Id: I0746de57e966499957fae8a73c1917548fcf22d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637011Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Auto-Submit: Hsu Wei-Cheng <mojahsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670356}

r669571 missed the case where ContextDocument() is not null but has a null frame.
This CL creates a new Agent in that case, just like we do for the FrameScheduler.

Bug: 974892
Change-Id: I1bae1d17653c0570f88ee15fbe4a220cd847ac84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663978Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670355}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/200c69540dc7..fd4e0560a28b


Created with:
  gclient setdep -r src-internal@fd4e0560a28b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:849505,chromium:790246
TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com

Change-Id: Ib80946cb7f6bf9f0a9942279f1493a1ea50111ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666555Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670354}

If the user's preferred language for the selected Google Cloud Print
(GCP) account does not match the language for the Chrome UI, the names
and descriptions of cloud printers will appear in the account's
preferred language, mismatching the langauge of the rest of the UI.
This also means these printer names/descriptions are not searchable in
the Chrome UI language, which is confusing. Send the locale as a query
parameter in cloud print requests so that the GCP server sends printer
names and descriptions in the appropriate language.

Note: the Accepts-Language header is ignored by the GCP server.

Bug: 974869
Change-Id: Ia63432d2ef83206a7985f38bf83f88ae6a24b63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663400
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670353}

https://chromium.googlesource.com/angle/angle.git/+log/32d718f3e81e..9a4bd48d5f0c


git log 32d718f3e81e..9a4bd48d5f0c --date=short --no-merges --format='%ad %ae %s'
2019-06-19 jiawei.shao@intel.com Allow overwriting angle_root in non-Chromium GN configurations
2019-06-18 jmadill@chromium.org Revert "Vulkan: Add missing command pool reset."
2019-06-18 ynovikov@chromium.org Switch ANGLE Win and Linux CI bots to builderless.
2019-06-18 geofflang@chromium.org GL: Add extensions to enable hardware video decode on Android.


Created with:
  gclient setdep -r src/third_party/angle@9a4bd48d5f0c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:973992,chromium:967410
TBR=jonahr@google.com

Change-Id: I0b5158eee0a856d7535f3c43c06f4831ee068157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666558Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670352}

https://webrtc.googlesource.com/src.git/+log/342f98b11765..b7a3e3f5c42a


git log 342f98b11765..b7a3e3f5c42a --date=short --no-merges --format='%ad %ae %s'
2019-06-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8639acbe..619b0737 (670130:670258)
2019-06-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bf62d746..8639acbe (669828:670130)
2019-06-18 sprang@webrtc.org Allow RtpPacketHistory encapsulator function to abort retransmit
2019-06-18 oprypin@webrtc.org Roll chromium_revision 6ae0f0cd..bf62d746 (669703:669828) + fix AndroidManifest
2019-06-18 perkj@webrtc.org Fix potential signed overflow in IntervalBudget::set_target_rate_kbps


Created with:
  gclient setdep -r src/third_party/webrtc@b7a3e3f5c42a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None,chromium:891996,chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icb31e172bfaf0aa5d79cbb0750c93ec10578be47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670351}

Bug: None
Change-Id: I777c8962ae3e4fe3db8531e461f83b179363ee0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646798
Auto-Submit: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670350}

The redesigned Clear All button is now shown at the top in the notification
stacking bar, so remove the bottom button.

BUG=952557

Change-Id: I4f471141094a01dc9cbc5b69f49cf87d69780097
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659535Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670349}

This also moves ShowSystemMenuAtPoint() from gfx (why was it there?) to views.

BUG=none
TEST=Hit alt-space; system menu should appear below the tabstrip.

Change-Id: Iba2ca9fc54746f253ef7d61ed5b190d61de47f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1049063Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670348}

This effectively disables the feature in tablet mode if entered before
creating more than one desk.

BUG=976442
TEST=Manual, added a new test.

Change-Id: I38966dd59cf0eb76873958ca0fb4472c9bf5a53f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666548
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670347}

Implements (most of) menus for use in DBus status icons.  Still left is
adding a default "click-action" item to the menu and showing a native
menu when the server does not support menus.

BUG=419673
R=thestig

Change-Id: Idc340581b9960ed9769b98857820eb8ab4a1c87f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654489
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670346}

This test was failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13544

TBR=akihiroota@chromium.org,aboxhall@chromium.org

Bug: 976105
Change-Id: I52a6f9a792d7e47acc5caff9143529333221e33c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666440
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670345}

- PLM observer
- Histograms
- Context Menu
- DRP Server LoFi Triggering
- ServerLoFi Blink code

Bug: 944286
Change-Id: I05de571209c85d6fb24dd47074b26b5ed171e190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652012
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670344}

This is addressing a TODO in the code that is no longer blocked.

Bug: None
Change-Id: Ifb42f374c4461dc490194651eae88101dd15b818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654192Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670343}

Suppresses several failures that started popping up in the Skia Gold
pixel tests on Windows after several blank images where marked as
negative.

TBR=kbr@chromium.org

Bug: 974380, 835867
Change-Id: I4f0fec24dce1d18154be0ec4ef44f64c3732cdae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666531Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670342}

Bug: 949839
Change-Id: I418e39d621ab7ab294fd00ee2618234341dbf287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661216Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670341}

Each check for hardware availability was very similar, this CL
introduces helper methods which reduce code duplication as much as
possible, making it easier to add new device types in the future. This CL
also attempts to consolidate conditional compilation where possible.

Bug: 968295
Change-Id: I9ed3c02251ed886156d46f3bbd70af7866a53cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642392Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#670340}

Also replace a few usages of bind(this) with arrow functions.

Bug: 747596
Change-Id: I498eda4d6b4667900eab27f3c69287b9deb02508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663185Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670339}

BUG=974713
TEST=compile
R=sunnyps@chromium.org

Change-Id: Icb9bbb7896fbd2994c0e1936b798e48eb7ab4f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666612
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670338}

Update expiration dates, or add one if the histogram doesn't already
have one. For histograms that we still need, set the expiry to M85,
which is around a year from now.

Bug: 976053
Change-Id: Icb71ebf6137b40644cb63976682cdf3437ec2948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663074Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670337}

Wanted for this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1654489/

BUG=419673
R=thestig

Change-Id: I7a2ecd8e443929ff38b08c16558eb210ca2308d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666528
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670336}

It disables BookmarkAppInstallManager code path (with BookmarkAppHelper inside).
It enables unified WebAppInstallManager and InstallFinalizer infrastructure.

Bug: 915043
Change-Id: Id77289a7b6b51681b8833d9c83d7a9657c1af624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627847
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670335}

Forgot this bit in https://chromium-review.googlesource.com/c/chromium/src/+/1663023

R=dpranke, jbudorick

Bug: 932269
Change-Id: I8f5df4581265fa55e57a3cbcfc2293518c4c3f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666330
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670334}

References to this unused field were deleted in
https://chromium.googlesource.com/chromium/src.git/+/84c5e49b65ef24c2c0acbc8b631138c2e7d41cb1.

Bug: 960113
Change-Id: Ic72e8ad8da55bc98e6070002973a57400dae323c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665897Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670333}

Using wpt-import in Chromium b00478d5.
With Chromium commits locally applied on WPT:
9e3affdd "Ship `referer` header length limitation."
3d4f72a8 "Worker: Add service worker interception tests for shared workers"
043af69d "WebSocket: stop removing an iframe in onerror from crashing"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I816cfb41c30a266e20368e2f5f8e943b18e005d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666368Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670332}

When ChromeVox is enabled, Search+Space simulates a mouse press, which was not
being forwarded properly to the child contents in NotifierSettingsView.

TEST=manually verified
BUG=897974

Change-Id: I13a738034891ac7d073c30d86daa3a3e98e321ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666309Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670331}

This CL replaces strict-equality comparisons like
  if (url == GURL(content::kAboutSrcDocURL)) ...
with
  if (url.IsAboutSrcdoc()) ...

Unlike the old code, the new code correctly handles about:srcdoc#ref and
other corner-cases (see gurl_unittest.cc for more examples).  Note that
in the long-term URLs like about:srcdoc#ref should not be encountered in
practice (see https://crbug.com/974300), but for now such navigations
are still possible (e.g. frames can directly navigate to
about:srcdoc#ref by setting window.location).  Using IsAboutSrcdoc
instead of strict-equality should correctly account for the current
implementation state (and should remain correct in the long-term).

To prevent reoccurence of strict-equality comparisons, the CL also
removes the content::kAboutSrcDocURL constant.

Bug: 973922
Change-Id: I2bd80c82c395a4659ccb50f4caf236baa5ad3c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659195
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670330}

Most of our Views class properties are of type ClassProperty<T*> where
T is a value type, but we're forced to use pointers because T can be of
any type and must therefore be allocated on the heap.

This leads to a lot of code like:
my_view->SetProperty(kMarginsKey, new Insets(kMyViewDefaultInsets));
...
*my_view->GetProperty(kMarginsKey) = new_insets;

(The latter pattern is to prevent a second heap allocation - but only
works if the initial allocation happens; otherwise it crashes.)

This CL shortcuts this behavior so that it behaves in the way we
actually want to use the system 90% of the time:

// Allocates a copy of kMyViewDefaultInsets for the property.
my_view->SetProperty(kMarginsKey, kMyViewDefaultInsets);

// Updates the value of the existing property.
my_view->SetProperty(kMarginsKey, new_insets);

// De-allocates the existing property value.
my_view->ClearProperty(kMarginsKey);

In order to use this new functionality:
 - The property must be an owned property of pointer type.
 - The property type behind the pointer must be copy- or
   move-assignable.

Change-Id: Idec1d5b9c104814f234270214b615774fa5a7084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657288Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670329}