- 26 Mar, 2019 40 commits
-
-
Bret Sepulveda authored
This patch refactors tab_strip_model_unittest.cc and some associated files in several ways: * Removes ChromeRenderViewHostTestHarness as a superclass of TabStripModelTest, which includes some heavyweight dependencies that are unused. This speeds up the suite by about 20% (~6500 ms runtime vs. ~8000ms before this patch). * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to return false, and deletes subclasses that exist solely to override that method (all of them, except TabStripDummyDelegate, which is renamed to UnloadListenerTabStripModelDelegate). * Moved several helper classes to be defined immediately before the test that uses them. * Deletes member variables from MockTabStripModelObserver, which are unused. * Fixes lint errors and cleans up unused includes. Change-Id: Ibb93ff41a21aab4c0b9b9f075df315381959c35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538575Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644437}
-
Reilly Grant authored
This change displays serial port permissions the user has granted to sites in chrome://settings/content/serialPorts. Bug: 908836 Change-Id: I49570dc785d6de395160ffbb4541e7203cda9357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1453363 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#644436}
-
Kush Sinha authored
If SecondaryGoogleAccountSigninAllowed policy is set to false, it sets the kSecondaryGoogleAccountSigninAllowed preference to false. This should result in any existing Secondary Accounts in Chrome OS Account Manager being removed. Please check https://crbug.com/934492#c6 for a Design Document. Bug: 934492 Test: browser_tests --gtest_filter="*AccountManagerPolicyControllerTest*" Change-Id: Ib620a8347b9859dae0245957a0e240490d450545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538185 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#644435}
-
Randy Rossi authored
Adding an AccessibilityStateChanged method to CastService so the browser process can notify any out-of-process (non chrome renderers) that need to know of that state change. Base implementation does nothing. ChromecastService will override this in a subsequent CL. Bug: None Change-Id: I4c85d7ec529906d11b9a469bda25d4fadc0ec5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539790 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#644434}
-
Niels Möller authored
Bug: webrtc:5876 Change-Id: I25baa7538e859b4e7e249fdb12ac07ee54767d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539663 Auto-Submit: Niels Möller <nisse@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#644433}
-
Eric Aleshire authored
Testing to see if the builder will work with the unit test target. Bug: 943883 Change-Id: Ia2f99adbaf515adfb3039a425a5b99878f976e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538447Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#644432}
-
Koji Ishii authored
The use here is for memory alloc performance, but since it has inline capacity of 64, it won't help when |size()| is O(n). Bug: 945671 Change-Id: I166e6615bcae5a814116ee1b6aaf0349405a67ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535507 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644431}
-
Pedro Amaral authored
Disable apative toolbar when the grid tab switcher is enabled. Also don't enable adaptive toolbar if the bottom toolbar is not enabled. Bug: 944653 Change-Id: I0c6e7319dc130def60103286452f3fccd5e6ac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536297Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#644430}
-
Edwin Joe authored
In MacOS, tab switch follows a different path than in Windows/Linux. It calls DelegatedFrameHost::WasShown when we are inside the call stack of NativeViewHostMac::AttachNativeView. This results in the check whether we have saved frames or not inside RWHVMac::WasUnOccluded to always return true since we have called DelegatedFrameHost::WasShown previously. This CL saves the saved frame condition before we call the first DelegatedFrameHost::WasShown in MacOS, and use this value to determine whether we have saved frames or not at a tab switch. Note that this might cause an upward spike in the MPArch.RWH_TabSwitchPaintDuration UMA metric since previously, it always record time as if we have saved frames, i.e. the presentation time for the delegated frame host. This CL will change that behavior to record time properly based on whether we have saved frames or not, which leads to a possible spike in the metric. Bug: 921120 Change-Id: If196665bb287a8b3e27ce24f4151ff88ae5f841f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538560 Commit-Queue: Edwin Joe <ejoe@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#644429}
-
Elly Fong-Jones authored
Bug: None Change-Id: I56ef7a820528dfe0ebdcd55eea2c5d59ad09a1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538614 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#644428}
-
John Rummell authored
Changes MediaDrmOriginIdManager so that if option kMediaDrmPreprovisioningAtStartup is enabled, it will attempt to pre-provision origin IDs after a 1 minute delay. This also registers MediaDrmOriginIdManagerFactory properly so that it is called during profile creation. BUG=942731 TEST=MediaDrmOriginIdManagerTest unit_tests pass Change-Id: Iad162b69a2bffecc52c02a352a55e1865eb2fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529854 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#644427}
-
Eugene But authored
Commit placeholder navigation item if one is available. This CL fixes NativeContentVirtualURL if StorePendingItemInContext is enabled for slim-nav. Bug: 899827 Change-Id: I4f563d67bea1a5aa89e69d6cc3b2bff9415d254e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538555 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644426}
-
Sunny Sachanandani authored
GPU.DirectComposition.DecodeSwapChainUsed UMA histogram was added a few days ago. We're seeing only ~8% of frames using decode swap chain, but we can't say if that's a good proportion of hardware decoded frames since we don't distinguish between software decoded frames which are always uploaded and blitted and hardware decoded frames which may or may not use a decode swap chain. We want to verify that a good proportion of hardware decoded frames use decode swap chain. Bug: 848093 Change-Id: I8ec443035f92f374bf5d7a24ea5e1a2cba0ff515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534475 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644425}
-
Daniel Bratell authored
MailboxHolder uses and exposes gpu/ipc/common/mailbox_holder_struct_traits.h so it needs to be a public dependency (as it already is in mailbox_holder_for_blink.typemap). One example of many resulting dependency errors: ERROR at //out/Default/gen/device/vr/public/mojom/isolated_xr_service.mojom-test-utils.cc:29:11: Can't include this header from here. ^-------------------------------------------- The target: //device/vr/public/mojom:mojom is including a file from the target: //gpu/ipc/common:struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //device/vr/public/mojom:mojom --> //gpu/ipc/common:interfaces --[private]--> //gpu/ipc/common:struct_traits Bug: 938893 Change-Id: I598db331d43cff5212d7d739da96e0648552b7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535859Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644424}
-
Maksym Onufriienko authored
Do the same logging as test_runnner: - show flaky/failed tests in bot summary - display stacktrace for each failure and each attempt - removed xcodebuild command from bot summary - changed print -> logging For non_started_tests case add `Message` from ErrorSummaries The examples of log: https://ci.chromium.org/p/chromium/builders/try/ios12-sdk-simulator/241 https://ci.chromium.org/p/chromium/builders/try/ios12-sdk-simulator/249 Bug: 912323 Change-Id: Ie48cf020db31ff2229a1e5a5be05f1ed651a1c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495440Reviewed-by:
-
Victor Vasiliev authored
R=davidben@chromium.org Change-Id: I3355397b8742d159e8835e867f4c9b62f9e7abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525000Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#644422}
-
Dmitry Gozman authored
This patch makes it so we entirely ignore navigations which are not going to commit, not issuing any client callbacks. This makes the case of DocumentLoader::LoadFailed() for provisional state non-existent, apart from frame detach during FrameLoader::PrepareForCommit. Since we don't really have to "fail" provisional load during detach, we just skip that by marking DocumentLoader as "sent did finish load". This corresponds to step 8.g from the doc linked to the bug. Bug: 855189 Change-Id: I99aaf68990d57c8b5a35d4d608d67a3ac22f62e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535233 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#644421}
-
Paul Jensen authored
It needs a base::TaskScheduler. Change-Id: I20f1f92a62c6c5e63990d6d1bb67b7ca063317ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539921 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644420}
-
Guido Urdaneta authored
Bug: 945167 Change-Id: Ida354c3fa5cd0076271fd76346122cf9bb17963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537101 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#644419}
-
Justin Cohen authored
iOS no longer uses the hermetic Xcode toolchain. Bug: 939785 Change-Id: I31a28e77a7e2b5b43f3db43c39ada9d9e6757540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539798Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Khushal authored
We currently fail serializing an op if it requires more than 512k bytes. Increase that up to the max transfer buffer size with incremental attempts. R=piman@chromium.org Bug: 924042 Change-Id: I83b4905343eff31af387e2ee6a2d70618cb399f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533054Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#644417}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d1b176c1d04..fb0753640a07 git log 7d1b176c1d04..fb0753640a07 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 paulthomson@users.noreply.github.com reduce: fix loop to selection dominance query (#2477) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fb0753640a07 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iffb5bb898d3ce6e0f97ff6455db9cffa5baacc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644416}
-
Nicolas authored
url_list rules with a '/' in them are now treated more similar to how the LBS extension treated them. There is some pre-processing on the rules, which parses the URL and converts the scheme + hostname to lowercase. Bug: 943497 Change-Id: I07814493213e7af30a237aac6791817167840461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531578Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#644415}
-
Peter Boström authored
Also modifies existing test to verify that the number of extension buttons inside the menu matches the number of added extensions. Bug: chromium:943702 Change-Id: Ifafc8cef9d3d6b110a7f4a510fa35531611329e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538863Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#644414}
-
Steven Valdez authored
Change-Id: I8ec1995b62eebedc4e2ea873399168fb73484dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536691Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8ea8dcbae6cb..081bec34bf2d git log 8ea8dcbae6cb..081bec34bf2d --date=short --no-merges --format='%ad %ae %s' 2019-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bef29707..e1296370 (644220:644325) 2019-03-26 srte@webrtc.org Removes PostStop from RepeatingTaskHandle. 2019-03-26 danilchap@webrtc.org Use TaskQueueForTest instead or TaskQueue in unittests 2019-03-26 nisse@webrtc.org Reland "Replace RTPHeader memset with assignment from a fresh object." 2019-03-26 kwiberg@webrtc.org Add thread safety annotations for some more PeerConnection members (part 8) Created with: gclient setdep -r src/third_party/webrtc@081bec34bf2d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:945598 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifbfa73d2df5b3dcb8cdcb7ed7043ec9f27acf67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538747Reviewed-by:
-
Karolina Soltys authored
Bug: 863341 Change-Id: I920dad29dbdf683edf2f1bcde77d884fecc7011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533941Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644411}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8ec7f194aed..e4ad58a4e2c1 git log b8ec7f194aed..e4ad58a4e2c1 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 mtklein@google.com move gpu_tool_utils to public_deps Created with: gclient setdep -r src/third_party/skia@e4ad58a4e2c1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I73a3d2c3191b8dbecf2316ce2389da051b1f5468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539062Reviewed-by:
-
Alexei Filippov authored
This is a reland of 1eae2114 Original change's description: > DevTools: Live heap profile drawer panel. > > The panel shows current memory usage broke down by URLs. This is put > behind an experiment. > > BUG=937880 > > Change-Id: I101e75037d8f1dcc68d220ff9750100e5c9607d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536686 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644155} TBR=dgozman@chromium.org Bug: 937880 Change-Id: Ic09fe5a6891b076edbba23c62be3203c5729ba8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538612Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#644409}
-
Tarun Bansal authored
Fix the enum names for DataReductionProxyBypassType in enums.xml to match with the actual code in data_reduction_proxy_bypass_type_list.h. Change-Id: I2effeccb3babc1d30995ccf76c35bcd9f7481b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539188Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644408}
-
James Lissiak authored
This change adds 4 new performance histograms for the DevTools using the prefix 'DevTools.Launch': - DevTools.Launch.Console - DevTools.Launch.Elements - DevTools.Launch.Network - DevTools.Launch.Sources These histograms measure the time between the DevTools window being shown during 'DevToolsWindow::ToggleDevToolsWindow' and a point in each tool that corresponds to the 'ready' state as seen by a user. These end points are unique to each tool but are as follows: - Console: At the end of the ConsolePrompt constructor - Elements: At the end of _updateMetrics when the styles panel has been populated for the initially selected node - Network: After the panel is shown - Sources: After the NetworkNavigatorView has been loaded These tools were chosen as they represent the most popular in terms of usage and will allow us to identify any significant performance impact in the time taken to launch the DevTools when these panels open by default. To see time captured by the histograms in terms of a perf trace for each tool please take a look at the following screenshots: https://imgur.com/a/rcAgQ8h In the traces you can see that the end marker for each load is at the end of the trace near first meaningful paint, and just as the user will see the content of the tool render fully. To accomplish the histograms, a new native function has been added to the DevTools ui bindings/embedder classes called 'recordPerformanceHistogram'. Along with the plumbing and a new helper function in the frontend javascript Host.UserMetrics file called 'panelLoaded' When the frontend javascript loads, it will store the initial panel to be loaded from the preferences. Once that panel has been created and the appropriate loaded marker has been hit, the duration of the launch will be calculated using performance.now(). That duration is then sent to the native code which will fire the appropriate histogram via the 'UMA_HISTOGRAM_TIMES' macros. The mechanism is similar to the existing one used for enumerated histograms and can be expanded to fire additional performance histograms in the future. Also added a new test for user-metrics to ensure that the panelLoaded function will correctly record the histograms. Change-Id: Ib9f0bf80c651231d6d2e308bee36c1a1223f04db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506388Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#644407}
-
Min Qin authored
BUG=842245 Change-Id: Ieea0d3bcaef8f8f47a32c74845c056c452ca7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532922 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644406}
-
Mohamed Amir Yosef authored
This CL extends life-time of histograms that are still useful for investigation of a long-standing recurring bug. I am also adding one more owner. Bug: 893969,893998 Change-Id: Ibf5abc0919e5198ab025a436e1ef38bd9e0e3907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538082Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#644405}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8a240a71a0c..7175abb56021 Created with: gclient setdep -r src-internal@7175abb56021 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I5cb731fcd89cf8d7a61b532e994a8df53c45db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539896Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644404}
-
Aga Wronska authored
Docked magnifier is not a part of shelf, so shelf should not store this value and make in available to other objects. Refactoring it will simplify ShelfLayoutManager interface and remove unnecessary dependencies on Shelf. Move docked magnifier height to RootWindowController. Trigger observer when the height changed. Test: manually with 2 displays + existing unit tests Bug: 944685 Change-Id: I9fa5cd9c7c22f23ef95321b885c6632d1561f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536597 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#644403}
-
Xianda Sun authored
As we use hit test region's data to compute transforms, not submitting data for pointer-events none OOPIFs can break transforming requests to those regions. This CL makes v2 viz hit test always submit a region for pointer-events none OOPIFs with kHitTestIgnore flag, see: https://chromium-review.googlesource.com/c/chromium/src/+/1487850 for v1 change. Bug: 934007 Change-Id: If049d3a94b82175094683fc29aea013d34603061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524083Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
-
Austin Eng authored
This patch adds GPUFences and GPUQueue::signal which is enough to test roundtrip operations from Blink through the command buffer to Dawn and back. When a GPUFence is signaled on a GPUQueue, the GPUFence's completedValue will update when the fence passes. The GPUFence can register an onCompletion callback which resolves a Promise when the fence passes. Bug: 941543 Change-Id: Ifae65dee1b1aeb3d3d78387983cbae4444d57c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497770Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#644401}
-
oysteine authored
This reverts commit 60955896. Reason for revert: Re-enabling tests after https://chromium-review.googlesource.com/c/chromium/src/+/1536801 Original change's description: > Disable all BackgroundTracingManagerBrowserTests due to data race. > > Bug: 945484 > Change-Id: Ie7ae6d64752b0aac9c88110b23a67b42c4580908 > TBR: sahel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538784 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644108} TBR=pkasting@chromium.org,sahel@chromium.org Change-Id: I83156abb16d6e34a85a8530e78558b58c7832274 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534867Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644400}
-
Jonah Chin authored
Patch that fixes the win7 error that happened in previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1496534 Should complete this revert first: https://chromium-review.googlesource.com/c/chromium/src/+/1538811 This is necessary in Windows since some fonts are not limited to weights that are multiples of 100. Eg. Segoe UI with a weight of 350 should match the semilight font as opposed to the regular one. Bug: 944301 Change-Id: I59e30d05be13bbfdc0bc06b82f2656f25ede525f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538890 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#644399}
-
Ben Pastene authored
This will let us call tast and sanity tests via a shell script on the device. (Actually switching them will come in a follow-up CL.) This will be useful for coverage tests, since they need special setup on the device's filesystem prior to the tests. Bug: 934059 Change-Id: I2a907d176faf4ce12411bd2157188f909e494cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534857Reviewed-by:
-
