GitLab

I missed out on removing a few things in http://crrev.com/2571063002, which I've cleaned up here.

BUG=673844

Review-Url: https://codereview.chromium.org/2576753002
Cr-Commit-Position: refs/heads/master@{#439011}

This is the sub-patch (2/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Added method |Editor::replaceSelectionForSpellChecker()| for
   |SpellChecker::replaceMisspelledRange()| to hide editor details;
2. Passed command source from |Editor::Command| to various methods in |Editor|,
   such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
   |replaceSelectionWithText()| etc.

Note:
It's OK to add extra |EditCommandSource| parameter to those methods because
they are going to be moved to "EditorCommand.cpp" (according to the editing
refactor doc), which means they should share the similar pattern as other
|static execute*()| methods.

This CL shouldn't have any behavior change.

Next CL will pass command source down to |CompositeEditCommand| and
|TypingCommand|.

Editing Refactor doc:
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14BNMFTB8ms9uedeArbw/edit?usp=sharing

BUG=673789

Review-Url: https://codereview.chromium.org/2576903002
Cr-Commit-Position: refs/heads/master@{#439010}

No longer needed.

BUG=674757
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2578373002
Cr-Commit-Position: refs/heads/master@{#439009}

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2579083002
Cr-Commit-Position: refs/heads/master@{#439008}

The test runner was previously tearing down the SIGTERM handler once
it finished running tests and generating results. In some cases, though,
it's still hanging after that point. This CL keeps the SIGTERM handler
through the end of the process s.t. we can still log hangs that happen
later.

BUG=664308

Review-Url: https://codereview.chromium.org/2584453003
Cr-Commit-Position: refs/heads/master@{#439007}

In some feedback reports, users see empty Files app because resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2584443002
Cr-Commit-Position: refs/heads/master@{#439006}

After checking in the CL which tries to address the Jumplisticon
performance bug, grt@ pointed out there are a few nits need to be
fixed, including inconsistent code change in different OS files,
unnecessary code and comments.

I copy and paste the comments from grt@ in line with the code in
this CL and reply direclty there.

BUG=40407
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2577163002
Cr-Commit-Position: refs/heads/master@{#439005}

Add a deprecation message if both 'audioCapabilities' and
'videoCapabilities' passed to navigator.requestMediaKeySystemAccess()
are empty. Support for this non-standard configuration will be removed
in M58.

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE

BUG=616233
TEST=message logged with EME layout tests

Review-Url: https://codereview.chromium.org/2528563005
Cr-Commit-Position: refs/heads/master@{#439004}

InnerDetach destroyes the current session and domain handlers, as opposite to
NotifyDetached, which prevents stale pointers and inconsistent state at the time
of DTAHI destruction.

BUG=674474

Review-Url: https://codereview.chromium.org/2579923002
Cr-Commit-Position: refs/heads/master@{#439003}

Following some recommendations in the spec [1] and [2],
this CL adds "video/x-matroska;codecs=avc1" and
"video/webm;codecs=avc1" to the supported list, reusing
the existing H264 encode path.

[1] https://github.com/w3c/mediacapture-record/issues/93
[2] https://github.com/w3c/mediacapture-record/issues/94

BUG=

Review-Url: https://codereview.chromium.org/2585533002
Cr-Commit-Position: refs/heads/master@{#439002}

Currently, clicking "Cancel" in an external protocol dialog with the
"Always open links for <app>" option checked will permanently silence
all protocol requests for that scheme. This result is unexpected given
the strings. This CL updates the strings to clarify the behaviour.
This is a stopgap fix for M56; future milestones will see further
changes to the behaviour of this dialog to improve its usability.

BUG=671658

Review-Url: https://codereview.chromium.org/2581623002
Cr-Commit-Position: refs/heads/master@{#439001}

There was a regression not showing web search menu item in
select action mode on Chrome if an activity for ACTION_WEB_SEARCH
cannot be found in the system. Chrome should always show it
since it can show the search result on a new tab. This CL fixes it
by showing the item by default, and having other embedder (webview)
configure it.

BUG=674104

Review-Url: https://codereview.chromium.org/2577963002
Cr-Commit-Position: refs/heads/master@{#439000}

Pressing Ctrl+Enter in a regualr source value attempts to run a snippet,
failing an assertion and showing red squiggles under the selected source
line.

BUG=None

Review-Url: https://codereview.chromium.org/2576983004
Cr-Commit-Position: refs/heads/master@{#438999}

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Review-Url: https://codereview.chromium.org/2577953004
Cr-Commit-Position: refs/heads/master@{#438998}

BUG=570441

Review-Url: https://codereview.chromium.org/2581003002
Cr-Commit-Position: refs/heads/master@{#438997}

Revert of Add Windows 10 build number to user-agent (patchset #1 id:1 of https://codereview.chromium.org/2533303003/ )

Reason for revert:
This can cause services expecting a Windows user-agent of only two version tokens (10.0) to break.

Original issue's description:
> Add Windows 10 build number to user-agent
>
> The build number would be added to the version string in UA
> only if the major version of Windows is equal or greater than 10.
> Nothing would be changed for the old version of Windows.
>
> BUG=664622
>
> Committed: https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
> Cr-Commit-Position: refs/heads/master@{#437532}

TBR=jochen@chromium.org,dcheng@chromium.org,pkasting@chromium.org,rbyers@chromium.org,ratsunny@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664622, 674723

Review-Url: https://codereview.chromium.org/2581033002
Cr-Commit-Position: refs/heads/master@{#438996}

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/IoIxRpn6l9g/ux1C1Cj7AQAJ

Spec:
https://w3c.github.io/browser-payment-api/#canmakepayment-method

Added in:
https://github.com/w3c/browser-payment-api/pull/380

BUG=664619

Review-Url: https://codereview.chromium.org/2579793003
Cr-Commit-Position: refs/heads/master@{#438995}

Desired size of content view added in https://crrev.com/2536223003
is supposed to be used for a particular instance like overlay panel.
This should be initialized back to default values after it was used
in adjusting backing size of the content in order not to affect
the size of other content views.

BUG=671967

Review-Url: https://codereview.chromium.org/2574693002
Cr-Commit-Position: refs/heads/master@{#438994}

Currently DidSwap runs before the swap, but we need a method
that is run after it. DidSwap is also not the best name because
it's called before the swap is done, so we believe WillSwap will
be a better name for it. So DidSwap will be renamed to WillSwap
and we will create a new DidSwap method that is run after the swap.

BUG=659598
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2580493002
Cr-Commit-Position: refs/heads/master@{#438993}

BUG=624136

Review-Url: https://codereview.chromium.org/2584763002
Cr-Commit-Position: refs/heads/master@{#438992}

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2579003003
Cr-Commit-Position: refs/heads/master@{#438991}

I couldn't find where in the code these were used and I couldn't find
them in the UI either ( chrome://settings/cookies ). I tried without
success to sleuth out when, if ever, these were actually used. js
lists don't show icons the way js trees do.

BUG=522168

Review-Url: https://codereview.chromium.org/2574803003
Cr-Commit-Position: refs/heads/master@{#438990}

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168

Review-Url: https://codereview.chromium.org/2568403004
Cr-Commit-Position: refs/heads/master@{#438989}

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353

Review-Url: https://codereview.chromium.org/2569943002
Cr-Commit-Position: refs/heads/master@{#438988}

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37BAAJ

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887

Review-Url: https://codereview.chromium.org/2557523002
Cr-Commit-Position: refs/heads/master@{#438987}

This CL aims to make html canvas to match to CSS style restriction regardless
whether it is transferred to OffscreenCanvas or not.

In a usual compositor commit, when a css style is imposed on the html canvas
to change its width and height, its layer will reset a different bounds.
However, in the case when html canvas has transferred control to offscreen,
it is using a SurfaceLayer, which directly use surface_size_ without
incorporating layer bounds to append SurfaceDrawQuad. This CL changes
SurfaceLayerImpl to take into account the special case when layer bounds is
different from surface_size by doing a transformation on the
Quad, especially when the aspect ratio is different.

The CL respects existing non-canvas cases on high-dpi devices and settings
when enable-use-zoom-for-dsf is on or off.

Also, it is also possible that the compositor commit due to style change
happens before the Surface Layer for html canvas is created. To prevent
flakiness, we force a compositor commit at the time when Surface Layer is
created and registered to GraphicsLayers.

TBR=khushalsagar@chromium.org, twellington@chromium.org, pfeldman@chromium.org
BUG=655335, 652931
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2495373003
Cr-Commit-Position: refs/heads/master@{#438986}

This error is produced if get_pointer_stylus method is called with
a pointer object that is already associated with a pointer stylus
object.

BUG=673666

Review-Url: https://codereview.chromium.org/2575693002
Cr-Commit-Position: refs/heads/master@{#438985}

This was raised in https://codereview.chromium.org/2582483002/#msg9

getInstance() would be more common name for a function to get a singleton
instance and less confusing for code readers.

BUG=n/a

Review-Url: https://codereview.chromium.org/2579823002
Cr-Commit-Position: refs/heads/master@{#438984}

BUG=672829
TEST=try

Review-Url: https://codereview.chromium.org/2583523002
Cr-Commit-Position: refs/heads/master@{#438983}

This CL allows caller of the me2me NMH to override the path to save the host
config, so that we can have separate host config file when testing NMH against
test gaia environment.

BUG=674685

Review-Url: https://codereview.chromium.org/2581043002
Cr-Commit-Position: refs/heads/master@{#438982}

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353

Review-Url: https://codereview.chromium.org/2581543002
Cr-Commit-Position: refs/heads/master@{#438981}

Peoriodically (every 1s) check whether video/viewport intersection is
changed when video is rendered remotely.

BUG=643964

Review-Url: https://codereview.chromium.org/2556333002
Cr-Commit-Position: refs/heads/master@{#438980}

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789

Review-Url: https://codereview.chromium.org/2578753002
Cr-Commit-Position: refs/heads/master@{#438979}

Add thread checkers to request options class.

Force the generation of the chrome-proxy header, and use it later when
generating the MockWrite for the sockets in tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=634061

Review-Url: https://codereview.chromium.org/2571993002
Cr-Commit-Position: refs/heads/master@{#438978}

FrameView::dispose() doesn't guarantee that the owner's widget is cleared
and this could be problematic when it's overwritten in
LocalFrame::createView() a short time later.

BUG=673170

Review-Url: https://codereview.chromium.org/2563313002
Cr-Commit-Position: refs/heads/master@{#438977}

This patch adds a few more items into traced value for picture layer
impls, in order to help diagnose issues.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2578193003
Cr-Commit-Position: refs/heads/master@{#438976}

This patch adds a query parameter "panel" which sets the default panel
when devtools loads.

BUG=673472
TBR=sky

Review-Url: https://codereview.chromium.org/2566573002
Cr-Commit-Position: refs/heads/master@{#438975}

Mark tests with pre-existing lines above as possible duplicates. Will follow up on each of those.

BUG=674313

Review-Url: https://codereview.chromium.org/2575293002
Cr-Commit-Position: refs/heads/master@{#438974}

It also makes binding to a raw handle easier.

BUG=579646

Review-Url: https://codereview.chromium.org/2578333002
Cr-Commit-Position: refs/heads/master@{#438973}

BUG=555865

Review-Url: https://codereview.chromium.org/2579693003
Cr-Commit-Position: refs/heads/master@{#438972}