GitLab

Jumbo is a unity build system for Chromium where many files are
compiled together. Since so much code is in headers and templates
this is much more efficient, and depending on your hardware, can
significantly speed up builds.

The headless module needs 26 CPU minutes to compile without jumbo.
With jumbo for everything, it needs 3.1 CPU minutes. Half of that
is already on master through the jumbo support in mojo. This patch
adds jumbo support for the rest, changing the compilation effort
from 15 CPU minutes to 3.

In real world time, this saves about 1.5 minutes on a full build on an
8 thread machine.

Bug: 883727
Change-Id: I3ede4805064344574c314d03904208110fdcb462
Reviewed-on: https://chromium-review.googlesource.com/1225702Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593216}

In some jumbo build configurations, two ClampBufferSize functions
in services/network ended up in the same translation unit which
caused compilation errors.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I6b7ea9c226b114a10d59fa9891e67f83537c5ec6
Reviewed-on: https://chromium-review.googlesource.com/1238219Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593215}

The fling unittests are using mock clock to make sure that the tests are
stable.

Bug: 868381
Change-Id: I4bafbb71edd668ea553507c00a8784c994f49597
Reviewed-on: https://chromium-review.googlesource.com/1157291Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593214}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/22defe0965adddaa09eebc13df7fa6c64e2abba3..54d332dd9b0263821376161cdffb60ffb3c7847f

Bug: 887943
Change-Id: I1a6eed501cc396f4dff8a057b2cf958d808c7869
Reviewed-on: https://chromium-review.googlesource.com/1238467Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593213}

This reverts commit 555dcba9.

Reason for revert: probably the cause of compile failures (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/3246 )

Original change's description:
> [iOS][MF] Secure filling
> 
> Observe the last focused field to validate it is secure before filling a password
> 
> Bug: 878388
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26
> Reviewed-on: https://chromium-review.googlesource.com/1221217
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593194}

TBR=mahmadi@chromium.org,gambard@chromium.org,javierrobles@chromium.org

Change-Id: Ie272d2622baeda172a802feaf552b1771e436bc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1238822Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593212}

Change-Id: I284f33451000a9927a0c2a16df523cd7fa7dd4b3
Reviewed-on: https://chromium-review.googlesource.com/1226101Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593211}

https://android.googlesource.com/platform/external/perfetto.git/+log/553230386b67..69356444050a


git log 553230386b67..69356444050a --date=short --no-merges --format='%ad %ae %s'
2018-09-21 hjd@google.com trace_processor_shell: Fix linenoise missing argument


Created with:
  gclient setdep -r src/third_party/perfetto@69356444050a

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I05328a8efca26bb046dd7d5a523f55d4b42b68a4
Reviewed-on: https://chromium-review.googlesource.com/1238695Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593210}

This roll includes only one change to fix
BCP 47 language tag validation for v8.

https://chromium.googlesource.com/chromium/deps/icu/+/c52a2a25

TBR=gsathya@chromium.org

Bug: v8:8135
Test: v8 - test262/intl402/Locale/constructor-unicode-ext-valid
Change-Id: Ida7ed667898c25d4cec6ff20c86d87e07b962c5a
Reviewed-on: https://chromium-review.googlesource.com/1238469Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593209}

This allows developers to specify the size which percentages in the
block (wrt child writing mode) direction should be resolved against.
Currently inline percentages still resolve against the available
inline-size.

This adds a "OverrideContainingBlockPercentageResolutionLogicalHeight"
field on layout box, which both the logic for
LayoutBox::ComputePercenatgeLogicalHeight and
LayoutBox::ComputeReplacedLogicalHeight use.

They follow similar logic to LayoutGrid, in that in quirks mode,
percentages are treated as indefinite (doesn't "walk-up" the tree).

Change-Id: I256381687d2eed7693a908074f7f5032d5963e2b
Reviewed-on: https://chromium-review.googlesource.com/1232206
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593208}

When linking with lld, the lgcc_s is removed from linkage and this
makes Nacl failed to load. This cl adds -lgcc_s before --as-needed
so that libgcc_s is kept.

BUG=chromium:884017
TEST=nacl_helper works when linking with lld.

Change-Id: I3a8503787c4b05b7f777c82bc279ae1005d604d1
Reviewed-on: https://chromium-review.googlesource.com/1226452
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593207}

This makes RuleData GarbageCollected so we can remove HeapTerminatedArray usage.

Bug: 581698
Change-Id: I2d2f11e21b04e3c7eae6428cb8c030d4bf4f91b1
Reviewed-on: https://chromium-review.googlesource.com/1221606
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593206}

Fixing:
(1) Action links fell out of the tab order because destinations_dialog
and destinations_list were not correctly importing action_link.html
(2) Absolute positioning of icon to set it on top of the cr-input in
print_preview_search_box led to icon getting misplaced when browser
window size changed. Fix by adding a prefix in cr-input.
(3) Destination icon was shrinking for large font sizes due to using
flex layout. Make icon fixed size (20px, per spec).
(4) Ensure there is enough margin on the "Manage" link to show the
focus outline.

Bug: 884600, 885090, 886593, 887227, 887229
Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f
Reviewed-on: https://chromium-review.googlesource.com/1237137
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593205}

Bug: 886553
Change-Id: I96f6e8381386b2b73ba4cfe60714e84534c24f12
Reviewed-on: https://chromium-review.googlesource.com/1237138Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593204}

Underlying issue was fixed here:
https://chromium-review.googlesource.com/1226195

Bug: 776330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3b1bbffd84e5bdc315c0ca32c1f8ff89747d5abc
Reviewed-on: https://chromium-review.googlesource.com/1238379Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593203}

In CL https://chromium-review.googlesource.com/c/chromium/src/+/1169528
we modified CreateGesture to always attach a unique_touch_event_id, if
available, to GestureEvents it creates. This facilitates event
targetting by not attempting to re-hittest these events in
RenderWidgetHostInputEventRouter. Normally an id of 0 indicates an
Android ContentView event which must be handled separately.

However, adding ids to all GestureEvents has lead to the associated
bug, since GestureEventDataPackets for TOUCH_TIMEOUT can now share a
unique_touch_event_id with another event in the same Sequence. In this
case, we shouldn't mistakenly ack events with source TOUCH_TIMEOUT from
the tail of the queue.

Bug: 879961
Change-Id: I65dd669cda6c276d6d73bb56b0d761694cb03c82
Reviewed-on: https://chromium-review.googlesource.com/1232592Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593202}

Removing ParentExistsForSubFrame metric as it was only briefly
necessary to verify that the code worked as intended.

Bug: 884233
Change-Id: I6934f92d295e03bf2715fc3460333dca63f6f53f
Reviewed-on: https://chromium-review.googlesource.com/1234224
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593201}

With frame messaging, the JS messages are filter sooner than with
window ID filtering.
The result is that the race condition on form submission is now
issue.
Pass the form data on submit event to avoid having to do a new JS
call.

Bug: 418827, 881364
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I64b0f6232e5ed46aa3f91cf7134cbe2c55c9c440
Reviewed-on: https://chromium-review.googlesource.com/1236277
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593200}

DeviceSettingsProvider in chrome/browser/chromeos/settings has an
undesirable dependency on g_browser_process, which it uses to access
the LocalState singleton. This CL removes the dependency on
g_browser_process by passing in LocalState explicitly.

Note that the tests and test helpers still depend on BrowserProcess
or TestingBrowserProcess, which they use to initialize and access the
LocalState. For tests in the settings package, I need to find a way to
remove this dependency in a follow up CL, so that the settings package
along with tests & test helpers can be moved out of chrome/browser.

See go/cros-untangle2

Bug: 446937
Change-Id: If9b14940f05ceef1fa8f33e612df22d3d9173d8f
Reviewed-on: https://chromium-review.googlesource.com/1233711Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593199}

Bug: 870049
Change-Id: Ib5927fd6a095ae5c60bea0eddbef70cb2060f4ba
Reviewed-on: https://chromium-review.googlesource.com/1192583
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593198}

Only add "show all" when Manual Fallback is disabled.

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I82a7a9818965716e19c57b78e13f196f52b34088
Reviewed-on: https://chromium-review.googlesource.com/1235673Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593197}

- Known bugs: navigation buttons do not work in iframes.
- Payment Request is only enabled in main frame.
- This CL does not enable autofill in iFrame by default.

Bug: 881364, 792642
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia18b8a0543d0c754a22d3ee9287171f6807f5f5c
Reviewed-on: https://chromium-review.googlesource.com/1233575Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593196}

  - Actual value of |maximum_backoff_ms| for |kBackoffPolicy| in
    |GaiaCookieManagerService| is 4 hours but the documentation/comment
    claims that it is 15 minutes. Fix the comment.
  - Fix lint error for an if-else statement.

Change-Id: If957966b754e8a33ab0531eef7d64ee871bdf5a0
Reviewed-on: https://chromium-review.googlesource.com/1238440Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593195}

Observe the last focused field to validate it is secure before filling a password

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26
Reviewed-on: https://chromium-review.googlesource.com/1221217
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593194}

The background can be painted underneath occasionally. When we have
a fullscreen element indicate the backdrop's color.

BUG=886544, 785001

Change-Id: I17d2533779abc68b14bc8af732f182dd32e963f0
Reviewed-on: https://chromium-review.googlesource.com/1234232
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593193}

Bug: 794372
Change-Id: Ic68afc2f66f340cf807406c3446567f886cd005e
Reviewed-on: https://chromium-review.googlesource.com/1237409Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593192}

Use case: An expensive function wants to make sure it's not running on the UI
thread so the expensive operations don't block that thread.
This assertion fails on threads other than scheduler workers.

Bug: 879181
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2a7ec2442c2020da4d68605c2476a01d25a45a33
Reviewed-on: https://chromium-review.googlesource.com/1221787Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593191}

The ModuleInstaller goes into the new component module_installer, which
hosts code necessary to install dynamic feature modules. It is used by
Chrome to install the AR module (and other modules in the future). See
go/chromevr-dfm-design-proposal for more information.

Bug: 863068, 862690
Change-Id: Ib7fb7451fbd9ce08cd57e96f923a81f7327a8ddb
Reviewed-on: https://chromium-review.googlesource.com/1228308
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593190}

NOTRY=true
TBR=nohle@chromium.org, dtrainor@chromium.org

Bug: 887953
Change-Id: I3a3f3ea828c86873fdea72d75c50a83a83271408
Reviewed-on: https://chromium-review.googlesource.com/1238377Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593189}

This CL deals properly with the root node for wallet data. This node
is sent (at least) in integration tests for migration to USS.

Bug: 853688
Change-Id: I94f38e38a4f7db7a7e960e5205c64d7ad6cf49e7
Reviewed-on: https://chromium-review.googlesource.com/1238541
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593188}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0664f0cf..980ce54f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I11d36cfe3b3e16e3be373688aa3b35ef44febb92
Reviewed-on: https://chromium-review.googlesource.com/1238374Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593187}

TBR= collinbaker@chromium.org,pkasting@chromium.org

Bug: 887815
Change-Id: Iff08fcfe7efeac0363d40302c57a08005b069bbb
Reviewed-on: https://chromium-review.googlesource.com/1237863
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593186}

Aimed to avoid ref-counted lifecycle of TaskQueueImpl.
SingleThreadTaskRunnner implementation will be dropped
from TaskQueue shortly. See bug for details.

TBR=gab@chromium.org

Bug: 865411
Change-Id: I92a3965299cb1c829e8a385f4bb2690383436107
Reviewed-on: https://chromium-review.googlesource.com/1234474
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593185}

This CL refines the way the wallet data bridge notifies about changes it
writes to the local database. This CL required a minor extension in the
AutofillWebDataBackend interface.

The changes are not guarded behind a feature flag for wallet_metadata
uss migration as they are backwards compatible for all current
implementations of AutofillWebDataServiceObserverOnDBSequence.

Bug: 853688
Change-Id: I3f9bd3e48c4591dddf3f645edef63d51cc8fbff8
Reviewed-on: https://chromium-review.googlesource.com/1236693Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593184}

TBR=tapted@chromium.org

Bug: 887811
Change-Id: I0ea74b31942f50ad2f3ffc463de60f48060f1639
Reviewed-on: https://chromium-review.googlesource.com/1237865Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593183}

https://android.googlesource.com/platform/external/perfetto.git/+log/f5eacf83622c..553230386b67


git log f5eacf83622c..553230386b67 --date=short --no-merges --format='%ad %ae %s'
2018-09-21 hjd@google.com Merge "Add linenoise to trace_processor"


Created with:
  gclient setdep -r src/third_party/perfetto@553230386b67

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I8a7c2d0ddcaba43fdec4e44f8229456e38919667
Reviewed-on: https://chromium-review.googlesource.com/1238323Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593182}

Scrollbar::Maximum is used by the theme paint code to determine whether
to disable the scroll arrows, based on whether the current scrollbar
position is all the way at the beginning or end of its range.

The rounding code used to set the visible size and overflow size for
the scrollbar behaves differently from that used by ScrollableArea to
clamp scroll offsets. The CL makes Scrollbar fall back to using values
computed by the ScrollableArea.

BUG=769615
R=skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I982e71b485cc402972cb7ac1f5f482c1f84e1a70
Reviewed-on: https://chromium-review.googlesource.com/1237390Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593181}

While OpenFile/CloseFile are already covered by ScopedBlockingCall,
this function does file reading operations (fread), which may block.
ScopedBlockingCall serves as a precise annotation of the scope that may/will
block for the scheduler. Since it supports nesting, there is no problem calling
CloseFile() in the same scope.

Bug: 874080
Change-Id: Id65de018cc20a2788d42d408c1c49052eed813c0
Reviewed-on: https://chromium-review.googlesource.com/1236393
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593180}

BUG=none
R=eyaich@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I54cc409664aaa53c0164f5a572f09e179602dd35
Reviewed-on: https://chromium-review.googlesource.com/1237654
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593179}

Bug: 874968
Change-Id: Id87498398908bfe8cf7e6c7ab596074b0575325a
Reviewed-on: https://chromium-review.googlesource.com/1236499
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593178}

This CL uses ScopedBlockingCall to mark blocking calls in /dbus.

This CL adds ScopedBlockingCall(MAY_BLOCK) for each scope containing a dbus_*
call, assuming all of those calls may block.
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=satorux@chromium.org

Bug: 874080
Change-Id: Ib90b59280bd22cb671a64bacabe299c02c6d6081
Reviewed-on: https://chromium-review.googlesource.com/1190930Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593177}