- 20 Jun, 2016 40 commits
-
-
peconn authored
This prevents a publisher name in a RTL/LTR language from messing up the formatting on a device set to a LTR/RTL language. BUG=608680 Review-Url: https://codereview.chromium.org/2064753006 Cr-Commit-Position: refs/heads/master@{#400668}
-
perezju authored
At the start of the story set, open the browsers associated with all stories. This makes sure that, when taking memory dumps, we always get a dump for all browsers all the time. BUG=616043 Review-Url: https://codereview.chromium.org/2073713003 Cr-Commit-Position: refs/heads/master@{#400667}
-
bruthig authored
BUG=597273 TEST=InkDropHostViewTest.* TEST=FloodFillInkDropRipple.MaxDistanceToCorners Review-Url: https://codereview.chromium.org/2042073002 Cr-Commit-Position: refs/heads/master@{#400666}
-
wnwen authored
- Do not re-save to disk if new metadata is the same as the old. - Add stats to determine where saveState is spending most of its time. - Move to using uptimeMillis to avoid stats being influenced by time spent in sleep. BUG=612574 Review-Url: https://codereview.chromium.org/2057733002 Cr-Commit-Position: refs/heads/master@{#400665}
-
wnwen authored
- Move responsibility of application context initialization in AwBrowserProcess to caller to prevent double initialization. - Switch to using ContextUtils.getApplicationContext for methods that only need the application context. Ensures the wrapped context is always used. - Move away from using mWebViewDelegate.getApplication as that returns the raw unwrapped application object. BUG=620790 Review-Url: https://codereview.chromium.org/2076623002 Cr-Commit-Position: refs/heads/master@{#400664}
-
jlebel authored
Fix for: https://codereview.chromium.org/1950033002/ Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. BUG=609064 Review-Url: https://codereview.chromium.org/2071323002 Cr-Commit-Position: refs/heads/master@{#400663}
-
benwells authored
BUG=621460, 621466, 621488 TBR=reillyg NOTRY=true Review-Url: https://codereview.chromium.org/2084533002 Cr-Commit-Position: refs/heads/master@{#400662}
-
yukishiino authored
We no longer need this hidden value. peria@ once removed this hidden value at https://crrev.com/1836193002 . This is the same. BUG= Review-Url: https://codereview.chromium.org/2079243002 Cr-Commit-Position: refs/heads/master@{#400661}
-
bnc authored
Use HttpServerProperties* instead of WeakPtr<HttpServerProperties> everywhere outside HttpServerProperties and its derived classes. In production, IOThread (or IOSChromeIOThread) outlives everything that would reference HttpServerProperties, so there are no lifetime issues. As for tests, this CL ensures that in test base classes that own both an HttpServerPropertiesImpl and an HttpNetworkSession instance, the former outlives the latter. BUG=508548 Review-Url: https://codereview.chromium.org/2041863002 Cr-Commit-Position: refs/heads/master@{#400660}
-
perezju authored
Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #1 id:1 of https://codereview.chromium.org/2059253002/ ) Reason for revert: CL wasn't responsible for the v8 breakage Original issue's description: > Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ ) > > Reason for revert: > Possibly breaking v8 perf bots. > > Original issue's description: > > [Android] Ensure perf test runner does not create shards for blacklisted devices. > > > > BUG=617559 > > > > Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0 > > Cr-Commit-Position: refs/heads/master@{#398197} > > TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=617559 > > Committed: https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce > Cr-Commit-Position: refs/heads/master@{#399460} TBR=jbudorick@chromium.org,mikecase@chromium.org,rnephew@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617559 Review-Url: https://codereview.chromium.org/2084493003 Cr-Commit-Position: refs/heads/master@{#400659}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/502f2a65..d604cd94 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2083513002 Cr-Commit-Position: refs/heads/master@{#400658}
-
srirama.m authored
Cleaning up video-dom* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Review-Url: https://codereview.chromium.org/2079203002 Cr-Commit-Position: refs/heads/master@{#400657}
-
sfiera authored
Doing it as it did with string substitution is brittle, since it forced assumptions about the JSON being generated out of the BuildRequest() function and into its callers and GetHostRestricts(). When we're generating different types of requests, it will be easier to understand what e.g. "obfuscated_gaia_id" is if it's always the ID, and never a partial string of JSON. Expose the BuildRequest() function to tests and test it. BUG=621090 Review-Url: https://codereview.chromium.org/2077973002 Cr-Commit-Position: refs/heads/master@{#400656}
-
haraken authored
BUG=613678 Review-Url: https://codereview.chromium.org/2078353002 Cr-Commit-Position: refs/heads/master@{#400655}
-
benwells authored
Revert of MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. (patchset #3 id:40001 of https://codereview.chromium.org/2076083003/ ) Reason for revert: New test is failing on DrMemory :( First failing build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%281%29/builds/3504 Sample test output: MdSettingsBrowserTest.BackForwardDoesntCrash: Did not complete. Original issue's description: > MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. > > But... > > ONCE AND FOR ALL! > > BUG=620370 > R=groby@chromium.org > > Committed: https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325 > Cr-Commit-Position: refs/heads/master@{#400528} TBR=groby@chromium.org,michaelpg@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620370 Review-Url: https://codereview.chromium.org/2082563002 Cr-Commit-Position: refs/heads/master@{#400654}
-
sigbjornf authored
Add detection of trace() calls over smart pointer types that either do not wrap up references to heap objects, or are otherwise not meant to be traced over. In particular, CrossThread(Weak)Persistent<T> fields are now detected as being illegal to trace over. Also consider OwnPtr<T>, RefPtr<T> and std::unique_ptr<T> as illegal to trace over & emit a more concise error messages for these. R= BUG=619149 Committed: https://crrev.com/3ba6089cd6a901b62ff5a0d8f08a2bd818edcbe8 Review-Url: https://codereview.chromium.org/2060553002 Cr-Original-Commit-Position: refs/heads/master@{#399861} Cr-Commit-Position: refs/heads/master@{#400653}
-
hayato authored
This test should be deleted at https://codereview.chromium.org/2076933002 BUG=531990 Review-Url: https://codereview.chromium.org/2071133004 Cr-Commit-Position: refs/heads/master@{#400652}
-
treib authored
Also clean up the existing tests a bit BUG=605870 Review-Url: https://codereview.chromium.org/2079833002 Cr-Commit-Position: refs/heads/master@{#400651}
-
caseq authored
BUG=614935 Review-Url: https://codereview.chromium.org/2072173003 Cr-Commit-Position: refs/heads/master@{#400650}
-
nisse authored
BUG=webrtc:5682 Review-Url: https://codereview.chromium.org/2068703002 Cr-Commit-Position: refs/heads/master@{#400649}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfa49712..502f2a65 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2080193002 Cr-Commit-Position: refs/heads/master@{#400648}
-
jiadong.zhu authored
merge the latest open source zlib into chromium external projects Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements: - Add new inflateGetDictionary() function - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream. - Fix bug in gzclose() when gzwrite() runs out of memory Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements: - Fix bug in gzclose_w() when gzwrite() fails to allocate memory - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen() - Add gzopen_w() in Windows for wide character path names - Fix type mismatch between get_crc_table() and crc_table Version 1.2.6 has many changes over 1.2.5, including these improvements: - gzread() can now read a file that is being written concurrently - gzgetc() is now a macro for increased speed - Added a 'T' option to gzopen() for transparent writing (no compression) - Added deflatePending() to return the amount of pending output - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode - deflatePrime() can now insert bits in the middle of the stream - ./configure now creates a configure.log file with all of the results - Added a ./configure --solo option to compile zlib with no dependency on any libraries - Fixed a problem with large file support macros - Fixed a bug in contrib/puff - Many portability improvements BUG=610615 R=agl@chromium.org R=gavinp@chromium.org Review-Url: https://codereview.chromium.org/1955383002 Cr-Commit-Position: refs/heads/master@{#400647}
-
Yuta Kitamura authored
This reverts commit 6a85b3b9. Cr-Commit-Position: refs/heads/master@{#400646}
-
yutak authored
Reland of Check DisplayItemCient aliveness in cached subsequences (patchset #1 id:1 of https://codereview.chromium.org/2078393003/ ) Reason for revert: It was not acceptable to revert the OwnPtr removal patch just for this revert. Relanding this to land OwnPtr commit again. Original issue's description: > Revert of Check DisplayItemCient aliveness in cached subsequences (patchset #6 id:100001 of https://codereview.chromium.org/2066603005/ ) > > Reason for revert: > Based on r400605 that is to be reverted. > > Original issue's description: > > Check DisplayItemCient aliveness in cached subsequences > > > > BUG=609218 > > > > Committed: https://crrev.com/127e5fadca5f431a5de1bef939f7f43aec1d136f > > Cr-Commit-Position: refs/heads/master@{#400607} > > TBR=chrishtr@chromium.org,wangxianzhu@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=609218 > > Committed: https://chromium.googlesource.com/chromium/src/+/6ece4aaeb5e2c53eca2617d42de64ff917cee884 TBR=chrishtr@chromium.org,wangxianzhu@chromium.org,vasilii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609218 Review-Url: https://codereview.chromium.org/2082553002 Cr-Commit-Position: refs/heads/master@{#400645}
-
Vasilii Sukhanov authored
Revert of Check DisplayItemCient aliveness in cached subsequences (patchset #6 id:100001 of https://codereview.chromium.org/2066603005/ ) Reason for revert: Based on r400605 that is to be reverted. Original issue's description: > Check DisplayItemCient aliveness in cached subsequences > > BUG=609218 > > Committed: https://crrev.com/127e5fadca5f431a5de1bef939f7f43aec1d136f > Cr-Commit-Position: refs/heads/master@{#400607} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609218 Review URL: https://codereview.chromium.org/2078393003 . Cr-Commit-Position: refs/heads/master@{#400644}
-
kjellander authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7e0fbca..b0d0745 TBR= CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2078363002 Cr-Commit-Position: refs/heads/master@{#400643}
-
markusheintz authored
BUG=609127 Review-Url: https://codereview.chromium.org/2073753002 Cr-Commit-Position: refs/heads/master@{#400642}
-
Vasilii Sukhanov authored
The CL is based on r400605 to be reverted. https://codereview.chromium.org/2050123002 This reverts commit f5f08765. BUG=582354 TBR=yutak@chromium.org Review URL: https://codereview.chromium.org/2080623002 . Cr-Commit-Position: refs/heads/master@{#400641}
-
kolos authored
BUG=582434 Review-Url: https://codereview.chromium.org/2055633003 Cr-Commit-Position: refs/heads/master@{#400640}
-
tkent authored
We need to clear |selected| state on every test run because every OPTION is selected after removeChild(). This CL makes select-single-remove.html very slower. BUG=620142 TBR=keishi@chromium.org Review-Url: https://codereview.chromium.org/2079233002 Cr-Commit-Position: refs/heads/master@{#400639}
-
machenbach authored
BUG=chromium:616035 TBR=jochen@chromium.org, dpranke@chromium.org Review-Url: https://codereview.chromium.org/2078343002 Cr-Commit-Position: refs/heads/master@{#400638}
-
yangguo authored
R=machenbach@chromium.org BUG=592409 Review-Url: https://codereview.chromium.org/2084493002 Cr-Commit-Position: refs/heads/master@{#400637}
-
falken authored
This is a vestige of older code added in https://crrev.com/0c171c6df9b7fbb Previously Doom() called StopIfIdle() rather than Stop(). Now (as of https://crrev.com/b34f1e5b97667e) Doom() terminates immediately, with the one exception when DevTools is attached. In that case, we stop immediately once DevTools is detached. There are two callsites that set status to REDUNDANT directly. This patch changes one to call Stop() first, as per spec. It's not necessary to call Doom() because the new version has already been stored which puts the old version's resources in the purged list. This is minor cleanup in anticipation of some changes for https://crbug.com/616331 BUG=616331,448670 TEST=third_party/WebKit/Tools/Scripts/run-webkit-tests --repeat-each=50 http/tests/serviceworker/register-same-scope-different-script-url.html Review-Url: https://codereview.chromium.org/2077843002 Cr-Commit-Position: refs/heads/master@{#400636}
-
zea authored
This histograms are no longer being used, and can be deprecated. BUG=none Review-Url: https://codereview.chromium.org/2078663002 Cr-Commit-Position: refs/heads/master@{#400635}
-
hlopko authored
V8 now tells EmbedderHeapTracer when it enters the final pause, and that is exactly the place where we need to trace active script wrappables. Previous implementation is not correct. LOG=no BUG=468240 Review-Url: https://codereview.chromium.org/2076133002 Cr-Commit-Position: refs/heads/master@{#400634}
-
vabr authored
This CL changes the type of PasswordFormManager::blacklisted_matches_ from ScopedVector to std::vector<std::unique_ptr>>. BUG=555132 Review-Url: https://codereview.chromium.org/2078253002 Cr-Commit-Position: refs/heads/master@{#400633}
-
hayato authored
This CL also fixes an implementation bug of HTMLSlotElement::hasAssignedNodesSlow(), which a new test revealed. BUG=531990,595287 Review-Url: https://codereview.chromium.org/2076933002 Cr-Commit-Position: refs/heads/master@{#400632}
-
srirama.m authored
Cleaning up video-currentTime* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Review-Url: https://codereview.chromium.org/2077833002 Cr-Commit-Position: refs/heads/master@{#400631}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#400630}
-
maksim.sisov authored
This cl makes SPDY to match HTTP and QUIC implementations and call the request_callback only after data is sent. The unittests are corrected accordingly. Review-Url: https://codereview.chromium.org/2064593002 Cr-Commit-Position: refs/heads/master@{#400629}
-