- 07 Nov, 2019 40 commits
-
-
Zakhar Voit authored
This introduces a flag that centers title text to WidgetDelegate and WebDialogDelegate and applies it to the login screen extension's window (it is one of the requirements for Imprivata TT launch). Bug: 1018682 Change-Id: I082a7de9ea29c07a6eb3e71a7c814ced5a2ce5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883568Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#713401}
-
Anastasiia Nikolaienko authored
This reverts commit 30fd9e19. Reason for revert: submitting https://crrev.com/c/1871591 instead ( where we call LogOutAllAccounts directly instead of changing the logic of AccountReconcilor). Original change's description: > Fix Mirror cookie validity mismatch > > In certain cases, Gaia's /ListAccounts APIs claims accounts to be in a > valid state when they are actually invalid. This causes issues with > account reconciliation because |AccountReconcilor| uses /ListAccounts as > the source of truth and is unable to detect this state. > In this state, certain Google properties like Gmail for example send a > Mirror re-authentication header for the offending account. However, even > after the user re-authenticates the account, account reconciliation ends > up being a no-op because the reconcilor thinks that the user's cookies > are valid and there is nothing to reconcile. > > Fix this by storing some flags in |CookieReminter| which are set when > we receive Mirror re-authentication headers from Gaia, and are cleared > when the next reconciliation cycle begins. > > This is a temporary fix until we can submit https://crrev.com/c/1871591. > > Bug: 1012649 > Change-Id: I04fd971cdc788094f038ee808b4a38003ef48e22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883652 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710870} Bug: 1012649 Change-Id: I2873677ac23f3ea98930603f0c1615a59fa8ce97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901036Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#713400}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1944f6e6df68..6d6b9a1ca930 git log 1944f6e6df68..6d6b9a1ca930 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 perezju@chromium.org [Telemetry] Remove legacy value system Created with: gclient setdep -r src/third_party/catapult@6d6b9a1ca930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:992427 Change-Id: I74236c8f2988daaac0cc8b252959fa7c3eb822bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713399}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/866bde58907c..1af507800d72 git log 866bde58907c..1af507800d72 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 primiano@google.com Merge "infra: quality of life" Created with: gclient setdep -r src/third_party/perfetto@1af507800d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iebb4e4fcb81b466fe05097a9e4de7e90f206610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903669Reviewed-by:
-
Sylvain Defresne authored
The omnibox already had a reimplentation of GTMFadeTruncatingLabel that used NSAttributedText property to perform the fade-truncation as OmniboxPopupTruncatingLabel. Move it to a shared location and rename it to FadeTruncatingLabel and convert TabView to use the new class thus removing another dependency on third_party/google_toolbox_for_mac. Before: https://drive.google.com/file/d/1YeEL6jkm-P9cNeEgS0vJxlPu-HIEo3_r/view After: https://drive.google.com/file/d/1U1jAVeXYg4RFiw98UzZ-yoBBoOG2e1MD/view Bug: none Change-Id: Ic43f0973d36ba6b74c0ad0a2fa9068d5a3be9bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901082 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713397}
-
Koji Ishii authored
This patch restructures nested `if` blocks in |NGBoxFragmentPainter::PaintObject| to reduce the duplicated code, by checking |paint_phase| first. This makes it easier to add the support for fragment items. There is no behavior changes by this change. Bug: 982194 Change-Id: I8b50db590a729245d647093dc00695fd3db9835a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903235Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713396}
-
Swapnil authored
Currently the logs were being uploaded at each chrome process restart. Upload at most K logs in any X hours window. This prevents log uploading at start of each chrome process. Local state of chrome process is maintained across reboots. Maintained a List of uploads made in the previous X hour window. UpdateLocalStateForLogs() keeps the logs updated for previous X hour window and appends if any upload is made recently. The unit test makes K+3 uploads consecutively, and checks if delay of first K uploads is 0 and for the remaining uploads it is approximately X. Another unit test checks that immediate log upload is not throttled. Initial Commit Bug: 789481 Change-Id: I16cadf69e68d8982b5b2384aebbeb6cdad892d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876092 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713395}
-
Andreas Haas authored
The original CL lacked a bounds check in the constructor of ArrayBufferContents. Original message: With this CL we finally use v8::BackingStore as the backing store implementation of blink::ArrayBuffer. Changes: * Use v8::BackingStore as the backing store for ArrayBufferContents. * Remove ArraybufferContents::DataHolder and ArrayBufferContents::DataHandle. * Replace all uses of DataHolder in ArraybufferContents with uses of v8::BackingStore. * Replace the use of DataHandle in the V8 bindings. * Add an exception to the presubmit check to allow std::shared_ptr in ArrayBufferContents. It is contained there and does not escape. R=haraken@chromium.org, ulan@chromium.org TBR=agrieve@chromium.org Bug: chromium:1008840 Change-Id: I630fe88d81dd5f9db396f831fb3388e5d0a1a59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901026 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713394}
-
Shakti Sahu authored
Change-Id: I3a1119ed94f1ad68845097b5cb3e9f3e4f756de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881972 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#713393}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d9fbf0234869..dc59b4b075e9 git log d9fbf0234869..dc59b4b075e9 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 afdx@google.com spirv-fuzz: vector shuffle transformation (#3015) 2019-11-06 afdx@google.com Add basic documentation about spirv-fuzz (#3016) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@dc59b4b075e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: Ibee444797794410670ee2e0957b96c7d7175a2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903412Reviewed-by:
-
Sergio Villar Senin authored
As part of crbug.com/1008303 we are removing all the blink/public/web dependencies from chrome/browser. It would be nice to add a presubmit check so that new dependencies are not added in the meantime. Bug: 1008303 Change-Id: Id6aee21e4c64271b0c1e00cdffc848de88bb4629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879921 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Marc Treib authored
It has done its job and is not needed anymore Bug: 1021386 Change-Id: I5afe5de0843dd40c945e3eeaa64735eec7d5f81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899992Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713390}
-
Jeonghee Ahn authored
After the hover event, some element may change shape or even disappeared. Current implementation trigger hover first and the focus is moved. If the target element disappeared due to a hover event, SpatNav does not finish completely. Then the focus dose not move at all, but the target element get hover status. Events of hover are incidental, so moving focus should be first. This patch change the order of event occurrence. Bug: 1021426 Change-Id: Id20bda8ab94c97d4eeef6526cf5954effce7e78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897403Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Cr-Commit-Position: refs/heads/master@{#713389}
-
Sylvain Defresne authored
Remove dependencies on //third_party/google_toolbox_for_mac that are no longer used (i.e. the code do not use GTM). Add a comment in third_party/breakpad/BUILD.gn to explain why there is a dependency on google_toolbox_for_mac even though there are no direct #include of any of its headers. Bug: none Change-Id: I297e4a6b8f4ff5b8b19f7c8d53f643547e406b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901030Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#713388}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dfb12d9e..67d4bf7a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id6f6e8a9777301f38e76c71f6ed5b8178d937364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902431Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713387}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3960.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I1dbc3f6a55a31e7b8ebef7edf3f56c57da98ac34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903670Reviewed-by:
-
Jan Scheffler authored
This patch adds a couple of tracing events to show how much time is spent waiting on network vs. actually parsing and compiling JavaScript when doing streaming compilation Bug: chromium:939275 Change-Id: I7deb7ad3e2fcf35fe0f8852d1debb198d166a571 Fixed: 939275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886896 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#713385}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.13-1572864139-benchmark-80.0.3954.0-r1 to 80-3945.13-1572864139-benchmark-80.0.3960.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I5819503f1f56f89b8165cd9d22b3593302e8f61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903667Reviewed-by:
-
Himanshu Jaju authored
Peer connection sharing capability is added to SharingSpecifics which determines if a remote peer is capable of receiving an incoming request to start a webrtc connection. This helps us to filter out M80+ devices from older devices and reduce failure rates. Bug: 1022288 Change-Id: If23506d07be0532a3e04a30fbd97d28fddd4d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903348Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#713383}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3943.1-1572873357-benchmark-80.0.3954.0-r1 to 80-3943.1-1572873357-benchmark-80.0.3960.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Icd6d5dc40a8c8f3ae79580cc401daafaaa709e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903666Reviewed-by:
-
Friedrich Horschig authored
If the state changes while or briefly after the bottom sheet is hidden, the BottomSheet#sendOffsetChangeEvents triggers without sheet content which sets the maximum full ratio to 0. Since the hidden full ration is divided by that maximum full ration, the result is NaN which is then propagated to Observers [1]. [1] Sample stack trace of an Observer receiving NaN after onLayout: BottomContainer${EmptyBottomSheetObserver}#onSheetOffsetChanged(NaN, 0); at Rz1.a(PG:2) at org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.a(PG:102) at org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.a(PG:127) at TV1.onLayoutChange(PG:40) at android.view.View.layout(View.java:19677) at android.view.ViewGroup.layout(ViewGroup.java:6075) at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323) at android.widget.FrameLayout.onLayout(FrameLayout.java:261) Bug: 1021885 Change-Id: I21573d91b92f1c017ec2267381c196ae79903545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901566Reviewed-by:Matthew Jones <mdjones@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713381}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc0919dcb64b..8542baee0645 git log cc0919dcb64b..8542baee0645 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 5d0e01d9e7f9..e471df3c9154 (2 commits) Created with: gclient setdep -r src/third_party/angle@8542baee0645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I16da7d893f90abb6c7c8b6c7d121be17b73e9539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903414Reviewed-by:
-
Dominick Ng authored
Bug: None Change-Id: I4d797045609142e466d030b6bb7911ca57cdcc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900788 Auto-Submit: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713379}
-
Yuki Shiino authored
__all__ has been misunderstood and unnecessarily defined. Removes __all__ definitions. We don't use |import *|. Bug: 839389 Change-Id: I571600ad50c0d3ef20028efe7fe576cd1ef60762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903183 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#713378}
-
Maya Lekova authored
Bug: chromium:988677 Change-Id: I8ed3228b225cb98f102f4493a47e9f2a231319ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886412 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/81bef5295824..c2ef0f867b79 git log 81bef5295824..c2ef0f867b79 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 achuith@chromium.org xbuddy: Fix for unittest in python3. 2019-11-07 vapier@chromium.org pylintrc: enable overlapping-except check 2019-11-07 vapier@chromium.org pylintrc: enable redefined-variable-type check Created with: gclient setdep -r src/third_party/chromite@c2ef0f867b79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaf7f20e4cd9a16887b5cd0522fd7c138e8d9d3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903413Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 998496 Change-Id: I47c837120811b27de1f22fccb35893ccb7c2ebcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901471Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/345a2735e2c8..c4420ef3dc6c git log 345a2735e2c8..c4420ef3dc6c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1d09b983031b..cc0919dcb64b (8 commits) Created with: gclient setdep -r src/third_party/skia@c4420ef3dc6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: If7d89f32291844c1dbf0324f5a0bdc72e1760941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903308Reviewed-by:
-
Mihai Sardarescu authored
Desktop Identity Consistency has now launched and we are using a different flag to force the Dice Identity Consistency migration. Note that this feature flag was used in the past by some users to disable browser sign-in, but that no longer works and the users can disable browser sign-in from the chrome://settings/privacy Note that this CL does not remove the corresponding finch feature as that is still required for unit and integration tests until ForceDiceMigration feature is rolled out. Bug: 1021535 Change-Id: Id671b3302af3cc854f2c2decd7511f5401cd0569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893273Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713373}
-
Marc Treib authored
Bug: 1016712 Change-Id: Iaf86d87d3f53c6446199897f4a2482c49ef5ff2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900996Reviewed-by:
-
Yang Guo authored
Previous names do not indicate what they actually do. Change-Id: I4ed60f0af77b017b88f95dab90a49a1ba940c57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883575 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713371}
-
Fredrik Söderquist authored
With some unlucky combinations of parameters (timing and current time), we could end up spinning in the resolve loop, (re)resolving the same interval over and over, not making forward progress. Guard against this by bumping the next "begin after" value by epsilon if the resolved end is the same as the current "begin after". Bug: 1021630 Change-Id: I71ba25cd423c24428f5d3f41f05fc83a2a1693cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901043Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#713370}
-
Michael Lippautz authored
The Visitor parameter was not needed for custom weak callbacks because such callbacks are anyways not allowed to revive an object. Replace the parameter with WeakCallbackInfo which can be used to query liveness information. This allows us to move ObjectAliveTraits and its callers into a heap-private section in future as WeakCallbackInfo is only exposed when such queries are allowed. Renamed RegisterWeakMembers to RegisterWeakCallbackMethod as it is just delegating to RegisterWeakCallback appropriately. The GC plugin bailed out on checking for whether all fields are traced as soon as RegisterWeakMembers was present. The rename now requires changing WeakMember<> to UntracedMember<> because the method name is different. This matches semantics though as WeakMember<> should be automatically cleared by the GC whereas UntracedMember<> is manually cleared by the callback. A followup removes the GC plugin logic. Bug: 982754 Change-Id: I8387c12c06a9c35a6732060dd212290f058a7199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899377 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f8045a095cc1..64cfaeac4c5d git log f8045a095cc1..64cfaeac4c5d --date=short --no-merges --format='%ad %ae %s' 2019-11-07 yunchao.he@intel.com Reland "Implement readonly storage buffer - validation at API side" Created with: gclient setdep -r src/third_party/dawn@64cfaeac4c5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I61963fb40a584f189e43394baa5b6c15c0981336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903411Reviewed-by:
-
chrome://help-appRachel Carpenter authored
This is shown in the launcher with --enable-features=HelpAppV2, otherwise existing Get Help app is shown. Bug: 1012578, b/140960611 Change-Id: I18a56bce24733fa2efa847ad4d2b8db5a7eccc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902174 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#713367}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I259fa814159f5f85b11515fbfddf3aff0356ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903407Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b70bebf7..dfb12d9e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f933d9011be92e00d46ebe1f8dfe1ee547a73e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902429Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e09342dccb0d..81bef5295824 git log e09342dccb0d..81bef5295824 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 vapier@chromium.org pylintrc: list more 3rd party libs Created with: gclient setdep -r src/third_party/chromite@81bef5295824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2eb62ef34984c46fb7774d2c11656d953a3dd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903406Reviewed-by:
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: Ia29e269f2335ee91432f3c4eb308d7ae3b8ac72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890431Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713363}
-
Adam Rice authored
Coverage indicated that the case where there is an exception looking up a pipeTo or pipeThrough option was not actually tested. Add a web platform test to verify that exceptions are thrown and that options are accessed in the correct order. Change-Id: I88d889a42853ee0625cc51fe30cd119b118289b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903169Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#713362}
-
