- 24 Aug, 2018 40 commits
-
-
Hugo Holgersson authored
"... the default action MUST be to shift the document focus". https://www.w3.org/TR/uievents/#event-type-keydown As focus movement happens during keydown, once we got the succeeding keyup-event, it's safe to assert activeElement. Why not do the asserts at 'focusin' instead? After 'keyup', we're safe to send another trigger-key. (Most spatnav tests verify several focus movements). Bug: 803086 Change-Id: I6927d61a9d323f5bd3fe8a6022aef2f6eca50521 Reviewed-on: https://chromium-review.googlesource.com/1188476Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#585855}
-
Tatiana Buldina authored
Updated several error codes returned by ChromeDriver, for compliance to W3C standard. Bug: chromedriver:2552 Change-Id: Ie05b784beee8f6e9a79e4c0356e9d3c2dbce3874 Reviewed-on: https://chromium-review.googlesource.com/1187193 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585854}
-
Guido Urdaneta authored
This makes these utilities easier to use from other projects, which we plan to do in the upcoming Hardware Platform Extension API (see crbug.com/854636). This CL also refactors the function to get the computer manufacturer and model so that they are available as separate strings, and adds a number of style/lint fixes. Bug: 874408 Change-Id: I408151cc478ccf37a0515d17d1381115b12d9122 Reviewed-on: https://chromium-review.googlesource.com/1175781Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585853}
-
Fredrik Söderquist authored
This moves the |base_value_updated_| flag from the "primitive type" version of SVGAnimatedProperty to SVGAnimatedPropertyBase, and sets it in BaseValueChanged. The flag is cleared in SynchronizeAttribute. This allows some code to be simplified. It also avoids synchronizations triggered by just having created the tear-off object like in the bug. Bug: 873470 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59f30dd69286dc0799a583eb6a52c41022b0af91 Reviewed-on: https://chromium-review.googlesource.com/1188305 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585852}
-
Balazs Engedy authored
Bug: 847985 Change-Id: I2ae8ec26a2c01e2ffd1b1527cad0387c1e90f389 Reviewed-on: https://chromium-review.googlesource.com/1187104 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585851}
-
David Quiroz Marin authored
The current implementation of font.Width has a problem with RTL text with spaces. Additionally, this fix allows to update canvas textMetrics actualBoundingBox which should return the minimum bounding box that covers all strokes/ink. Bug:277215 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If8815d640836d334381072b385d7fa8474a6ec45 Reviewed-on: https://chromium-review.googlesource.com/1179244Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585850}
-
Majid Valipour authored
EffectProxy.localTime should accept undefined as its local time and treat that as meaning that the keyframe effect is not in effect. Note: This is a partial fix. We still need to make sure that any applied effect is cleared once localTime is set to undefined. This patch only ensures that when the initial value is not set, or set to undefined the keyframe effect is not applied. Test: virtual/threaded/fast/animationworklet/worklet-animation-local-time-undefined.html Bug: 870711 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2fdc716c331eb11a9b3eed524ac703f50a222a49 Reviewed-on: https://chromium-review.googlesource.com/1181935Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585849}
-
Lei Zhang authored
There are a couple places that starts with UTF8 data and converts them to UTF16 before passing them to base::Value. base::Value turns around and converts it back to UTF8. Fix some nits along the way. Change-Id: I10ad741de22aecc04b37fa633ab0033a26acc688 Reviewed-on: https://chromium-review.googlesource.com/1188033Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585848}
-
Mugdha Lakhani authored
This removes BackgroundFetchSettledFetches from blink, idl files, and the WPT tests. In a follow up CL I'll remove it from all the event dispatcher code on the browser side. This fix also makes cache_query_params optional in MatchRequests() in mojo. This is required because otherwise the mojo bindings logic crashes the renderer when we try to pass in a nullptr for cache_query_params from blink. Bug: 869918, 863016 Change-Id: Ifa933451f98f82902d8455ba5401c629c8c24811 Reviewed-on: https://chromium-review.googlesource.com/1186735 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585847}
-
Thomas Tangl authored
The eligibility for showing the consent bump is checked on every startup during the creation of the UnifiedConsentService. Two metrics for the consent bump suppress reason are added: - User turned off a sync data type - User turned off a on-by-default privacy setting Bug: 872435 Change-Id: I6187e88bebce1516aec72fd369281c34b89039be Reviewed-on: https://chromium-review.googlesource.com/1188478 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585846}
-
John Budorick authored
TBR=tapted@chromium.org Bug: 877129 Change-Id: I86a6136f304f5dde483c9b778ed1a8d058090294 Reviewed-on: https://chromium-review.googlesource.com/1187828Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585845}
-
Nico Weber authored
The arm NEON comment was about FELightingNEON.cpp which was removed in https://codereview.chromium.org/14262015 , with the other neon code then being garbage-collected later in https://codereview.chromium.org/313303003 The file also contains a few source_sets with only header files. Since header filesa aren't compiled by themselves, that doesn't make much sense, so remove all these targets that didn't also contain cc files. Bug: 381082 Change-Id: I13a4a9ded44fa46a119574a03fe18a7f12b54cec Reviewed-on: https://chromium-review.googlesource.com/1187503Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585844}
-
John Budorick authored
Bug: 876539 Change-Id: Ib28bf55e7213789186b8180904f7317cb5c0d8ce Reviewed-on: https://chromium-review.googlesource.com/1186542 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#585843}
-
Fredrik Söderquist authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I989622cb82e8135d387f5807723eaf0704e2bbb3 Reviewed-on: https://chromium-review.googlesource.com/1188306Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#585842}
-
Lei Zhang authored
Instead of creating spans from ReadOnlySharedMemoryMappings manually. Change-Id: I00a1d10eafc58e3eb8e8b6ddb31c27fdcec05643 Reviewed-on: https://chromium-review.googlesource.com/1187742Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585841}
-
Sigurdur Asgeirsson authored
Bug: 874968 Change-Id: I32c3ab375b033f64436f47cc1fa2186a5b63178a Reviewed-on: https://chromium-review.googlesource.com/1187181 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#585840}
-
Oriol Brufau authored
The cssText style serialization attempts to minimize the output by converting different longhand declarations into a single shorthand one. However, this shouldn't happen if the shorthand is disabled behind a runtime flag. BUG=876913 TEST=fast/css/inset-serialize.html Change-Id: I264dff3352c452ab5407e34ccbcf94a519107a99 Reviewed-on: https://chromium-review.googlesource.com/1187102 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585839}
-
Scott Haseley authored
Change-Id: Ic6e7206b47f6bfa0c4d4451b2580acb95fe29ffb Reviewed-on: https://chromium-review.googlesource.com/1187562Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#585838}
-
Helen Li authored
This CL adds a note to ProxyResolvingClientSocket on why QUIC proxy isn't yet supported and links to crbug. Bug: 876885 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5d07064e252e8bdd9b28281488d88613fa102bd4 Reviewed-on: https://chromium-review.googlesource.com/1185746Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585837}
-
Paul Jensen authored
Do so by sharing logic from Android and iOS. Bug: 869406 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If51d4acb13103818171bbd9e3f6ddc0e7bb9e294 Reviewed-on: https://chromium-review.googlesource.com/1185210 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#585836}
-
Mugdha Lakhani authored
This is step 1, everything needed to support this on the browser side. Bug: 876691, 869918 Change-Id: I4c161ae404e24caae9d09b7ea4709a6eb161a95e Reviewed-on: https://chromium-review.googlesource.com/1185006 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585835}
-
Kushagra Sinha authored
Presence of Chrome OS Account Manager implies Mirror Account Reconciliation, which implies that the only allowed operations are: - Going Incognito. - Displaying Chrome OS Account Manager. The incognito case is already handled. Handle the display of Chrome OS Account Manager. Bug: 833797 Change-Id: I387db8a50a84f82724fa8f4b41b32f3a8fccf518 Reviewed-on: https://chromium-review.googlesource.com/1188474Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#585834}
-
Pavel Shmakov authored
This is the resurrection of the CL by dgn@: https://chromium-review.googlesource.com/c/chromium/src/+/803975 What changed: - Dagger updated from 2.13 to 2.17, along with corresponding updates of dependencies. - A couple of changes in internal_rules.gni to get annotation processor and their dependencies added as targets. - Added dagger-spi, which is a dependency of dagger since 2.14. - Removed findbugs_jsr305, since it is already present in the project. - Moved javax.inject into android_deps. Bug: 787005 Change-Id: Ia64bdef606cbcbc6ca39fefa431b2434cc7b7263 Reviewed-on: https://chromium-review.googlesource.com/1183903Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585833}
-
Roger Tawa authored
Bug: 874558 Change-Id: I09dbdacde63bf0f9fc771b214ca5ee021fdada19 Reviewed-on: https://chromium-review.googlesource.com/1178889Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#585832}
-
David Bienvenu authored
With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to use NOINLINE instead of MSVC_DISABLE_OPTIMIZE, which is more explicit and specific anyway. Bug: 873359 Change-Id: Ieb5c29e3212596f928a636d15143d717bd2c744c Reviewed-on: https://chromium-review.googlesource.com/1187265Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585831}
-
Dave Tapuska authored
Avoid setting position absolute on top layer elements that are the documentElement. This matches what Firefox does. The root element is special when it is in fullscreen mode because it does not get the style applied that forces its dimensions and position to be fixed. BUG=876339 Change-Id: I42b18047dc9648585bc279510d66decd6d6a4516 Reviewed-on: https://chromium-review.googlesource.com/1186961 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585830}
-
Guido Urdaneta authored
MediaStreamSources do not have constraints, so remove old accessors that provided that functionality. Bug: 877430 Change-Id: Iee3973f5ddcb8d85608a798565784a59e474231a Reviewed-on: https://chromium-review.googlesource.com/1188312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585829}
-
Helen Li authored
The internal chrome_signin_cookie_manager.mm is converted to the constructor with NetLog. The constructor with one param is now unused. This CL removes it. Bug: 801910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icf1ff6df91a37b6f914e60f29ac6757760cb7a2a Reviewed-on: https://chromium-review.googlesource.com/1187387Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585828}
-
Amirhossein Simjour authored
The issues only appear on Android P and using software Canvas instead of HardwareCanvas resolves the problem. It looks that HardwareCanvas get locked and doesn't refresh. Bug: 876492, 859913 Change-Id: I821278cab6029ea66e3dcd77f5c9514bd58ec53a Reviewed-on: https://chromium-review.googlesource.com/1187362 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#585827}
-
Max Morin authored
The processing_id added to AudioSinkParameters in a previous CL is now plumbed all the way into the Audio Service. It is used to register as an observer of a StreamMonitor group with the appropiate ID. The output controller will check when new (processed) input streams join the group and will notify them of its existence, as well as when it goes away. The next CL will connect InputControllers in a similar manner. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id1dcaf882b59b963abd7c157fe7259e2b762660e Reviewed-on: https://chromium-review.googlesource.com/1174833Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585826}
-
Stepan Khapugin authored
This reverts commit 11fe369f. Reason for revert: Breaks downstream bots (crbug.com/877485) Original change's description: > Detect CSP errors from translate.js and pass it back to native code. > > Currently all CSP errors are reported wrongly as INITIALIZATION_ERROR, > this change will report it as BAD_ORIGIN. > > Change-Id: I2cc09d9dcd722ab0657605e540acac69e142eb6c > Bug: 686364 > Reviewed-on: https://chromium-review.googlesource.com/1141047 > Commit-Queue: John Wu <jzw@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585580} TBR=droger@chromium.org,eugenebut@chromium.org,anthonyvd@chromium.org,jzw@chromium.org Change-Id: Ibd3c5af48b75f39d392ba803dff0de1f2deab169 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 686364 Reviewed-on: https://chromium-review.googlesource.com/1188543Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585825}
-
Charlie Harrison authored
This CL adds three new fields to UkmSource. A follow-up will propagate changes to the underlying proto fields. Bug: 873316 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic691221c8165df7cee16b089407d8ddd346e78c3 Reviewed-on: https://chromium-review.googlesource.com/1175033 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585824}
-
Martin Kreichgauer authored
This is a follow-up to crrev.com/c/1181863, which added OPERATION_DENIED handling for Touch ID. In this change that behavior is extended to all transports. Bug: 875982 Change-Id: If10000f8333dccd4c2e83becf51e36baedbc2655 Reviewed-on: https://chromium-review.googlesource.com/1187683 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585823}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a9a4168ab6e9..1e44d066259f git log a9a4168ab6e9..1e44d066259f --date=short --no-merges --format='%ad %ae %s' 2018-08-24 nastasoiuf@google.com Parser for metrics & splitted components Created with: gclient setdep -r src/third_party/catapult@1e44d066259f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ie92ff83562fd5c711f0d25fae48176d1623244af Reviewed-on: https://chromium-review.googlesource.com/1188442Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585822}
-
Jan Wilken Doerrie authored
This change adds a feature flag for caBLE for Windows and disables it by default. Bug: 821766, 837088 Change-Id: I2f87be1854a3fc64d23c9a0493eaecf0ee73668b Reviewed-on: https://chromium-review.googlesource.com/1187146 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585821}
-
Jérôme Lebel authored
When the user clicks on "Not johndoe@example.com", the sign-in dialog is opened with the identity chooser dialog opened. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7aff360ee229ebd83063dfbef5b9bc7fe36d345 Reviewed-on: https://chromium-review.googlesource.com/1186739 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585820}
-
Rune Lillesveen authored
Comments, processing instructions, attr, and doctype nodes should never have style, are never marked dirty, never runs through style recalc and marked clean, and should not have style dirty initially. Attr and doctype nodes will never run through AttachLayoutTree since they can not be descendants of the root element, but since PI and comments can, we need to say that it's OK that they don't need attachment for AttachLayoutTree. Also, don't mark the ancestor chain with ChildNeedsStyleRecalc when inserting such nodes into a tree. This is fixing the TODO introduced in 492730. Bug: 492730, 868810 Change-Id: I4470ce11a94e1390c2c6a9b7d1420c0e28844ade Reviewed-on: https://chromium-review.googlesource.com/1186729Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585819}
-
Eli Ribble authored
These are currently failing ~20% of the time. Needs more investigation, but disabling for now to avoid flakiness in build system. Bug: 875548 Change-Id: I17ac3ee3cb18c21177c58a1a3a66d6591c0ef1cb Reviewed-on: https://chromium-review.googlesource.com/1187836Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#585818}
-
Josh Karlin authored
The 8.0 list is comprised of the top 1000 rules used from easylist version 201808030717 when run against HttpArchive's July 15th of 2018 list of page requests. Bug: 877148 Change-Id: Ib43639379c1f8b6abeea416345dd3b9468b0354f Reviewed-on: https://chromium-review.googlesource.com/1187069 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585817}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33a17747. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23219 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I766667fae4e4e8acc67683f85a92976a3490cc0a Reviewed-on: https://chromium-review.googlesource.com/1188482 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585816}
-