GitLab

This CL implements CookieMonster::MutableParsedCookie which is derived from CookieMonster::ParsedCookie. This allows parsing a cookie and modifying it afterwards.

BUG=112155
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10697035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149622 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cduvall@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149621 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149620 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133866

Review URL: https://chromiumcodereview.appspot.com/10830121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133866
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10837069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149617 0039d316-1c4b-4281-b951-d872f2087c98

Add linux_chromeos and linux_chromeos_clang as preferred try bots whenever chromeos files are modified.

TBR=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137994


Review URL: https://chromiumcodereview.appspot.com/10827115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149615 0039d316-1c4b-4281-b951-d872f2087c98

vector of DataFetcherFactories

In the current implementation, any OS can only use at most one DataFetcher, so
there will always be 0 or 1 DataFetcherFactories in the vector. Therefore it
is simpler to use a single DataFetcherFactory instead of an array. Since DataFetcherFactory is a pointer itself, it can be NULL when there are no available DataFetchers.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10837055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149614 0039d316-1c4b-4281-b951-d872f2087c98

extensions by removing them when extensions are uninstalled. Tweak several
defensive guards against this to be CHECKs.


BUG=139869


Review URL: https://chromiumcodereview.appspot.com/10851002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149613 0039d316-1c4b-4281-b951-d872f2087c98

Also remove stale comment from speech_recognition_error.h.

BUG=116954


Review URL: https://chromiumcodereview.appspot.com/10831110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149612 0039d316-1c4b-4281-b951-d872f2087c98

All are stylistic changes reordering targets for better maintainability. 

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10832082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149611 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/10792008/ for background.

BUG=139592

Review URL: https://chromiumcodereview.appspot.com/10828067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149610 0039d316-1c4b-4281-b951-d872f2087c98

These gyp defines are set unconditionally in envsetup, which means they
are not in fact part of the "environment" but just the defaults for the
Android build. Move them into common.gypi instead to make this clear.
Several of them were already the correct setting and can simply be
removed.

The makefiles generated by gyp are identical before and after this
change.


Review URL: https://chromiumcodereview.appspot.com/10825131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131177, 132773
TEST=manual, units

Review URL: https://chromiumcodereview.appspot.com/10835041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149608 0039d316-1c4b-4281-b951-d872f2087c98

Revert 149604 - Support calling GrabWindowSnapshot when no BrowserProcess instance is avaliable (eg. tests)


BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10821104

TBR=qfel@google.com
Review URL: https://chromiumcodereview.appspot.com/10830135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149606 0039d316-1c4b-4281-b951-d872f2087c98

Originally landed in http://codereview.chromium.org/10808052/


Review URL: https://chromiumcodereview.appspot.com/10823035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10821104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149604 0039d316-1c4b-4281-b951-d872f2087c98

With some comment fixes for style nits.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149603 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=140060


Review URL: https://chromiumcodereview.appspot.com/10836070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=apavlov
Review URL: https://chromiumcodereview.appspot.com/10829140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149600 0039d316-1c4b-4281-b951-d872f2087c98

Also, slightly widen one recently added suppression
BUG=140196
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10836071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149597 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149596 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima
BUG=131354,79322
Review URL: https://chromiumcodereview.appspot.com/10837068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149594 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149593 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149592 0039d316-1c4b-4281-b951-d872f2087c98

This class is introduced to separate code related to WAPI
(codename of Documents List API) feed loading.

To minimize diffs, the the class is defined in gdata_file_system.cc
The code will be moved to a set of new files in a separate patch.

BUG=130669
TEST=out/Release/unit_tests --gtest_filter=GData* && out/Release/browser_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10828126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140041
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10828128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140163


Review URL: https://chromiumcodereview.appspot.com/10837067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149588 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149587 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10850012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149586 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r149576, which was reverted as it broke
RemoteFileSystemExtensionApiTest.RemoteMountPoint. Turned out that
ui_weak_ptr_ in GDataFileSystem shouldn't be removed.

Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.

Wez on [chromium-dev] Weak ptrs for derived types?

You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10843043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=hashimoto@chromium.org
for a simple change adding ALLOW_THIS_IN_INITIALIZER_LIST.

Review URL: https://chromiumcodereview.appspot.com/10834120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97804
TEST=existing unittests 

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149583 0039d316-1c4b-4281-b951-d872f2087c98

Broke RemoteFileSystemExtensionApiTest.RemoteMountPoint

Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.

Wez on [chromium-dev] Weak ptrs for derived types?

You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10837061

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149582 0039d316-1c4b-4281-b951-d872f2087c98

FFmpeg's vector_fmac function, without the hassle of 32-byte align
and over allocation.

VectorFMAC_SSE requires 16-byte alignment of the source and dest
vectors.  Size does not need to be a multiple of 4 though.

Performance results from AudioRendererMixerTest.VectorFMACBenchmark:

Benchmarking 200000 iterations:
VectorFMAC_C took 2030.73ms.
VectorFMAC_SSE (unaligned size) took 598.33ms; which is 3.39x faster than VectorFMAC_C.
VectorFMAC_SSE (aligned size) took 597.71ms; which is 3.40x faster than VectorFMAC_C and 1.00x faster than VectorFMAC_SSE (unaligned size).

BUG=133637
TEST=media_unittests + AudioRendererMixer/* tests.

Review URL: https://chromiumcodereview.appspot.com/10802005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149581 0039d316-1c4b-4281-b951-d872f2087c98

In IBusLookupTable::page_size actually does not affect for Chrome OS.
However, if we use chromeos-chrome on linux desktop, zero value crashes ibus's lookup table.

BUG=None
TEST=ran chromeos_unittests

Review URL: https://chromiumcodereview.appspot.com/10828114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149580 0039d316-1c4b-4281-b951-d872f2087c98

- IBusEngineFactoryService takes the ownership of engine_id - CreateEngine handler mapping.
- Make IBusEngineFactoryService::CreateEngine asynchronous, and introduce asynchronous unittest.

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10836047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120576


Review URL: https://chromiumcodereview.appspot.com/10830114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149578 0039d316-1c4b-4281-b951-d872f2087c98