GitLab

Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.chromiumos.

BUG=386891,396494,396496,396497,396499,396501,396502,396504,396505,393208,223888,396506,387045,396507,396509,396510
R=viettrungluu@chromium.org
TBR=sky, stevenjb

Review URL: https://codereview.chromium.org/407073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396645
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/413743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284935 0039d316-1c4b-4281-b951-d872f2087c98

Probably, we should also do something (assert/DCHECK) in the bindings
code too, but I'll do that separately.

R=darin@chromium.org
BUG=389666

Review URL: https://codereview.chromium.org/407643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284934 0039d316-1c4b-4281-b951-d872f2087c98

This is a cleanup, as discussed in the comments of https://codereview.chromium.org/287103004/

This turned out to require extending gfx::TruncateString with an extra BreakType parameter; it now supports breaking within words as well as at word boundaries. All call sites have been updated accordingly.

BUG=none

Review URL: https://codereview.chromium.org/381953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284933 0039d316-1c4b-4281-b951-d872f2087c98

Broke Mac ASan Builder gclient runhooks step:

Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium returned non-zero exit status 1 in /Volumes/data/b/build/slave/Mac_ASan_Builder/build
Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
gyp: Found /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/third_party/libc++/libc++.gyp:libcxx_proxy#target in dependencies! of /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/base/base.gyp:sanitizer_options#target, but not in dependencies
builder -> 'ninja'
gyp_defines -> {'asan': '1', 'gomadir': '/Volumes/data/b/build/goma', 'use_goma': '1', 'component': 'static_library', 'release_extra_cflags': '-gline-tables-only'}
IsWindows -> False
IsLinux -> False
platform -> 'mac'
Running build/landmines.py...
Hook '/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium' took 51.21 secs

> Use libc++ for all non-Windows ASan builds.
> 
> BUG=318770
> TBR=earthdok@chromium.org
> 
> Review URL: https://codereview.chromium.org/414703002

TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/410213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284932 0039d316-1c4b-4281-b951-d872f2087c98

The test creates multiple-displays, and multi-display tests do not work reliably
on Windows.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/410943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/414703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284930 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=396639
NOTRY=true

Review URL: https://codereview.chromium.org/410193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284929 0039d316-1c4b-4281-b951-d872f2087c98

Previously touch operations are handled by SwipeOverlay class. Overlay is a
common way to obtain mouse/touch events in Gallery, but it does not support
touch specific capability (e.g. multi fingers). The CL newly adds TouchHandlers
class to the SlideMode class and let it call the zoom/scroll feature of the
slide mode depending on user's touch gestures.

BUG=245926
TEST=on link

Review URL: https://codereview.chromium.org/411853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284926 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/400973002/

BUG=387614
TBR=zelidrag@chromium.org,derat@chromium.org,stevenjb@chromium.org

Review URL: https://codereview.chromium.org/398753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284925 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::targetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/409593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=202947

Review URL: https://codereview.chromium.org/391783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284921 0039d316-1c4b-4281-b951-d872f2087c98

The shared timer must be deleted on the same thread that it was executing on. When the WebThread is being destroyed, it is done from a different thread, so the shared timer must be deleted prior to that. This gives an API for the thread cleanup code to do so.

BUG=301515
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/416453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284920 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut (https://codereview.chromium.org/379773003/)

Reason for revert:
I am reverting this CL because it causes regressions like crbug.com/395985. This CL is in the right direction, but I need to make the capture code for tab dragging less crazy first. See comment #3 in crbug.com/395985 for more details

Original issue's description:
> Simplify the logic in DesktopWindowTreeHostX11 for FocusOut
> 
> We should have the same handling regardless of whether the 'mode' member is
> NotifyGrab or NotifyUngrab. According to
> http://tronche.com/gui/x/xlib/events/input-focus/grab.html, whether the mode
> field is NotifyGrab or NotifyUngrab depends on whether there is a new
> capturer for the keyboard. The X window has lost keyboard capture in both cases.
> 
> BUG=392480
> TEST=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283823

TBR=erg@chromium.org,erg@google.com,sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392480

Review URL: https://codereview.chromium.org/409223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284919 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284918 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/409363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284917 0039d316-1c4b-4281-b951-d872f2087c98

Based on experimentation, it appears that calling setNeedsDisplay or
displayIfNeeded on a CAOpenGLLayer which has the isAsynchronous
property set, will result in the animation getting screwed up. In
particular, calls to canDrawInCGLContext stop occurring.

This was working in M35 and M36 because, entirely accidentally, we
were calling setAsynchronous:NO before most instances of
setNeedsDisplay and displayIfNeeded. In r272469, these calls were
removed, and resulting in the janky animation.

Add calls to setAsynchronous:NO before all instances of calling
displayIfNeeded, and almost all instances of calling setNeedsDisplay.

BUG=395827
TEST=manual, automated tests in progress

Review URL: https://codereview.chromium.org/408153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284916 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=344769

Review URL: https://codereview.chromium.org/410083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284915 0039d316-1c4b-4281-b951-d872f2087c98

Before, wifi_config_view directly set the shill::kEapCertIdProperty and shill::kEapKeyIdProperty. Since the system token is enabled in ChromeOS, these properties have to be of the format '<slot_id>:<key_id>' and not only '<key_id>'.

This change fixes this by reusing the client_cert::SetShillProperties function, which sets the properties in the correct format.

R=pastarmovj@chromium.org
TBR=stevenjb@chromium.org
BUG=358366, 396181

Review URL: https://codereview.chromium.org/415483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284914 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where combobox dropdowns would render in the wrong
place for tabs that were created in the background. This was happening
because the native view and clipping windows weren't being added in the
right order, causing the incorrect screen space coordinates to get
passed around.

BUG=394715

Review URL: https://codereview.chromium.org/399343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284913 0039d316-1c4b-4281-b951-d872f2087c98

Since these targets are not static libraries, hard_dependency has no
effect (confirmed by Mark Mentovai and Tony Chang).

Files found with the following command line:

$ for f in $(g ls-files | grep strings.gyp ); do grep hard_dependency $f; echo $f; done
$ for f in $(g ls-files | grep resources.gyp ); do grep hard_dependency $f; echo $f; done

BUG=None
TEST=None
R=jochen@chromium.org,yoz@chromium.org

Review URL: https://codereview.chromium.org/393123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/common
R=brettw@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/411783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284911 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for copying files which are on the same provided file
system. Note, that copying between file system instances will be done using
FileStreamWriter.

TEST=unit_tests, browser_tests: *FileSystemProvider*Copy*
BUG=391362

Review URL: https://codereview.chromium.org/384303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284910 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284909 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178709:178745&mode=html
TBR=pkasting@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/411863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284908 0039d316-1c4b-4281-b951-d872f2087c98

> aura: Use PlatformWindow from WindowTreeHostWin.
> 
> With this patch, both Windows and Ozone implementations use PlatformWindow for
> interacting with the native windowing system. Eventually, the X11 implementations
> will also use this, and WindowTreeHost will have a single implementation on all
> platforms.
> 
> BUG=none
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/400413002

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/410873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284905 0039d316-1c4b-4281-b951-d872f2087c98

The instance |ChildThread::service_worker_dispatcher_| is never used. Removing.

BUG=None

Review URL: https://codereview.chromium.org/408143013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284904 0039d316-1c4b-4281-b951-d872f2087c98

This patch migrates entries to external entries, as preparation for taking an advantage of external entries.

BUG=none
TEST=video player works
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/414623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284903 0039d316-1c4b-4281-b951-d872f2087c98

Previously the video player used old way to control a cast, but it's now deprecated and we need to migrate to new way.

BUG=305511
TEST=List of casts is shown
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/410043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284902 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/411543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223352
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284899 0039d316-1c4b-4281-b951-d872f2087c98

This make VideoRenderer consistent with the rest of the media pipeline.

BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/414583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284898 0039d316-1c4b-4281-b951-d872f2087c98

In case display width is less than content width,
UpdateCachedBoundsAndOffset() does not handle center-aligned text
properly when content width is reduced (e.g. by deleting some
characters) or display width is increased.

BUG=none

Review URL: https://codereview.chromium.org/384953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284897 0039d316-1c4b-4281-b951-d872f2087c98

Disable report rate throttling on test for faster test iteration

BUG=344769
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*'

Review URL: https://codereview.chromium.org/417443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284896 0039d316-1c4b-4281-b951-d872f2087c98

Remove the suppression of this test with LEAK_SANITIZER as it does not
leak any more.

BUG=317363
TEST=browser_tests + lsan

Review URL: https://codereview.chromium.org/404693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/405993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284889 0039d316-1c4b-4281-b951-d872f2087c98

As written the argument ended up in the .ninja file as \\\$$ORIGIN/lib/
but we want \$$ORIGIN/lib/ to match gyp.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/409883009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284888 0039d316-1c4b-4281-b951-d872f2087c98

These functions are simplistic and doesn't depend on chrome's
feature, so there's no reason to be under chrome/browser.
Moving to components/ would help further componentization
task of autocomplete anad omnibox_field_trials.

BUG=371538
R=brettw@chromium.org, pkasting@chromium.org, blundell@chromium.org
TBR=tedchoc@chromium.org, jhawkins@chromium.org
TEST=build

Review URL: https://codereview.chromium.org/393173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284885 0039d316-1c4b-4281-b951-d872f2087c98

The example window currently doesn't activate itself properly because it
lacks an activation policy and a menubar.

This CL sets the activation policy, adds a menubar and defers window
creation until the applicationDidFinishLoading notification. Creating a
window before this can activate and receive key events, but the menubar
will not switch properly.

With this, views_examples_with_content_exe compiles and runs nicely on a
Mac build with `GYP_DEFINES=toolkit-views=1`. Note the `WebView` example
will crash for now because views::NativeViewHost is not yet implemented
for mac.

BUG=395507

Review URL: https://codereview.chromium.org/309483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284883 0039d316-1c4b-4281-b951-d872f2087c98

This adds logic for representing page skips as values in Telemetry, in the
spirit of how failures are to be handled with regard to the linked bug. The
goal for this CL is just to add the logic, and then once it's safely in the
codebase, we can wire it up and make sure Buildbot is happy with it.

BUG=392901

Review URL: https://codereview.chromium.org/409023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284882 0039d316-1c4b-4281-b951-d872f2087c98