- 24 Jun, 2020 40 commits
-
-
Omar Morsi authored
This CL changes NetworkHealthUnittest after CrosNetworkConfig starts to report VPN device state when CrosNetworkConfig::GetDeviceStateList function is called. Bug: 1064893, 1082327 Change-Id: I958f530676f4847b7c62dc491a86480184a9b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253765 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781795}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592967357-1044ce77a8c2825b6c9c5357d74768eafbc87565.profdata to chrome-win64-master-1592971072-917710ea24284ef9aa6ebcca30f6d2746c0234cd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I926fdf3a7d7715d992f037b424494798ca82e091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781794}
-
Anders Hartvoll Ruud authored
I'm guessing it differed from the main longhand order at some point, but currently it's identical to the shorthand that's generated. R=ericwilligers@chromium.org Change-Id: I388d3dd4d51ba18948246cb07083e1f48926f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253740Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#781793}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/839704450200..fbb9dc2cf1af 2020-06-24 johnkslang@users.noreply.github.com Merge pull request #2285 from proydakov/msvc-rtti-compilation-warning-fix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ice58ab440fa5d2537e43a0121c00a9ac147aebbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263173Reviewed-by:
-
Christoph Schwering authored
This CL cleans up the UMA metric code for the Autofill.FormDynamicity metric, which is not needed anymore. Bug: 1082744 Change-Id: I4a5efe995edae005b7a431ad2d0975b06dd05d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252181Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#781791}
-
Friedrich Horschig authored
The new metrics ReauthToUnlockAccountStore.* report whether reauth succeeded or was aborted/failed. It's split by access points: - Filling dropdown - Generation - Settings - Saving/Updating - Moving password Bug: 1063852 Change-Id: Ifd90ae032405d2677f5a5bb554275a2c14e9a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252809 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781790}
-
Kushagra Sinha authored
Change-Id: Ia9a8794d62e11ca294583c524a9f6256ee7b048a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256218 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781789}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I505c982ee92bf7ef4c58f419989ee64e3a50415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260601Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#781788}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I1fb8dc3865279f34be2fbb7bc7012dfb0e12d456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262953 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
We have Net.KeepaliveRequest.BlockStatus but that doesn't count requests cancelled by the onBeforeRequest WebRequest API. Bug: 1098251 Change-Id: Iadc526a6acc7eb9b6142d643bbe0df07a56086c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260474 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781786}
-
Denis Kuznetsov authored
Fixed: 1097739 Change-Id: Ic10887517d34390de9a05e00073d537d9f25bdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260653 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
-
Morten Stenshorne authored
And even (unintentionally) fix a bug in nested multicol! Avoid duplicated work and duplicated code. We used to have separate code paths for setting the block-size, depending on whether we were in a block fragmentation context or not. In the case of the block layout algorithm, we even calculated the block-size twice when we were block-fragmented: First at the common place (in FinishLayout()), then we'd just discard that, and calculate it over again, but this time correctly for block fragmentation (FinalizeForFragmentation()). Let's just do it correctly the first time instead. Cleaning up the code allows us to call FinishFragmentation() even when the fragmentation block-size is unknown (initial column balancing pass). This actually fixed a bug, which I discovered because a unit test started to fail, but that was just because of the fact that the test assumed that there was no column balancing, even though column-fill was 'balance' (initial value). Set it to 'auto' instead to get expected behavior. Also added a web test that demonstrates what got fixed. Introduce two setters and getters for block-size in NGBoxFragmentBuilder. Regular layout will set the CSS box size (as if all fragments were stitched together into one tall fragment), then pass it on to the block fragmentation machinery, which will set the actual fragment size. I also realized that intrinsic block-size makes no sense when a node fragments (nobody uses it in such cases), so we'll now DCHECK that there's only one fragment. Bug: 829028 Change-Id: I820e1b281ba19bd8e39b1b55f52288000d8b802c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255365Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#781784}
-
Oleh Lamzin authored
Introduce probe service converters. It's a good practice to use mojo::StructTraits or it's preferred to use mojo:TypeConverter even when it's deprecated, but in our case we may need to change converter in the runtime. For example, depending on some policy value we may/may not provide some fields: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/security/mojo.md#use-structtraits Bug: b:158658869 Change-Id: Ibfe1ef41d71e4dcb90581354135b1a9d44d28a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252038 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#781783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/42297a7669fc..1c99a943d920 2020-06-24 wolfi@chromium.org Revert "Logic to log event for panel closed." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad8769158b5f8ead3327eeccdf74f2198258123c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262797Reviewed-by:
-
Koji Ishii authored
The DCHECK was added to ensure |AddLine| is executed after |SetCurrentLine|, which is not true for this unit test. Bug: 982194 Change-Id: Idfdb0f5bd61f973937ffbc19c0da2e7d8d268047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262028 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781781}
-
sandromaggi authored
This re-adds the hiding of keyboard if it shows up in an unexpected state. Bug: b/159113241 Bug: b/153625351 Change-Id: Iea7cdc1ffa97a4edf3fe8c4a602b7960dad19bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253978 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#781780}
-
Fergal Daly authored
These tests are exercise the feature a lot and have seen some failures and will likely see more for RD on main frames. This will also ensure that fixes don't regress. This is a bit messy since SitePerProcessBrowserTest has many subclasses that are already parameterized. Since I care more about running the main bulk of tests parameterized against RB level, I'm not going to double-parameterizer them unless someone thinks some of them are important to get. - Create SitePerProcessBrowserTestBase and move already-parameterized tests to inherit from that. - Parameterize SitePerProcessBrowserTest and instantiate all subclasses. - Rename SitePerProcesProgrammaticScrollTest, it's missing an "s" - disable the subframe version of SitePerProcessBrowserTest.NavigateCrashedSubframeToSameSite pending the fix in https://crrev.com/c/2246087 Bug: 1064944 Change-Id: I881567e6e673a6ee29251123c5cbcace61c6d748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250142 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781779}
-
Asami Doi authored
This CL updates browser tests in InstallableManager to support offline environment by default. By this changes, all existing tests in InstallableManager should work correctly both when the CheckOfflineCapability flag is enabled and disabled. In the following CL, I'll update fieldtrial_testing_config.json to enable the CheckOfflineCapability flag for dry run: https://chromium-review.googlesource.com/c/chromium/src/+/2235580 Bug: 965802 Change-Id: I0581172fab336539985bc88da83d0faaf90f0034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246042 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781778}
-
Sigurd Schneider authored
The file ads_page_load_metrics_observer.cc included a mojo definition file from blink, instead of the shared version. This resulted in flaky build failures, as the blink version of the mojo is not a GN dependency, and was sometimes not yet generated. TBR=jkarlin@chromium.org Bug: chromium:1095617 Change-Id: Id6930a4f7af08c6ff0344f853dea7b79ce2d3748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262613Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#781777}
-
Alex Chau authored
- It'll be replaced by chrome/services/sharing/nearby/platform_v2 introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2228543 Bug: 1091190, 1092595 Change-Id: I3e16a8831e8c5e04326485f497e1bb00354ce354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247726Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#781776}
-
Zain Afzal authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JFXGDZ4SXUx3Hmzx9tzDH7x90Qb-Oa2Z_BqPo4BfioIC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006230800_RC00.html Bug: b/159408606, b/159186081, b/159305536, b/133374709, b/159407608, b/159409929 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ief3e29faa262ee79ccf823dfd142272887ad32cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262378Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#781775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I927f065cd5bcb7ccff8c77fc95b5ec3cfad41624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262796Reviewed-by:
-
Joel Hockey authored
This is a refactor to move code out of file_manager.js and into crostini_controller.js in preparation to add more features for showing messages. Updated UI tests to use FILES_NG_ENABLED and work with all files that import from chrome://resources such as files_message.html. Bug: 1095889 Change-Id: I9c9f34304e26dca8df4c0aa64a51c124650385b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259873Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781773}
-
Mugdha Lakhani authored
Explicitly disable more features with failing WPT tests. Spreadsheet with details (Google internal only): https://docs.google.com/spreadsheets/d/1mBU2pCrRPkw67-9hlcD-xN5bE6F5LM34kccd-Ptf3wc/edit?usp=sharing Bug: 1087494 Change-Id: Iec331d5cd706b0e6e41ea7c2c8dbed9ec36c7453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254600 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#781772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib7eceadd228ba6948b2fd3d6e66fc3505c990b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262123Reviewed-by:
-
Hajime Hoshi authored
Before this CL, the detection whether the page was in background between when the page was restored the first-paint happened was not accurate. The checking function checked only the last timings were checked and did not consider multiple restorings. This CL fixes this issue by recording all the backgrounding states related to restoring, and check an appropriate state by specifying an index. This CL also added an item to histograms.xml Change-Id: I9ae6b0bb8ee192f21ae42c518166372106bfb878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251526 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781770}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/57186883cdf3..dc3f366469ed 2020-06-24 abennetts@google.com Workaround spurious pylint invalid-name warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1090608 Tbr: oysteine@google.com Change-Id: I8ba82ae3da9a7a8fc80475e8a9ca3b961937859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262794Reviewed-by:
-
Simon Zünd authored
SameSite cookie issues are currently sent to the renderer process to be stored there. This CL switches SameSite cookie issues over to use the new browser-based issue storage. R=sigurds@chromium.org Bug: chromium:1063007, chromium:1080595 Change-Id: Icd48cbc7b370f7bdfb2f6e2302c009eaecf9428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252161 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592960277-bc23f7c6050a632e956b7539dc4edff3e9938101.profdata to chrome-win64-master-1592967357-1044ce77a8c2825b6c9c5357d74768eafbc87565.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I60a9dc674f4f6e032acd29b83681d82fde4e62e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262649Reviewed-by:
-
Maksim Sisov authored
This patch adds for usage of ozone platform in //components. And changes the following patterns: #ifdef(USE_X11) DoXxx(); #endif to #ifdef(USE_X11) if (!IsUsingOzonePlatform()) DoXxx(); #endif and #ifdef(USE_OZONE) DoXxx(); #endif to #ifdef(USE_OZONE) if (IsUsingOzonePlatform()) DoXxx(); #endif ----- Please note that this ugliness is added temporarily and will be removed as soon as use_x11 is removed (hopefully by Q1 2021 depending on how the finch trial goes). Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Icce90019c12db275a796dcab993abffa158023af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250006 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#781766}
-
Jiewei Qian authored
This CL adds a metric to record whether WebAppUrlLoader::PrepareForLoad succeeds. Given we have observed WebAppUrlLoader fails to load WebUI URLs, we are uncertain whether loading about:blank in WebAppUrlLoader is always successful. Thus we added a metric to collect the result of this action, so we can make better decisions. Bug: 1098139 Change-Id: I758ef5c7b3b0d2e1b0daa1053e3d364ac709b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259699 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
On Windows, the existing warning halo might not be enough (on some fonts at least) to contain the entire warning triangle. To mitigate that, make the halo a bit bigger and the triangle a tiny bit smaller so that the rounding errors that cause the misalignment aren't visible anymore. Additionally, the dark mode still used pixel measurements which did not scale with the text size. It's using the same height units now. (Tested on Windows and on Linux; Screenshot in linked bug) Bug: 1098238 Change-Id: I037a82403eb1acfbe9173500d9fb85cfd34a4e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260639Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781764}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I36148ac23ad52bc3b974933c5a47c660216a5c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262418Reviewed-by:
-
Yoichi Osato authored
This CL enables origin trial flag FetchUploadStreaming. You can try the feature with "Chrome --enable-features=FetchUploadStreaming" or an OT token. Given https://github.com/whatwg/fetch/issues/966#issuecomment-608128154, this CL also introduces the temporal AllowHTTP1ForStreamingUpload property to measure upload streaming capability over each protocol. API explaner: https://bit.ly/2SVvKbR Bug: 688906 Change-Id: I46ccf37b2268371bb98af50c16b032f2d5fd470a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174099 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#781762}
-
Yoshifumi Inoue authored
This patch changes "caret-ltr.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I7824072725bd418bed800b0a114bcd1b74fafa62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262399 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Lei Zhang authored
<string>, not "string". Change-Id: I16343119e3432d1fa307462e208b8c887c425650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261794Reviewed-by:
-
Noel Gordon authored
When a drag drop operation is active over FilesApp, add a global class .drag-drop-active to the root element. Bug: 1062902, 1002394 Change-Id: If9f27e047f23cb38ae214875eee91ea1c4ef3243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262772 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781759}
-
Maksim Sisov authored
This patch adds for usage of ozone platform in //content. It's not possible to use the linux wrapper [1] for everything as it may introduce circular deps and other problems. Plus, there are many places that are guarded either by single a single USE_X11 or USE_OZONE. Thus, use the IsUsingOzonePlatform feature flag to choose the correct path. [1] https://crrev.com/c/2250106 ----- Please note that this ugliness is added temporarily and will be removed as soon as use_x11 is removed (hopefully by Q1 2021 depending on how the finch trial goes). Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I51054a82bcad34f3f887379003cf24a66a1e9928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250110Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#781758}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592956785-31e85dda22463f39949762c5e4ca2295e5fc2ed3.profdata to chrome-mac-master-1592977371-60cb1203aa6c110107f3f77527ea01cdc8177bb5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3eafbfa57e787cca5047c2a2b3c19caeb13de758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262648Reviewed-by:
-
Friedrich Horschig authored
Whenever a user submits a password that they can move to their account, they will face the move dialog. If they haven't opted-in, they need to confirm that they want to opt in by reauthenticating. Before this CL, this reauthentication was missing and the move would fail silently. Bug: 1097699 Change-Id: I9ea54f2bdb21af027d602735a8a81a99d0f9f47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257231Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781756}
-
