GitLab

Before this patch, Chrome always set Sec-Fetch-Site header to
"cross-origin" when downloading manifests to verify Android payment
apps.

This patch sets the initiator origin for downloading payment method
manifest files and sets that file's origin as the initiator of web app
manifest file download when verifying Android payment apps. These
origins enable setting the correct Sec-Fetch-Site headers in network
request, for example.

In addition, this patch uses org.chromium.url.URI objects in the JNI
interface of PaymentManifestDownloader.java instead of converting to and
from a string.

After this patch, Chrome correctly sets Sec-Fetch-Site header to either
"cross-origin", "same-site", or "same-origin" when downloading manifests
to verify Android payment app.

Bug: 1048201
Change-Id: If256926daa4a9e43733d79c8fd3049cfbd65a5c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044710
Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740352}

The mouse-related events in autotestPrivateAPI is using
ui::SystemInputInjector, but it actually assumes the location
is in the coordinate of the physical bounds of the DrmWindow.

Most of the tests do not meet any problems, but it turns out that
fake display bounds has some offset, which confuses the mouse
location and leads failing further events.

Bug: 1050810
Test: tast.ui.LauncherSearchNativeApps on guado without displays
Change-Id: Ie7cab3dd9301aebefec8e2f99f55aabae2219bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049204Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740351}

This reverts commit d5544fc0.

Reason for revert: Suspect for continuously failing CrSettingsAnimatedPagesV3Test.All and CrSettings* related tests
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16982

Original change's description:
> Settings: Port settings_menu/ to Polymer 3.
> 
> Bug: 1026426
> Change-Id: Id6b62c39b9184532a8e3e3c34c2bdee98a37240e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045171
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740247}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: I029222c3bee9a354964d4d5fa8d02f724c7c4039
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050868Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740350}

This test verifies a behavior when javascript is allowed to run on a
page that is being prerendered. We don't use that mode anymore, so this
test can simply be deleted.

Bug: 1050143, 1038053
Change-Id: Icbef41a1b604d80725cf6ea9ee736546636dfea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047516Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740349}

See discussion thread at
https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/m/O8Blk8SoEQAJ

The recommendation style is as follows:

class Foo : public IComIsFun {
  IFACEMETHODIMP IsFun(BOOL* fun) override;
};

HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; }

Change-Id: I912443b78734ec95a8b79a2210153e1bc1bb970f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048413Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740348}

BUG=947004

Change-Id: I84356c8ebd4a8563a641cf9de84b2326e394ab08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041752
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740347}

These tests seems to have accumulated multiple bugs through sherrifing.
Dupe the bugs with little or no activity into crbug.com/658305, which is
the bug with the most action (although perhaps not the most actionable).

Bug: 658305, 758133, 862716, 869364, 873454
Change-Id: Ia16b9eb34d26690e051d49b8703bc315c9c0593d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050691
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740346}

WKWebView was quite a lot crashy on iOS 13.1. It is possible that this
instability was making this test flaky.
As the bots were updated to iOS 13.3, it should be possible to
re-enable this test.

Fixed: 1046576
Change-Id: I694daecb4c320bcd13dad12d27a1fa64bc0207e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047065
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740345}

This test had been suppressed in order to land:
https://skia-review.googlesource.com/c/skia/+/268686
but I believe this bug fix follow up
https://skia-review.googlesource.com/c/skia/+/269758 actually made it so
that the original baseline image is still valid. So all this does is
remove the suppression, no new images needed.

Bug: 1050086
Change-Id: I60677a16a53cd314d8a080957b1051c3efe0720b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050663
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740344}

Fix the mock object, TabModelFilter, in TabSuggestionsOrchestratorTest
to follow the TabModelFilter's contract.

Change-Id: I0c56d55c3cdc7e4b04bd1519b3a37b63d076378c
Bug: 1049917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043100
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Maunder <davidjm@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740343}

Bug: 789216
Change-Id: Ifc42cb21b72668dce0df44b4d627deeae1f0d1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035410
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740342}

When running xvfb, the R,G,B color masks will all be 0. To prevent
breaking this configuration, remove the strict check from
ColorTypeForVisual() and silently continue without graphics.

R=msisov

Change-Id: Iab55663c0f9541060ca231c679ab75f2c85eba30
Bug: 1025266, 1049066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047767Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740341}

The filter that should be applied is referenced via the stylesheet, and
is loaded as a separate file. Since this resource is not considered to
be "critical" it may not have competed loaded when the document 'load'
event fires (and the screenshot is taken).
Add a 'load' handler on the <link> element that forces a style-recalc,
so that the style will be applied and the load started for the filter
resource - thus having it block the document 'load' event.

Bug: 658305
Change-Id: I424c82c1006f3db586cce056c07b94824d169925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050495
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740340}

A device policy which controls the chrome variations on the login screen.
The policy can be applied as a mandatory policy only.

Bug: TBD
Change-Id: I025e8722edc7f55ea42dfd0c3e3bbf3daa88bcd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050683Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#740339}

is flaky on win-asan.

https://ci.chromium.org/p/chromium/builders/ci/win-asan
for example: https://ci.chromium.org/p/chromium/builders/ci/win-asan/10248

TBR=finnur@chromium.org,rdevlin.cronin@chromium.org
Bug: 1051051

Change-Id: I718511d0652aae39c712e9e2d41d296742298773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050372Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740338}

This can be helpful for other tests that require a mock as well

Change-Id: Ic68a3693c0eb92aa6717b9527ef51fe29be6ddbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040442Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740337}

Currently the timeout is enforced only on the lifetime of the thread making the request and the request itself is using default values. If a timeout is set that is greater than the system default then the timeout won't be as expected.

Bug: 1049803
Change-Id: I3146a5a99714d756c2e214b0db59fbd388a17e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042260Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Robin Lewis <wrlewis@google.com>
Cr-Commit-Position: refs/heads/master@{#740336}

On a previous CL
(https://chromium-review.googlesource.com/c/chromium/src/+/2050484), we
disabled console-stack-overflow-source-url.html. However, the top file
for this test is the .js one, and this .js is the one that we want to
disable.

Bug: v8:10149
Change-Id: If7247b0beaedef38c0bcd694924737a1fb0395e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050687
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740335}

This CL makes sure that the user agent used at the creation of the
WebView is the correct one when the default user agent is automatic.

Bug: 1025225
Change-Id: I9e4408b0ff0fb36a2904f9f9304480656b60ab7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047189
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740334}

This CL renames the classes that are only used when the BVC is being
presented by the TabGrid to Legacy to prepare for the BVC to be
contained.

Bug: 1038034
Change-Id: Ib0ead44eea36646840057709b237381fa70ca561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050371
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740333}

Using wpt-import in Chromium 00758091.
With Chromium commits locally applied on WPT:
5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT"
822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ia65e9b1bd433b130ea6e048d892d2503f7066fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050134Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740332}

on win-asan

The test is flaky https://ci.chromium.org/p/chromium/builders/ci/win-asan?limit=200

TBR=hbos@chromium.org,phoglund@chromium.org

Change-Id: I310634b36e0fe641b25d86c8b5e76cd93c452750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050494Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740331}

This change removes the header handling (incl. parsing) code from
//components/domain_reliability. This removes the ability for
whitelisted domains to dynamically update their DR configurations.

This feature was not being used, and was nonfunctional for several years
anyway, as the parsing code was not updated when the header format
changed.

Bug: 1048340
Change-Id: I41fbc8c483a1d3f9d66807bd2e09af4544de80a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048944Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740330}

Subframe history navigations that redirect are now handled properly.

Bug: 628782
Change-Id: Ice1bed0e70a536678c876ca5fa0220b7eb71726c
Fixed: 628782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047993Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740329}

Since crrev.com/738675, TraceAnalyzer understands the dict we receive
from TracingController ({"traceEvents": ...}).

Bug: 1045064
Change-Id: Ie62613453193856ce796d9f72b5259e1d963b286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044920Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740328}

This CL updates the names of the object providing animations
information from GridTransitionStateProviding to
GridTransitionAnimationLayoutProviding and its methods.
Hopefully, it should increase the readability of the responsibilities
of the object.

It also removes the context parameter as it wasn't used and I plan to
use this class without a context in a future CL.

Bug: 1038034
Change-Id: I9b125cdd6603c7441dfd0cb9f1c256b3d60e37b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050317Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740327}

None is comparable in Python 2, but not in Python 3.
None compares less than anything else, including empty strings, on Python 2.

Emulate this behaviour for compatibility with Python 3 by returning an empty string if the ordinal is None.
The code fortunately doesn't seem to rely on the very special None sorting.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 199, in _GenerateModule
    imports[parsed_imp.import_filename] = self._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 199, in _GenerateModule
    imports[parsed_imp.import_filename] = self._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 474, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleHeader(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 38, in GeneratorInternal
    return ApplyTemplate(args[0], path_to_template, parameters, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 31, in ApplyTemplate
    return template.render(params)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_4b4c750a11f14c4ee990ca69a07408825b11d62d.py", line 179, in <module>
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_3cfd1c143e820f5d5f5c850420142fd64dfa3890.py", line 39, in <module>
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 878, in _GetStructConstructors
    ordinal_fields = sorted(struct.fields, key=lambda field: field.ordinal)
TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'

Bug: 941669
Change-Id: Id659a362fb5f3c56163b8164766d3f6963960c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044080
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#740326}

This CL makes sure that, when the desktop version is requested by
default, when the flag to force the mobile version of the SRP is
enabled, the mobile version is actually requested.

Fixed: 1043637
Change-Id: Ie2f267583c88bbfc63d14383f3d87da00da73c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050264Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740325}

Fuchsia's SDK will soon provide GN rules include one for declaring
fuchsia package targets. Since the SDK-provided rule works differently
from the Chromium one but is called fuchsia_package(), we need to rename
the Chromium rule to avoid them clashing.

Bug: 1050703
Change-Id: I08c14069d98df07f78e9ef25bc2c234a825d5ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047033
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740324}

Partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/2026147

The problem with the above CL was that the default fill color was set
for all SVGs. This is not according to the spec.

The real problem was that we were reverting fill and stroke colors
for non-SVG elements in forced colors mode. These elements are not
handled in the UA styleshet, and thus will have their fill and stroke
colors set to the default black.

If an SVG element inherits the fill or stroke colors from a non-SVG
parent, it will similarly get set to the default black color.
To fix this, this change avoids reverting fill and stroke for non-
SVG elements to allow for proper inheritance in this case.

(This change also replaces instances of the deprecated Window/
WindowText with Canvas/CanvasText.)

Bug: 970285
Change-Id: Ib37cffc5015d01996836d5a22d24fafc9a247522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032181Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#740323}

Tests cover specific errors API exposes to the extension.

Bug: 996785
Change-Id: I732d91f5b4b4e6543b2657edaa7175d1c1abfd4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012029
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740322}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eecaa7adff55..b5bbcc0078b0

git log eecaa7adff55..b5bbcc0078b0 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 jacktfranklin@chromium.org Add sinonjs@8.1.1 dependency
2020-02-11 jacktfranklin@chromium.org Remove defunct code in `CookieModel`
2020-02-11 janscheffler@chromium.org Fix escaping for Copy as cURL

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@b5bbcc0078b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4f5c747702a8dbe47836313df0ac68785b4616a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740321}

UMA histograms are recording whether the accessibility shortcut was
enabled or not, when its being toggled.

Bug: 552439
Change-Id: I18b56f02860a3417b6719c7950c185e4a2146653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000717
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740320}

Bug: 1048196
Change-Id: I3ca37b0c1c973bd98ba971396fc5d4712fd14cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032080
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740319}

The plan is to submit this change and merge it to M81 to address
multi-mon issues in that release.  Once Jamie is back, he will revert
this change and finish the VideoCapturer impl for M82.

Change-Id: I33f1261061c43afeffbfc76df138440daa56f80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048306
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740318}

This CL moves the Kaleidoscope URL constants into the public repo.

Bug: 1044741
Change-Id: I9fcc63929439f72acf2b8026710cddf35a34d53c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048403Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740317}

This change improves the documentation for CheckedContiguousRange and
makes its default constructor well-behaved. Prior to this change
CheckedContiguousRange was default-constructible, but every operation on
it would have resulted in a nullptr dereference.

After this change a caller can query a default constructed range for its
data() and size() and obtain iterators without causing a crash.

Bug: 990059
Change-Id: I14e1a42c86591c4b362dd1e05ea21ed35c7610a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049963Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740316}

Previously the color values were only dumped as decimal integers which
were neither human-readable nor able to be used by web ui programs
directly. Now use rgba format.

Change-Id: I352b1ee890c7bc72e1446c0af54c9938656809de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044750Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740315}

Calling net::URLRequestJob::NotifyStartError synchronously from  Start
is not supported, so issue a PostTask to respond asynchronously instead.

Also, update header comment with this restriction.

Fixed: 942488
Change-Id: I1f39d2b4c0c60f6a156bb9462f21aaffbf409498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049208Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740314}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d31fdd914bc4..7a341dac0524


Created with:
  gclient setdep -r src-internal@7a341dac0524

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I09abb1bae6c3c60a907841d678bc8868adc54022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050555Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740313}