GitLab

This CL eliminates the appending of the Google locale to all "learnMore" and
"help" URLs.

BUG=164939
TBR=sky

Review URL: https://codereview.chromium.org/325963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276616 0039d316-1c4b-4281-b951-d872f2087c98

The componentization is straightforward.

BUG=382568

Review URL: https://codereview.chromium.org/310393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276615 0039d316-1c4b-4281-b951-d872f2087c98

IDMap<T, OS> owns its values only if OS == IDMapOwnPtr.

BUG=NONE
R=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/323083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276614 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/324883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276613 0039d316-1c4b-4281-b951-d872f2087c98

The CopyOutputRequest's area is now in layer's scale factor, not
in pixel.

R=danakj@chromium.org, piman@chromium.org
BUG=381578
TEST=manually, snapshot_unittests succeeds

Review URL: https://codereview.chromium.org/321323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276612 0039d316-1c4b-4281-b951-d872f2087c98

This tries to update the bandwidth used to what is available.
The algorithm is essentially that we estimate how much bandwidth we've been sending recently.
Then we check how full our buffers are. We set a target for having our buffers be 90% empty.
If the buffer is more than 90% empty, we use more bandwidth than the resently sent, if
the buffer is less than 90% empty, we use less.

This change should be relatively safe since we normally set our min and max bandwidth to a
very limited range, and this change respects those limits.

Review URL: https://codereview.chromium.org/326783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276611 0039d316-1c4b-4281-b951-d872f2087c98

Shrink value passed over IPC only in if defined (OS_WIN && !WIN_PDF_METAFILE_FOR_PRINTING)
This build config should be gone in near future.

PrintedPage::shrink_factor_ is used only for OS_WIN.

BUG=379961
NOTRY=true

Review URL: https://codereview.chromium.org/335473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379331

Review URL: https://codereview.chromium.org/308713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276609 0039d316-1c4b-4281-b951-d872f2087c98

This is experimental and behind a flag. It does not currently do
anything except allow us to explore what kind of UI we want.

BUG=378171

Review URL: https://codereview.chromium.org/324043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/323143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276607 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380030
TEST=n/a

Review URL: https://codereview.chromium.org/322003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276605 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, toolbox WebContents may be referenced by browser
window on Mac while undocked DevToolsWindow is being destroyed.

Destroying toolbox WebContents after browser window update fixes this.

BUG=382502

Review URL: https://codereview.chromium.org/329193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276604 0039d316-1c4b-4281-b951-d872f2087c98

This benchmark tests how much latency, packet loss and bandwidth loss we can tolerate.
It runs hundreds of times faster than real-time and results are independent of CPU speed.
So far, it does a series of binary searches to find a spanning tree of the space in which
our algorithms can operate comfortably.

This is a re-upload of cl 293173002, which was reverted because it broke some windows build.

Review URL: https://codereview.chromium.org/308713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380356

Review URL: https://codereview.chromium.org/318973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276602 0039d316-1c4b-4281-b951-d872f2087c98

This is needed with some recent refactoring to separate media stream from peerconnection. And it will crash if the peerconnection goes away before media stream is stopped.

NOTRY=true
BUG=379856
TEST=cluster-fuzz bot, and local build with ASAN.

Review URL: https://codereview.chromium.org/310013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276600 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds UMA histograms that tracks age (time since creation) of
cache entries for web fonts. Histograms are suffixed with font names:
"roboto", "opensans", or "others".

Also, fixes a bug that DiskCache.ReuseCount.Evict was recording
evictions of non-webfont entries.

BUG=379670

Review URL: https://codereview.chromium.org/323013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276599 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the namespace was omitted for interface and interface
request arguments imported from another module.

Review URL: https://codereview.chromium.org/332653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276598 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes the sampling rate of `powermetrics` from 20hz to the default - 5s.  We don't need the extra resolution for our measurements and it seems that increasing the sampling rate draws power in and of itself which affects what's being measured.

BUG=None

Review URL: https://codereview.chromium.org/322423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245436

Review URL: https://codereview.chromium.org/324953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276596 0039d316-1c4b-4281-b951-d872f2087c98

To use, make a BPF program return ErrorCode(ERR_TRACE + ret_data), where
ret_data is a 16 bit value that will be available to the tracing process
via PTRACE_GETEVENTMSG.

BUG=231000

Review URL: https://codereview.chromium.org/278583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276595 0039d316-1c4b-4281-b951-d872f2087c98

Knowing which window managers Chrome is most often used on will help in testing in new feature development.

BUG=372580
TEST=None

Review URL: https://codereview.chromium.org/330493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276593 0039d316-1c4b-4281-b951-d872f2087c98

Finding whether you are running 64-bit or 32-bit is proving tricky for users
since the chrome://version page is not linked anywhere.

This adds "64-bit" string to the chrome://chrome page for 64-bit builds.

BUG=381246

Review URL: https://codereview.chromium.org/326773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276592 0039d316-1c4b-4281-b951-d872f2087c98

- Make observers to external services sticky over re-initialization.
- Leave SyncWorker NULL when non sign-in state.
- Observe sign-in event and trigger initialization on it.

BUG=374101,380615

Review URL: https://codereview.chromium.org/324343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276591 0039d316-1c4b-4281-b951-d872f2087c98

VideoCaptureDevice Win: Enumerate devices' supported formats when they don't have a DevicePath property.

BUG=380939

Review URL: https://codereview.chromium.org/328463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276590 0039d316-1c4b-4281-b951-d872f2087c98

Add a global device color profile cache and use it to extract the
color profile associated with screen display devices.

TEST=ui_unittests.exe --gtest_filter="ColorProfileTest*"
BUG=368694

Review URL: https://codereview.chromium.org/312723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276589 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/326303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276588 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step in refactoring the (overly-gigantic)
extension_service_unittest.cc

BUG=381251

TBR=atwilson@chromium.org (c/b/background/)
TBR=bauerb@chromium.org (c/b/managed_mode/)
TBR=battre@chromium.org (c/b/profile_resetter/)
TBR=pkotwicz@chromium.org (c/b/themes)
TBR=koz@chromium.org (c/b/ui/app_list)
All TBRs are for simple mechanical changes (primarily namespace move).

Review URL: https://codereview.chromium.org/318863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276587 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds GinJavaMethodInvocationHelper class which serves
for coercion of arguments and return values of Java methods to / from
base::Value and GinJavaBridgeValue.

The coercion code is taken from the existing implementation
(JavaBoundObject) with required conversions to use base::Value and
GinJavaBridgeValue instead of NPVARIANT and friends.

There are extensive Java tests for coercion, so here we only add some
unit tests for edge cases.

This patch also adds a trivial EventLog class for writing into Android
Event Log from C++ code.

BUG=355644
R=bulach@chromium.org, torne@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/302173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276586 0039d316-1c4b-4281-b951-d872f2087c98

This is to fix permission breakage on extension background pages after
blink patch r173044. Before this patch, permission settings were loaded
on V8 context initialize. However, the blink patch deferred the V8
context initialize until its first use.

This patch adds a call to |Dispatcher::InitOriginPermissions| on
|Dispatcher::OnActivateExtension| which is called when render process
for the extension is created.

TEST=Manually confirmed that Files.app image viewer can load images
on its first load.
BUG=380346, 380502

Review URL: https://codereview.chromium.org/315143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276585 0039d316-1c4b-4281-b951-d872f2087c98

Two remaining issues:
1. It seems that WebviewGuest doesn't support SharedWorker yet, so this CL
   doesn't include the changes for SharedWorker.
2. To request file system access for operations like getFile(), removeFile() etc., I have to set "unlimitedstorage"
   permission in manifest.json, otherwise will get QuotaExceededError (request persistent storage without "unlimitedstorage" permission). Any idea?  


BUG=343382

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276251

Review URL: https://codereview.chromium.org/306473012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383430

Review URL: https://codereview.chromium.org/333443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276583 0039d316-1c4b-4281-b951-d872f2087c98

 Used to maximize menu as well.

Toggle home card when ctrl-l is pressed.

BUG=380438
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/332463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276582 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276581 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175950:175978&mode=html
TBR=yhirano@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276580 0039d316-1c4b-4281-b951-d872f2087c98

r249463 was intended for this, but it turned out --prerender=enabled is
specified by default for Android and prerender is enabled for 100%
users.

BUG=341056

Review URL: https://codereview.chromium.org/321943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276579 0039d316-1c4b-4281-b951-d872f2087c98

* add vendor id and custom display name to media selection
* propagate selected media size in PrintSettings Related 
Сhanges in JS:
* Use media custom diaply name received from the native layer 
* Make sure media size selection is propagated to the native layer

BUG=239879
NOTRY=true

Review URL: https://codereview.chromium.org/325313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379961
NOTRY=true

Review URL: https://codereview.chromium.org/329033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276577 0039d316-1c4b-4281-b951-d872f2087c98

While trying to figure out why Firefox does not work with the peerconnection.html page I discovered we never caught the actual error message for RTCPeerConnection and createAnswer/Offer in the error callbacks.


TEST=P2P calls between tabs using Firefox and Chrome.
BUG=378199

Review URL: https://codereview.chromium.org/306033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276576 0039d316-1c4b-4281-b951-d872f2087c98

(This CL merges changes until last Friday).

Change the QUIC TLP to send new data instead of retransmitting old data
when new data is available.

Also tighten up the QuicSentPacketManagerTest for TLP per avd's request.

Merge internal change: 68731782
https://codereview.chromium.org/327383002/


Use override consistently instead of virtual.

Merge internal change: 68717267
https://codereview.chromium.org/325373002/


QUIC - added code to read kUAID in the server code from the CHLO
message.

The following is the list of kUAID strings for chrome built by google.

The following is true for all platforms for clients built by
google (android, posix, windows and chromeos).

UAID: "unknown Chrome/37.0.2029.0" chrome developer's builds.
UAID: " Chrome/37.0.2029.0"        Stable
UAID: "canary Chrome/37.0.2029.0"  Canary
UAID: "dev Chrome/37.0.2029.0"     Dev
UAID: "beta Chrome/37.0.2029.0"    Beta

Merge internal change: 68715745
https://codereview.chromium.org/333523002/


Minor change to keep the code similar between chromium and internal
source tree.

+ use SupportedVersions.
+ One line per argument.
+ Minor fixes to comments.

Merge internal change: 68659711
https://codereview.chromium.org/335433002/


Changed  SetIpInfoInCmsg to return the length of the packet info
structure used.

Merge internal change: 68639530
https://codereview.chromium.org/329223003/


(minor) rename frames_ to buffered_frames_ in QuicStreamSequencer

Merge internal change: 68571729
https://codereview.chromium.org/329403003/


Enables PacketGenerator's use of PacketCreator's FEC primitives.

Adds methods in PacketGenerator that enable use of the PacketCreator's
FEC primitives, and adds tests for these methods.

Merge internal change: 68558082
https://codereview.chromium.org/326403006/


Connection level flow control (CLFC) accounting on receipt of FIN/RST
for already closed streams.

This implements the following behavior discussed internally.

  Proposal: implement rch/jar's solution from earlier in the thread, in
  which "bytes sent" is added to the RST frame, and each endpoint must
  send a FIN or RST containing "bytes sent" on stream termination.

  This gets the job done pretty simply, and will make our flow control
  very similar to SPDY. We can investigate more exotic dynamic stream
  window scaling (as per avd's suggestion earlier in the thread) in
  future if SPDY-style flow control is shown to be a problem.

A stream *must* send either a FIN or a RST on termination, either of
which contain enough data that the peer can definitively determine how
many bytes were sent on that stream (this is already implemented). This
CL implements the correct CLFC accounting of these frames when received
after the stream has been closed locally.

Motivating example: Client sends GET+FIN, Server sends response. Before
response arrives, client RSTs the stream (user closed tab?), tearing
down local state. Before this CL, when the server response arrives it
just gets dropped - but the server has counted the bytes sent against
its CLFC _send_ window. The client will not count these bytes against
it's CLFC _receive_ window, and so the endpoint states are now out of
sync.

To fix this, when a stream is closed we store the current "last bytes
received offset" in a map in the session, and handle a FIN/RST for a
closed stream by removing the difference between the final byte offset
from FIN/RST and the stored value from the map to the CLFC receive
window.

QUIC: Connection level flow control accounting on receipt of FIN/RST for
already closed streams. Protected behind existing flag:
FLAGS_enable_quic_connection_flow_control

Merge internal change: 68555475
https://codereview.chromium.org/320263003/


Add QuicStreamSequencerPeer to quic/test_tools, to make stream sequencer
tests more consistent with other tests.

Merge internal change: 68553409
https://codereview.chromium.org/318333002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/327393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276575 0039d316-1c4b-4281-b951-d872f2087c98