- 12 Mar, 2018 40 commits
-
-
liberato@chromium.org authored
Some devices seem to be sending multiple EOS output buffers to MCAD, which doesn't handle them well. This CL makes it possible for a MediaCodecLoop client to signal an error when an EOS buffer arrives, to transition MCL into the error state safely. Bug: 818866 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic40b2a10ee4d983be28211b18ee9268a379f13d5 Reviewed-on: https://chromium-review.googlesource.com/957642Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#542576}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbbe951b..fc5740ae Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4ed1484c2f676f72325c39e74702f4a01d93afa1 Reviewed-on: https://chromium-review.googlesource.com/957920Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542575}
-
Robert Liao authored
Browser unhandled keyboard event forwarding was added for 130131, but is incompatible with the way Mac dispatches events. Views unhandled keyboard event forwarding was added for 145184 and should be the main way to cover this scenario for all platforms. BUG=130131,145184,820208 Change-Id: Ia6fd96b6059a5b5932e186299a0769b6a931c356 Reviewed-on: https://chromium-review.googlesource.com/957975Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542574}
-
Daniel Cheng authored
This method doesn't really make sense on Frame, as it is a property of a LocalFrame. Putting it on Frame implies that there are situations where it would return true for RemoteFrame, but that acn never happen. There are a few places that walk all frames in the frame tree looking for local roots and thus need to do an extra IsLocalFrame() check now: - PropagateZoomFactorToLocalFrameRoots: visits all the local roots in a frame tree to update the zoom factor. - DidExitFullscreen: this one is slightly unusual in that it only notifies the *topmost* local root. - FocusedOrMainFrame: arguably wrong and should be removed. If there are a more instances in the future of needing to walk the frame tree for all local roots, it might be worth adding a helper. Change-Id: Ie4f9a5ffc4b9b50331a7139b2c4935de53875659 Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/959230Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542573}
-
Michael Thiessen authored
This reverts commit 848f0ea0. Reason for revert: Reland after reverting enums.xml change Original change's description: > Revert "VR: Remove VR Launch Intents flag" > > This reverts commit c83231b7. > > Reason for revert: Should not have removed flags from enums.xml > > Original change's description: > > VR: Remove VR Launch Intents flag > > > > This flag was really only for development while we weren't sure how to > > handle VR Intents. With Chrome VR browsing already shipped, there's no > > reason not to allow Intents to launch it. > > > > Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f > > Reviewed-on: https://chromium-review.googlesource.com/959051 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542508} > > TBR=yfriedman@chromium.org,mthiesse@chromium.org > > Change-Id: I6b92369c483f7f0d8a11290bb9a50f6cfd1ea766 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/958021 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542550} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Iadb349fe60ea6a3a843228f3a4dcf24c6b9f9589 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958103 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542572}
-
Adrienne Walker authored
Bug: 820399 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6911388373a2e12397db9ae2d995c9769cd10033 Reviewed-on: https://chromium-review.googlesource.com/958335Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542571}
-
Khushal authored
For PaintRecord backed shaders, skia performs the rasterization of the shader's record at the required scale before tiling. In order to decode images in these records using cc's decode cache, we create a temporary SkPicture with images replaced with decodes from cc's cache and use that in a new SkPictureShader each time the PaintShader is rasterized. Skia internally maintains a cache of rasterized pictures used in these shaders, keyed on the SkPictureShader's uniqueID. Since a new SkPictureShader is created for each raster call, we don't get a cache hit in skia and end up re-rasterizing the shader's record. The ideal solution for this would be to maintain a PaintShaderCache which caches rasterized records. But given the rarity of these cases, its not worth duplicating skia's picture cache. However, if any of the images in these records are animated, they must go through cc's decode stack to update them and use cached animation frames. The change ensures that we only decode shaders in cc if they have animated images. Note that the performance hit of re-rasterization of records in these cases will still exist. R=chrishtr@chromium.org, enne@chromium.org, ericrk@chromium.org Bug: 817640 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd1f3db9902f21fca20c99be1cf9e36b54cd7085 Reviewed-on: https://chromium-review.googlesource.com/952529 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542570}
-
https://pdfium.googlesource.com/pdfium.git/+log/735eda96cf24..83a01491dbd9 $ git log 735eda96c..83a01491d --date=short --no-merges --format='%ad %ae %s' 2018-03-12 hnakashima Fix crash when creating a CFX_DIBitmap with FXDIB_Invalid. 2018-03-12 rharrison Add test that non-ASCII characters to not foul hyphen processing Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8ba1dafad38e6148569cad231238be54fa3796bf Reviewed-on: https://chromium-review.googlesource.com/958332 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542569}
-
Farah Charab authored
Change-Id: I78a42bdb82f83b0d64386def369253ef4087bbe5 Reviewed-on: https://chromium-review.googlesource.com/955857Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542568}
-
Sonny Sasaka authored
This adds sender='<name>' filter as the match rule for subscribing to signal in ObjectProxy. This is needed to reduce the unnecessary polluted log of rejecting some signals. The manual sender verification is still needed because as mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=507206#c14 service_name_ might be empty and sender='' means to not filter by sender at all. BUG=chromium:812468 TEST=Tested on device and checked that communications to D-Bus services (e.g. power, bluetooth) don't break Change-Id: I0ef4e03b5d9d8aa4412ef97286b971c30f458e99 Reviewed-on: https://chromium-review.googlesource.com/958324Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#542567}
-
Gustav Sennton authored
Split/publish ServiceWorker related functionality in the android.webkit glue layer to allow the support library glue to use that functionality. Bug: 819595 Change-Id: Ia705f3c867400f4ab30c0cc14083e7a0abc0a269 Reviewed-on: https://chromium-review.googlesource.com/958867Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#542566}
-
Wenzhao Zang authored
This is a follow-up to CL 945075. It uses the same logic to support preview for online wallpapers. Bug: 818075 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I17eaf9c554bacfee0b3075213e0936aa0f20c189 Reviewed-on: https://chromium-review.googlesource.com/949884Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai (OOO 3-12) <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542565}
-
Tommy Steimel authored
This CL fixes a couple of visibility issues for the modern media controls. First, it only toggles the controls visibility on touch events instead of all click events. Second, it changes the ShouldHideMediaControls hover check to only use the hover state of the button panel and timeline instead of the panel itself, which in modern media controls covers the entire video element. This fixes an issue on desktop where the controls wouldn't hide during fullscreen since the controls were always hovered. Bug: 812890 Change-Id: I8cb30841020e7f3ffdadc53131a4fa374b4254c2 Reviewed-on: https://chromium-review.googlesource.com/938841 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#542564}
-
Shimi Zhang authored
There is no usage of this version anywhere, so removing it. Bug: 805531 Change-Id: I11d1fe29268ae17255d05d79283dca9d7a83bcc2 Reviewed-on: https://chromium-review.googlesource.com/959302Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#542563}
-
Moe Ahmadi authored
Replaces an unused boolean argument with an optional callback that indicates whether the input element's value was changed. This callback is used to mark elements as autofilled only when the value has actually changed. This fixes cases where a <select> element is marked as autofilled while its value hasn't actually changed from its default value. e.g., www.crutchfield.com Bug: 803670 Change-Id: Iced545fb0f43fa351342b6b51dbacf789f150f8a Reviewed-on: https://chromium-review.googlesource.com/959052 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542562}
-
Luna Lu authored
Mark http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html flaky on Mac Bug: 788390 Change-Id: I2216e1c17ef9b4431d361180fe7a0d998dd807aa Reviewed-on: https://chromium-review.googlesource.com/959385 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542561}
-
David Benjamin authored
Bug: 820198 Change-Id: If15c9ae81c1d43f7c45d5fcf28ecbad0a8ba8635 Reviewed-on: https://chromium-review.googlesource.com/956030 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542560}
-
Linkun Chen authored
Bug: 70225530 Test: build and push OTA to device. Change-Id: I3e77b8e0ea55084c499de36169d80a195c0de74a Reviewed-on: https://chromium-review.googlesource.com/958225Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542559}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0f4e29651e2..c5edef2fbc54 $ git log e0f4e2965..c5edef2fb --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5511d6dc54fa7178ead91b99e8a2c2d9c60a440 Reviewed-on: https://chromium-review.googlesource.com/958334 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542558}
-
Derek Cheng authored
This is a workaround for enterprise setups (such as universities) where the network topology assigns public IP addresses to their Cast devices (presumably these devices are protected behind a firewall). Public IP addresses were disallowed in crrev.com/519857 which causes such setup to be broken, as users can no longer connect to those devices. To our knowledge there are at least 2 EDU setups (and a handful of individual users) that were affected by this. The workaround is implemented as a feature that is disabled by default. The intended target is affected users for whom the option of changing the Cast devices is infeasible (mostly EDU organizations). It can be enabled by passing in --enable-features=CastAllowAllIPs in the command line, or by turning it on in chrome://flags. Bug: 813974 Change-Id: Ia02702315f02544245862561dc6925f0e15725db Reviewed-on: https://chromium-review.googlesource.com/954345Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542557}
-
sangwoo.ko authored
Bug: 651022 Change-Id: I95d405ca9be1747abfe24f68f0837ed5981571ed Reviewed-on: https://chromium-review.googlesource.com/958783Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542556}
-
edchin authored
The layout needs updating whenever a new image is set. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If7e9d731f31bec7d28198a6f06275abd36071185 Reviewed-on: https://chromium-review.googlesource.com/954502Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542555}
-
Yury Khmel authored
It is possible to drop using wallpaper test client for the set of unit tests where wallpaper test client is used to prevent crash from the fake user manager. Test: git cl try Bug: N/A Change-Id: I7a788656fe0558841523744dc5ada3a1d5ffde9b Reviewed-on: https://chromium-review.googlesource.com/957788 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542554}
-
Sammie Quon authored
This is a reland of b513507c Original change's description: > tablet: Remove minimum time between taps for quick switch. > > Previously relied on using tap_count in GestureEvent which has a minimum > time between taps of 40ms for consecutive taps to have tap_count of 2. > Remove that and track double taps in overview button tray.cc. Allows > double tap from mice now. > > Test: ash_unittests OverviewButtonTrayTest.* > Bug: 817883 > Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907 > Reviewed-on: https://chromium-review.googlesource.com/956769 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542315} Bug: 817883 Change-Id: Ifd6ecabf3f1702d8aeffa29a48a6475f0e6b5422 Reviewed-on: https://chromium-review.googlesource.com/958014Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#542553}
-
Fredrik Söderquist authored
The initial value used here shouldn't make a difference, so use the initial value of 'fill' since that looks less confusing. It will also simplify conversion to a different computed <paint> representation. Bug: 769774 Change-Id: I5a08f73d4affc28f5804f3c3164051197721b2a4 Reviewed-on: https://chromium-review.googlesource.com/959009Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542552}
-
Marijn Kruisselbrink authored
There isn't much point in using any kind of download_to_file like optimization when loading from a data URL, so just don't, and make downloading data URLs as blob work. Bug: 412752 Change-Id: I3cd1e9ae290cdbf34d6d045c91b5717d8b997f8c Reviewed-on: https://chromium-review.googlesource.com/957302 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#542551}
-
Michael Thiessen authored
This reverts commit c83231b7. Reason for revert: Should not have removed flags from enums.xml Original change's description: > VR: Remove VR Launch Intents flag > > This flag was really only for development while we weren't sure how to > handle VR Intents. With Chrome VR browsing already shipped, there's no > reason not to allow Intents to launch it. > > Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f > Reviewed-on: https://chromium-review.googlesource.com/959051 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542508} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: I6b92369c483f7f0d8a11290bb9a50f6cfd1ea766 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958021Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542550}
-
Tommy Steimel authored
This CL also disables modern media controls on some Cast browser tests that currently make pixel-based assumptions about the controls. There will be a followup to fix those tests once the modern controls are in a more stable state. BUG=812893 Change-Id: Ibef663b0053a8adce80e8b057f76d3eb53f7dc88 Reviewed-on: https://chromium-review.googlesource.com/922917Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#542549}
-
Stefan Zager authored
These rects should mirror the behavior of getBoundingClientRect, which doesn't snap. BUG=758587,737228 Change-Id: If735df6bd24414dfbbd58dce01dc2a90f71df381 Reviewed-on: https://chromium-review.googlesource.com/951640Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#542548}
-
https://skia.googlesource.com/skia.git/+log/689d02d4b480..cf81fa995f38 $ git log 689d02d4b..cf81fa995 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 benjaminwagner Use goma ensure_stop. 2018-03-12 reed update include path for SkBlurMask.h 2018-03-06 caryclark make paint flatten unflatten private 2018-03-12 scroggo Update piex 2018-03-12 herb Fix overflow in blur for VERY wide bitmaps. 2018-03-09 caryclark pathmeasure fuzzer 2018-03-09 herb Remove DetachCache and AttachCache. 2018-03-12 kjlubick Small cleanups suggested by ClangTidy Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I57dd28ba7867321e61e4120be0ffc5dcd84cb5e3 Reviewed-on: https://chromium-review.googlesource.com/959164 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542547}
-
Qiang Xu authored
changes: Instead of using ScopedUmaRecorder, which is essentially implementing in a "callback" way. This CL replaces it with base::OnceCallback, which makes code more concise. Bug: 817643 Test: covered by tests Change-Id: Id99e9c08e8fe49886ca7c30a5901fb4128b04a42 Reviewed-on: https://chromium-review.googlesource.com/957816 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542546}
-
Djordje Golubovic authored
Bug: 821015 Change-Id: I60824857a26ea8660b80aa22dafd33bb3fc42289 Reviewed-on: https://chromium-review.googlesource.com/959120Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#542545}
-
Morten Stenshorne authored
Make fast/css/acid2.html and http/tests/misc/acid2.html useful, by scrolling the test face into view, rather than showing the instructional text at the top of the document (which basically says "click here to run the test"). There was an acid2-pixel.html alongside the acid2.html test, which I'm removing. The idea was apparently to keep an unmodified (and useless) acid2.html test, in addition to a useful but modified one, i.e. one that made the test face visible without first having to scroll (by adjusting margins and stuff). But since acid2.html has already been modified by us anyway, let's just go all in and scroll the face into view. Also no longer dump the render tree, since it's not useful. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie4518d40b0376bfc7920e6789c1d13f8758b22c6 Reviewed-on: https://chromium-review.googlesource.com/958922 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#542544}
-
https://chromium.googlesource.com/angle/angle.git/+log/391bda23b56d..529434a5a565 $ git log 391bda23b..529434a5a --date=short --no-merges --format='%ad %ae %s' 2018-03-08 jiawei.shao ES31: Update dEQP-GLES31 geometry shader related test expectations 2018-03-09 kvark Update driver constants on program change. Comes with a new SamplerMetadataUpdateOnSetProgram test. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4ef48968020c342df6878d1d24cc424c96a54523 Reviewed-on: https://chromium-review.googlesource.com/959167 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542543}
-
https://webrtc.googlesource.com/src.git/+log/b619936dee28..3e77afd0d29b $ git log b619936de..3e77afd0d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifceb169cbffa4eaaf933b10492abb5d4583b8d35 Reviewed-on: https://chromium-review.googlesource.com/959165 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542542}
-
Sorin Jianu authored
Bug: 813193 Change-Id: I939aee748e638ae6fc3e5171a27491d83df151c3 Reviewed-on: https://chromium-review.googlesource.com/957484Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542541}
-
Ken Rockot authored
This was introduced as an oversight in r541905. The original code safely handled null element readers on a URLRequest. This CL restores that safety. Bug: 820764 Change-Id: I1c37dc546cda989d7796ea66f2f9c073813fe50f Reviewed-on: https://chromium-review.googlesource.com/959227Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542540}
-
Luna Lu authored
This reverts commit 0588d062. Reason for revert: break Linux Builder (dbg) Build 121988 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988 error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::ScopedU2fDiscoveryFactory() >>> referenced by fake_u2f_discovery.cc:85 error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::~ScopedU2fDiscoveryFactory() >>> referenced by fake_u2f_discovery.cc:86 Original change's description: > Introduce a generic ScopedU2fDiscoveryFactory override. > > -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a > base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory > derive from that. > -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could > not care less about when a discovery starts, add a version of the fake > discovery where SimulateStarted()/SimulateStopped() is called automatically. > > Bug: 785955 > Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a > Reviewed-on: https://chromium-review.googlesource.com/959001 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542507} TBR=engedy@chromium.org,jdoerrie@chromium.org Change-Id: Iff7c0aa010fe3ae83262508795bdded90d1f620c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785955 Reviewed-on: https://chromium-review.googlesource.com/959282Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542539}
-
Marc Treib authored
This has been disabled in release builds for a while, and might not work anymore anyway. Bug: none Change-Id: I1cadea9d93944909958067eb75c3c64130da9d41 Reviewed-on: https://chromium-review.googlesource.com/959019Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#542538}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 37496521. With Chromium commits locally applied on WPT: 5abdda89 "Remove duplicate color parsing tests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13764 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I80bec75d5d71873ffd2dfe86f14bdbb2fb9d4cff Reviewed-on: https://chromium-review.googlesource.com/958220 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542537}
-