GitLab

What we want to do is to instantiate some templates of
<T> with T's full definition, in Member<T>::get() and
Member<T>::checkPointer().
To guarantee that template instantiations come after
T's definition, we put static_assert() in Member<T>.
See the change in platform/heap/Handle.h.

To achieve the condition, this CL does either of
1) move implementation of methods using Member<T> from .h to .cpp
2) include necessary .h
(1) can change inline definitions to outline definitions,
and it may regress performance a bit.

BUG=556947

Review URL: https://codereview.chromium.org/1455943002

Cr-Commit-Position: refs/heads/master@{#360570}

The type name in the |USING_FAST_MALLOC| macro is currently not used,
which allowed a few typos to sneak in. This fixes those to prevent
compile errors in case the type name is used in the future.

Review URL: https://codereview.chromium.org/1461743004

Cr-Commit-Position: refs/heads/master@{#360569}

WebRTC 10685:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..0f714d5

Libjingle 10671:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3ecea8a..17fe6f9

TBR=
BUG=

Review URL: https://codereview.chromium.org/1456393002

Cr-Commit-Position: refs/heads/master@{#360568}

https://html.spec.whatwg.org/#document

After this change, setting document.cookie to null will stringify to
"null", so it's simply like setting a cookie by that name. This matches
Firefox Nightly and Edge.

BUG=497307

Review URL: https://codereview.chromium.org/1458753003

Cr-Commit-Position: refs/heads/master@{#360567}

BUG=558341
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1462873002

Cr-Commit-Position: refs/heads/master@{#360566}

BUG=545480
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1453293003 .

Cr-Commit-Position: refs/heads/master@{#360565}

https://chromium.googlesource.com/chromium/src/+/6546ae27

BUG=128055
TBR=davve@opera.com

Review URL: https://codereview.chromium.org/1461023002 .

Cr-Commit-Position: refs/heads/master@{#360564}

cricket::CapturedFrame.elapsed_time is deprecated since
https://codereview.webrtc.org/1324263004/.

BUG=544125
R=perkj@chromium.org,sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1456083002

Cr-Commit-Position: refs/heads/master@{#360563}

CSP's matching algorithm has been updated to make clever folks like Yan
slightly less able to gather data on user's behavior based on CSP
reports[1]. This matches Firefox's existing behavior (they apparently
changed this behavior a few months ago, via a happy accident[2]), and
mitigates the CSP-variant of Sniffly[3].

On the dashboard at https://www.chromestatus.com/feature/6653486812889088.

[1]: https://github.com/w3c/webappsec-csp/commit/0e81d81b64c42ca3c81c048161162b9697ff7b60
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218524#c2
[3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218778#c7

BUG=544765,558232

Review URL: https://codereview.chromium.org/1455973003

Cr-Commit-Position: refs/heads/master@{#360562}

BUG=553425, 545480
R=akuegel@chromium.org

Review URL: https://codereview.chromium.org/1460723002 .

Cr-Commit-Position: refs/heads/master@{#360561}

Revert of Add noBarrierStore to WTF and use it for spinlocks (patchset #2 id:20001 of https://codereview.chromium.org/1461743002/ )

Reason for revert:
This CL broke compilation on the TSan bot.
Please consider using the linux_clang_tsan trybot or building locally with GYP_DEFINES=tsan=1 next time.

Original issue's description:
> Add noBarrierStore to WTF and use it for spinlocks
>
> This will eliminate TSAN warnings on some benign races,
> and help ensure that they remain benign.
>
> BUG=556469
>
> Committed: https://crrev.com/12678ed8e9f993cbe343ddd3d08ee174244b6552
> Cr-Commit-Position: refs/heads/master@{#360481}

TBR=haraken@chromium.org,jschuh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556469

Review URL: https://codereview.chromium.org/1457843003

Cr-Commit-Position: refs/heads/master@{#360560}

BUG=550407

Review URL: https://codereview.chromium.org/1456783004

Cr-Commit-Position: refs/heads/master@{#360559}

Before this patch, one SVGImageForContainer object is saved in
ImageResource for each corresponding use of SVGImage.

<img style="width: 1000px" src="image.svg">
...
<img style="width: 500px" src="image.svg">

This example would give one ImageResource (for image.svg) and within
it two SVGImageForContainer, one for each <img>. SVGImageForContainer
contains the unzoomed container size along with the zoom level,
indexed on the layout object of the container in
SVGImageFor*Container*.

There were at least three problems with this approach:

1. It's racy. setContainerSizeForLayoutObject is called sometimes from
   layout(), sometimes during paint(). Users of APIs such as
   imageForLayoutObject or imageSizeForLayoutObject that depend on
   setContainerSizeForLayoutObject would get different results
   depending on when they are called. Basically the only "safe" time
   to call these methods are right before paint.

2. It limits the number of associations between layout object and
   SVGImage to one. Consider an element/layout object having one
   SVGImage as content and another SVGImage as background. The
   container size for those two SVGImages in this case isn't
   necessarily the same and strictly speaking we should need two
   SVGImageForContainer objects. Only one SVGImageForContainer can be
   stored per layout object.

3. It breaks layering. ImageResource lives in fetch and having fetch/
   depend on svg code is undesirable. DEPS for fetch/ states
   "core/fetch/ shouldn't depend on anything else in core/".

After this patch, these three problems have been
addressed. SVGImageForContainer is now only allocated when it's
needed, to be passed through the GraphicsContext layer as a wrapper to
get the correct size and zoom level to avoid pixelated rasterization.

There are risks with this patch. In some cases code may rely on having
the container size saved inside ImageResource.cpp. However, such code
is most often already brittle and unreliable due to (1) above.

One quirk is the added BackgroundImageGeometry::imageContainerSize()
containing the tile size before 'background-repeat: round' has been
applied. Before this patch, this size was the one kept for the
respective container in ImageResource (since
setContainerSizeForLayoutObject were called before tile size
adjustments for background-repeat: round). It turns out this is
important to get the stretching correct, i.e. makes the underlying
drawing code ignore the intrinsic ratio of the background
image. svg/as-background-image/background-repeat.html exercises this
behavior.

BUG=128055, 306222

Review URL: https://codereview.chromium.org/1427943002

Cr-Commit-Position: refs/heads/master@{#360558}

This is the fix for regression introduced by
https://codereview.chromium.org/1344783002

After the CL, SWProviderContext::ControllerDelegate::AssociateRegistration()
wrongly set its |installing_| field to the active worker and |active_| field
to nullptr. These messed fields eventually show up as
ServiceWorkerGlobalScope.registration's version attributes.

This CL fixes the wrong field assignment and adds layout tests.

BUG=532098, 557551

Review URL: https://codereview.chromium.org/1460653002

Cr-Commit-Position: refs/heads/master@{#360557}

This is a follow-up CL for http://crrev.com/1397073002
static_assert in HashTable ignored this case because
HTMLPlugInElement is forward declared in this file and
we cannot know it is GCed class.

BUG=515524

Review URL: https://codereview.chromium.org/1459473005

Cr-Commit-Position: refs/heads/master@{#360556}

The new behavior is reasonable because tooltips can disturb text editing
with keyboards, and is compatible with Firefox.

BUG=557660
TEST=automated

Review URL: https://codereview.chromium.org/1454363002

Cr-Commit-Position: refs/heads/master@{#360555}

MediaStreamCenter::didCreateMediaStream is called from here.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp&sq=package:chromium&type=cs&l=146&rcl=1447771613

Before that, the tracks have already been created.

Review URL: https://codereview.chromium.org/1462473002

Cr-Commit-Position: refs/heads/master@{#360554}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f931913e..88939fd8

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1457253002

Cr-Commit-Position: refs/heads/master@{#360553}

Port all targets required to build "ios_chrome_unittests" from gyp to gn,
adding reference to the GN target in the gyp files. The targets links but
does not runs as resources bundles are still unsupported with gn.

The resources are also not packed, but this will be done in a follow up
CL in order to reduce the size of this already large CL.

BUG=459705

Review URL: https://codereview.chromium.org/1452593002

Cr-Commit-Position: refs/heads/master@{#360552}

View::Layout is not invoked if only origin has been changed.
R=sadrul@chromium.org,sky@chromium.org
BUG=none
TEST=See unittest.

Review URL: https://codereview.chromium.org/1442683002

Cr-Commit-Position: refs/heads/master@{#360551}

This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.

I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.

R=jam@chromium.org,tsepez@chromium.org
http://crbug.com/551253

Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
Cr-Commit-Position: refs/heads/master@{#360293}

Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
Cr-Commit-Position: refs/heads/master@{#360396}

Review URL: https://codereview.chromium.org/1452823003

Cr-Commit-Position: refs/heads/master@{#360550}

Before this CL, strings and container types were passed to callback
method by const reference. Dictionary types should also be passed
by const ref to avoid unnecessary copying.

BUG=557590

Review URL: https://codereview.chromium.org/1455883003

Cr-Commit-Position: refs/heads/master@{#360549}

This patch makes following tests to use w3c test harness to simplify tests
and avoid to compare pixel results.

Pixel results aren't essential for tests changed in this patch and when
we enable asynchronous spell checking, pixel result contains red wave lines for
miss spelled. These read wave lines aren't related what we want to test.

This patch is a preparation of getting rid of synchronous code path for
spellcheck to enable asynchronous spell checking always.

BUG=295722
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1456333002

Cr-Commit-Position: refs/heads/master@{#360548}

Introduce PasswordsModelDelegate as an abstraction between ManagePasswordsBubbleModel and ManagePasswordsUIController.

BUG=557128
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/1445383003

Cr-Commit-Position: refs/heads/master@{#360547}

Also make sure, we're always in the script context when invoking unwrap
(as opposed to the debugger context)

BUG=none
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1455583002

Cr-Commit-Position: refs/heads/master@{#360546}

This CL moves updateFocusAppearance() call from Element::focus() to
Document::setFocusedElement() so that 'focus' event handler can refer to correct
selection information.

The last updateLayoutIgnorePendingStylesheets() call in Element::focus is
unnecessary now.  Because this CL removes it,
textfield-to-password-on-focus.html needs a delay to pour key inputs.

BUG=526516

Review URL: https://codereview.chromium.org/1437813002

Cr-Commit-Position: refs/heads/master@{#360545}

Revert of Flip 'Linux x64' bot on chromium waterfall to GN. (patchset #2 id:20001 of https://codereview.chromium.org/1461453002/ )

Reason for revert:
compiling 'all' fails w/ GN:

http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/12149/steps/compile/logs/stdio

Original issue's description:
> Flip 'Linux x64' bot on chromium waterfall to GN.
>
> This flips the Linux x64 bot on the chromium waterfall to
> GN, and cleans up some mistakes in the MB config (the
> builders should've been setting linux_dump_symbols=0,
> which is the default, not linux_dump_symbols=1).
>
> TBR=phajdan.jr@chromium.org, brettw@chromium.org
> BUG=530733, 432959
>
> Committed: https://crrev.com/9bb757129af95f0ca1539c65269cd8bc85df04f8
> Cr-Commit-Position: refs/heads/master@{#360510}

TBR=phajdan.jr@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530733, 432959

Review URL: https://codereview.chromium.org/1457593005

Cr-Commit-Position: refs/heads/master@{#360544}

In C++11, std::swap() moved to <utility>. However, lots of random source
files still depend on scoped_ptr.h having #include <algorithm>.

BUG=none
R=kinuko@google.com
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/1463463002 .

Cr-Commit-Position: refs/heads/master@{#360543}

Now that Blink lives in src/, regular checkdeps.py without --root argument
does the right thing, so this script is no longer needed.

BUG=none

Review URL: https://codereview.chromium.org/1461003002

Cr-Commit-Position: refs/heads/master@{#360542}

In MutaionObserverInterestGroup, MutationObservers were held in HashSet
as raw pointers.  In case a MutationObserver is gone while mutation
events are collected (and garbage collector collects the object),
it causes use-after-free while the code tries to enqueue the recorded
mutation events.  Use RefPtr<> to hold the pointer so that the object
will be kept until it goes out of scope.

BUG=557981
TEST=fast/dom/MutationObserver/mutation-and-deletion-race.html

Review URL: https://codereview.chromium.org/1463433002

Cr-Commit-Position: refs/heads/master@{#360541}

This essentially made it impossible to support more than two column rows in
auto-height multicol containers.

When a new fragmentainer group is created, resetColumnHeight() is called right
*before* the fragmentainer group is inserted into the array, so we'd trick
ourselves into believing that height always was non-auto, because the
heightIsAuto() method on MultiColumnFragmentainerGroup would require the
fragmentainer group to be the last one in the array to count as auto.

We could fix the order in which things are done, or just make the whole thing a
bit more robust, which this CL aims to do.

BUG=447718
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1424913003

Cr-Commit-Position: refs/heads/master@{#360540}

The aim is to make scoped_ptr and std::unique_ptr functionally
identical so scoped_ptr can simply be a typedef.

BUG=554298

Review URL: https://codereview.chromium.org/1445003002

Cr-Commit-Position: refs/heads/master@{#360539}

This patch makes following tests to use w3c test harness to simplify tests
and avoid to compare pixel results.

Pixel results aren't essential for tests changed in this patch and when
we enable asynchronous spell checking, pixel result contains red wave lines for
miss spelled. These read wave lines aren't related what we want to test.

This patch is a preparation of getting rid of synchronous code path for
spellcheck to enable asynchronous spell checking always.

BUG=295722
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1459783003

Cr-Commit-Position: refs/heads/master@{#360538}

Gets rid of SubtreeStyleChange which relies on sibling tree recalcs.

Added TODO with issue for :default which just doesn't trigger any updates
from the DOM side.

R=hayato@chromium.org,ericwilligers@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1461653002

Cr-Commit-Position: refs/heads/master@{#360537}

This CL adds a simple logic to record the file type when user long
presses the save link menu.
It guesses the mime type by checking the url extensions.
This may not work for all cases, but it should provide a good case study for
the provided crbug.

BUG=550711

Review URL: https://codereview.chromium.org/1441683010

Cr-Commit-Position: refs/heads/master@{#360536}

Previously we disable subsequence caching for layers having clip or
overflow-clip to ensure descendant layers to be repainted when an
ancestor layer's clip changes. This doesn't work if a descendant layer
is painted not using the same PaintLayerPaintingInfo of the ancestor
layer (e.g. when the ancestor layer is not a stacking context). This
also unnecessarily disables subsequence caching even if clipping
doesn't change.

Now save previous paintingClipRects and check if it changes before
issuing subsequence display item.

BUG=533717,553392
TEST=paint/invalidation/repaint-subsequence-on-ancestor-clip-change.html
TEST=paint/invalidation/repaint-subsequence-on-ancestor-clip-change-complex.html

Review URL: https://codereview.chromium.org/1452313004

Cr-Commit-Position: refs/heads/master@{#360535}

imported csswg-test@248da687d983cefab3286333963021da8c1dd505
imported web-platform-tests@68823b89d97b51927051a73161a43a72181edc54

New Skip
- cssom-view (missed when it was added, remove in this CL.)

css-writing-modes-3
- 1 new + 1 modified for the 'outline' property.

html/semantics
- 1 modified (new cases added,) 3 meta-data only changes.

html/webappsapis
- 3 meta-data only changes.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org
BUG=490511, 492664

Review URL: https://codereview.chromium.org/1461663004

Cr-Commit-Position: refs/heads/master@{#360534}

After https://codereview.chromium.org/1192013003, when Chrome extension
sends XHR request to "chrome-extension://*" to get the contents in the
extension, the request goes to the page's ServiceWorker.

This is breaking some extensions. (crbug.com/517181)
And also it is causing ASSERT failure. (crbug.com/528818)

The requests initiated from extensions should not go to the ServiceWorker.
So this CL checks DOMWrapperWorld.isIsolatedWorld and sets the
skipServiceWorker flag to bypass the SW.

BUG=528818,517181

Review URL: https://codereview.chromium.org/1390943003

Cr-Commit-Position: refs/heads/master@{#360533}

This CL adds IsSvelte to AndroidPlatformBackend, and exposes it through
AndroidPlatform, so that benchmarks can be disabled only on svelte devices.

BUG=555167

Review URL: https://codereview.chromium.org/1455863004

Cr-Commit-Position: refs/heads/master@{#360532}

https://chromium.googlesource.com/skia.git/+log/1ac3f40b4350..fbe1c110acf2

$ git log 1ac3f40b4..fbe1c110a --date=short --no-merges --format='%ad %ae %s'
2015-11-18 fmalita [Reland] Fix NVPR assert for equivalent ovals
2015-11-18 bsalomon Make SkTLList prealloc its first block of nodes
2015-11-18 bsalomon Make block size a template parameter of SkTLList
2015-11-18 mtklein Revert SkBlitMask_opts.h back to hand-coded NEON.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/1460913003

Cr-Commit-Position: refs/heads/master@{#360531}