GitLab

This CL introduces ModuleScriptCustomFetchType enums that indicate which custom
fetch hook is specified. Modulator::CreateModuleScriptFetcher() creates a
ModuleScriptFetcher instance based on the enum. For example, WorkerModulatorImpl
creates WorkerModuleScriptFetcher for new Worker() and
DocumentModuleScriptFetcher for dynamic import.

The main motivation of this change is to avoid settings ReferrerPolicy in
WorkerGlobalScope multiple times in WorkerModuleScriptFetcher. See changes there
for details.

Change-Id: I964276e5fc1d2d364a4484a5a47ea5b3a700fbf7
Bug: 842553
Reviewed-on: https://chromium-review.googlesource.com/1113078
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570359}

This setting can be used to control presentation of all full-tab
promotional content. In this iteration, it controls both variants of the
welcome page.

BUG=703809

Change-Id: Ib2d87d85807fb86e25833e29b1f2a1ef89b80ca6
Reviewed-on: https://chromium-review.googlesource.com/1105818
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570358}

This CL adds a feature to sync the DnD status between Chrome and Android.
- When the DnD status is changed on Android side, set it to Chrome-side.
- When the DnD status is changed on Chrome side, set it to Android-side.

Bug: b/79951342
Test: Ran added tests
Change-Id: I3eba63420a91de60e7baf333dfb4dd7c1da74310
Reviewed-on: https://chromium-review.googlesource.com/1111495
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570357}

Use colors from the popup spec for the omnibox popup.

Bug: 821817
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic90f502e54b4d338ebfbc4532e70467f890dac8a
Reviewed-on: https://chromium-review.googlesource.com/1111856Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570356}

Let me improve compile step time for mac_chromium_rel_ng builder.

This is mainly to improve some slow compile step on the builder.
But also aims to mitigate total CQ time heavily affected by very slow webkit_layout_tests like below builds.

8253s (total) and 2431s (compile): https://ci.chromium.org/b/8942705844272728000
7389s (total) and 3601s (compile): https://ci.chromium.org/b/8942775029613500944
7321s (total) and 2489s (compile): https://ci.chromium.org/b/8942701297855457248
7105s (total) and 3355s (compile): https://ci.chromium.org/b/8942762808006546480
6681s (total) and 3702s (compile): https://ci.chromium.org/b/8942774232656410784

Bug: 851355, 804251
Change-Id: Id81e97b9733e87b4445414e5e096f412119f8405
Reviewed-on: https://chromium-review.googlesource.com/1114397Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570355}

If "setting" mode is enabled, user can't slide the view and see any
control buttons. This is used for showing the inline settings. With
this CL, this mode is enabled during the inline setting is visible.

Bug: b/110329209
Test: Ran the added unittest.

Change-Id: Id5ff6fccf9fd4208ecf8542c470cf812b278704d
Reviewed-on: https://chromium-review.googlesource.com/1105805
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570354}

When the steady location bar is tapped when in scrolled-away state, it
now exits fullscreen first; only the second tap focuses the omnibox.

Bug: 821807
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iadaed09fa545d4335872f4f5990d6201a2351782
Reviewed-on: https://chromium-review.googlesource.com/1113749Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570353}

Picture-in-Picture API is disabled in Android WebView as there is no UI
implemented.

Bug: 855270, 852449
Change-Id: Id7c0ebcc94085f6e1b3f00383254780a5357269b
Reviewed-on: https://chromium-review.googlesource.com/1112247
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570352}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c8a626f49c09..29cb3db927ce


git log c8a626f49c09..29cb3db927ce --date=short --no-merges --format='%ad %ae %s'
2018-06-26 dgarrett@google.com build_stages: Add logging to CancelObsoleteSlaveBuilds.
2018-06-26 metzman@chromium.org [fuzzing] Make env script handle new builds better.


Created with:
  gclient setdep -r src/third_party/chromite@29cb3db927ce

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:855801,chromium:648042
TBR=chrome-os-gardeners@chromium.org

Change-Id: I43554c0983bc43f97ae4f021b113baafd720556b
Reviewed-on: https://chromium-review.googlesource.com/1114047Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570351}

This patch fixes max-content size when the line has floats
outside of its content box.

In such case, ComputeContentSize computes a negative value
for |floats_inline_size|. Such |floats_inline_size| should
not affect max-content size.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie3076c1a135a8bf00a264f7275abb19ef1392864
Reviewed-on: https://chromium-review.googlesource.com/1113094Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570350}

This implements a super simple subset of the currently spec-ed
format. The format is subject to change and hence format details
are encapsulated in the OriginPolicyParser class.

Bug: 751996
Change-Id: I72d49c83228d6c7debf15524748d93f5cd0c4ff1
Reviewed-on: https://chromium-review.googlesource.com/1090725Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570349}

Add a new method Element.toggleAttribute(string qualifiedName,
optional bool force) that allow toggling the existence of an element’s
attribute, similar to Element.classList.toggle.

Spec
https://dom.spec.whatwg.org/#dom-element-toggleattribute

Intent to Implement and Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/mAWBTaANvmE/OgaCRH04BAAJ

Bug: 854960
Change-Id: Iab8a1a97dd4e2f8b377bcf590401699f9013aa8a
Reviewed-on: https://chromium-review.googlesource.com/1111761
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570348}

Use touchstart as a criterion to stop contextmenu propagation.

Bug: 812056
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2d6272b08c0f1ad8229fe340825607e8ef6df007
Reviewed-on: https://chromium-review.googlesource.com/1109668
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570347}

This is a reland CL for the reverted CL
https://chromium-review.googlesource.com/c/chromium/src/+/1113203

On top of the original CL, this CL updates module name of
dispatch_fetch_event_params.mojom from content.mojom to blink.mojom.

BUG=789846

Change-Id: I650ffaf9b862c75a553b2174bcc10eefe27f43ed
Reviewed-on: https://chromium-review.googlesource.com/1114392
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570346}

//components/safe_browsing depends on //content that is not build on iOS.
This means that //components/unified_consent cannot depend on
//components/safe_browsing as it needs to be build on iOS.

This CL removes the usage of safe_browsing from //components/unified_consent
and adds the corresponding method in the client.


Bug: NONE
Change-Id: I2c32629524d5621e36717dcb801fd8be00732a55
Reviewed-on: https://chromium-review.googlesource.com/1113753Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570345}

This comment is outdated: this is no longer true for other container
behaviours.

TBR=blakeo@chromium.org

Change-Id: I8cd3bce943f4e177d41ad404eb7fb737a0dd397f
Reviewed-on: https://chromium-review.googlesource.com/1113713Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570344}

Bug: webrtc:9239
Change-Id: I796ec3f6b332233c20050e58fc1dd97730dcbbe7
Reviewed-on: https://chromium-review.googlesource.com/1113453Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570343}

BUG=827083
R=dtrainor@chromium.org

Change-Id: Iffaa3adff0bb82cdeabf9af70a5952e6a50c7079
Reviewed-on: https://chromium-review.googlesource.com/1113447Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570342}

Now all interfaces are on Oilpan heap, and we don't support [GarbageCollected].
Hence we don't have to have tests for InterfaceGarbageCollected
separately from Interface.


Bug: 819112
Change-Id: I7ef1d9e373944836e61194419d6d4c12300d4610
Reviewed-on: https://chromium-review.googlesource.com/1114398Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570341}

Bug: 853104
Change-Id: I6b6a0e0436e7c3753e09f9071110bf36c10be1a1
Tests: 
ash: ash_unittests:AcceleratorControllerTest.TestDialogCancel
ash: ash_unittests:AcceleratorControllerTest.TestToggleHighContrast
ash: ash_unittests:MagnifiersAcceleratorsTester.TestToggleFullscreenMagnifier
ash: ash_unittests:MagnifiersAcceleratorsTester.TestToggleDockedMagnifier
Reviewed-on: https://chromium-review.googlesource.com/1102217
Commit-Queue: Sara Kato <sarakato@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570340}

We rename some KeyboardControllerObserver events to avoid confusion:
- OnKeyboardClosed -> OnKeyboardDisabled ("closed" could mean hidden
  too).
- OnKeyboardAvailabilityChanged -> OnKeyboardVisibilityChanged
  ("available" could mean that VK is enabled).

Bug: 845780
Change-Id: I8a0f1532b064377ce4441e2e407ba136778cd506
Reviewed-on: https://chromium-review.googlesource.com/1111489Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570339}

https://webrtc.googlesource.com/src.git/+log/111fdfd73204..84916937b704


git log 111fdfd73204..84916937b704 --date=short --no-merges --format='%ad %ae %s'
2018-06-25 deadbeef@webrtc.org Update packetsLost and jitter stats any time a packet is received.


Created with:
  gclient setdep -r src/third_party/webrtc@84916937b704

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I911fc8def915a9f75350355c1905c72974f55374
Reviewed-on: https://chromium-review.googlesource.com/1114050Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570338}

Bug: pdfium:1105
Change-Id: Ieb85b8258ce321b9b28bc1f7265980395b184fc5
Reviewed-on: https://chromium-review.googlesource.com/1114072
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570337}

The new implementation is based on Mac OS Vision Framework[1] which recognizes
more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode
detection provider to choose different implementation.

Split original large CL[2] up in smaller subpatches including this CL.

[1] https://developer.apple.com/documentation/vision
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466

BUG=848182

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e
Reviewed-on: https://chromium-review.googlesource.com/1107493
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570336}

This patch implements hit testing on culled inline elements by:

- After hit testing each inline fragment, fall back to the legacy
  LayoutObject tree to see if there is any culled inline ancestor
  element, and hit test each of them. This part replicates relevant
  logic in InlineFlowBox::NodeAtPoint.

- Adds a |parent_fragment| parameter to
  LayoutInline::HitTestCulledInline to ensure that only descendant
  rects of |parent_fragment| are hit tested. This ensure that, e.g.,
  for a multi-line SPAN, we hit test its rects line-by-line, to ensure
  correct hit test ordering.

Tests: 6 layout tests are fixed. One of them is rebaselined due to
whitespace-only difference in text dump.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic303ce5f8a192f92ad326c304a9d84fa898e4c94
Reviewed-on: https://chromium-review.googlesource.com/1110737Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570335}

Change-Id: I5f171e2c769be38ffc5f2a8c63230071163235a5
Reviewed-on: https://chromium-review.googlesource.com/1114152Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570334}

https://skia.googlesource.com/skia.git/+log/fcd480bcab9e..f46710802ad5


git log fcd480bcab9e..f46710802ad5 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@f46710802ad5

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I09638c1e2ae4d354d547f523e8edc14b7ebac393
Reviewed-on: https://chromium-review.googlesource.com/1114051Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570333}

It is currently calculated in many places as 10 * kHundrethsMMPerInch.
Since it is commonly used, add a constant for it and replace the
calculations. After which, kHundrethsMMPerInch is infrequently used, so
remove it.

Change-Id: I5b0297b8ed175ef2936657f0db8f92ce6e294b4d
Reviewed-on: https://chromium-review.googlesource.com/1111682Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570332}

May control this with a Finch flag later.

Bug: 800945
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idfaa09501781398a805d8b4ae0453538d7a5ee4b
Reviewed-on: https://chromium-review.googlesource.com/1099999
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570331}

Add CHECK statements to KURL::Port() to verify that it is behaving as expected,
in preparation for removing unnecessary code.

The CHECKs will be replaced with DCHECKs in a followup CL after there's been
time for any crashes to appear.

BUG=606462

Change-Id: Ib3bcc738005de27201435f2c62aa4056965d5c91
Reviewed-on: https://chromium-review.googlesource.com/1111879Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570330}

TBR=inferno@chromium.org,rockot@chromium.org

Bug: 856188
Change-Id: Ic215f12810032592df4ed6832ecc40f92068bbc8
Reviewed-on: https://chromium-review.googlesource.com/1113710
Commit-Queue: Oliver Chang <ochang@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570329}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ifa7108a77525552b091b2fc6877c5e7042022cc4
Reviewed-on: https://chromium-review.googlesource.com/1114391
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570328}

With Declarative Net Request, there is no easy way for extensions to collapse
the DOM elements corresponding to the resources they blocked. This CL implements
the ability for the blocked <iframe> elements to be automatically collapsed in
the DOM.

BUG=848842

Change-Id: Iaf9ce75b5dc1a978a09e1ae698f2ed180351c288
Reviewed-on: https://chromium-review.googlesource.com/1111341
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570327}

- correct message string id (i.e. + '_description')
- walk up to the first scrollable ancestor (based on the availability of the scrolling action).

Test: 1. open Learn Mode. Perform three finger swipe up/down. Verify scroll back/forward output.
2. Scroll within an Android app. Verify content changes appropriately.

Change-Id: I4da02e1f09eb38dc2a61e5141b4ef67e57139b46
Reviewed-on: https://chromium-review.googlesource.com/1114200Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570326}

TEST=./out/Default/chrome https://web-platform.test:8444/service-workers/service-worker/referrer-policy-header.https.html --enable-features=ServiceWorkerServicification (with ./third_party/blink/tools/run_blink_wptserve.py)

Bug: 855948
Change-Id: Ib055174295d6b54f9e3bf0e14bd4f7002ceb33f2
Reviewed-on: https://chromium-review.googlesource.com/1113711Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570325}

Mac browser fullscreen mode allows to keep the top UI, as well as
toggling between showing and hiding the top UI. In these cases, bookmark
bar should always show or hide in sync with the top UI. This requires
tracking top UI change, and change bookmark bar state or visibility
accordingly.

In Views, bookmark bar state is cached in Browser::bookmark_bar_state_,
and is updated through Browser::UpdateBookmarkBarState(). So when the
visibility of top UI changes, we need to execute
UpdateBookmarkBarState() to update bookmark bar state as well.

BUG=831219
TEST=pls check bookmark bar (non-detached) in fullscreen mode, which
     should always show or hide along with toolbar/tabstrip.

Change-Id: I04475edc455a62e045857ed666c44a31ead2b402
Reviewed-on: https://chromium-review.googlesource.com/1109405
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570324}

The contents view of |menu_widget_| in PowerButtonController will be updated
when showing menu, which means the destructor of PowerButtonMenuScreenView
will not be called when DismissMenu. This will cause the arrow key traversal
enabled value in FocusManager will not be restored correctly. Move the logic from
PowerbuttonMenuScreenView into PowerButtonController to make sure the value
can be restored correctly if dismiss the menu.

Bug: 846639
Change-Id: I32ceebb8e81cf19e3fed119af0ccee3bd8c55638
Reviewed-on: https://chromium-review.googlesource.com/1114309
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570323}

webgl2_conformance_tests' shards are taking at least 3 hours to
schedule, so increase the timeout to 6 hours.

Bug: 856268
Tbr: jbudorick@chromium.org
Change-Id: Idf610388955f4b6cb73b81f5075a810c13c2fda0
Reviewed-on: https://chromium-review.googlesource.com/1114356Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570322}

* There is no need to do any work for a PaintLayer if it has no past/current compositing state.
* There is no need to recurse if the entire stacking subtree has no past/current compositing state.

Bug: 814439

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib1d2c23e1e2c9a34bea63432d95f83a8bbe0ab13
Reviewed-on: https://chromium-review.googlesource.com/1101817
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570321}

This change adds onpictureinpicturecontrolsclick to the partial
interface of an HTMLVideoElement and creates the plumbing that
allows for functions to trigger that event (note: it is not
currently being called in this CL).

Manual testing was done by initiating the call in
overlay_window_views.cc by calling controller_->ControlClick() and
confirming the new EventHandler was triggered.

Bug: 852572
Change-Id: I57038fa4809085b7000ca7e5d933c38e82d133e7
Reviewed-on: https://chromium-review.googlesource.com/1100043
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570320}